Re: Uncrustify Configuration vs RTEMS Coding Style

On 05/04/2021 17:25, Joel Sherrill wrote: On Mon, Apr 5, 2021 at 9:51 AM Sebastian Huber > wrote: Hello Joel, On 04/04/2021 22:19, Joel Sherrill wrote: > Hi Sebastian, > > Do you have a list or remember where uncrustify could

[PATCH] Format some files with clang-format

This patch is not intended to be integrated. It just gives an example for using clang-format. Using AlignConsecutiveDeclarations: false PointerAlignment: Right would be closer to the RTEMS style, however, this combination is not really supported:

Re: #3860 - GSoC enquiries

On 04/04/2021 22:18, Joel Sherrill wrote: On Sun, Apr 4, 2021 at 2:25 PM Ida Delphine > wrote: Hello, Please who are the possible mentors for this project? IMO this is a project which has a larger potential potential set of mentors than one focused on

Re: GSoC'21 Raspberry Pi BSP project

Hi, I can try to give you some background, hopefully others will correct me if I don't get everything right. You are correct that the BSP just covers the original Pi1 and Pi Zero (not Pi Zero W) models + the Pi 2. I don't think the I2C and GPIO interfaces were ported to the Pi2. At some point, I

Re: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

On 5/4/21 11:11 pm, Ryan Long wrote: > When you say "allocating the main data structure", are you referring to the > Run-Time Link Editor (rtl)? If so, rtems_rtl_data_init() is allocating memory > for it. If it fails then rtems_rtl_data_init() returns false. Then, this > causes rtems_rtl_lock()

Re: [PATCH 2/2] coverage.py: Call covoar once

On Mon, Apr 5, 2021 at 1:25 PM Alex White wrote: > > Updates #4374 > --- > tester/rt/coverage.py | 59 +-- > 1 file changed, 29 insertions(+), 30 deletions(-) > > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py > index 29ed60b..8860c94 100644 >

Re: Standalone repository for libnetworking stack

On Tue, Mar 23, 2021 at 2:12 PM Vijay Kumar Banerjee wrote: > > On Tue, Mar 23, 2021 at 1:10 PM Gedare Bloom wrote: > > > > On Tue, Mar 23, 2021 at 12:34 PM Joel Sherrill wrote: > > > > > > > > > > > > On Tue, Mar 23, 2021 at 11:27 AM Vijay Kumar Banerjee > > > wrote: > > >> > > >> Hi, > > >>

Re: [PATCH rtems-libbsd] Import telnetd from RTEMS repository

push this if no one complains by Wednesday I think we should keep this telnetd and the legacy one in sync for now, and consider them as a good candidate for a new 'rtems-net-services' repository. On Mon, Mar 29, 2021 at 7:39 PM Vijay Kumar Banerjee wrote: > > ping :) > > On Tue, Mar 23, 2021 at

GSoC'21 Raspberry Pi BSP project

I've been going through the RTEMS raspberry pi repository, And i'm having trouble understanding a couple of things there. the Pi1 (and Pi Zero) had the BCM2835 SoC while the pi2 had the BCM2836 SoC, now, in the bsp directory where the raspberry pi header is defined, the header file has register

RE: [PATCH 0/2] covoar: Handle symbol sets

On Mon, Apr 5, 2021 at 2:25 PM Alex White wrote: > > This patch set changes the way covoar is invoked so that its run time > is greatly reduced. For instance, a full coverage run for the > xilinx_zynq_a9_qemu took 58 minutes before these changes. After making > these changes, that same coverage

[PATCH 1/4] main_cp.c: Unused value (CID #1255344)

CID 1255344: Unused value in copy(). Closes #4339 --- cpukit/libmisc/shell/main_cp.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..2984a50 100644 ---

[PATCH 2/4] print-ls.c: Unused value (CID #1255346)

CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340 --- cpukit/libmisc/shell/print-ls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c index 15702b4..95a2cdf 100644 ---

[PATCH 4/4] disp_hcms29xx.c: Unused value (CID #1399752)

CID 1399752: Unused value in disp_hcms29xx_update_task(). Closes #4342 --- bsps/shared/dev/display/disp_hcms29xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 740aa56..5ad7063

[PATCH 3/4] fastlz.c: Unused value (CID #1399751)

CID 1399751: Unused value in fastlz2_compress(). Closes #4341 --- cpukit/libdl/fastlz.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c index 3c9d6f6..7257c98 100644 --- a/cpukit/libdl/fastlz.c +++

[PATCH 0/4] Unused value Coverity issues

Hi, For these patches, I got rid of variables that are being reassigned before their previous value is being used, and those changes were put in #ifdefs. Thanks, Ryan Ryan Long (4): main_cp.c: Unused value (CID #1255344) print-ls.c: Unused value (CID #1255346) fastlz.c: Unused value

[PATCH 1/2] covoar: Split symbols by symbol set

This changes the way covoar organizes the symbols. Instead of treating all symbols as one set, covoar is now aware of multiple symbol sets and tracks statistics for each set. It now also generates reports for each symbol set. This change relieves the caller of covoar of the reponsibility of

[PATCH 2/2] coverage.py: Call covoar once

Updates #4374 --- tester/rt/coverage.py | 59 +-- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py index 29ed60b..8860c94 100644 --- a/tester/rt/coverage.py +++ b/tester/rt/coverage.py @@ -304,22

[PATCH 0/2] covoar: Handle symbol sets

This patch set changes the way covoar is invoked so that its run time is greatly reduced. For instance, a full coverage run for the xilinx_zynq_a9_qemu took 58 minutes before these changes. After making these changes, that same coverage run takes 3 minutes 15 seconds. Care has been taken to limit

Re: GSoC 2021 Student Applications Open and Deadline

On Mon, Apr 5, 2021 at 11:26 AM Joel Sherrill wrote: > > > > On Mon, Apr 5, 2021 at 12:13 PM Gedare Bloom wrote: >> >> As I recall, students can submit their 'final' PDF proposals multiple >> times, so unless a student is not certain about submitting a proposal >> to RTEMS, they should feel free

Re: GSoC 2021 Student Applications Open and Deadline

On Mon, Apr 5, 2021 at 12:13 PM Gedare Bloom wrote: > As I recall, students can submit their 'final' PDF proposals multiple > times, so unless a student is not certain about submitting a proposal > to RTEMS, they should feel free to submit their drafts as final once > they have the bulk of it

Re: [PATCH v2 0/3] Unchecked return value from library patches

All 3 are fine with me, thanks On Mon, Apr 5, 2021 at 7:28 AM Ryan Long wrote: > > Hi, > > For these patches, I just added #ifdefs and (void)'s to get rid of the > issues. > > Thanks, > Ryan > > Ryan Long (3): > gen_uuid.c: Ignore return values from fcntl() > main_cp.c: Ignore return value

Re: GSoC 2021 Student Applications Open and Deadline

As I recall, students can submit their 'final' PDF proposals multiple times, so unless a student is not certain about submitting a proposal to RTEMS, they should feel free to submit their drafts as final once they have the bulk of it done. Probably should confirm that however. Gedare On Mon, Apr

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

ok, push on Wednesday if no one complains On Sat, Apr 3, 2021 at 7:06 PM Vijay Kumar Banerjee wrote: > > --- > netlegacy.py | 18 +- > nfsclient/wscript | 1 + > wscript | 2 +- > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/netlegacy.py

Re: [PATCH rtems-net-legacy v2] Remove RTEMS_NETWORKING checks

On Sat, Apr 3, 2021 at 2:13 PM Vijay Kumar Banerjee wrote: > > > > On Sat, Apr 3, 2021 at 12:27 PM Gedare Bloom wrote: > > > > On Fri, Apr 2, 2021 at 7:32 PM Vijay Kumar Banerjee wrote: > > > > > > * Remove nfsclient wscript and build from netlegacy.py > > > > These two different changes

Re: [PATCH 1/2] Added FAQ page

On Sat, Apr 3, 2021 at 5:15 PM Chris Johns wrote: > > On 3/4/21 6:29 am, Gedare Bloom wrote: > > On Fri, Apr 2, 2021 at 12:55 PM Joel Sherrill wrote: > >> On Fri, Apr 2, 2021 at 1:50 PM Ayushman Mishra > >> wrote: > >>> > >>> Sir, It was given as an issue https://devel.rtems.org/ticket/3958 (

Re: Ticket#3889 updated

On Sat, Apr 3, 2021 at 4:04 PM zack_on_the_speed_chanel wrote: > > Thanks so much I was able to get it working! I was able to modify the test > code and i was able to create the clock with the clock monotonic. > > I basically changed the the clock create argument to CLOCK_MONOTONIC which >

Re: GSoC Project- BSP Executable Conversion

On Sat, Apr 3, 2021 at 1:29 PM Daman Bir Singh wrote: > > Thanks for the update. > > If It's not too late, another project I would like to suggest is 4213, > libbsd: Reduce footprint of minimal buildset. Please tell me if I can go > ahead with this project. > Yes, #4213 would be suitable for

Re: Uncrustify Configuration vs RTEMS Coding Style

On Mon, Apr 5, 2021 at 9:51 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Joel, > > On 04/04/2021 22:19, Joel Sherrill wrote: > > Hi Sebastian, > > > > Do you have a list or remember where uncrustify could not match the > > RTEMS Coding Style? > > my uncrustify had 742

Re: Uncrustify Configuration vs RTEMS Coding Style

Hello Joel, On 04/04/2021 22:19, Joel Sherrill wrote: Hi Sebastian, Do you have a list or remember where uncrustify could not match the RTEMS Coding Style? my uncrustify had 742 options and I didn't manage do find an option set which produces the RTEMS Coding Style. I think using options

[PATCH v2 2/3] main_cp.c: Ignore return value from stat()

CID 26051: Unchecked return value from library in main_cp(). Closes #4365 --- cpukit/libmisc/shell/main_cp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..c2ffc10 100644 ---

[PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 9f59e9d..564bc30 100644 ---

[PATCH v2 0/3] Unchecked return value from library patches

Hi, For these patches, I just added #ifdefs and (void)'s to get rid of the issues. Thanks, Ryan Ryan Long (3): gen_uuid.c: Ignore return values from fcntl() main_cp.c: Ignore return value from stat() main_help.c: Do not care what char is returned by getchar()

[PATCH v2 1/3] gen_uuid.c: Ignore return values from fcntl()

CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpukit/libmisc/uuid/gen_uuid.c

GSoC 2021 Student Applications Open and Deadline

Hi I wanted to make sure all the students interested in GSoC 2021 with RTEMS were aware that the application period is open and that the deadline for applications is April 13 18:00 UTC. This means you really need to get your proposal together soon to allow potential mentors to review it and

RE: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

When you say "allocating the main data structure", are you referring to the Run-Time Link Editor (rtl)? If so, rtems_rtl_data_init() is allocating memory for it. If it fails then rtems_rtl_data_init() returns false. Then, this causes rtems_rtl_lock() to return NULL. -Original Message-