[PATCH v2] rtems: Constify rtems_task_wake_when()

Add a parameter to _TOD_Validate() to disable the validation of the ticks member. There are two reasons for this change. Firstly, in rtems_task_wake_when() was a double check for time_buffer == NULL (one in rtems_task_wake_when() and one in _TOD_Validate()). Secondly, the ticks member is

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

On 11/05/2021 22:00, Gedare Bloom wrote: diff --git a/bsps/arm/altera-cyclone-v/rtc/rtc.c b/bsps/arm/altera-cyclone-v/rtc/rtc.c index 3e8c68e789..fb30da8d66 100644 --- a/bsps/arm/altera-cyclone-v/rtc/rtc.c +++ b/bsps/arm/altera-cyclone-v/rtc/rtc.c @@ -353,10 +353,9 @@ static int

Re: [PATCH 3/3] rtems: Constify rtems_task_wake_when()

On 11/05/2021 22:07, Gedare Bloom wrote: I'm not a big fan of the way this has been implemented. It exposes an internal implementation detail (how you mask the ticks). I don't quite see why it is being done. [...] diff --git a/cpukit/rtems/src/taskwakewhen.c b/cpukit/rtems/src/taskwakewhen.c

Re: [PATCH v2] user/bld/index.rst: removed references to legacy network config options

Hi Harrison, This patch looks good. If no one objects by Friday, I'll push this. Thanks. Best regards, Vijay On Tue, May 11, 2021 at 7:16 PM Harrison Edward Gerber wrote: > > --- > user/bld/index.rst | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/user/bld/index.rst

[PATCH v2] user/bld/index.rst: removed references to legacy network config options

--- user/bld/index.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/user/bld/index.rst b/user/bld/index.rst index ebedf5a..411b3a2 100644 --- a/user/bld/index.rst +++ b/user/bld/index.rst @@ -309,10 +309,6 @@ in the configuration file. Set ``RTEMS_MULTIPROCESSING`` to

Re: [PATCH 3/3] rtems: Constify rtems_task_wake_when()

I'm not a big fan of the way this has been implemented. It exposes an internal implementation detail (how you mask the ticks). I don't quite see why it is being done. On Tue, May 11, 2021 at 9:38 AM Sebastian Huber wrote: > > Add a parameter to _TOD_Validate() to disable the validation of the >

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

On Tue, May 11, 2021 at 9:38 AM Sebastian Huber wrote: > > From: Frank Kühndel > > This patch fixes bug #4403. Directives > > * rtems_timer_fire_when() > * rtems_timer_server_fire_when() > * rtems_task_wake_when() > > are documented to return RTEMS_INVALID_ADDRESS when their time-of-day >

RE: [PATCH v2 1/5] libcsupport: Added futimens() and utimensat()

-Original Message- From: Gedare Bloom Sent: Monday, May 10, 2021 11:50 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH v2 1/5] libcsupport: Added futimens() and utimensat() On Mon, May 10, 2021 at 3:16 PM Ryan Long wrote: > > Reply is below. > > -Original Message-

[PATCH 1/3] _TOD_Validate(): Fix incorrect return code

From: Frank Kühndel This patch fixes bug #4403. Directives * rtems_timer_fire_when() * rtems_timer_server_fire_when() * rtems_task_wake_when() are documented to return RTEMS_INVALID_ADDRESS when their time-of-day argument is NULL. But actually they return RTEMS_INVALID_CLOCK. To fix the issue

[PATCH 0/3] Improve time of day validation

Frank Kühndel (1): _TOD_Validate(): Fix incorrect return code Sebastian Huber (2): rtems: Use rtems_clock_get_ticks_per_second() rtems: Constify rtems_task_wake_when() bsps/arm/altera-cyclone-v/rtc/rtc.c| 11 - bsps/shared/dev/rtc/rtc-support.c | 2 +-

[PATCH 2/3] rtems: Use rtems_clock_get_ticks_per_second()

This avoids an integer division at runtime. --- cpukit/rtems/src/clocktodvalidate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/rtems/src/clocktodvalidate.c b/cpukit/rtems/src/clocktodvalidate.c index d8e9d01382..95c8e77c37 100644 ---

[PATCH 3/3] rtems: Constify rtems_task_wake_when()

Add a parameter to _TOD_Validate() to disable the validation of the ticks member. Close #4406. --- bsps/arm/altera-cyclone-v/rtc/rtc.c| 3 +-- bsps/shared/dev/rtc/rtc-support.c | 2 +- cpukit/include/rtems/rtems/clockimpl.h | 13 - cpukit/include/rtems/rtems/tasks.h |

[PATCH v4] sb: Merge mailer changes from rtems-tools

This adds the improved mailer.py script from rtems-tools. Closes #4388 --- source-builder/sb/mailer.py | 194 ++-- source-builder/sb/options.py| 26 - source-builder/sb/setbuilder.py | 2 + 3 files changed, 189 insertions(+), 33 deletions(-) diff --git

Re: Error when using RTEMS_MICROSECONDS_TO_TICKS

> > Yes, 6000 microseconds isn't 6 seconds. :p Ouch. Yes. Thanks. Use (rtems_clock_get_ticks_per_second() * 6) as documented here: > > https://docs.rtems.org/releases/rtems-docs-4.11.2/c-user/clock_manager.html#rtems-clock-get-ticks-per-second > Yes, This works! Thanks. On Tue, May 11, 2021

Re: timing on qemu

Thank you for the reply. I should have searched for the definition before asking for help. On Tue, May 11, 2021 at 11:39 AM Gedare Bloom wrote: > On Sat, May 8, 2021 at 12:09 PM Richi Dubey wrote: > > > > Hi, > > > > When I use benchmark_timer_initialize() and later read the value with >

Re: Error when using RTEMS_MICROSECONDS_TO_TICKS

On Tue, May 11, 2021 at 1:11 AM Gedare Bloom wrote: > On Sun, May 9, 2021 at 9:33 AM Richi Dubey wrote: > > > > Hi, > > > > I am using the line: > rtems_task_wake_after(RTEMS_MICROSECONDS_TO_TICKS(6000)); in my test > program to emulate a 6 seconds sleep. But when I deubg the program using >

Re: [PATCH rtems-libbsd v2] ipsec-tools/pfkey: Fix socket leak

Thanks. I pushed them (with separate tickets for 5 and 6). Am 10.05.21 um 22:52 schrieb Gedare Bloom: looks good, thanks. for the backport please open a separate ticket to 5. On Mon, May 10, 2021 at 11:26 AM Christian MAUDERER wrote: Only change is a better description. Am 10.05.21 um

Re: [PATCH] user/bld/index.rst: removed references to legacy network config options

ignore this patch, I spoke with Harrison on Discord and he will send another in the next few days On Sat, May 8, 2021 at 8:13 PM Harrison Edward Gerber wrote: > > From: Harrison > > --- > user/bld/index.rst | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/user/bld/index.rst

Re: code review: help implementing clock_montonic

On Fri, May 7, 2021 at 12:53 PM zack_on_the_speed_chanel wrote: > > hello, > > Currenttly i'm trying to implement the clock_monotonic which was part of > ticket #3889. So far these are the changes are as follows > This ticket mostly references the need for a test. Have you tried to write a test

Re: Error when using RTEMS_MICROSECONDS_TO_TICKS

On Sun, May 9, 2021 at 9:33 AM Richi Dubey wrote: > > Hi, > > I am using the line: > rtems_task_wake_after(RTEMS_MICROSECONDS_TO_TICKS(6000)); in my test program > to emulate a 6 seconds sleep. But when I deubg the program using qemu, I do > not see it waiting for 6 seconds; on debugging,

Re: timing on qemu

On Sat, May 8, 2021 at 12:09 PM Richi Dubey wrote: > > Hi, > > When I use benchmark_timer_initialize() and later read the value with > benchmark_timer_read(), it always shows 0 for me in qemu. Is this expected? > > I am using the arm/realview_pbx_a9_qemu bsp, qemu 4.1.0, and I built the >

Fwd: [PATCH] riscv/console: console-config.c update

Gentle Reminder. Hi All, Can you please review this patch and let me know if there are any suggestions/comments. Regards, Somesh -- Forwarded message - From: Somesh Deshmukh Date: Wed, May 5, 2021 at 11:26 PM Subject: [PATCH] riscv/console: console-config.c update To: Cc: