Re: [PATCH] score: Add Thread_queue_Deadlock_status

On 24/09/2021 20:21, Sebastian Huber wrote: Replace the boolen return value with the new enum Thread_queue_Deadlock_status. This improves the code readability. Improve documentation. Shorten function names. Ping. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim

Re: [PATCH] score: Avoid dead code in thread queue surrender

On 23/09/2021 07:38, Sebastian Huber wrote: For uniprocessor configurations, this patch removes dead code in the _Thread_queue_Surrender() and _Thread_queue_Surrender_priority_ceiling() functions. Dead code is removed from _Thread_queue_Surrender_sticky(). Ping. -- embedded brains GmbH Herr

Re: IDLE Stacks Not Allocated via User Provided Stack Allocator

On 30/09/2021 00:43, Joel Sherrill wrote: Hi In Feb 2020, idle thread stack memory was changed to be statically allocated which is good for most RTEMS deployments. However, it is broken when you REALLY need it to be allocated by the plugin stack allocator. The paravirtualized environment that

Re: [PATCH] record-client.c: Ignore return value from visit()

On 29/09/2021 16:28, Ryan Long wrote: CID 1503011: Unchecked return value in resolve_hold_back(). Looks good, thanks. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94

Re: [PATCH rtems-docs] eng: Add rules for attribution

On 29/9/21 6:38 pm, Christian MAUDERER wrote: > Am 29.09.21 um 02:40 schrieb Chris Johns: >> On 28/9/21 11:11 pm, Christian MAUDERER wrote: >>> Hello Joel, >>> >>> Am 28.09.21 um 14:48 schrieb Joel Sherrill: On Tue, Sep 28, 2021, 1:40 AM Christian MAUDERER >>>

Re: [PATCH] rtems: Adjust parameter names

On Wed, Sep 29, 2021, 6:23 PM Chris Johns wrote: > On 30/9/21 6:30 am, Joel Sherrill wrote: > > On Wed, Sep 29, 2021, 3:24 PM Chris Johns > > wrote: > > > > Is it worth mentioning in the commit message the reserved nature of > time is the > > reason for the

Re: [PATCH] rtems: Adjust parameter names

On 30/9/21 6:30 am, Joel Sherrill wrote: > On Wed, Sep 29, 2021, 3:24 PM Chris Johns > wrote: > > Is it worth mentioning in the commit message the reserved nature of time > is the > reason for the change? > > > Do you mean the method time()? No. I checked the

IDLE Stacks Not Allocated via User Provided Stack Allocator

Hi In Feb 2020, idle thread stack memory was changed to be statically allocated which is good for most RTEMS deployments. However, it is broken when you REALLY need it to be allocated by the plugin stack allocator. The paravirtualized environment that tripped over this provides stack memory

Re: [PATCH] rtems: Adjust parameter names

On Wed, Sep 29, 2021, 3:24 PM Chris Johns wrote: > Is it worth mentioning in the commit message the reserved nature of time > is the > reason for the change? > Do you mean the method time()? > > Otherwise OK. > > On 30/9/21 12:10 am, Sebastian Huber wrote: > > Adjust parameter names to match

Re: [PATCH] rtems: Adjust parameter names

Is it worth mentioning in the commit message the reserved nature of time is the reason for the change? Otherwise OK. On 30/9/21 12:10 am, Sebastian Huber wrote: > Adjust parameter names to match with the declaration. > > Close #4035. > --- > cpukit/rtems/src/clockgettod.c| 20

Re: [PATCH] rtems: Justify integer conversions

OK On 29/9/21 11:24 pm, Sebastian Huber wrote: > Close #2548. > --- > cpukit/rtems/src/clockgettod.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/cpukit/rtems/src/clockgettod.c b/cpukit/rtems/src/clockgettod.c > index 5058b42375..01daa3dc15 100644 > ---

Re: [PATCH] glossary: Add terms

OK On 29/9/21 8:45 pm, Sebastian Huber wrote: > --- > c-user/glossary.rst | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/c-user/glossary.rst b/c-user/glossary.rst > index f85c08c..e91e356 100644 > --- a/c-user/glossary.rst > +++ b/c-user/glossary.rst >

[PATCH] ReportsBase.cc: Add assert for member variables

The uncoveredRanges and uncoveredBranch member variables are allocated as a pair. They are both either NULL or not NULL. Coverity does not know this though, so this assert is added to ensure they are not NULL before being dereferenced. CID 1503710: Dereference after null check Closes #4428 ---

[PATCH] record-client.c: Ignore return value from visit()

CID 1503011: Unchecked return value in resolve_hold_back(). Closes #4423 --- trace/record/record-client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/trace/record/record-client.c b/trace/record/record-client.c index e1365fe..edc4ab3 100644 ---

[PATCH] rtems: Adjust parameter names

Adjust parameter names to match with the declaration. Close #4035. --- cpukit/rtems/src/clockgettod.c| 20 ++-- cpukit/rtems/src/clockgettodtimeval.c | 6 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cpukit/rtems/src/clockgettod.c

[PATCH] rtems: Justify integer conversions

Close #2548. --- cpukit/rtems/src/clockgettod.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/rtems/src/clockgettod.c b/cpukit/rtems/src/clockgettod.c index 5058b42375..01daa3dc15 100644 --- a/cpukit/rtems/src/clockgettod.c +++

[PATCH] glossary: Add terms

--- c-user/glossary.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index f85c08c..e91e356 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -101,9 +101,21 @@ Glossary C++11 The standard

Re: [PATCH rtems-docs] eng: Add rules for attribution

Am 29.09.21 um 02:40 schrieb Chris Johns: On 28/9/21 11:11 pm, Christian MAUDERER wrote: Hello Joel, Am 28.09.21 um 14:48 schrieb Joel Sherrill: On Tue, Sep 28, 2021, 1:40 AM Christian MAUDERER mailto:christian.maude...@embedded-brains.de>> wrote:     Hello Joel,     Am 28.09.21 um