libbsd tests not linking

2022-07-23 Thread Joel Sherrill
Hi

I have updated tools. rtems, and am building libbsd for arm/zynq qemu. The
build fails with this:

Binary file
build/arm-rtems6-xilinx_zynq_a9_qemu-default/freebsd/lib/libc/stdio/fgetln.c.12.o
matches
Binary file build/arm-rtems6-xilinx_zynq_a9_qemu-default/libbsd.a matches
b.log:/home/joel/rtems-work/rtems-libbsd/build/arm-rtems6-xilinx_zynq_a9_qemu-default/../../freebsd/lib/libc/stdio/fgetln.c:150:
undefined reference to `__getreent'

Looks like it is coming from here.

freebsd/lib/libc/stdio/local.h:#define __srefill(_x)
__srefill_r(__getreent(), _x)

I guess this macro needs updating to whatever the current correct thing is
to do it. But I am not confident what that would be.

Thanks.

--joel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v4 1/7] bsps/stm32f4 Include STM32F4 HAL

2022-07-23 Thread Duc Doan
Hello Christian,

On Sat, 2022-07-23 at 10:31 +0200, o...@c-mauderer.de wrote:
> Hello Duc,
> 
> Am 23.07.22 um 09:37 schrieb Duc Doan:
> > Hello Karel,
> > 
> > On Sat, 2022-07-23 at 09:09 +0200, Karel Gardas wrote:
> > > 
> > > Duc,
> > > 
> > > where have you taken F4 HAL exactly? I'm asking since your import
> > > is
> > > full of CRLF line endings which we try hard to eliminate in RTEMS
> > > while
> > > original is not. Proof:
> > > 
> > > $ git clone https://github.com/STMicroelectronics/STM32CubeF4.git
> > > Cloning into 'STM32CubeF4'...
> > > remote: Enumerating objects: 75365, done.
> > > remote: Counting objects: 100% (1271/1271), done.
> > > remote: Compressing objects: 100% (48/48), done.
> > > remote: Total 75365 (delta 1231), reused 1229 (delta 1221), pack-
> > > reused
> > > 74094
> > > Receiving objects: 100% (75365/75365), 157.59 MiB | 6.87 MiB/s,
> > > done.
> > > Resolving deltas: 100% (46903/46903), done.
> > > Updating files: 100% (39125/39125), done.
> > > rtems@silence:~/vcs$ cd STM32CubeF4/
> > > rtems@silence:~/vcs/STM32CubeF4$
> > > rtems@silence:~/vcs/STM32CubeF4$
> > > rtems@silence:~/vcs/STM32CubeF4$ git ls-files --eol|grep crlf
> > > rtems@silence:~/vcs/STM32CubeF4$
> > > 
> > > 
> > > Please use the command above to review your CRLF files.
> > > 
> > > Thanks,
> > > Karel
> > > 
> > 
> > I took the HAL from ST's website by downloading the zip. And yes,
> > when
> > I tried the command, all HAL files have CRLF. I will remove them in
> > the
> > next patch set.
> 
> Have you thought about using the STM32CubeF4 repo that Karel linked 
> instead of the ZIP file as a source?
> 
> Can you please add the source for your files to the commit
> description? 
> If you used a zip, provide the link, date, version (if available) and
> maybe a checksum of the file. If you used a git repository (which I 
> would prefer), provide a link and the commit ID. That makes it
> simpler 
> to some when find the sources that you used.
> 
> Best regards
> 
> Christian
> 

Yes, in the next patch set I will replace the HAL files by those from
the repo Karel linked. I will remember to provide the link and commit
ID in the commit message.

Best,

Duc Doan

> > 
> > Thanks for the reminder,
> > 
> > Duc Doan
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> > 

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH v4 1/7] bsps/stm32f4 Include STM32F4 HAL

2022-07-23 Thread oss

Hello Duc,

Am 23.07.22 um 09:37 schrieb Duc Doan:

Hello Karel,

On Sat, 2022-07-23 at 09:09 +0200, Karel Gardas wrote:


Duc,

where have you taken F4 HAL exactly? I'm asking since your import is
full of CRLF line endings which we try hard to eliminate in RTEMS
while
original is not. Proof:

$ git clone https://github.com/STMicroelectronics/STM32CubeF4.git
Cloning into 'STM32CubeF4'...
remote: Enumerating objects: 75365, done.
remote: Counting objects: 100% (1271/1271), done.
remote: Compressing objects: 100% (48/48), done.
remote: Total 75365 (delta 1231), reused 1229 (delta 1221), pack-
reused
74094
Receiving objects: 100% (75365/75365), 157.59 MiB | 6.87 MiB/s, done.
Resolving deltas: 100% (46903/46903), done.
Updating files: 100% (39125/39125), done.
rtems@silence:~/vcs$ cd STM32CubeF4/
rtems@silence:~/vcs/STM32CubeF4$
rtems@silence:~/vcs/STM32CubeF4$
rtems@silence:~/vcs/STM32CubeF4$ git ls-files --eol|grep crlf
rtems@silence:~/vcs/STM32CubeF4$


Please use the command above to review your CRLF files.

Thanks,
Karel



I took the HAL from ST's website by downloading the zip. And yes, when
I tried the command, all HAL files have CRLF. I will remove them in the
next patch set.


Have you thought about using the STM32CubeF4 repo that Karel linked 
instead of the ZIP file as a source?


Can you please add the source for your files to the commit description? 
If you used a zip, provide the link, date, version (if available) and 
maybe a checksum of the file. If you used a git repository (which I 
would prefer), provide a link and the commit ID. That makes it simpler 
to some when find the sources that you used.


Best regards

Christian



Thanks for the reminder,

Duc Doan
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH v4 1/7] bsps/stm32f4 Include STM32F4 HAL

2022-07-23 Thread Duc Doan
Hello Karel,

On Sat, 2022-07-23 at 09:09 +0200, Karel Gardas wrote:
> 
> Duc,
> 
> where have you taken F4 HAL exactly? I'm asking since your import is 
> full of CRLF line endings which we try hard to eliminate in RTEMS
> while 
> original is not. Proof:
> 
> $ git clone https://github.com/STMicroelectronics/STM32CubeF4.git
> Cloning into 'STM32CubeF4'...
> remote: Enumerating objects: 75365, done.
> remote: Counting objects: 100% (1271/1271), done.
> remote: Compressing objects: 100% (48/48), done.
> remote: Total 75365 (delta 1231), reused 1229 (delta 1221), pack-
> reused 
> 74094
> Receiving objects: 100% (75365/75365), 157.59 MiB | 6.87 MiB/s, done.
> Resolving deltas: 100% (46903/46903), done.
> Updating files: 100% (39125/39125), done.
> rtems@silence:~/vcs$ cd STM32CubeF4/
> rtems@silence:~/vcs/STM32CubeF4$
> rtems@silence:~/vcs/STM32CubeF4$
> rtems@silence:~/vcs/STM32CubeF4$ git ls-files --eol|grep crlf
> rtems@silence:~/vcs/STM32CubeF4$
> 
> 
> Please use the command above to review your CRLF files.
> 
> Thanks,
> Karel
> 

I took the HAL from ST's website by downloading the zip. And yes, when
I tried the command, all HAL files have CRLF. I will remove them in the
next patch set.

Thanks for the reminder,

Duc Doan
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: [PATCH v4 1/7] bsps/stm32f4 Include STM32F4 HAL

2022-07-23 Thread Karel Gardas



Duc,

where have you taken F4 HAL exactly? I'm asking since your import is 
full of CRLF line endings which we try hard to eliminate in RTEMS while 
original is not. Proof:


$ git clone https://github.com/STMicroelectronics/STM32CubeF4.git
Cloning into 'STM32CubeF4'...
remote: Enumerating objects: 75365, done.
remote: Counting objects: 100% (1271/1271), done.
remote: Compressing objects: 100% (48/48), done.
remote: Total 75365 (delta 1231), reused 1229 (delta 1221), pack-reused 
74094

Receiving objects: 100% (75365/75365), 157.59 MiB | 6.87 MiB/s, done.
Resolving deltas: 100% (46903/46903), done.
Updating files: 100% (39125/39125), done.
rtems@silence:~/vcs$ cd STM32CubeF4/
rtems@silence:~/vcs/STM32CubeF4$
rtems@silence:~/vcs/STM32CubeF4$
rtems@silence:~/vcs/STM32CubeF4$ git ls-files --eol|grep crlf
rtems@silence:~/vcs/STM32CubeF4$


Please use the command above to review your CRLF files.

Thanks,
Karel

On 7/23/22 05:53, Duc Doan wrote:

This patch is too large so I cannot send via email. Please find it here:
https://github.com/dtbpkmte/GSoC-2022-RTEMS/commit/098ca07151bb9186c7681c45f8474cf1441acb40

---
  .../stm32f4/hal/Legacy/stm32f4xx_hal_can.c| 1679 
  .../stm32f4/hal/Legacy/stm32f4xx_hal_eth.c| 2307 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal.c  |  615 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_adc.c  | 2110 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_adc_ex.c   | 1112 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_can.c  | 2462 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_cec.c  |  996 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_cortex.c   |  502 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_crc.c  |  328 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_cryp.c | 7132 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_cryp_ex.c  |  680 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dac.c  | 1341 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dac_ex.c   |  495 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dcmi.c | 1161 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dcmi_ex.c  |  182 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dfsdm.c| 4423 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dma.c  | 1305 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dma2d.c| 2126 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dma_ex.c   |  313 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_dsi.c  | 2760 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_eth.c  | 3112 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_exti.c |  547 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_flash.c|  775 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_flash_ex.c | 1347 +++
  .../stm32f4/hal/stm32f4xx_hal_flash_ramfunc.c |  172 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_fmpi2c.c   | 6864 +++
  .../arm/stm32f4/hal/stm32f4xx_hal_fmpi2c_ex.c |  258 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_fmpsmbus.c | 2749 ++
  .../stm32f4/hal/stm32f4xx_hal_fmpsmbus_ex.c   |  145 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_gpio.c |  533 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_hash.c | 3514 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_hash_ex.c  | 1040 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_hcd.c  | 1728 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_i2c.c  | 7524 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_i2c_ex.c   |  182 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_i2s.c  | 2094 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_i2s_ex.c   | 1135 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_irda.c | 2687 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_iwdg.c |  262 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_lptim.c| 2484 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_ltdc.c | 2215 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_ltdc_ex.c  |  151 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_mmc.c  | 3201 +++
  .../stm32f4/hal/stm32f4xx_hal_msp_template.c  |  100 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_nand.c | 2405 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_nor.c  | 1543 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_pccard.c   |  946 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_pcd.c  | 2387 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_pcd_ex.c   |  341 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_pwr.c  |  571 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_pwr_ex.c   |  600 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_qspi.c | 2915 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_rcc.c  | 1122 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_rcc_ex.c   | 3784 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_rng.c  |  867 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_rtc.c  | 1896 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_rtc_ex.c   | 1878 
  bsps/arm/stm32f4/hal/stm32f4xx_hal_sai.c  | 2554 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_sai_ex.c   |  310 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_sd.c   | 3277 +++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_sdram.c| 1308 +++
  .../arm/stm32f4/hal/stm32f4xx_hal_smartcard.c | 2364 +
  bsps/arm/stm32f4/hal/stm32f4xx_hal_smbus.c| 2784 ++
  bsps/arm/stm32f4/hal/stm32f4xx_hal_spdifrx.c  | 1627