Re: [PATCH rtems-docs] eng: show how to set local default subject-prefix
Looks good to me! I use this on all of the repos I send mail from. Kinsey On Thu, Nov 3, 2022 at 11:33 AM Gedare Bloom wrote: > --- > eng/vc-users.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/eng/vc-users.rst b/eng/vc-users.rst > index 64c2624..680c004 100644 > --- a/eng/vc-users.rst > +++ b/eng/vc-users.rst > @@ -466,6 +466,11 @@ the rtems-docs repo, use > >git format-patch --subject-prefix="PATCH rtems-docs" ... > > +You can set a default subject prefix for each repository locally, for > example: > + > +.. code-block:: shell > + git config format.subjectprefix "PATCH rtems-docs" > + > Patches created using ``git format-patch`` are formatted so they can be > emailed > and rely on having Git configured with your name and email address, for > example > > -- > 2.34.1 > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 2/2] wscript: rename bsp_list to bsplist
+1
On 4/11/2022 2:59 am, Gedare Bloom wrote:
> ---
> wscript | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/wscript b/wscript
> index a8510edbee..b42c8f1119 100755
> --- a/wscript
> +++ b/wscript
> @@ -1694,7 +1694,7 @@ COMPILER = {}""".format(
> no_matches_error(ctx, white_list)
>
>
> -def bsp_list(ctx):
> +def bsplist(ctx):
> """lists base BSP variants"""
> check_forbidden_options(
> ctx, ["compiler", "config", "options", "tools", "top_group",
> "version"]
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH rtems-docs] eng: show how to set local default subject-prefix
--- eng/vc-users.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/eng/vc-users.rst b/eng/vc-users.rst index 64c2624..680c004 100644 --- a/eng/vc-users.rst +++ b/eng/vc-users.rst @@ -466,6 +466,11 @@ the rtems-docs repo, use git format-patch --subject-prefix="PATCH rtems-docs" ... +You can set a default subject prefix for each repository locally, for example: + +.. code-block:: shell + git config format.subjectprefix "PATCH rtems-docs" + Patches created using ``git format-patch`` are formatted so they can be emailed and rely on having Git configured with your name and email address, for example -- 2.34.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 1/2] eng, user: update bsp_defaults to bspdefaults
Oops, looks like I don't have my scripts set up properly for tagging the repo. Anyway these two are for rtems-docs, reflecting the proposal to change the rtems.git/wscript API On Thu, Nov 3, 2022 at 9:58 AM Gedare Bloom wrote: > > --- > eng/build-system.rst | 2 +- > user/bld/index.rst| 16 > user/bsps/arm/imxrt.rst | 2 +- > user/bsps/arm/stm32h7.rst | 2 +- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/eng/build-system.rst b/eng/build-system.rst > index 030679d..dd979e9 100644 > --- a/eng/build-system.rst > +++ b/eng/build-system.rst > @@ -79,7 +79,7 @@ In the ``./waf bsp_list`` command, the BSP list is > generated from the > BSP Defaults > > > -In the ``./waf bsp_defaults`` command, the BSP defaults are generated from > the > +In the ``./waf bspdefaults`` command, the BSP defaults are generated from the > :ref:`SpecTypeBuildBSPItemType` and :ref:`SpecTypeBuildOptionItemType` items. > Build specification items contribute to the command through the > ``do_defaults()`` method in the ``wscript``. > diff --git a/user/bld/index.rst b/user/bld/index.rst > index 411b3a2..d75cb5d 100644 > --- a/user/bld/index.rst > +++ b/user/bld/index.rst > @@ -123,7 +123,7 @@ items can be specified by the ``--rtems-specs`` command > line option. > BSP Defaults > > > -The BSP defaults command ``./waf bsp_defaults`` loads the build specification > +The BSP defaults command ``./waf bspdefaults`` loads the build specification > items and generates a list options with default values for each base BSP from > it. The list is sorted by architecture and base BSP name. Which base BSPs > are > listed can be controlled by the ``--rtems-bsps`` command line option. > Default > @@ -134,12 +134,12 @@ option. > > .. code-block:: none > > -$ ./waf bsp_defaults --rtems-bsps=gr712rc --rtems-compiler=gcc | grep > ABI_FLAGS > +$ ./waf bspdefaults --rtems-bsps=gr712rc --rtems-compiler=gcc | grep > ABI_FLAGS > ABI_FLAGS = -mcpu=leon3 -mfix-gr712rc > > .. code-block:: none > > -$ ./waf bsp_defaults --rtems-bsps=gr712rc --rtems-compiler=clang | grep > ABI_FLAGS > +$ ./waf bspdefaults --rtems-bsps=gr712rc --rtems-compiler=clang | grep > ABI_FLAGS > ABI_FLAGS = -mcpu=gr712rc > > Configure > @@ -222,12 +222,12 @@ option. > INHERIT = gr740 > COMPILER = clang > > -Use the ``./waf bsp_defaults`` command to get a list of all configuration > +Use the ``./waf bspdefaults`` command to get a list of all configuration > options with default values. > > .. code-block:: none > > -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 > +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 > [sparc/erc32] > # Flags passed to the library archiver > ARFLAGS = crD > @@ -246,7 +246,7 @@ options with default values. > INSTALL_LEGACY_MAKEFILES = True > > It is not recommended to blindly add all the options obtained through the > -``./waf bsp_defaults`` command to custom configuration files. The specified > +``./waf bspdefaults`` command to custom configuration files. The specified > options should be kept at the necessary minimum to get the desired build. > > Some projects may still want to specify all options in a configuration file > to > @@ -255,9 +255,9 @@ the user and base BSP values with the ``diff`` command. > > .. code-block:: none > > -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 > config.ini > +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 > config.ini > $ sed -i 's/BUILD_TESTS = False/BUILD_TESTS = True/' config.ini > -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 | diff -u - config.ini > +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 | diff -u - config.ini > --- config.ini 2019-12-04 08:21:36.049335872 +0100 > +++ - 2019-12-04 08:21:41.187432405 +0100 > @@ -31,7 +31,7 @@ > diff --git a/user/bsps/arm/imxrt.rst b/user/bsps/arm/imxrt.rst > index e185823..b4f37fd 100644 > --- a/user/bsps/arm/imxrt.rst > +++ b/user/bsps/arm/imxrt.rst > @@ -20,7 +20,7 @@ Build Configuration Options > Please see the documentation of the `IMXRT_*` and `BSP_*` configuration > options > for that. You can generate a default set of options with:: > > - ./waf bsp_defaults --rtems-bsps=arm/imxrt1052 > config.ini > + ./waf bspdefaults --rtems-bsps=arm/imxrt1052 > config.ini > > Boot Process > > diff --git a/user/bsps/arm/stm32h7.rst b/user/bsps/arm/stm32h7.rst > index ec7440f..9f1f082 100644 > --- a/user/bsps/arm/stm32h7.rst > +++ b/user/bsps/arm/stm32h7.rst > @@ -332,7 +332,7 @@ Generate default configuration for the board: > > .. code-block:: shell > > -$ ./waf bsp_defaults --rtems-bsps=arm/stm32h747i-disco > > stm32h747i-disco.ini > +$ ./waf bspdefaults --rtems-bsps=arm/stm32h747i-disco > > stm32h747i-disco.ini > Regenerate build specification cache (needs a couple of > seconds)... > > To run basic hello world or
[PATCH 2/2] wscript: rename bsp_list to bsplist
---
wscript | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/wscript b/wscript
index a8510edbee..b42c8f1119 100755
--- a/wscript
+++ b/wscript
@@ -1694,7 +1694,7 @@ COMPILER = {}""".format(
no_matches_error(ctx, white_list)
-def bsp_list(ctx):
+def bsplist(ctx):
"""lists base BSP variants"""
check_forbidden_options(
ctx, ["compiler", "config", "options", "tools", "top_group", "version"]
--
2.34.1
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH 1/2] wscript: rename bsp_defaults to bspdefaults
---
wscript | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/wscript b/wscript
index 4071cc9ef8..a8510edbee 100755
--- a/wscript
+++ b/wscript
@@ -1289,24 +1289,24 @@ def options(ctx):
rg.add_option(
"--rtems-bsps",
metavar="REGEX,...",
-help="a comma-separated list of Python regular expressions which
select the desired BSP variants (e.g. 'sparc/erc32'); it may be used in the
bsp_defaults and bsp_list commands",
+help="a comma-separated list of Python regular expressions which
select the desired BSP variants (e.g. 'sparc/erc32'); it may be used in the
bspdefaults and bsps commands",
)
rg.add_option(
"--rtems-compiler",
metavar="COMPILER",
-help="determines which compiler is used to list the BSP option
defaults [default: 'gcc']; it may be used in the bsp_defaults command; valid
compilers are: {}".format(
+help="determines which compiler is used to list the BSP option
defaults [default: 'gcc']; it may be used in the bspdefaults command; valid
compilers are: {}".format(
", ".join(compilers)
),
)
rg.add_option(
"--rtems-config",
metavar="CONFIG.INI,...",
-help="a comma-separated list of paths to the BSP configuration option
files [default: 'config.ini']; default option values can be obtained via the
bsp_defaults command; it may be used in the configure command",
+help="a comma-separated list of paths to the BSP configuration option
files [default: 'config.ini']; default option values can be obtained via the
bspdefaults command; it may be used in the configure command",
)
rg.add_option(
"--rtems-specs",
metavar="SPECDIRS,...",
-help="a comma-separated list of directory paths to build specification
items [default: 'spec/build']; it may be used in the bsp_defaults, bsp_list,
and configure commands",
+help="a comma-separated list of directory paths to build specification
items [default: 'spec/build']; it may be used in the bspdefaults, bsps, and
configure commands",
)
rg.add_option(
"--rtems-tools",
@@ -1316,12 +1316,12 @@ def options(ctx):
rg.add_option(
"--rtems-top-group",
metavar="UID",
-help="the UID of the top-level group [default: '/grp']; it may be used
in the bsp_defaults and configure commands",
+help="the UID of the top-level group [default: '/grp']; it may be used
in the bspdefaults and configure commands",
)
rg.add_option(
"--rtems-version",
metavar="VALUE",
-help="sets the RTEMS major version number; it is intended for RTEMS
maintainers and may be used in the bsp_defaults and configure commands",
+help="sets the RTEMS major version number; it is intended for RTEMS
maintainers and may be used in the bspdefaults and configure commands",
)
rg.add_option(
"--rtems-option",
@@ -1329,7 +1329,7 @@ def options(ctx):
action="append",
dest="rtems_options",
default=[],
-help="sets the option identified by KEY to the VALUE in the build
specification; it is intended for RTEMS maintainers and may be used in the
bsp_defaults and configure commands",
+help="sets the option identified by KEY to the VALUE in the build
specification; it is intended for RTEMS maintainers and may be used in the
bspdefaults and configure commands",
)
@@ -1653,7 +1653,7 @@ def no_matches_error(ctx, white_list):
ctx.fatal("The build specification contains no BSPs")
-def bsp_defaults(ctx):
+def bspdefaults(ctx):
"""get all options with default values for base BSP variants"""
check_forbidden_options(ctx, ["config", "tools"])
add_log_filter(ctx.cmd)
@@ -1680,7 +1680,7 @@ def bsp_defaults(ctx):
# selection and changing the compiler may lead to unpredictable behaviour if
# these options are not adjusted as well. Use the --rtems-compiler command
line
# option to get the default values for a particular compiler via
-# ./waf bsp_defaults.
+# ./waf bspdefaults.
COMPILER = {}""".format(
variant, compiler
)
--
2.34.1
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH 1/2] eng, user: update bsp_defaults to bspdefaults
--- eng/build-system.rst | 2 +- user/bld/index.rst| 16 user/bsps/arm/imxrt.rst | 2 +- user/bsps/arm/stm32h7.rst | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/eng/build-system.rst b/eng/build-system.rst index 030679d..dd979e9 100644 --- a/eng/build-system.rst +++ b/eng/build-system.rst @@ -79,7 +79,7 @@ In the ``./waf bsp_list`` command, the BSP list is generated from the BSP Defaults -In the ``./waf bsp_defaults`` command, the BSP defaults are generated from the +In the ``./waf bspdefaults`` command, the BSP defaults are generated from the :ref:`SpecTypeBuildBSPItemType` and :ref:`SpecTypeBuildOptionItemType` items. Build specification items contribute to the command through the ``do_defaults()`` method in the ``wscript``. diff --git a/user/bld/index.rst b/user/bld/index.rst index 411b3a2..d75cb5d 100644 --- a/user/bld/index.rst +++ b/user/bld/index.rst @@ -123,7 +123,7 @@ items can be specified by the ``--rtems-specs`` command line option. BSP Defaults -The BSP defaults command ``./waf bsp_defaults`` loads the build specification +The BSP defaults command ``./waf bspdefaults`` loads the build specification items and generates a list options with default values for each base BSP from it. The list is sorted by architecture and base BSP name. Which base BSPs are listed can be controlled by the ``--rtems-bsps`` command line option. Default @@ -134,12 +134,12 @@ option. .. code-block:: none -$ ./waf bsp_defaults --rtems-bsps=gr712rc --rtems-compiler=gcc | grep ABI_FLAGS +$ ./waf bspdefaults --rtems-bsps=gr712rc --rtems-compiler=gcc | grep ABI_FLAGS ABI_FLAGS = -mcpu=leon3 -mfix-gr712rc .. code-block:: none -$ ./waf bsp_defaults --rtems-bsps=gr712rc --rtems-compiler=clang | grep ABI_FLAGS +$ ./waf bspdefaults --rtems-bsps=gr712rc --rtems-compiler=clang | grep ABI_FLAGS ABI_FLAGS = -mcpu=gr712rc Configure @@ -222,12 +222,12 @@ option. INHERIT = gr740 COMPILER = clang -Use the ``./waf bsp_defaults`` command to get a list of all configuration +Use the ``./waf bspdefaults`` command to get a list of all configuration options with default values. .. code-block:: none -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 [sparc/erc32] # Flags passed to the library archiver ARFLAGS = crD @@ -246,7 +246,7 @@ options with default values. INSTALL_LEGACY_MAKEFILES = True It is not recommended to blindly add all the options obtained through the -``./waf bsp_defaults`` command to custom configuration files. The specified +``./waf bspdefaults`` command to custom configuration files. The specified options should be kept at the necessary minimum to get the desired build. Some projects may still want to specify all options in a configuration file to @@ -255,9 +255,9 @@ the user and base BSP values with the ``diff`` command. .. code-block:: none -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 > config.ini +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 > config.ini $ sed -i 's/BUILD_TESTS = False/BUILD_TESTS = True/' config.ini -$ ./waf bsp_defaults --rtems-bsps=sparc/erc32 | diff -u - config.ini +$ ./waf bspdefaults --rtems-bsps=sparc/erc32 | diff -u - config.ini --- config.ini 2019-12-04 08:21:36.049335872 +0100 +++ - 2019-12-04 08:21:41.187432405 +0100 @@ -31,7 +31,7 @@ diff --git a/user/bsps/arm/imxrt.rst b/user/bsps/arm/imxrt.rst index e185823..b4f37fd 100644 --- a/user/bsps/arm/imxrt.rst +++ b/user/bsps/arm/imxrt.rst @@ -20,7 +20,7 @@ Build Configuration Options Please see the documentation of the `IMXRT_*` and `BSP_*` configuration options for that. You can generate a default set of options with:: - ./waf bsp_defaults --rtems-bsps=arm/imxrt1052 > config.ini + ./waf bspdefaults --rtems-bsps=arm/imxrt1052 > config.ini Boot Process diff --git a/user/bsps/arm/stm32h7.rst b/user/bsps/arm/stm32h7.rst index ec7440f..9f1f082 100644 --- a/user/bsps/arm/stm32h7.rst +++ b/user/bsps/arm/stm32h7.rst @@ -332,7 +332,7 @@ Generate default configuration for the board: .. code-block:: shell -$ ./waf bsp_defaults --rtems-bsps=arm/stm32h747i-disco > stm32h747i-disco.ini +$ ./waf bspdefaults --rtems-bsps=arm/stm32h747i-disco > stm32h747i-disco.ini Regenerate build specification cache (needs a couple of seconds)... To run basic hello world or ticker samples you do not need to modify -- 2.34.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH 2/2] eng, user: update bsp_list to bsplist
--- eng/build-system.rst | 2 +- user/bld/index.rst | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/eng/build-system.rst b/eng/build-system.rst index dd979e9..6974aa8 100644 --- a/eng/build-system.rst +++ b/eng/build-system.rst @@ -73,7 +73,7 @@ the following ``waf`` commands do. BSP List -In the ``./waf bsp_list`` command, the BSP list is generated from the +In the ``./waf bsplist`` command, the BSP list is generated from the :ref:`SpecTypeBuildBSPItemType` items. BSP Defaults diff --git a/user/bld/index.rst b/user/bld/index.rst index d75cb5d..18092d2 100644 --- a/user/bld/index.rst +++ b/user/bld/index.rst @@ -54,7 +54,7 @@ Work Flow There are five steps necessary to build and install one or more BSPs. 1. Select which BSPs you want to build. See also :ref:`BSPs` and - ``./waf bsp_list``. + ``./waf bsplist``. 2. Write a BSP build configuration file (e.g. ``config.ini``) which determines which BSPs are built and how they are configured. @@ -93,7 +93,7 @@ Use ``./waf --help`` to get a list of commands and options. BSP List -The BSP list command ``./waf bsp_list`` loads the build specification items and +The BSP list command ``./waf bsplist`` loads the build specification items and generates a list of base BSPs from it. The list is sorted by architecture and base BSP name. Which base BSPs are listed can be controlled by the ``--rtems-bsps`` command line option. It expects a comma-separated list of @@ -103,7 +103,7 @@ items can be specified by the ``--rtems-specs`` command line option. .. code-block:: none -$ ./waf bsp_list --rtems-bsps=sparc/ +$ ./waf bsplist --rtems-bsps=sparc/ sparc/at697f sparc/erc32 sparc/gr712rc @@ -115,7 +115,7 @@ items can be specified by the ``--rtems-specs`` command line option. .. code-block:: none -$ ./waf bsp_list --rtems-bsps='/leon,/rv64imac$' +$ ./waf bsplist --rtems-bsps='/leon,/rv64imac$' riscv/rv64imac sparc/leon2 sparc/leon3 @@ -186,7 +186,7 @@ name. This one line configuration file is sufficient to build the base BSP `sparc/erc32` with default values for all options. The base BSPs are determined -by the build specification. The ``./waf bsp_list`` command lists all base BSPs. +by the build specification. The ``./waf bsplist`` command lists all base BSPs. You can create your own BSP names. However, in this case you have to inherit from a base BSP. The inheritance works only within an architecture, e.g. a `riscv` BSP cannot inherit options from an `arm` BSP. -- 2.34.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: bsp/riscv: Store/AMO address misaligned trap occured
Check what is the address of .Lsecondary_processor_go and confirm it is 8-byte aligned. The patch you indicated with the `.option norelax` could have an effect on alignment, but it should be the case that the alignment is ensured (rather than violated). On Thu, Nov 3, 2022 at 12:37 AM wrote: > > > On Thu, 2022-11-03 at 05:40 +, padmarao.beg...@microchip.com > wrote: > > Hi Gedare, > > > On Wed, 2022-11-02 at 09:58 -0600, Gedare Bloom wrote: > > > > > > t0 contains the address of .Lsecondary_processor_go > > > > > > start.S has: > > > ```asm > > > #if __riscv_xlen == 32 > > > .align 2 > > > #elif __riscv_xlen == 64 > > > .align 3 > > > #endif > > > > > > .Lsecondary_processor_go: > > > ``` > > > Can you confirm the value of __riscv_xlen is properly defined to 64 > > > for the PolarFire? > > > > > No, the value of __riscv_xlen is showing 32(config.log) instead of 64 > > for PolarFire SoC and other 64-bit RISCV BSPs. > > > Ignore previous one "the value of __riscv_xlen is showing > 32(config.log)" > > The __riscv_xlen is 64 for PolarFire SoC, have seen while executing the > rtems on the board. > > > Regards > > Padmarao > > > On Wed, Nov 2, 2022 at 12:40 AM > > > wrote: > > > > Hi Sebastian, > > > > > > > > The "Store/AMO address misaligned" trap occured in the "start.S" > > > > at "amoswap.w zero, zero, 0(t0)" while testing the sample > > > > application with the latest RTEMS master for RISC-V on > > > > the Microchip PolarFire SoC. > > > > > > > > The trap occured after this 89ba2a98/rtems latest commit for > > > > riscv > > > > (bsps/riscv: Workaround for sporadic linker issues). > > > > > > > > Regards > > > > Padmarao > > > > ___ > > > > devel mailing list > > > > devel@rtems.org > > > > http://lists.rtems.org/mailman/listinfo/devel > > ___ > > devel mailing list > > devel@rtems.org > > http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
