Re: libbsd development policy clarification needed?

2023-02-06 Thread Sebastian Huber
On 06.02.23 20:47, Gedare Bloom wrote: On Mon, Feb 6, 2023 at 8:49 AM Sebastian Huber wrote: On 06.02.23 16:06, Gedare Bloom wrote: Yes, thanks. This looks like a good analysis. I would definitely prefer to get master and 6-freebsd-12 into harmony. Then it is a little simpler to discuss the

Re: [PATCH] spec/bsps: Deduplicate objxilinxsupport

2023-02-06 Thread Sebastian Huber
On 06.02.23 23:09, Gedare Bloom wrote: ok. I'm not sure, maybe we need a note about this in https://docs.rtems.org/branches/master/eng/build-system.html A hint in the documentation would be helpful. Even more helpful would be a consistency check before patch sets are pulled in. For example,

Re: GitLab and BuildBot

2023-02-06 Thread Chris Johns
On 30/1/2023 10:12 pm, Christian MAUDERER wrote: > Hello, > > recently the following tickets were added (beneath a few more related ones): > > https://devel.rtems.org/ticket/4790 - Setup Gitlab instance > https://devel.rtems.org/ticket/4791 - Update BuildBot > > It's great that a patch review

Re: [PATCH rtems-libbsd] CONTRIBUTING: Sharpen priority development goals

2023-02-06 Thread Chris Johns
On 6/2/2023 7:07 pm, Christian MAUDERER wrote: > Hello Chris, > > thanks for your feedback on the patch. No problem :) > On 2023-02-06 05:16, Chris Johns wrote: >> On 3/2/2023 6:31 pm, Christian Mauderer wrote: >>> This patch tries to make the most important goals of LibBSD development >>> more

Re: [PATCH] spec/bsps: Deduplicate objxilinxsupport

2023-02-06 Thread Kinsey Moore
On 2/6/2023 4:09 PM, Gedare Bloom wrote: ok. I'm not sure, maybe we need a note about this in https://docs.rtems.org/branches/master/eng/build-system.html I'll see if I can find an appropriate place for it to go in that document. Some parts of it are aspirational and apply to any build

Re: [PATCH] spec/bsps: Deduplicate objxilinxsupport

2023-02-06 Thread Gedare Bloom
ok. I'm not sure, maybe we need a note about this in https://docs.rtems.org/branches/master/eng/build-system.html On Mon, Feb 6, 2023 at 2:02 PM Kinsey Moore wrote: > > The objxilinxsupport build object was accidentally included twice in > some of the ZynqMP BSPs by two different drivers that

Re: [PATCH] wscript: Deduplicate installed files

2023-02-06 Thread Gedare Bloom
On Mon, Feb 6, 2023 at 1:03 PM Kinsey Moore wrote: > > On 2/6/2023 8:44 AM, Sebastian Huber wrote: > > On 06.02.23 15:30, Joel Sherrill wrote: > >> On Mon, Feb 6, 2023 at 12:55 AM Sebastian Huber > >> >> > wrote: > >> On 06.02.23 03:35, Chris Johns

[PATCH] spec/bsps: Deduplicate objxilinxsupport

2023-02-06 Thread Kinsey Moore
The objxilinxsupport build object was accidentally included twice in some of the ZynqMP BSPs by two different drivers that required it. This commit manually deduplicates the inclusions by moving that inclusion to the BSP. Duplication of object inclusions is considered a bug and can cause race

Re: [PATCH] wscript: Deduplicate installed files

2023-02-06 Thread Kinsey Moore
On 2/6/2023 8:44 AM, Sebastian Huber wrote: On 06.02.23 15:30, Joel Sherrill wrote: On Mon, Feb 6, 2023 at 12:55 AM Sebastian Huber > wrote:     On 06.02.23 03:35, Chris Johns wrote: > On 4/2/2023 6:11 am, Sebastian Huber wrote: >> On

Re: libbsd development policy clarification needed?

2023-02-06 Thread Gedare Bloom
On Mon, Feb 6, 2023 at 8:49 AM Sebastian Huber wrote: > > On 06.02.23 16:06, Gedare Bloom wrote: > > Yes, thanks. This looks like a good analysis. I would definitely > > prefer to get master and 6-freebsd-12 into harmony. Then it is a > > little simpler to discuss the other problems in libbsd. >

[docs] c-user: Remove obsolete config section

2023-02-06 Thread Sebastian Huber
This commit already clarified that the defines of the removed section are optional BSP provided default values and not application configuration options: commit cf9f2121577b11f8eab5e49c48173c46cf09c627 Author: Sebastian Huber Date: Wed Nov 17 08:46:56 2021 +0100 c-user: Clarify BSP

[PATCH 3/4] doxygen: Generalize appl config constraints

2023-02-06 Thread Sebastian Huber
Rename the constaints section of application configuration options from "Value Constraints" in "Constraints. Adjust the constraint wording accordingly. This is in line with the RTEMS Classic API Guide. Update #3994. --- cpukit/doxygen/appl-config.h | 1101 ++ 1

[PATCH 4/4] doxygen: Use @anchor for appl config options

2023-02-06 Thread Sebastian Huber
The application configuration options are documented in "cpukit/doxygen/appl-config.h". Since the application configuration option defines are also present in multiple test program sources, the "#OPTION" references cannot be mapped to a unique definition. Add an anchor for each option and

[PATCH 0/4] Improve Doxygen documentation of application configuration options

2023-02-06 Thread Sebastian Huber
Sebastian Huber (4): doxygen: Use quotes for href URLs doxygen: Clarify CONFIGURE_DISABLE_BSP_SETTINGS doxygen: Generalize appl config constraints doxygen: Use @anchor for appl config options cpukit/doxygen/appl-config.h | 2169 +---

[PATCH 1/4] doxygen: Use quotes for href URLs

2023-02-06 Thread Sebastian Huber
Update #3994. --- cpukit/doxygen/appl-config.h | 110 +-- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h index 964f8d0616..a8d964832e 100644 --- a/cpukit/doxygen/appl-config.h +++

[PATCH 2/4] doxygen: Clarify CONFIGURE_DISABLE_BSP_SETTINGS

2023-02-06 Thread Sebastian Huber
Each BSP may optionally provide default values for some application configuration options. Remove the documentation of these items, since the BSP provided defines are not application configuration options, they are optional default values. Clarify CONFIGURE_DISABLE_BSP_SETTINGS accordingly and

Re: libbsd development policy clarification needed?

2023-02-06 Thread Sebastian Huber
On 06.02.23 16:06, Gedare Bloom wrote: Yes, thanks. This looks like a good analysis. I would definitely prefer to get master and 6-freebsd-12 into harmony. Then it is a little simpler to discuss the other problems in libbsd. Vijay had similar kind of success (and problems) as you did with

Re: libbsd development policy clarification needed?

2023-02-06 Thread Christian MAUDERER
move every patch that is not compile clean and pushed my current working version here: https://gitlab.com/c-mauderer/rtems-libbsd/-/tree/cm/20230206-port-patches-to-master At the moment it's cherry-picking patches from 6-freebsd-12 to master as long as they apply and compile. I didn't make sur

Re: [patch] medit problem

2023-02-06 Thread Gedare Bloom
Hi Zack, thanks for this patch. Can you please provide a first line of commit message in line with: https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance Specifically, the first line of your commit should preferably start with "shell:" or "libmisc/shell:" and if

Re: libbsd development policy clarification needed?

2023-02-06 Thread Gedare Bloom
On Mon, Feb 6, 2023 at 2:26 AM Christian MAUDERER wrote: > > On 2023-02-06 10:02, Christian MAUDERER wrote: > > On 2023-02-05 11:38, Christian Mauderer wrote: > >> > >> > >> Am 04.02.23 um 01:25 schrieb Gedare Bloom: > >>> On Fri, Feb 3, 2023 at 3:29 PM Christian Mauderer > >>> wrote: > >

Re: [PATCH] wscript: Deduplicate installed files

2023-02-06 Thread Sebastian Huber
On 06.02.23 15:30, Joel Sherrill wrote: On Mon, Feb 6, 2023 at 12:55 AM Sebastian Huber > wrote: On 06.02.23 03:35, Chris Johns wrote: > On 4/2/2023 6:11 am, Sebastian Huber wrote: >> On 03.02.23 19:45, Kinsey Moore wrote: >>>

Re: [PATCH] wscript: Deduplicate installed files

2023-02-06 Thread Joel Sherrill
On Mon, Feb 6, 2023 at 12:55 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 06.02.23 03:35, Chris Johns wrote: > > On 4/2/2023 6:11 am, Sebastian Huber wrote: > >> On 03.02.23 19:45, Kinsey Moore wrote: > >>> This is my first stab at solving this duplicate install

Re: [PATCH rtems-libbsd] CONTRIBUTING: Sharpen priority development goals

2023-02-06 Thread Karel Gardas
On 2/6/23 05:16, Chris Johns wrote: + * A lot of different hardware uses LibBSD as network or USB stack or maybe in + the future even only for other subsystems. Some of the targets have + hundreds of megabytes memory. Others can only have a few megabytes (like + the ATSAMV71).

Re: libbsd development policy clarification needed?

2023-02-06 Thread Christian MAUDERER
On 2023-02-06 10:02, Christian MAUDERER wrote: On 2023-02-05 11:38, Christian Mauderer wrote: Am 04.02.23 um 01:25 schrieb Gedare Bloom: On Fri, Feb 3, 2023 at 3:29 PM Christian Mauderer wrote: Am 3. Februar 2023 22:52:48 MEZ schrieb Gedare Bloom : On Fri, Feb 3, 2023 at 2:39 PM

Re: libbsd development policy clarification needed?

2023-02-06 Thread Christian MAUDERER
On 2023-02-05 11:38, Christian Mauderer wrote: Am 04.02.23 um 01:25 schrieb Gedare Bloom: On Fri, Feb 3, 2023 at 3:29 PM Christian Mauderer wrote: Am 3. Februar 2023 22:52:48 MEZ schrieb Gedare Bloom : On Fri, Feb 3, 2023 at 2:39 PM Christian Mauderer wrote: Am 3. Februar 2023

Re: [PATCH 2/2] RISC-V: Test rv32i and rv32imafdc on QEMU

2023-02-06 Thread Hesham Almatary
This needs to be merged for the tests to pass. On Mon, 9 Jan 2023 at 18:28, Hesham Almatary wrote: > > Is this patchset fine to merge? > > On Fri, 23 Dec 2022 at 09:25, wrote: > > > > From: Hesham Almatary > > > > Updates #4775 > > --- > > tester/rtems/testing/bsps/rv32i.ini | 37

Re: [PATCH rtems-libbsd] CONTRIBUTING: Sharpen priority development goals

2023-02-06 Thread Christian MAUDERER
Hello Chris, thanks for your feedback on the patch. On 2023-02-06 05:16, Chris Johns wrote: On 3/2/2023 6:31 pm, Christian Mauderer wrote: This patch tries to make the most important goals of LibBSD development more clear based on the results of the discussion on the mailing list: