Re: [PATCH 2/5] build: Use CSafeLoader if available

2023-04-26 Thread Sebastian Huber
On 27.04.23 02:11, Chris Johns wrote: On 26/4/2023 6:04 pm, Sebastian Huber wrote: The CSafeLoader uses the C libyaml libary to considerably speed up the loading of YAML files. No from me. What do you mean with not for me? You have the CSafeLoader available and it is slow? Do you have some

Re: [PATCH 2/5] build: Use CSafeLoader if available

2023-04-26 Thread Chris Johns
On 26/4/2023 6:04 pm, Sebastian Huber wrote: > The CSafeLoader uses the C libyaml libary to considerably speed up the > loading of YAML files. No from me. I do not agree with conditional states of operation in the build system that depend on packages a host has installed. If speed is an

RSB repo commits need approval

2023-04-26 Thread Chris Johns
Hi, All RSB repo commits need to be posted for review and independent approval given before being pushed to the top level repo. Thanks Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: Change build specification files from YAML to JSON?

2023-04-26 Thread Joel Sherrill
On Wed, Apr 26, 2023 at 3:58 PM Gedare Bloom wrote: > Is the result of this discussion to use CSafeLoader for now? Or do we > still debate the transition to JSON? > > I see some quirks need to be dealt with as you mentioned with the > multi-line stuff. The yaml is pretty simple to understand and

Re: Change build specification files from YAML to JSON?

2023-04-26 Thread Gedare Bloom
Is the result of this discussion to use CSafeLoader for now? Or do we still debate the transition to JSON? I see some quirks need to be dealt with as you mentioned with the multi-line stuff. The yaml is pretty simple to understand and work with. I've dealt with hand-editing JSON and it's a pain

Re: [PATCH v3 1/3] cpukit/flash: Add API for Flash devices

2023-04-26 Thread Gedare Bloom
I'm satisfied with the API. I have a couple minor comments on the implementation. On Thu, Apr 20, 2023 at 1:23 AM wrote: > > From: Aaron Nyholm > > --- > cpukit/dev/flash/flashdev.c | 849 > cpukit/include/dev/flash/flashdev.h | 458 +++ >

Re: Change build specification files from YAML to JSON?

2023-04-26 Thread Sebastian Huber
On 26.04.23 00:37, Chris Johns wrote: On 26/4/2023 4:01 am, Sebastian Huber wrote: On 25.04.23 13:02, Karel Gardas wrote: On 4/25/23 12:32, Sebastian Huber wrote: On 25.04.23 12:10, Karel Gardas wrote: On 4/25/23 11:03, Sebastian Huber wrote: On 25.04.23 11:00, Karel Gardas wrote: On

Re: Change build specification files from YAML to JSON?

2023-04-26 Thread Sebastian Huber
On 26.04.23 01:52, Chris Johns wrote: On 25/4/2023 5:35 pm, Sebastian Huber wrote: Tooling makes sense if you have a high change rate. That is not the use case I am discussing and it is not a factor. This is not the case for the RTEMS build specification items. I am not saying it is.

[PATCH 5/5] build: Load items on demand during a build

2023-04-26 Thread Sebastian Huber
If the CSafeLoader is available, load only the necessary build items. This considerably speeds up the build setup time if the CSafeLoader is used. --- wscript | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/wscript b/wscript index

[PATCH 3/5] build: Avoid cache if CSafeLoader is available

2023-04-26 Thread Sebastian Huber
Move the item cache handling to a ItemCache class. Implement this class depending on the availability of CSafeLoader. --- wscript | 240 +--- 1 file changed, 143 insertions(+), 97 deletions(-) diff --git a/wscript b/wscript index

[PATCH 4/5] build: Rename TOPGROUP in TOPGROUP_UID

2023-04-26 Thread Sebastian Huber
This makes it more obvious that this is an item UID. --- wscript | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wscript b/wscript index 143ee722e2..cb5674b5b9 100755 --- a/wscript +++ b/wscript @@ -1511,12 +1511,12 @@ def configure_variant(conf, cp, bsp_map, path_list,

[PATCH 0/5] Optimize the build by using the CSafeLoader

2023-04-26 Thread Sebastian Huber
The CSafeLoader uses the C libyaml libary to considerably speed up the loading of YAML files. Sebastian Huber (5): build: Format with yapf build: Use CSafeLoader if available build: Avoid cache if CSafeLoader is available build: Rename TOPGROUP in TOPGROUP_UID build: Load items on

[PATCH 1/5] build: Format with yapf

2023-04-26 Thread Sebastian Huber
--- wscript | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/wscript b/wscript index 567f42db2f..60fd8a1595 100755 --- a/wscript +++ b/wscript @@ -229,9 +229,8 @@ class Item(object): try: self.do_build(bld, bic) except Exception

[PATCH 2/5] build: Use CSafeLoader if available

2023-04-26 Thread Sebastian Huber
The CSafeLoader uses the C libyaml libary to considerably speed up the loading of YAML files. --- wscript | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/wscript b/wscript index 60fd8a1595..5a2fb84314 100755 --- a/wscript +++ b/wscript