CID 1399763: Unchecked return value from library in gr_rasta_io_init1().
Closes #4284
---
bsps/shared/grlib/pci/gr_rasta_io.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/pci/gr_rasta_io.c
b/bsps/shared/grlib/pci/gr_rasta_io.c
index f4c9d50..f93f73c
CID 1399767: Unchecked return value error from library in
gr_cpci_leon4_n2x_init1().
Closes #4285
---
bsps/sparc/shared/pci/gr_leon4_n2x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/sparc/shared/pci/gr_leon4_n2x.c
b/bsps/sparc/shared/pci/gr_leon4_n2x.c
index
CID 1399771: Unchecked return value from library in gr_rasta_tmtc_init1().
Closes #4286
---
bsps/shared/grlib/pci/gr_rasta_tmtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/pci/gr_rasta_tmtc.c
b/bsps/shared/grlib/pci/gr_rasta_tmtc.c
index
CID 1399780: Unchecked return value from library in gr_rasta_adcdac_init1().
Closes #4287
---
bsps/shared/grlib/pci/gr_rasta_adcdac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/pci/gr_rasta_adcdac.c
b/bsps/shared/grlib/pci/gr_rasta_adcdac.c
index
CID 1399783: Unchecked return value from library in gr701_init1().
Closes #4288
---
bsps/shared/grlib/pci/gr_701.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/pci/gr_701.c b/bsps/shared/grlib/pci/gr_701.c
index c9ac0db..25dc680 100644
---
CID 1399785: Unchecked return value from library in gr_tmtc_1553_init1().
Closes #4289
---
bsps/shared/grlib/pci/gr_tmtc_1553.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/pci/gr_tmtc_1553.c
b/bsps/shared/grlib/pci/gr_tmtc_1553.c
index
CID 1437650: Unchecked return value from library in rtems_shell_help().
Closes #4291
---
cpukit/libmisc/shell/main_help.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c
index 611f2e0..c76139e 100644
---
CID 1437630: Unchecked return value from library in gr_cpci_gr740_init1().
Closes #4290
---
bsps/sparc/shared/pci/gr_cpci_gr740.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/sparc/shared/pci/gr_cpci_gr740.c
b/bsps/sparc/shared/pci/gr_cpci_gr740.c
index
the value that is returned.
Ryan
Ryan Long (12):
gen_uuid.c: Fix two Unchecked return value from library errors
main_chmod.c: Fix Unchecked return value from library (CID #1063856)
pwdgrp.c: Fix Unchecked return value from library (CID #1255518)
gr_rasta_spw_router.c: Fix Unchecked return
CID 1049146: Unchecked return value from library in get_clock().
CID 1049147: Unchecked return value from library in get_random_fd().
Closes #4280
---
cpukit/libmisc/uuid/gen_uuid.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/cpukit/libmisc/uuid/gen_uuid.c
CID 1063856: Unchecked return value from library in
rtems_shell_main_chmod().
Closes #4281
---
cpukit/libmisc/shell/main_chmod.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_chmod.c
b/cpukit/libmisc/shell/main_chmod.c
index 0c39072..df18ef1
Hi,
These are patches for the third party Coverity issues. I forgot to
include them with the other patch last week. The only file that I used
the _Assert_Unused_variable_equals() macro with was grspw.c. The others, I just
used (void) to "use" them.
Thanks,
Ryan
Ryan Long (3):
fdt
CID 1047324: Unchecked return value in fdt_add_subnode_namelen().
Updates #4256
---
cpukit/dtc/libfdt/fdt_rw.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c
index 1385425..d6f7d93 100644
---
CID 1399781: Unchecked return value in grspw_device_init().
Closes #4259
---
bsps/shared/grlib/spw/grspw.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c
index 1b50cc6..74a0fc7 100644
---
CID 1255318: Unchecked return value in display_line().
Updates #4257
---
cpukit/libmisc/shell/main_edit.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c
index a011049..8730b21 100644
---
Hi,
Here are the patches with the suggested changes.
Thanks,
Ryan
Ryan Long (3):
fdt_rw.c: Fix Unchecked return value (CID #1047324)
grspw.c: Fix Unchecked return value (CID #1399781)
main_edit.c: Fix Unchecked return value (CID #1255318)
bsps/shared/grlib/spw/grspw.c| 7
CID 1399781: Unchecked return value in grspw_device_init().
Closes #4259
---
bsps/shared/grlib/spw/grspw.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c
index 1b50cc6..32740d4 100644
---
CID 1255318: Unchecked return value in display_line().
Updates #4257
---
cpukit/libmisc/shell/main_edit.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c
index a011049..9819a94 100644
---
CID 1047324: Unchecked return value in fdt_add_subnode_namelen().
Updates #4256
---
cpukit/dtc/libfdt/fdt_rw.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c
index 1385425..41abd8c 100644
---
Hi,
Since I've sent a lot of patches this week, I just want to verify which are
ready to be merged and what needs to be resubmitted.
Ready to be merged:
Grlib patches:
* grspw.c
* gr_rasta_spw_router.c
* gr_rasta_tmtc.c
* gr_leon4_n2x.c
* gr_701.c
*
Hi,
Here are the patches with the recommended fixes.
Thanks,
Ryan
Ryan Long (4):
gen_uuid.c: Fix two Unchecked return value from library errors
main_chmod.c: Fix Unchecked return value from library (CID #1063856)
pwdgrp.c: Fix Unchecked return value from library (CID #1255518
CID 1049146: Unchecked return value from library in get_clock().
CID 1049147: Unchecked return value from library in get_random_fd().
Closes #4280
---
cpukit/libmisc/uuid/gen_uuid.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/cpukit/libmisc/uuid/gen_uuid.c
CID 1063856: Unchecked return value from library in
rtems_shell_main_chmod().
Closes #4281
---
cpukit/libmisc/shell/main_chmod.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_chmod.c
b/cpukit/libmisc/shell/main_chmod.c
index 0c39072..df18ef1
CID 1255518: Unchecked return value from library in pwdgrp_init().
Closes #4282
---
cpukit/libcsupport/src/pwdgrp.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c
index a97d397..f4a10f7 100644
---
CID 1437650: Unchecked return value from library in rtems_shell_help().
Closes #4291
---
cpukit/libmisc/shell/main_help.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c
index 611f2e0..9f59e9d 100644
---
CID 1255518: Unchecked return value from library in pwdgrp_init().
Closes #4282
---
cpukit/libcsupport/src/pwdgrp.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c
index a97d397..f4a10f7 100644
---
CID 1049146: Unchecked return value from library in get_clock().
CID 1049147: Unchecked return value from library in get_random_fd().
Closes #4280
---
cpukit/libmisc/uuid/gen_uuid.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/cpukit/libmisc/uuid/gen_uuid.c
CID 1437650: Unchecked return value from library in rtems_shell_help().
Closes #4291
---
cpukit/libmisc/shell/main_help.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c
index 611f2e0..9f59e9d 100644
---
CID 1063856: Unchecked return value from library in
rtems_shell_main_chmod().
Closes #4281
---
cpukit/libmisc/shell/main_chmod.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/cpukit/libmisc/shell/main_chmod.c
b/cpukit/libmisc/shell/main_chmod.c
index
Hi,
Here are the patches with the fix to main_chmod.c.
Thanks,
Ryan
Ryan Long (4):
gen_uuid.c: Fix two Unchecked return value from library errors
main_chmod.c: Fix Unchecked return value from library (CID #1063856)
pwdgrp.c: Fix Unchecked return value from library (CID #1255518
CID 1255318: Unchecked return value in display_line().
Updates #4257
---
cpukit/libmisc/shell/main_edit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c
index a011049..8ac7eee 100644
---
Hi,
Here's the fix for main_edit.c. I just just needed to add a space
between (void) and the function call.
Thanks,
Ryan
Ryan Long (1):
main_edit.c: Fix Unchecked return value (CID #1255318)
cpukit/libmisc/shell/main_edit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.3.1
Hi,
Here are the patches with the recommended changes.
Thanks,
Ryan
Ryan Long (4):
main_cp.c: Unused value (CID #1255344)
print-ls.c: Unused value (CID #1255346)
fastlz.c: Unused value (CID #1399751)
disp_hcms29xx.c: Unused value (CID #1399752)
bsps/shared/dev/display/disp_hcms29xx.c
CID 1255346: Unused value in rtems_shell_ls_printacol().
Closes #4340
---
cpukit/libmisc/shell/print-ls.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c
index 15702b4..95a2cdf 100644
---
CID 1255344: Unused value in copy().
Closes #4339
---
cpukit/libmisc/shell/main_cp.c | 32
1 file changed, 32 insertions(+)
diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c
index cddbc95..913ece1 100644
---
CID 1399752: Unused value in disp_hcms29xx_update_task().
Closes #4342
---
bsps/shared/dev/display/disp_hcms29xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/dev/display/disp_hcms29xx.c
b/bsps/shared/dev/display/disp_hcms29xx.c
index 740aa56..5ad7063
CID 1399751: Unused value in fastlz2_compress().
Closes #4341
---
cpukit/libdl/fastlz.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c
index 3c9d6f6..7257c98 100644
--- a/cpukit/libdl/fastlz.c
+++
ping
-Original Message-
From: Ryan Long
Sent: Friday, March 12, 2021 8:56 AM
To: devel@rtems.org
Cc: Ryan Long
Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID
#1399709)
CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save().
Closes
Fixes CID #1437625 and #1472765 where the return value of rtems_task_create and
rtems_task_start is discarded.
Fix file consolesimpletask.c
---
cpukit/libcsupport/src/consolesimpletask.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
Fixes CID #1468682 where target is dereferenced before it has been
checked as to whether it is null or not in the
rtems_debugger_target_swbreak_control function.
Fix file rtems-debugger-target.c
---
cpukit/libdebugger/rtems-debugger-target.c | 6 --
1 file changed, 4 insertions(+), 2
of the function and assigned its value where I
had declared and initialized it in the first version of this patch.
Thanks,
Ryan
Ryan Long (3):
assert.h: Add macros to assert status and use it
consolesimpletask.c: Fix Coverity Unchecked return value
rtems-debugger-target.c: Fix Coverity Dereference
These macros are to be used to check the status from calls that are flagged by
Coverity as 'Unchecked return value'.
Fix file assert.h
---
cpukit/include/rtems/score/assert.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/cpukit/include/rtems/score/assert.h
CID 1399840: Dereference before null check in grtc_ioctl().
Closes #4252
---
bsps/shared/grlib/tmtc/grtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/tmtc/grtc.c b/bsps/shared/grlib/tmtc/grtc.c
index 44e9685..e9acea4 100644
---
CID 1399846: Dereference before null check in grspw_addr_ctrl().
Closes #4253
---
bsps/shared/grlib/spw/grspw_pkt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/spw/grspw_pkt.c
b/bsps/shared/grlib/spw/grspw_pkt.c
index 2cc4e886..ca8767e 100644
---
CID 1467420: Dereference before null check in rtems_shell_line_editor().
Closes #4254
---
cpukit/libmisc/shell/shell.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c
index 3c357a1..1e5962b 100644
---
asn't null before being passed to fileno().
Thanks,
Ryan
Ryan Long (5):
b1553brm.c: Fix Dereference before null check (CID #1399829)
b1553rt.c: Fix Deference before null check (CID #1399830)
grtc.c: Fix Dereference before null check (CID #1399840)
grspw_pkt.c: Fix Dereference before null
CID 1399829: Dereference before null check in brm_control().
Closes #4250
---
bsps/shared/grlib/1553/b1553brm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bsps/shared/grlib/1553/b1553brm.c
b/bsps/shared/grlib/1553/b1553brm.c
index 57ef701..694f585 100644
---
CID 1399830: Dereference before null check in rt_control().
Closes #4251
---
bsps/shared/grlib/1553/b1553rt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/shared/grlib/1553/b1553rt.c b/bsps/shared/grlib/1553/b1553rt.c
index d7257e4..df72ada 100644
---
Fixes CID #1468682 where target is dereferenced before it has been
checked as to whether it is null or not in the
rtems_debugger_target_swbreak_control function.
---
cpukit/libdebugger/rtems-debugger-target.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Fixes CID #1468681, 1468690, and 1468694 by checking if threads is null in
the rtems_debugger_thread_find_index, rtems_debugger_thread_system_resume,
and rtems_debugger_thread_continue_all functions.
---
cpukit/libdebugger/rtems-debugger-threads.c | 14 +++---
1 file changed, 11
Fixes CID #1437625 and #1472765 where the return value of rtems_task_create and
rtems_task_start is discarded.
---
cpukit/libcsupport/src/consolesimpletask.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/cpukit/libcsupport/src/consolesimpletask.c
These macros are to be used to check the status from calls that are flagged by
Coverity as 'Unchecked return value'.
---
cpukit/include/rtems/score/assert.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/cpukit/include/rtems/score/assert.h
around the dereferencing of values.
Thanks,
Ryan
Ryan Long (4):
assert.h: Add macros to assert status and use it
consolesimpletask.c: Fix Coverity Unchecked return value
rtems-debugger-threads.c: Fix Coverity Dereference before null check
rtems-debugger-target.c: Fix Coverity Dereference
Changed the way the tests were structured, added rtems_test_assert()'s,
updated psx13.scn and the license.
---
testsuites/psxtests/psx13/main.c| 37 +-
testsuites/psxtests/psx13/psx13.scn | 21 +-
testsuites/psxtests/psx13/test.c| 852
3 files
Initialize member variables not listed.
CID 1503019: Uninitialized scalar field.
Closes #4500
---
rtemstoolkit/rld-dwarf.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/rtemstoolkit/rld-dwarf.cpp b/rtemstoolkit/rld-dwarf.cpp
index 1eae50c..2d6f306 100644
---
Hi,
To fix these issues I just needed to add the missing member variables from the
initialization lists.
Thanks,
Ryan
Ryan Long (3):
rtems-exeinfo.cpp: Initialize byteorder
GcovData.cc: Initialize gcnoPreamble
rld-dwarf.cpp: Initialize member variables
linkers/rtems-exeinfo.cpp | 3
CID 1471637: Uninitialized scalar field
Closes #4499
---
linkers/rtems-exeinfo.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linkers/rtems-exeinfo.cpp b/linkers/rtems-exeinfo.cpp
index caae168..e54f9b2 100644
--- a/linkers/rtems-exeinfo.cpp
+++
CID 1506206: Uninitialized scalar field
Closes #4487
---
tester/covoar/GcovData.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc
index 02e7489..723e9af 100644
--- a/tester/covoar/GcovData.cc
+++ b/tester/covoar/GcovData.cc
@@ -21,6
Removed some ampersands that were left in on accident.
---
tester/covoar/GcovData.cc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc
index 44928a9..59412a6 100644
--- a/tester/covoar/GcovData.cc
+++
- Change status of all spintrcritical tests to indeterminate, expanded upon
comments.
- Add indeterminate tests to xilinx-versal
---
spec/build/bsps/aarch64/a53/tsta53.yml| 40 ++---
spec/build/bsps/aarch64/xilinx-versal/tstqemu.yml | 54 ++-
CID 1506207: Buffer not null terminated
Closes #4491
---
tester/covoar/TraceWriterQEMU.cc | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tester/covoar/TraceWriterQEMU.cc b/tester/covoar/TraceWriterQEMU.cc
index c417745..be9b6e1 100644
---
I haven't been building these with clang, so I'll make sure to start doing
that. I've got a Macbook, so I can test it on there as well.
-Original Message-
From: Chris Johns
Sent: Thursday, September 2, 2021 11:59 PM
To: Ryan Long ; devel@rtems.org
Subject: Re: [PATCH v1 00/10] Convert
Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to aarch64 tool
builds with newlib.
---
rtems/config/tools/rtems-gcc-10-newlib-head.cfg | 3 +++
1 file changed, 3 insertions(+)
diff --git a/rtems/config/tools/rtems-gcc-10-newlib-head.cfg
b/rtems/config/tools/rtems-gcc-10-newlib-head.cfg
CID 1506204: Uninitialized scalar variable
Closes #4488
---
tester/covoar/TraceWriterQEMU.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/tester/covoar/TraceWriterQEMU.cc b/tester/covoar/TraceWriterQEMU.cc
index c417745..cc849b6 100644
--- a/tester/covoar/TraceWriterQEMU.cc
+++
Hi,
These patches will get rid of the "Uninitialized pointer field" Coverity
issues. I noticed that some other member variables were not initialized
while doing this, so I initialized them as well.
Thanks,
Ryan
Ryan Long (4):
DesiredSymbols.h: Initialize symbolInfo
GcovFunct
CID 1503020: Uninitialized pointer field
Closes #4434
---
trace/record/record-filter-zlib.cc | 13 +
1 file changed, 13 insertions(+)
diff --git a/trace/record/record-filter-zlib.cc
b/trace/record/record-filter-zlib.cc
index 87b2cfe..62f1171 100644
---
CID 1399627: Uninitialized pointer field
Closes #4433
---
tester/covoar/DesiredSymbols.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tester/covoar/DesiredSymbols.h b/tester/covoar/DesiredSymbols.h
index 7ea3a9a..dbeeb2c 100644
--- a/tester/covoar/DesiredSymbols.h
+++
CID 1399640: Uninitialized pointer field
Closes #4432
---
tester/covoar/GcovFunctionData.cc | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/GcovFunctionData.cc
b/tester/covoar/GcovFunctionData.cc
index aec04ce..847439b 100644
---
Accidentally got left in, so it is being removed.
CID 1506210: Uninitialized pointer field
Closes #4492
---
tester/covoar/ObjdumpProcessor.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/tester/covoar/ObjdumpProcessor.h b/tester/covoar/ObjdumpProcessor.h
index ed36981..6a207dd 100644
-Original Message-
From: Gedare Bloom
Sent: Wednesday, September 1, 2021 3:21 PM
To: Ryan Long
Cc: devel@rtems.org
Subject: Re: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy
On Thu, Aug 19, 2021 at 7:42 AM Ryan Long wrote:
>
> CID 1506207: Buffer not null term
Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to AArch64 tools
builds with newlib. This forces the generation of AArch64 assembly from
C sources instead of using the hand-optimized code in newlib since it
does not support ILP32. This can be removed when it is fixed upstream.
Updates #4510
Adds patch to add the -DPREFER_SIZE_OVER_SPEED flag to AArch64 tool
builds with newlib. This forces the generation of AArch64 assembly from
C sources instead of using the hand-optimized code in newlib since it
does not support ILP32. This can be removed when it is fixed upstream.
Updates #4510
, September 1, 2021 10:01 PM
To: Ryan Long ; devel@rtems.org
Subject: Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables
On 25/8/21 3:12 am, Ryan Long wrote:
> Initialize member variables not listed.
>
> CID 1503019: Uninitialized scalar field.
>
> Closes #4500
> -
---
tester/covoar/CoverageMapBase.cc | 261 ---
1 file changed, 159 insertions(+), 102 deletions(-)
diff --git a/tester/covoar/CoverageMapBase.cc b/tester/covoar/CoverageMapBase.cc
index 334426b..7073260 100644
--- a/tester/covoar/CoverageMapBase.cc
+++
---
tester/covoar/CoverageFactory.h | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tester/covoar/CoverageFactory.h b/tester/covoar/CoverageFactory.h
index f71860d..52443e8 100644
--- a/tester/covoar/CoverageFactory.h
+++ b/tester/covoar/CoverageFactory.h
@@ -32,9
Hi,
For this and the following series of patches I followed this series of
steps.
1. Convert a file from the C way of doing things to C++
2. Go through all the files that had to do with the converted file and
make the formatting consistent.
Thanks,
Ryan
Ryan Long (10):
CoverageMap.cc: Fix
---
tester/covoar/CoverageFactory.cc | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/tester/covoar/CoverageFactory.cc b/tester/covoar/CoverageFactory.cc
index e6c3774..89f8376 100644
--- a/tester/covoar/CoverageFactory.cc
+++
---
tester/covoar/CoverageMap.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tester/covoar/CoverageMap.cc b/tester/covoar/CoverageMap.cc
index b470fea..3e0b9ce 100644
--- a/tester/covoar/CoverageMap.cc
+++ b/tester/covoar/CoverageMap.cc
@@ -13,7 +13,7 @@ namespace Coverage
---
tester/covoar/CoverageFactory.cc | 10 +-
tester/covoar/CoverageFactory.h | 2 +-
tester/covoar/CoverageReaderBase.h| 2 +-
tester/covoar/CoverageReaderQEMU.cc | 35 ++-
tester/covoar/CoverageReaderQEMU.h| 4 +++-
---
tester/covoar/CoverageReaderSkyeye.cc | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/tester/covoar/CoverageReaderSkyeye.cc
b/tester/covoar/CoverageReaderSkyeye.cc
index de0d4ad..abb3878 100644
--- a/tester/covoar/CoverageReaderSkyeye.cc
+++
---
tester/covoar/CoverageReaderTSIM.cc | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tester/covoar/CoverageReaderTSIM.cc
b/tester/covoar/CoverageReaderTSIM.cc
index 9c6ff7d..11f0be6 100644
--- a/tester/covoar/CoverageReaderTSIM.cc
+++
---
tester/covoar/CoverageReaderRTEMS.cc | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/tester/covoar/CoverageReaderRTEMS.cc
b/tester/covoar/CoverageReaderRTEMS.cc
index e869fc2..6331a81 100644
--- a/tester/covoar/CoverageReaderRTEMS.cc
+++
21 2:44 am, Ryan Long wrote:
> ---
> tester/covoar/CoverageWriterBase.h| 4 +++-
> tester/covoar/CoverageWriterRTEMS.cc | 26 +++---
> tester/covoar/CoverageWriterRTEMS.h | 4 +++-
> tester/covoar/CoverageWriterSkyeye.cc | 33
> ++--
2:44 am, Ryan Long wrote:
> Got rid of C-strings, changed FILE pointer to ifstream.
> ---
> tester/covoar/covoar.cc | 52
> +++--
> 1 file changed, 24 insertions(+), 28 deletions(-)
>
> diff --git a/tester/covoar/covoar.cc b/te
---
tester/covoar/CoverageWriterRTEMS.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterRTEMS.h
b/tester/covoar/CoverageWriterRTEMS.h
index c760936..9110303 100644
--- a/tester/covoar/CoverageWriterRTEMS.h
+++
---
tester/covoar/CoverageWriterSkyeye.cc | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tester/covoar/CoverageWriterSkyeye.cc
b/tester/covoar/CoverageWriterSkyeye.cc
index fcc7052..f7c71c4 100644
--- a/tester/covoar/CoverageWriterSkyeye.cc
+++
---
tester/covoar/CoverageWriterBase.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterBase.h
b/tester/covoar/CoverageWriterBase.h
index fca501a..ee8c148 100644
--- a/tester/covoar/CoverageWriterBase.h
+++ b/tester/covoar/CoverageWriterBase.h
---
tester/covoar/covoar.cc | 300 +++-
1 file changed, 167 insertions(+), 133 deletions(-)
diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc
index 710294b..ec126d6 100644
--- a/tester/covoar/covoar.cc
+++ b/tester/covoar/covoar.cc
@@
---
tester/covoar/CoverageWriterRTEMS.cc | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tester/covoar/CoverageWriterRTEMS.cc
b/tester/covoar/CoverageWriterRTEMS.cc
index fc8a241..a451999 100644
--- a/tester/covoar/CoverageWriterRTEMS.cc
+++
---
tester/covoar/CoverageWriterSkyeye.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterSkyeye.h
b/tester/covoar/CoverageWriterSkyeye.h
index 8f11959..5ef6432 100644
--- a/tester/covoar/CoverageWriterSkyeye.h
+++
---
tester/covoar/CoverageWriterTSIM.cc | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tester/covoar/CoverageWriterTSIM.cc
b/tester/covoar/CoverageWriterTSIM.cc
index 9ec12e4..ed9da96 100644
--- a/tester/covoar/CoverageWriterTSIM.cc
+++
---
tester/covoar/CoverageWriterTSIM.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterTSIM.h
b/tester/covoar/CoverageWriterTSIM.h
index 5ae57f8..9325a6a 100644
--- a/tester/covoar/CoverageWriterTSIM.h
+++ b/tester/covoar/CoverageWriterTSIM.h
---
tester/covoar/CoverageWriterBase.h| 4 +++-
tester/covoar/CoverageWriterRTEMS.cc | 26 +--
tester/covoar/CoverageWriterRTEMS.h | 4 +++-
tester/covoar/CoverageWriterSkyeye.cc | 39 +++
tester/covoar/CoverageWriterSkyeye.h | 4 +++-
Hi,
For these patches I
- Changed the data type of bytes_before so that it builds with clang
- Replaced instances of "\n" with std::endl
- Changed .c_str() argument to just a string
Thanks,
Ryan
Ryan Long (10):
CoverageWriter: Convert to C++
covoar.cc: Convert to C++
CoverageWr
Got rid of C-strings, changed FILE pointer to ifstream.
---
tester/covoar/covoar.cc | 50 +++--
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc
index f9d4814..710294b 100644
---
Hi,
These patches add some of the code that we are waiting for newlib to
pull.
Thanks,
Ryan
Ryan Long (2):
rtems-gcc-10-newlib-head.cfg: Add newlib patch
rtems-gcc-head-newlib-head.cfg: Add newlib patch
rtems/config/tools/rtems-gcc-10-newlib-head.cfg | 3 +++
rtems/config/tools/rtems
Adds patch to add sanitation to the padding of bits and size_t types for
AArch64 tools builds with newlib. These changes have been made in ARM, but
newlib has yet to pull them. This can be removed once newlib has pulled
the code.
Updates #4510
---
rtems/config/tools/rtems-gcc-10-newlib-head.cfg
Adds patch to add sanitation to the padding of bits and size_t types for
AArch64 tools builds with newlib. These changes have been made in ARM, but
newlib has yet to pull them. This can be removed once newlib has pulled
the code.
Updates #4510
---
Replaced a couple of calls to os.linesep() with os.linesep because
os.linesep() does not exist.
---
tester/rt/check.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tester/rt/check.py b/tester/rt/check.py
index 95fa47e..c01c25d 100755
--- a/tester/rt/check.py
+++
Kinsey got the fix merged upstream from newlib, so now we just have to wait
till newlib pulls those changes.
-Original Message-
From: Gedare Bloom
Sent: Tuesday, September 7, 2021 1:09 PM
To: Ryan Long
Cc: devel@rtems.org
Subject: Re: [PATCH RSB v2 2/2] rtems-gcc-head-newlib-head.cfg
201 - 300 of 612 matches
Mail list logo