Building rtems-kernel with RSB

2021-09-16 Thread Ryan Long
Hi, I'm trying to build rtems-kernel with the RSB. I haven't gotten it to work. I'm getting "Undefined reference to" errors for variables defined in tls.h (_TLS_Data_size, _TLS_Data_begin, etc.). I noticed that they are being defined in linkcmds.base in my bsp-install directory. The current

[PATCH v1] pxcdevctl: Adjust for standard (5 branch)

2021-09-13 Thread Ryan Long
psxdevctl is supposed to return the value in errno. Before, it was returning -1 and setting errno. Changed the tests to reflect these changes. Added code from RRADE's posix_devctl.c. Closes #4505 --- cpukit/libcsupport/src/posix_devctl.c | 80 ++

[PATCH v1] pxcdevctl: Adjust for standard

2021-09-13 Thread Ryan Long
psxdevctl is supposed to return the value in errno. Before, it was returning -1 and setting errno. Changed the tests to reflect these changes. Added code from RRADE's posix_devctl.c. Closes #4506 --- cpukit/libcsupport/src/posix_devctl.c | 80 ++

[PATCH rtems-tools v1 04/10] covoar.cc: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/covoar.cc | 300 +++- 1 file changed, 167 insertions(+), 133 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 746add1..e8fb430 100644 --- a/tester/covoar/covoar.cc +++ b/tester/covoar/covoar.cc @@

[PATCH rtems-tools v1 02/10] covoar.cc: Convert to C++

2021-09-08 Thread Ryan Long
Got rid of C-strings, changed FILE pointer to ifstream. --- tester/covoar/covoar.cc | 52 +++-- 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index f9d4814..746add1 100644 ---

[PATCH rtems-tools v1 01/10] CoverageWriter: Convert to C++

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterBase.h| 4 +++- tester/covoar/CoverageWriterRTEMS.cc | 26 +++--- tester/covoar/CoverageWriterRTEMS.h | 4 +++- tester/covoar/CoverageWriterSkyeye.cc | 33 ++--- tester/covoar/CoverageWriterSkyeye.h | 4

[PATCH rtems-tools v1 03/10] CoverageWriterBase.h: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterBase.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/CoverageWriterBase.h b/tester/covoar/CoverageWriterBase.h index fca501a..ee8c148 100644 --- a/tester/covoar/CoverageWriterBase.h +++ b/tester/covoar/CoverageWriterBase.h

[PATCH rtems-tools v1 05/10] CoverageWriterRTEMS.cc: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterRTEMS.cc | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tester/covoar/CoverageWriterRTEMS.cc b/tester/covoar/CoverageWriterRTEMS.cc index 3332cd4..d6c6ca3 100644 --- a/tester/covoar/CoverageWriterRTEMS.cc +++

[PATCH rtems-tools v1 06/10] CoverageWriterRTEMS.h: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterRTEMS.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/CoverageWriterRTEMS.h b/tester/covoar/CoverageWriterRTEMS.h index c760936..9110303 100644 --- a/tester/covoar/CoverageWriterRTEMS.h +++

[PATCH rtems-tools v1 07/10] CoverageWriterSkyeye.cc: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterSkyeye.cc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tester/covoar/CoverageWriterSkyeye.cc b/tester/covoar/CoverageWriterSkyeye.cc index 5225406..08aa609 100644 --- a/tester/covoar/CoverageWriterSkyeye.cc +++

[PATCH rtems-tools v1 08/10] CoverageWriterSkyeye.h: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterSkyeye.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/CoverageWriterSkyeye.h b/tester/covoar/CoverageWriterSkyeye.h index 8f11959..5ef6432 100644 --- a/tester/covoar/CoverageWriterSkyeye.h +++

RE: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

2021-09-08 Thread Ryan Long
in the CFLAGS_OPTIMIZE_V list From: Joel Sherrill Sent: Tuesday, September 7, 2021 12:27 PM To: Mr. Andrei Chichak Cc: Ryan Long ; rtems-de...@rtems.org Subject: Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch On Tue, Sep 7, 2021, 12:18 PM Mr. Andrei Chichak mailto:gro...@chichak.ca>>

[PATCH rtems-tools v1 00/10] Convert and reformat pt. 2

2021-09-08 Thread Ryan Long
Hi, For this series of patches, I followed this series of steps: 1. Convert a file from the C way of doing things to C++ 2. Go through all the files that had to do with the converted file and make the formatting consistent. Thanks, Ryan Ryan Long (10): CoverageWriter: Convert to C

[PATCH rtems-tools v1 10/10] CoverageWriterTSIM.h: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterTSIM.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/CoverageWriterTSIM.h b/tester/covoar/CoverageWriterTSIM.h index 5ae57f8..9325a6a 100644 --- a/tester/covoar/CoverageWriterTSIM.h +++ b/tester/covoar/CoverageWriterTSIM.h

[PATCH rtems-tools v1 09/10] CoverageWriterTSIM.cc: Fix formatting

2021-09-08 Thread Ryan Long
--- tester/covoar/CoverageWriterTSIM.cc | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/tester/covoar/CoverageWriterTSIM.cc b/tester/covoar/CoverageWriterTSIM.cc index bd15c9d..6c11b2b 100644 --- a/tester/covoar/CoverageWriterTSIM.cc +++

RE: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch

2021-09-07 Thread Ryan Long
Alright, I’ll have that in the next version. From: Joel Sherrill Sent: Saturday, September 4, 2021 3:31 PM To: Chris Johns Cc: Ryan Long ; rtems-de...@rtems.org Subject: Re: [PATCH RSB] rtems-gcc-10-newlib-head.cfg: Add newlib patch On Fri, Sep 3, 2021, 9:05 PM Chris Johns mailto:chr

[PATCH v1 1/6] ReportsBase.cc: Fix formatting

2021-07-14 Thread Ryan Long
--- tester/covoar/ReportsBase.cc | 305 ++- 1 file changed, 156 insertions(+), 149 deletions(-) diff --git a/tester/covoar/ReportsBase.cc b/tester/covoar/ReportsBase.cc index cc3810b..cd65c53 100644 --- a/tester/covoar/ReportsBase.cc +++

[PATCH v1 2/6] ReportsBase.h: Fix formatting

2021-07-14 Thread Ryan Long
--- tester/covoar/ReportsBase.h | 105 +++- 1 file changed, 36 insertions(+), 69 deletions(-) diff --git a/tester/covoar/ReportsBase.h b/tester/covoar/ReportsBase.h index ed381fb..41add8e 100644 --- a/tester/covoar/ReportsBase.h +++

[PATCH v1 6/6] ReportsText.h: Fix formatting

2021-07-14 Thread Ryan Long
--- tester/covoar/ReportsText.h | 60 ++--- 1 file changed, 24 insertions(+), 36 deletions(-) diff --git a/tester/covoar/ReportsText.h b/tester/covoar/ReportsText.h index 3e33be9..9ad80ef 100644 --- a/tester/covoar/ReportsText.h +++

[PATCH v1 5/6] ReportsText.cc: Fix formatting

2021-07-14 Thread Ryan Long
--- tester/covoar/ReportsText.cc | 103 +++ 1 file changed, 54 insertions(+), 49 deletions(-) diff --git a/tester/covoar/ReportsText.cc b/tester/covoar/ReportsText.cc index 35ad786..146fc35 100644 --- a/tester/covoar/ReportsText.cc +++

[PATCH v1 4/6] ReportsHtml.h: Fix formatting

2021-07-14 Thread Ryan Long
--- tester/covoar/ReportsHtml.h | 88 + 1 file changed, 32 insertions(+), 56 deletions(-) diff --git a/tester/covoar/ReportsHtml.h b/tester/covoar/ReportsHtml.h index 21ca8bd..a7ed0af 100644 --- a/tester/covoar/ReportsHtml.h +++

[PATCH v2 01/13] Remove AllExplanations global variable

2021-08-02 Thread Ryan Long
- Replaced AllExplanations in app_common with a local variable in covoar() - Added the allExplanations_m member variable to ReportsBase - Added a parameter to ReportsBase and its derived classes' constructors to initialize allExplanations_m - Added parameter to GenerateReports() to pass the

[PATCH v2 00/13] Remove app_common

2021-08-02 Thread Ryan Long
Hi, In this iteration I: - Removed the typedef in ObjdumpProcessor.h - Changed targetInfo to be a shared pointer - Got rid of some of the get & set methods for targetInfo_m - Added lastState_m to initialization list in ReportsHtml.cc Thanks, Ryan Ryan Long (13): Remove AllExplanations gl

[PATCH v2 02/13] ReportsHtml.cc: Initialize lastState_m

2021-08-02 Thread Ryan Long
When not initialized, an extra code segment would be added to annotated.html --- tester/covoar/ReportsHtml.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tester/covoar/ReportsHtml.cc b/tester/covoar/ReportsHtml.cc index 88ea25b..83fc52f 100644 ---

[PATCH v2 03/13] Remove objdumpProcessor global variable

2021-08-02 Thread Ryan Long
- Replaced objdumpProcessor in app_common with a local variable in TraceConverter.cc and covoar.cc - Added objdumpProcessor as a parameter for GenerateReports() and the processFile() member function of TraceReaderBase and its derived classes - Changed previous objdumpProcessor member

[PATCH v2 04/13] Remove Verbose global variable

2021-08-02 Thread Ryan Long
Replaced Verbose in app_common with local variables that are passed as a parameter into numerous functions --- tester/covoar/DesiredSymbols.cc | 17 tester/covoar/DesiredSymbols.h| 13 +--- tester/covoar/ExecutableInfo.h| 1 + tester/covoar/ObjdumpProcessor.cc

[PATCH v2 05/13] Remove dynamicLibrary global variable

2021-08-02 Thread Ryan Long
- Replaced dynamicLibrary in app_common with local variables - Changed data type to string - Changed conditionals to reflect this --- tester/covoar/ExecutableInfo.cc | 10 +- tester/covoar/ExecutableInfo.h | 6 +++--- tester/covoar/TraceConverter.cc | 5 +++--

[PATCH v2 07/13] Remove outputDirectory global variable

2021-08-02 Thread Ryan Long
- Replaced outputDirectory in app_common with a local variable in covoar() - Created the outputDirectory_m member variable - Added parameters to Reports* constructors to initialize outputDirectory_m and non member functions --- tester/covoar/ReportsBase.cc | 41

[PATCH v2 06/13] Remove projectName global variable

2021-08-02 Thread Ryan Long
- Replaced projectName in app_common with a local variable in covoar() - Changed datatype to string - Changed conditionals to reflect this - Created projectName_m member variable for ReportsBase - Added parameter to Reports* constructors to initialize projectName_m ---

[PATCH v2 08/13] Remove input buffer global variables

2021-08-02 Thread Ryan Long
- Removed input buffers from app_common and added them as a local variable to functions where inputBuffer was being used - Added #define for MAX_LINE_LENGTH in files where it is used - Changed Explanations::load to use a string instead of a C-string --- tester/covoar/Explanations.cc |

[PATCH v2 09/13] Remove SymbolsToAnalyze global variable

2021-08-02 Thread Ryan Long
- Removed SymbolsToAnalyze from app_common and replaced it with the symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and ObjdumpProcessor - Added a parameter to constructors to initialize symbolsToAnalyze_m - Moved the definition of objdumpLine_t out of ObjdumpProcessor to make

[PATCH v2 10/13] Remove BranchInfoAvailable global variable

2021-08-02 Thread Ryan Long
- Removed BranchInfoAvailable from app_common - Created member variable in CoverageReaderBase and ReportsBase and a function to get the value of the member variable --- tester/covoar/CoverageReaderBase.cc | 5 + tester/covoar/CoverageReaderBase.h | 10 ++

[PATCH v2 11/13] Remove TargetInfo global variable

2021-08-02 Thread Ryan Long
- Remove TargetInfo from app_common - Created the targetInfo_m member variable in CoverageReaderBase, TraceWriterBase, and ObjdumpProcessor - Made functions to set the value of targetInfo_m --- tester/covoar/CoverageReaderBase.h | 5 + tester/covoar/CoverageReaderQEMU.cc | 4 ++--

[PATCH v2 12/13] app_common: Remove functions and macros

2021-08-02 Thread Ryan Long
- Moved functions from app_common to the file they are used - Got rid of FileIsNewer() since it's not being used - Removed macros --- tester/covoar/TraceReaderLogQEMU.cc | 14 + tester/covoar/app_common.cc | 58 - tester/covoar/app_common.h

[PATCH v2 13/13] Remove app_common and all references to it

2021-08-02 Thread Ryan Long
- Removed the includes of app_common.h - Removed app_common references in build infrastructure - Removed app_common.cc and app_common.h --- tester/covoar/CoverageReaderQEMU.cc | 1 - tester/covoar/CoverageReaderTSIM.cc | 1 - tester/covoar/DesiredSymbols.cc | 1 -

RE: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable

2021-08-02 Thread Ryan Long
3 PM To: j...@rtems.org Cc: Ryan Long ; rtems-de...@rtems.org Subject: Re: [PATCH v1 09/13] Remove SymbolsToAnalyze global variable On 2/8/21 1:20 pm, Joel Sherrill wrote: > > > On Sun, Aug 1, 2021, 10:11 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > >

Restore ostream format after setpreicision() call

2021-08-02 Thread Ryan Long
Hi, Does anyone know a better approach to restore the precision value after using setprecision()? I found something online that recommended std::streamsize prec = std::ios_base::precision(); std::setprecision(2); . . . std::setprecision(prec); This makes sense and would work, but I don't know

[PATCH v1 0/4] Reformat GcovData and GcovFunctionData

2021-08-03 Thread Ryan Long
Hi, For these patches I: - Made the formatting consistent - Added Doxygen comments for parameters where it was missing - Fixed lines that went past 80 columns (except for some comments) Thanks, Ryan Ryan Long (4): GcovData.cc: Fix formatting GcovData.h: Fix formatting GcovFunctionData.cc

[PATCH v1 4/4] GcovFunctionData:h: Fix formatting

2021-08-03 Thread Ryan Long
--- tester/covoar/GcovFunctionData.h | 113 +++ 1 file changed, 54 insertions(+), 59 deletions(-) diff --git a/tester/covoar/GcovFunctionData.h b/tester/covoar/GcovFunctionData.h index e1ad431..4a98abb 100644 --- a/tester/covoar/GcovFunctionData.h +++

[PATCH v1 1/4] GcovData.cc: Fix formatting

2021-08-03 Thread Ryan Long
--- tester/covoar/GcovData.cc | 198 +- 1 file changed, 106 insertions(+), 92 deletions(-) diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc index 59963b6..6b18fa3 100644 --- a/tester/covoar/GcovData.cc +++ b/tester/covoar/GcovData.cc

[PATCH v1 2/4] GcovData.h: Fix formatting

2021-08-03 Thread Ryan Long
--- tester/covoar/GcovData.h | 61 +--- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/tester/covoar/GcovData.h b/tester/covoar/GcovData.h index e135ffe..242970f 100644 --- a/tester/covoar/GcovData.h +++ b/tester/covoar/GcovData.h @@

[PATCH v1 3/4] GcovFunctionData.cc: Fix formatting

2021-08-03 Thread Ryan Long
--- tester/covoar/GcovFunctionData.cc | 271 +++--- 1 file changed, 162 insertions(+), 109 deletions(-) diff --git a/tester/covoar/GcovFunctionData.cc b/tester/covoar/GcovFunctionData.cc index 34af677..7c9e627 100644 --- a/tester/covoar/GcovFunctionData.cc +++

RE: [PATCH v2] rtems-utils: Change data type definition

2021-08-09 Thread Ryan Long
. This was the only way we figured out how to get it to compile without the typedef at the top of the file. -Original Message- From: Chris Johns Sent: Friday, August 6, 2021 12:46 AM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v2] rtems-utils: Change data type definition On 6/8/21

[PATCH v2] rtems-utils: Change data type definition

2021-08-05 Thread Ryan Long
Remove typedef of ostream_guard and change datatype of ostream_guards to have the namespace in the variable declarations. --- linkers/rtems-exeinfo.cpp| 6 ++ tester/covoar/CoverageMapBase.cc | 4 +--- tester/covoar/ReportsHtml.cc | 4 +--- tester/covoar/ReportsText.cc | 4

RE: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-05 Thread Ryan Long
We think that the best thing to do is to keep the ostream_guard in place and ignore the "Restore ostream format" issues. -Original Message- From: Chris Johns Sent: Wednesday, August 4, 2021 8:44 PM To: Gedare Bloom Cc: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1

[PATCH] TraceWriterQEMU.cc: Remove unterminated string

2021-08-12 Thread Ryan Long
Replaced header.magic with QEMU_TRACE_MAGIC to get rid of "String not null terminated" Coverity issue. CID 1506203: String not null terminated Closes #4486 --- tester/covoar/TraceWriterQEMU.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tester/covoar/TraceWriterQEMU.cc

RE: [PATCH] GcovData.cc: Fix out-of-bounds access errors

2021-08-12 Thread Ryan Long
Would you need to check if length < sizeof(gcov_preamble) since length is assigned that value? -Original Message- From: Gedare Bloom Sent: Wednesday, August 11, 2021 11:13 AM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH] GcovData.cc: Fix out-of-bounds access errors On

[PATCH] GcovData.cc: Fix out-of-bounds access errors

2021-08-11 Thread Ryan Long
Adjusted number of bytes to be read CID 1506208: Out-of-bounds access CID 1506209: Out-of-bounds access Closes #4485 --- tester/covoar/GcovData.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc index

RE: [PATCH] GcovData.cc: Fix out-of-bounds access errors

2021-08-12 Thread Ryan Long
Oh now I see what you mean. Preamble is of gcov_preamble type. I'll change sizeof( gcov_preamble ) to sizeof( preamble ) to make that easier to follow. -Original Message- From: Gedare Bloom Sent: Thursday, August 12, 2021 12:39 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH

[PATCH v2] GcovData.cc: Fix out-of-bounds access errors

2021-08-12 Thread Ryan Long
Adjusted number of bytes to be read CID 1506208: Out-of-bounds access CID 1506209: Out-of-bounds access Closes #4485 --- tester/covoar/GcovData.cc | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc index

[PATCH 1/5] GcovData: Convert to C++

2021-07-29 Thread Ryan Long
Change C-style code to C++ --- tester/covoar/GcovData.cc | 317 -- tester/covoar/GcovData.h | 32 ++-- tester/covoar/GcovFunctionData.cc | 287 -- tester/covoar/GcovFunctionData.h | 44 +++--- 4 files changed,

RE: [PATCH 1/5] GcovData: Convert to C++

2021-07-29 Thread Ryan Long
I'm not sending in five patches. I just wanted to send in the conversion to C++ separately from the reformatting of GcovData. -Original Message- From: Ryan Long Sent: Thursday, July 29, 2021 12:45 PM To: devel@rtems.org Cc: Ryan Long Subject: [PATCH 1/5] GcovData: Convert to C

[PATCH] rtems-utils: Change data type definition

2021-07-29 Thread Ryan Long
Change typedef for ostream_guard to using. --- linkers/rtems-exeinfo.cpp| 2 +- tester/covoar/CoverageMapBase.cc | 2 +- tester/covoar/ReportsHtml.cc | 2 +- tester/covoar/ReportsText.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v1 02/13] ReportsHtml.cc: Initialize lastState_m

2021-08-01 Thread Ryan Long
When not initialized, an extra code segment would be added to annotated.html --- tester/covoar/ReportsHtml.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/covoar/ReportsHtml.cc b/tester/covoar/ReportsHtml.cc index 88ea25b..4c024d5 100644 --- a/tester/covoar/ReportsHtml.cc +++

[PATCH v1 00/13] Remove the global variables in app_common

2021-08-01 Thread Ryan Long
of the global variables were pointers before, and they have been changed to reference variables. The only exception to this is TargetInfo. Thanks, Ryan Ryan Long (13): Remove AllExplanations global variable ReportsHtml.cc: Initialize lastState_m Remove objdumpProcessor global variable

[PATCH v1 03/13] Remove objdumpProcessor global variable

2021-08-01 Thread Ryan Long
- Replaced objdumpProcessor in app_common with a local variable in TraceConverter.cc and covoar.cc - Added objdumpProcessor as a parameter for GenerateReports() and the processFile() member function of TraceReaderBase and its derived classes - Changed previous objdumpProcessor member

[PATCH v1 04/13] Remove Verbose global variable

2021-08-01 Thread Ryan Long
Replaced Verbose in app_common with local variables that are passed as a parameter into numerous functions --- tester/covoar/DesiredSymbols.cc | 17 tester/covoar/DesiredSymbols.h| 13 +--- tester/covoar/ExecutableInfo.h| 1 + tester/covoar/ObjdumpProcessor.cc

[PATCH v1 05/13] Remove dynamicLibrary global variable

2021-08-01 Thread Ryan Long
- Replaced dynamicLibrary in app_common with local variables - Changed data type to string - Changed conditionals to reflect this --- tester/covoar/ExecutableInfo.cc | 10 +- tester/covoar/ExecutableInfo.h | 6 +++--- tester/covoar/TraceConverter.cc | 5 +++--

[PATCH v1 06/13] Remove projectName global variable

2021-08-01 Thread Ryan Long
- Replaced projectName in app_common with a local variable in covoar() - Changed datatype to string - Changed conditionals to reflect this - Created projectName_m member variable for ReportsBase - Added parameter to Reports* constructors to initialize projectName_m ---

[PATCH v1 07/13] Remove outputDirectory global variable

2021-08-01 Thread Ryan Long
- Replaced outputDirectory in app_common with a local variable in covoar() - Created the outputDirectory_m member variable - Added parameters to Reports* constructors to initialize outputDirectory_m and non member functions --- tester/covoar/ReportsBase.cc | 41

[PATCH v1 08/13] Remove input buffer global variables

2021-08-01 Thread Ryan Long
- Removed input buffers from app_common and added them as a local variable to functions where inputBuffer was being used - Added #define for MAX_LINE_LENGTH in files where it is used - Changed Explanations::load to use a string instead of a C-string --- tester/covoar/Explanations.cc |

[PATCH v1 09/13] Remove SymbolsToAnalyze global variable

2021-08-01 Thread Ryan Long
- Removed SymbolsToAnalyze from app_common and replaced it with the symbolsToAnalyze_m member variable in DesiredSymbols, GcovData, and ObjdumpProcessor - Added a parameter to constructors to initialize symbolsToAnalyze_m - Moved the definition of objdumpLine_t out of ObjdumpProcessor to make

[PATCH v1 10/13] Remove BranchInfoAvailable global variable

2021-08-01 Thread Ryan Long
- Removed BranchInfoAvailable from app_common - Created member variable in CoverageReaderBase and ReportsBase and a function to get the value of the member variable --- tester/covoar/CoverageReaderBase.cc | 5 + tester/covoar/CoverageReaderBase.h | 10 ++

[PATCH v1 11/13] Remove TargetInfo global variable

2021-08-01 Thread Ryan Long
- Remove TargetInfo from app_common - Created the targetInfo_m member variable in CoverageReaderBase, TraceWriterBase, and ObjdumpProcessor - Made functions to set the value of targetInfo_m --- tester/covoar/CoverageReaderBase.cc | 5 + tester/covoar/CoverageReaderBase.h | 12

[PATCH v1 12/13] app_common: Remove functions and macros

2021-08-01 Thread Ryan Long
- Moved functions from app_common to the file they are used - Got rid of FileIsNewer() since it's not being used - Removed macros --- tester/covoar/TraceReaderLogQEMU.cc | 14 + tester/covoar/app_common.cc | 58 - tester/covoar/app_common.h

[PATCH v1 13/13] Remove app_common and all references to it

2021-08-01 Thread Ryan Long
- Removed the includes of app_common.h - Removed app_common references in build infrastructure - Removed app_common.cc and app_common.h --- tester/covoar/CoverageReaderQEMU.cc | 1 - tester/covoar/CoverageReaderTSIM.cc | 1 - tester/covoar/DesiredSymbols.cc | 1 -

[PATCH v1 2/5] rtems-exeinfo.cpp: Reset cout stream flags

2021-08-04 Thread Ryan Long
CID 1503006: Not restoring ostream format CID 1503007: Not restoring ostream format Remove ostream_guard, add restiosflags() call, and store the value of precision before it is changed restore it afterwards. Closes #4469 --- linkers/rtems-exeinfo.cpp | 11 --- 1 file changed, 4

[PATCH v1 0/5] Fix ostream format errors

2021-08-04 Thread Ryan Long
r changing the setfill value to something else. I don't know if Coverity will recognize storing the precision value and restoring it as a fix for the setprecision() calls, but the only other option is to just set the precision value to 6 (the default value). Thanks, Ryan Ryan Long (5): rtems-utils

[PATCH v1 4/5] ReportsHtml.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1505939: Not restoring ostream format Remove ostream_guard, add call to resetiosflags(), store precision value before changing it and restore it afterwards. Closes #4471 --- tester/covoar/ReportsHtml.cc | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v1 3/5] CoverageMapBase.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1503022: Not restoring ostream format Remove ostream_guard, change ostream format back to defaults. Closes #4470 --- tester/covoar/CoverageMapBase.cc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tester/covoar/CoverageMapBase.cc b/tester/covoar/CoverageMapBase.cc

[PATCH v1 5/5] ReportsText.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1505940: Not restoring ostream format Remove ostream_guard, add call to resetiosflags(), store precision value before changing it and restore it afterwards. Closes #4472 --- tester/covoar/ReportsText.cc | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-04 Thread Ryan Long
ostream_guard did not fix the "Not restoring ostream format" Coverity issues as hoped, so there's no reason to have it. --- rtemstoolkit/rtems-utils.h | 20 1 file changed, 20 deletions(-) diff --git a/rtemstoolkit/rtems-utils.h b/rtemstoolkit/rtems-utils.h index

[PATCH 1/3] GcovData.cc: Add ostream_guard

2021-08-11 Thread Ryan Long
CID 1506202: Not restoring ostream format Closes #4483 --- tester/covoar/GcovData.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tester/covoar/GcovData.cc b/tester/covoar/GcovData.cc index 02e7489..d4acfa4 100644 --- a/tester/covoar/GcovData.cc +++ b/tester/covoar/GcovData.cc @@ -16,6

[PATCH 2/3] GcovFunctionData.cc: Add ostream_guard

2021-08-11 Thread Ryan Long
CID 1506205: Not restoring ostream format Closes #4484 --- tester/covoar/GcovFunctionData.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tester/covoar/GcovFunctionData.cc b/tester/covoar/GcovFunctionData.cc index aec04ce..4db5eba 100644 --- a/tester/covoar/GcovFunctionData.cc +++

[PATCH 3/3] ReportsText.cc: Add ostream_guard

2021-08-11 Thread Ryan Long
CID 1505940: Not restoring ostream format Closes #4472 --- tester/covoar/ReportsText.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tester/covoar/ReportsText.cc b/tester/covoar/ReportsText.cc index 40558d8..edf7984 100644 --- a/tester/covoar/ReportsText.cc +++

[PATCH 0/3] Add ostream_guard patches

2021-08-11 Thread Ryan Long
Hi, In this series of patches, I just added ostream_guards where there were "Restore ostream format" errors. This won't make the error go away, but we're going to start ignoring those errors and just placing ostream_guards as was done here. Thanks, Ryan Ryan Long (3): GcovDa

[PATCH rtems-docs] posix.rst: Add info for FreeBSD 13

2021-09-21 Thread Ryan Long
Add list of additional packages needed to build RTEMS environment for FreeBSD 13. --- user/hosts/posix.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/user/hosts/posix.rst b/user/hosts/posix.rst index 6686fc9..284df48 100644 --- a/user/hosts/posix.rst +++

RE: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-23 Thread Ryan Long
, September 22, 2021 7:24 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting On 23/9/21 12:35 am, Ryan Long wrote: > I changed the definition of discardBuff to > > char discardBuff[100]{}; char discardBuff[100] = {}; ? > S

[PATCH v1] rtems-binutils: Update to 2.37 and update head

2021-10-13 Thread Ryan Long
Update to binutils 2.37 for RTEMS 6 to fix an issue when building tests for AArch64. Also updated the commit and hash for binutils in rtems-binutils-head. --- rtems/config/6/rtems-default.bset | 2 +- rtems/config/tools/rtems-binutils-2.37.cfg | 12

[PATCH rtems-tools v1] TraceConverter.cc: Add catch for exception

2021-10-12 Thread Ryan Long
CID 1471639: Add catch for exception Closes #4501 --- tester/covoar/TraceConverter.cc | 45 ++--- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/tester/covoar/TraceConverter.cc b/tester/covoar/TraceConverter.cc index 16c69d4..4a24bd4 100644

[PATCH rtems-tools v1] TraceConverter.cc: Add catch for exception

2021-10-12 Thread Ryan Long
CID 1471639: Add catch for exception Closes #4501 --- tester/covoar/TraceConverter.cc | 45 ++--- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/tester/covoar/TraceConverter.cc b/tester/covoar/TraceConverter.cc index 16c69d4..4a24bd4 100644

[PATCH v2] rtems-kernel: Implement kernel recipe using waf

2021-10-13 Thread Ryan Long
Closes #4145 --- rtems/config/tools/rtems-kernel-6.cfg | 6 +- rtems/config/tools/rtems-kernel-common.cfg | 91 +-- source-builder/sb/options.py | 136 +++-- 3 files changed, 119 insertions(+), 114 deletions(-) diff --git

RE: [PATCH] rtems-kernel: Implement kernel recipe using waf

2021-10-12 Thread Ryan Long
-Original Message- From: Chris Johns Sent: Friday, October 8, 2021 6:44 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH] rtems-kernel: Implement kernel recipe using waf Hi Ryan, Thank you for taking this on. I would like see one addition, a user supplied config.ini file

[rtems-tools] tester: Update jobs configuration

2021-10-20 Thread Ryan Long
Allow for default_jobs and max_jobs to be specified in the BSP's configuration file. --- rtemstoolkit/options.py| 45 +- tester/rtems/testing/bsps/beagleboardxm.ini| 2 +- tester/rtems/testing/bsps/beagleboneblack.ini | 2 +-

RE: [PATCH v1] rtems-binutils: Update to 2.37 and update head

2021-10-14 Thread Ryan Long
, 2021 7:21 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1] rtems-binutils: Update to 2.37 and update head On 14/10/21 3:20 am, Ryan Long wrote: > Update to binutils 2.37 for RTEMS 6 to fix an issue when building > tests for AArch64. Also updated the commit and hash for bi

RE: [PATCH v2] rtems-kernel: Implement kernel recipe using waf

2021-10-19 Thread Ryan Long
ping -Original Message- From: Ryan Long Sent: Wednesday, October 13, 2021 5:08 PM To: devel@rtems.org Cc: Ryan Long Subject: [PATCH v2] rtems-kernel: Implement kernel recipe using waf Closes #4145 --- rtems/config/tools/rtems-kernel-6.cfg | 6 +- rtems/config/tools/rtems-kernel

RE: [PATCH] rtems/6: Update binutils to 2.37

2021-10-19 Thread Ryan Long
It hasn't been pushed yet. You had asked if there was a ticket that needed to be closed with that patch since it was fixing an issue we've had with aarch64. I responded to the email, but I guess I forgot to send in V2 with the ticket that it was supposed to close. -Original Message-

RE: [PATCH] rtems/6: Update binutils to 2.37

2021-10-19 Thread Ryan Long
Ticket 4218 closed -Original Message- From: Joel Sherrill Sent: Tuesday, October 19, 2021 9:37 AM To: Ryan Long Cc: Chris Johns ; rtems-de...@rtems.org Subject: Re: [PATCH] rtems/6: Update binutils to 2.37 I just pushed it. Ryan.. please check that the ticket got updated correctly

[PATCH rtems-tools v1] rtems-tld.cpp: Remove logically dead code

2021-10-08 Thread Ryan Long
CID 1399595: Logically dead code in generate_traces(). Closes #4525 --- linkers/rtems-tld.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/linkers/rtems-tld.cpp b/linkers/rtems-tld.cpp index 7b42e45..bc1ad89 100644 --- a/linkers/rtems-tld.cpp +++

[PATCH] rtems-kernel: Implement kernel recipe using waf

2021-10-08 Thread Ryan Long
Closes #4145 --- rtems/config/tools/rtems-kernel-6.cfg | 8 ++- rtems/config/tools/rtems-kernel-common.cfg | 95 +- 2 files changed, 47 insertions(+), 56 deletions(-) diff --git a/rtems/config/tools/rtems-kernel-6.cfg b/rtems/config/tools/rtems-kernel-6.cfg

[PATCH rtems-tools v2] rtems-bin2c.c: Check length of buffer to be copied

2021-09-28 Thread Ryan Long
CID 1063892: Copy into fixed size buffer in process(). Closes #4424 --- misc/bin2c/rtems-bin2c.c | 13 + 1 file changed, 13 insertions(+) diff --git a/misc/bin2c/rtems-bin2c.c b/misc/bin2c/rtems-bin2c.c index 8e32d25..ace1dae 100644 --- a/misc/bin2c/rtems-bin2c.c +++

[PATCH] ReportsBase.cc: Add assert for member variables

2021-09-29 Thread Ryan Long
The uncoveredRanges and uncoveredBranch member variables are allocated as a pair. They are both either NULL or not NULL. Coverity does not know this though, so this assert is added to ensure they are not NULL before being dereferenced. CID 1503710: Dereference after null check Closes #4428 ---

[PATCH] record-client.c: Ignore return value from visit()

2021-09-29 Thread Ryan Long
CID 1503011: Unchecked return value in resolve_hold_back(). Closes #4423 --- trace/record/record-client.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/trace/record/record-client.c b/trace/record/record-client.c index e1365fe..edc4ab3 100644 ---

[PATCH] record-main-lttng.cc: Change size of empty array

2021-09-30 Thread Ryan Long
Change size of kEmptyThreadName from THREAD_API_COUNT to THREAD_NAME_SIZE. Closes #4519 --- trace/record/record-main-lttng.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/record/record-main-lttng.cc b/trace/record/record-main-lttng.cc index 7cfa48c..faa762d 100644

RE: Building rtems-kernel with RSB

2021-10-06 Thread Ryan Long
ping -Original Message- From: devel On Behalf Of Ryan Long Sent: Thursday, September 16, 2021 5:25 PM To: devel@rtems.org Subject: Building rtems-kernel with RSB Hi, I'm trying to build rtems-kernel with the RSB. I haven't gotten it to work. I'm getting "Undefined reference to&qu

[PATCH rtems-tools v1 2/2] rld-rapp.cpp: Add catch for exception

2021-10-07 Thread Ryan Long
CID 1471643: Uncaught exception Closes #4502 --- rtemstoolkit/rld-rap.cpp | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/rtemstoolkit/rld-rap.cpp b/rtemstoolkit/rld-rap.cpp index 235de27..93ffbdc 100644 --- a/rtemstoolkit/rld-rap.cpp +++

[PATCH rtems-tools v1 0/2] Uncaught exception patches

2021-10-07 Thread Ryan Long
Hi, These patches fix the "Uncaught exception" Coverity issues. To fix this, I just added a try and catch for the exception that Coverity identified. Thanks, Ryan Ryan Long (2): TraceConverter.cc: Add catch for exception rld-rapp.cpp: Add catch for exception rtemstoolkit/r

[PATCH rtems-tools v1 1/2] TraceConverter.cc: Add catch for exception

2021-10-07 Thread Ryan Long
CID 1471639: Uncaught exception Closes #4501 --- tester/covoar/TraceConverter.cc | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/tester/covoar/TraceConverter.cc b/tester/covoar/TraceConverter.cc index 0f32efb..16c69d4 100644 ---

RE: [PATCH rtems-tools v1 4/7] TraceReaderLogQEMU.cc: Fix formatting

2021-09-22 Thread Ryan Long
ECTION_END "" Neither are close to going over the size of discardBuff, but I can add a check and return false if it does happen to go over that length. -Original Message- From: Chris Johns Sent: Tuesday, September 21, 2021 6:16 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATC

RE: Certificate validation issue when trying to build qemu

2021-10-04 Thread Ryan Long
Actually, I was only able to download it on my Linux VM. My FreeBSD 13 VM won't let me download it from the browser. I was using Firefox for both. -Original Message- From: devel On Behalf Of Ryan Long Sent: Monday, October 4, 2021 2:40 PM To: devel@rtems.org Subject: Certificate

<    1   2   3   4   5   6   7   >