Re: [PATCH] improved error checking in ticks per timeslice

2024-03-06 Thread Will
Hey Zack, Sebastian posted exactly what he thought those lines should be to match the surrounding coding style: #if defined(CONFIGURE_TICKS_PER_TIMESLICE) && CONFIGURE_TICKS_PER_TIMESLICE <= 0 It should just be a single #if like that and with that order of conditionals. You'll of course need to

Re: [PATCH rtems6 1/1] xparameters.h: fix typo in comment

2024-01-08 Thread Will
Looks good to me. There is generally no need for a 0/X email when X is small unless you think it is necessary. In this case, a message of "see patch" isn't very useful. Kinsey On Sun, Jan 7, 2024 at 12:27 PM wrote: > From: Bernd Moessner > > --- > bsps/include/xil/xparameters.h | 2 +- > 1 fi

Re: [PATCH 2/9] cpukit/jffs2: Protect the inode cache

2023-12-13 Thread Will
On Wed, Dec 13, 2023 at 2:43 PM Chris Johns wrote: > On 14/12/2023 6:32 am, Sebastian Huber wrote:> We use this file system on > lower > end controllers. > > I do not believe this is relevant to the discussion. The issue standard on > its > own merit and not yours or my uses. Can we please avoid

Re: [PATCH] rtemsbsd/versal_slcr: Fix Versal GEM clock set

2023-06-15 Thread Will
This looks good as far as the functional content is concerned. As a nit, it looks like some unnecessary newlines were added in cgem_set_ref_clk() and the added if() conditional braces are inconsistent in their formatting so feel free to tweak those before commit. On Thu, Jun 15, 2023 at 12:48 AM

Re: [PATCH] spec/bsp/makecustom: Make BSP include path a system include path

2023-04-13 Thread Will
This change is fine, but it also needs the packageconfig change to match. The thread from October has the full patch (title was "[PATCH v2] spec/pkgconfig: Allow builds to override headers"). This also needs a change to libbsd to account for this alteration, IIRC. Kinsey On Wed, Apr 12, 2023 at 5

Re: Flash Device API

2023-03-17 Thread Will
has no implementation. It has no tests. It has no > > driver framework (ONFI, JEDEC). It has no example driver. It has no > > Doxygen documentation. The coding style of the new file has nothing to > > do with the RTEMS coding style. > > > > I think the provided code appear

Re: [PATCH rtems-libbsd 3/3] freebsd/cgem: Add weak symbol for riscv

2023-03-01 Thread Will
ation that will actually set the reference clock. On Tue, Feb 28, 2023 at 11:57 PM Padmarao Begari < padmarao.beg...@microchip.com> wrote: > Add __weak_symbol instead of __weak_reference for the > cgem_set_ref_clk() function for riscv build. > --- > freebsd/sys/dev/cadence/if_

Re: [PATCH rtems-libbsd 2/3] freebsd/cgem: Read clock frequency from device tree

2023-03-01 Thread Will
On Tue, Feb 28, 2023 at 11:57 PM Padmarao Begari < padmarao.beg...@microchip.com> wrote: > Read the clock frequency from the device tree and use it to > calculate the mdc clock divider for the MII bus if not found > then use default clock divider. > --- > freebsd/sys/dev/cadence/if_cgem.c | 39 ++

Re: [PATCH rtems-libbsd 1/3] freebsd/cgem: Add phy address to read it from device tree

2023-03-01 Thread Will
On Tue, Feb 28, 2023 at 11:57 PM Padmarao Begari < padmarao.beg...@microchip.com> wrote: > Read the phy address from the device tree and use it to > find the phy device if not found then search in the > range of 0 to 31. > --- > freebsd/sys/dev/cadence/if_cgem.c | 41 -

Re: [PATCH] posix: Only check shm_unlink obj_err if necessary

2020-06-27 Thread Will
; > >> >shm = _POSIX_Shm_Get_by_name( name, 0, &obj_err ); >> > - switch ( obj_err ) { >> > -case OBJECTS_GET_BY_NAME_INVALID_NAME: >> > - err = ENOENT; >> > - break; >> > - >> > -case OBJECTS_GET_BY_NAME_NAME_TOO_LONG: &

Re: .rtemsstack location on ARM

2020-01-09 Thread Will
Hi Sebastian, The relocated vector table is also present in REGION_VECTOR as long as bsp_vector_table_in_start_section is not defined in the linker script. It sounds like this is expected behavior, though, so I'll adjust accordingly. Thanks, William On Wed, Jan 8, 2020 at 11:58 PM Sebastian Huber

.rtemsstack location on ARM

2020-01-08 Thread Will
I've been working on a Cortex-M4 BSP and its Qemu model has some peculiarities requiring me to relocate the vector table to the end of the available storage, at least temporarily. In the process of doing this, I noticed that .rtemsstack is placed in REGION_VECTOR in the shared linkcmds.base instead

Re: ARM GICv3 Support

2018-10-24 Thread Will
Great, thanks! That will make initial bringup a little bit easier while deciding whether I need to write a full GICv3 driver. William On Wed, Oct 24, 2018 at 6:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Will, > > On 23/10/2018 20:28, Will wrote:

ARM GICv3 Support

2018-10-23 Thread Will
Hi, I'm currently doing some evaluations for an ARMv8 BSP which would necessarily include a GIC that implements the GICv3 spec[1]. I see that there is a shared GIC driver for ARM that seems to implement the ARM GICv1 spec based on the BSPs in which it is used. Is anyone aware of whether the shared