Re: [rtems-tools commit] tester/exe: Adjust timeouts by the step size

2021-10-15 Thread Sebastian Huber
On 15/10/2021 08:26, Chris Johns wrote: On 15/10/21 5:15 pm, Sebastian Huber wrote: On 22/09/2021 00:59, Chris Johns wrote: Module:    rtems-tools Branch:    master Commit:    cfd5aa41e847752cd98cde65515df7ce45ff9665 Changeset:http://git.rtems.org/rtems-tools/commit/?id

Re: [rtems-tools commit] tester/exe: Adjust timeouts by the step size

2021-10-15 Thread Sebastian Huber
:00.842749 Testing time : 0:00:50.564911 -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899

Re: [PATCH] rtems: Fix rate monotonic statistics

2021-10-12 Thread Sebastian Huber
On 12/10/2021 08:36, Sebastian Huber wrote: diff --git a/cpukit/libcsupport/src/__times.c b/cpukit/libcsupport/src/__times.c index 7bb7e0e9ca..a37c662654 100644 --- a/cpukit/libcsupport/src/__times.c +++ b/cpukit/libcsupport/src/__times.c @@ -65,7 +65,8 @@ clock_t _times( * of ticks since

[PATCH] rtems: Fix rate monotonic statistics

2021-10-12 Thread Sebastian Huber
The rate monotonic period statistics were affected by rtems_cpu_usage_reset(). The logic to detect and work around a CPU usage reset was broken. The Thread_Contol::cpu_time_used is changed to contain the processor time used throughout the entire lifetime of the thread. The new member

[PATCH] rtems: Add new clock manager directives

2021-10-11 Thread Sebastian Huber
Update #4527. --- cpukit/include/rtems/rtems/clock.h | 590 + cpukit/score/src/kern_tc.c | 56 +++ 2 files changed, 646 insertions(+) diff --git a/cpukit/include/rtems/rtems/clock.h b/cpukit/include/rtems/rtems/clock.h index 8511cb9cef..16b838a842 100644 ---

[PATCH] c-user: Document new clock manager directives

2021-10-11 Thread Sebastian Huber
Add new clock manager directives to get all times provided by the timehands. Update #4527. --- For an updated document to review see: https://ftp.rtems.org/pub/rtems/people/sebh/c-user.pdf c-user/clock/directives.rst | 830 ++ c-user/clock/introduction.rst |

[PATCH] score: Simplify _Watchdog_Next_first()

2021-10-11 Thread Sebastian Huber
--- cpukit/include/rtems/score/watchdogimpl.h | 55 +++ 1 file changed, 36 insertions(+), 19 deletions(-) diff --git a/cpukit/include/rtems/score/watchdogimpl.h b/cpukit/include/rtems/score/watchdogimpl.h index 7b364b8828..ba1a884a3d 100644 ---

Re: Scope of variables flagged by code inspector

2021-10-11 Thread Sebastian Huber
in the coding style. From my point of view we should go one step further and allow the declaration and preferably also the initialization of local variables as close to their first use as possible in contrast to only the scope begin. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178

Re: [RTEMS 5 v3] Add support for IDLE Thread stack allocator

2021-10-07 Thread Sebastian Huber
, looks good. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer

Re: [RTEMS 5 v2] Add support for IDLE Thread stack allocator

2021-10-05 Thread Sebastian Huber
lude +#include Why the wkspace.h include? + +const Stack_Allocator_allocate_for_idle _Stack_Allocator_allocate_for_idle = +_Stack_Allocator_allocate_for_idle_default; Please move the definition to this file and make _Stack_Allocator_allocate_for_idle_default() static. [...] -- embed

Re: [PATCH] score: Optimize EDF SMP scheduler ops

2021-10-05 Thread Sebastian Huber
On 05/10/2021 20:34, Joel Sherrill wrote: On Tue, Oct 5, 2021 at 1:26 PM Sebastian Huber wrote: The schedule operation is only called by rtems_task_mode(). It is called if preempt mode of the executing thread changes from disabled to enabled. Since the EDF SMP scheduler does not support

[PATCH] score: Optimize EDF SMP scheduler ops

2021-10-05 Thread Sebastian Huber
The schedule operation is only called by rtems_task_mode(). It is called if preempt mode of the executing thread changes from disabled to enabled. Since the EDF SMP scheduler does not support the disabled preemption mode, the schedule operation is never called. ---

[PATCH v2 4/4] sys/tree.h: Red child with black sibling rotations

2021-10-05 Thread Sebastian Huber
Add specialized rotations RB_RED_ROTATE_LEFT() and RB_RED_ROTATE_RIGHT() which may be used if we rotate a red child which has a black sibling. Such a red node must have at least two child nodes so that the following red-black tree invariant is fulfilled: Every path from a given node to any of

[PATCH v2] Align *utime*() with POSIX/glibc

2021-10-05 Thread Sebastian Huber
Change the prototypes to be in line with POSIX/glibc. This may fix issues with new warnings produced by GCC 11. Signed-off-by: Sebastian Huber --- newlib/libc/include/sys/_default_fcntl.h | 2 +- newlib/libc/include/sys/stat.h | 4 ++-- newlib/libc/include/sys/time.h | 6

[PATCH v2 3/4] sys/tree.h: Add parent rotations

2021-10-05 Thread Sebastian Huber
Add specialized rotations RB_PARENT_ROTATE_LEFT() and RB_PARENT_ROTATE_RIGHT() which may be used if the parent node exists and the direction of the child is known. The specialized rotations are derived from RB_ROTATE_LEFT() and RB_ROTATE_RIGHT() where the RB_SWAP_CHILD() was replaced by a simple

[PATCH v2 2/4] sys/tree.h: Simplify chain of conditions

2021-10-05 Thread Sebastian Huber
In RB_GENERATE_REMOVE_COLOR() simplify a chain of conditions of the following pattern if (x) { ... } else if (!x) { ... } to if (x) { ... } else { ... } --- newlib/libc/include/sys/tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libc/include/sys/tree.h

[PATCH v2 0/4] Optimize red-black tree insert/extract

2021-10-05 Thread Sebastian Huber
Code coverage analysis of the red-black tree insert/extract operations defined in showed that the macros contain dead code. This patch set simplifies some expressions and add specialized rotations. v2: Add comments in patch 3 and 4. Sebastian Huber (4): sys/tree.h: Simplify loop condition

[PATCH v2 1/4] sys/tree.h: Simplify loop condition

2021-10-05 Thread Sebastian Huber
We have #define RB_ISRED(elm, field) \ ((elm) != NULL && RB_COLOR(elm, field) == RB_RED) So, the RB_ISRED() contains an implicit check for NULL. In RB_GENERATE_REMOVE_COLOR() the "elm" pointer cannot be NULL in the while condition. Use RB_COLOR(elm) == RB_BLACK instead. ---

[PATCH 0/4] Optimize red-black tree insert/extract

2021-10-05 Thread Sebastian Huber
Code coverage analysis of the red-black tree insert/extract operations defined in showed that the macros contain dead code. This patch set simplifies some expressions and add specialized rotations. Sebastian Huber (4): sys/tree.h: Simplify loop condition sys/tree.h: Simplify chain

[PATCH 3/4] sys/tree.h: Add parent rotations

2021-10-05 Thread Sebastian Huber
Add specialized rotations RB_PARENT_ROTATE_LEFT() and RB_PARENT_ROTATE_RIGHT() which may be used if the parent node exists and the direction of the child is known. The specialized rotations are derived from RB_ROTATE_LEFT() and RB_ROTATE_RIGHT() where the RB_SWAP_CHILD() was replaced by a simple

[PATCH 4/4] sys/tree.h: Red child with black sibling rotations

2021-10-05 Thread Sebastian Huber
Add specialized rotations RB_RED_ROTATE_LEFT() and RB_RED_ROTATE_RIGHT() which may be used if we rotate a red child which has a black sibling. Such a red node must have at least two child nodes so that the following red-black tree invariant is fulfilled: Every path from a given node to any of

[PATCH 2/4] sys/tree.h: Simplify chain of conditions

2021-10-05 Thread Sebastian Huber
In RB_GENERATE_REMOVE_COLOR() simplify a chain of conditions of the following pattern if (x) { ... } else if (!x) { ... } to if (x) { ... } else { ... } --- newlib/libc/include/sys/tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libc/include/sys/tree.h

[PATCH 1/4] sys/tree.h: Simplify loop condition

2021-10-05 Thread Sebastian Huber
We have #define RB_ISRED(elm, field) \ ((elm) != NULL && RB_COLOR(elm, field) == RB_RED) So, the RB_ISRED() contains an implicit check for NULL. In RB_GENERATE_REMOVE_COLOR() the "elm" pointer cannot be NULL in the while condition. Use RB_COLOR(elm) == RB_BLACK instead. ---

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-10-04 Thread Sebastian Huber
On 05/10/2021 03:51, Chris Johns wrote: On 5/10/21 4:29 am, Sebastian Huber wrote: On 02/10/2021 01:44, Chris Johns wrote: The fatal extensions have a well defined order (position in the table). The user has the full control over the initial extensions table. Is it backwards compatible when

Re: [PATCH v2 2/6] cpukit: Add Exception Manager

2021-10-04 Thread Sebastian Huber
on't have to call the complicated raise() function in the exception context. It is called in thread context. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741

Re: [RTEMS 5] Add support for IDLE Thread stack allocator

2021-10-04 Thread Sebastian Huber
nfig.stack_area = (*_Stack_Allocator_allocate_for_idle)( + _Per_CPU_Get_index( cpu ), + config.stack_size +); + } /* * The entire workspace is zeroed during its initialization. Thus, all [...] -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-10-04 Thread Sebastian Huber
not sure what you mean with backward compatible in this case. If you don't enable the exception to signal mapping (default), then nothing changes. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741

Re: [PATCH 3/3] microblaze: Rework for RTEMS 6

2021-10-04 Thread Sebastian Huber
-- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Ra

[PATCH 6/6] posix: Remove "RTEMS" from POSIX API group

2021-10-01 Thread Sebastian Huber
Clarify group description. Update #3706. --- cpukit/include/rtems/posix/posixapi.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cpukit/include/rtems/posix/posixapi.h b/cpukit/include/rtems/posix/posixapi.h index 122dd644e6..8d30ee21e5 100644 ---

[PATCH 5/6] scoe: Move workspace group definition

2021-10-01 Thread Sebastian Huber
Define the group in the header file which is used by . Update #3706. --- cpukit/include/rtems/score/wkspace.h | 10 +- cpukit/include/rtems/score/wkspacedata.h | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/cpukit/include/rtems/score/wkspace.h

[PATCH 4/6] rtems: Add ASR implementation to existing group

2021-10-01 Thread Sebastian Huber
Update #3706. --- cpukit/include/rtems/rtems/asrdata.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/include/rtems/rtems/asrdata.h b/cpukit/include/rtems/rtems/asrdata.h index 3f44d3b030..924e616a9a 100644 --- a/cpukit/include/rtems/rtems/asrdata.h +++

[PATCH 3/6] score: Add Hash Handler to group

2021-10-01 Thread Sebastian Huber
Update #3706. --- cpukit/include/rtems/score/hash.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/include/rtems/score/hash.h b/cpukit/include/rtems/score/hash.h index 8a269cc548..c6f9ebf463 100644 --- a/cpukit/include/rtems/score/hash.h +++ b/cpukit/include/rtems/score/hash.h @@

[PATCH 2/6] rtems: Canonicalize Doxygen in

2021-10-01 Thread Sebastian Huber
Update #3706. --- cpukit/include/rtems/counter.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cpukit/include/rtems/counter.h b/cpukit/include/rtems/counter.h index 5bf7736e4a..0053afcbd5 100644 --- a/cpukit/include/rtems/counter.h +++ b/cpukit/include/rtems/counter.h

[PATCH 0/6] Doxygen groups cleanup

2021-10-01 Thread Sebastian Huber
Sebastian Huber (6): rtems: Canonicalize Doxygen in rtems: Canonicalize Doxygen in score: Add Hash Handler to group rtems: Add ASR implementation to existing group scoe: Move workspace group definition posix: Remove "RTEMS" from POSIX API group cpukit/include/rtems

[PATCH 1/6] rtems: Canonicalize Doxygen in

2021-10-01 Thread Sebastian Huber
Update #3706. --- cpukit/include/rtems/seterr.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cpukit/include/rtems/seterr.h b/cpukit/include/rtems/seterr.h index 711382d732..adce762dc9 100644 --- a/cpukit/include/rtems/seterr.h +++ b/cpukit/include/rtems/seterr.h

[PATCH] rtems: Generate

2021-10-01 Thread Sebastian Huber
Write the documentation from scratch. --- cpukit/include/rtems/cpuuse.h | 217 -- 1 file changed, 178 insertions(+), 39 deletions(-) diff --git a/cpukit/include/rtems/cpuuse.h b/cpukit/include/rtems/cpuuse.h index 50c986671d..da51e9708a 100644 ---

Re: Workspace Initialization Faliure Bug

2021-10-01 Thread Sebastian Huber
On 01/10/2021 16:27, Joel Sherrill wrote: On Fri, Oct 1, 2021, 8:42 AM Sebastian Huber <mailto:sebastian.hu...@embedded-brains.de>> wrote: On 01/10/2021 00:38, Joel Sherrill wrote: > I think in this configuration, the workspace is essentially unneeded > but

Re: Workspace Initialization Faliure Bug

2021-10-01 Thread Sebastian Huber
you get this error with an unmodified master branch? Why is the workspace initialized? I tried to arrange everything so that the workspace doesn't get initialized if it is not needed. What pulled in the workspace initialization? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178

Re: [PATCH v2 1/6] cpukit/aarch64: Use correct interrupt level types

2021-10-01 Thread Sebastian Huber
On 01/10/2021 06:24, Gedare Bloom wrote: If the rest of the patch set isn't ready, please split this out for separate submission. It looks fine to me. Yes, sorry for the slow review. I somehow overlooked this patch set. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim

Re: [PATCH v2 5/6] cpukit: Add signal mapping support

2021-10-01 Thread Sebastian Huber
The fatal extensions have a well defined order (position in the table). The user has the full control over the initial extensions table. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741

Re: [PATCH v2 2/6] cpukit: Add Exception Manager

2021-10-01 Thread Sebastian Huber
on at least another architecture. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte

[PATCH] score: Remove _Thread_queue_Do_nothing_extract()

2021-09-30 Thread Sebastian Huber
This function was unused. It was a relict of the thread queue rework done during the SMP support development. In an early stage, the extract operation was called with a NULL thread queue. However, this is no longer the case. The extract operation is only called if we have a non-NULL thread

Re: [PATCH] score: Add Thread_queue_Deadlock_status

2021-09-29 Thread Sebastian Huber
On 24/09/2021 20:21, Sebastian Huber wrote: Replace the boolen return value with the new enum Thread_queue_Deadlock_status. This improves the code readability. Improve documentation. Shorten function names. Ping. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim

Re: [PATCH] score: Avoid dead code in thread queue surrender

2021-09-29 Thread Sebastian Huber
On 23/09/2021 07:38, Sebastian Huber wrote: For uniprocessor configurations, this patch removes dead code in the _Thread_queue_Surrender() and _Thread_queue_Surrender_priority_ceiling() functions. Dead code is removed from _Thread_queue_Surrender_sticky(). Ping. -- embedded brains GmbH Herr

Re: IDLE Stacks Not Allocated via User Provided Stack Allocator

2021-09-29 Thread Sebastian Huber
r the idle task stack size and the idle task index. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer:

Re: [PATCH] record-client.c: Ignore return value from visit()

2021-09-29 Thread Sebastian Huber
On 29/09/2021 16:28, Ryan Long wrote: CID 1503011: Unchecked return value in resolve_hold_back(). Looks good, thanks. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94

[PATCH] rtems: Adjust parameter names

2021-09-29 Thread Sebastian Huber
Adjust parameter names to match with the declaration. Close #4035. --- cpukit/rtems/src/clockgettod.c| 20 ++-- cpukit/rtems/src/clockgettodtimeval.c | 6 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cpukit/rtems/src/clockgettod.c

[PATCH] rtems: Justify integer conversions

2021-09-29 Thread Sebastian Huber
Close #2548. --- cpukit/rtems/src/clockgettod.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/rtems/src/clockgettod.c b/cpukit/rtems/src/clockgettod.c index 5058b42375..01daa3dc15 100644 --- a/cpukit/rtems/src/clockgettod.c +++

[PATCH] glossary: Add terms

2021-09-29 Thread Sebastian Huber
--- c-user/glossary.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index f85c08c..e91e356 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -101,9 +101,21 @@ Glossary C++11 The standard

[PATCH v2] score: Add Doxygen group for mutexes

2021-09-24 Thread Sebastian Huber
--- v2: Add group description. cpukit/score/src/mutex.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/cpukit/score/src/mutex.c b/cpukit/score/src/mutex.c index f7e35093b2..92bd614967 100644 --- a/cpukit/score/src/mutex.c +++ b/cpukit/score/src/mutex.c @@

[PATCH] score: Add Thread_queue_Deadlock_status

2021-09-24 Thread Sebastian Huber
Replace the boolen return value with the new enum Thread_queue_Deadlock_status. This improves the code readability. Improve documentation. Shorten function names. --- cpukit/include/rtems/score/threadqimpl.h | 50 ++- cpukit/score/src/threadchangepriority.c | 4 +-

[PATCH v2] eng: Add register block specification types

2021-09-24 Thread Sebastian Huber
A register block may be used to specify the interface of devices which use a linear address space. Register blocks consist of register block members specified by the ``definition`` attribute. Register block members are either instances of registers specified by the ``registers`` attribute or

[PATCH] glossary: Add OMIP

2021-09-24 Thread Sebastian Huber
--- c-user/glossary.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index 74f4ee1..f85c08c 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -604,6 +604,12 @@ Glossary variety of entities. Object-oriented systems shield

[PATCH] score: Add Doxygen group for mutexes

2021-09-24 Thread Sebastian Huber
--- cpukit/score/src/mutex.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/cpukit/score/src/mutex.c b/cpukit/score/src/mutex.c index f7e35093b2..cad434bbd2 100644 --- a/cpukit/score/src/mutex.c +++ b/cpukit/score/src/mutex.c @@ -1,7 +1,7 @@ /** * @file * -

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Sebastian Huber
On 23/09/2021 10:44, Chris Johns wrote: On 23/9/21 4:29 pm, Sebastian Huber wrote: On 23/09/2021 07:43,chr...@rtems.org wrote: From: Chris Johns - This call is provided by RTEMS and that is preferred Closes #4518 This removes the kqueue() support for pipe(). It does but it also lets

Re: [PATCH rtems-libbsd] rtemsbsd/syscalls: Remove pipe()

2021-09-23 Thread Sebastian Huber
On 23/09/2021 07:43, chr...@rtems.org wrote: From: Chris Johns - This call is provided by RTEMS and that is preferred Closes #4518 This removes the kqueue() support for pipe(). -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded

[PATCH] score: Avoid dead code in thread queue surrender

2021-09-22 Thread Sebastian Huber
For uniprocessor configurations, this patch removes dead code in the _Thread_queue_Surrender() and _Thread_queue_Surrender_priority_ceiling() functions. Dead code is removed from _Thread_queue_Surrender_sticky(). --- cpukit/score/src/threadqenqueue.c | 79 ++- 1 file

[PATCH] score: Improve variable names in thread init

2021-09-21 Thread Sebastian Huber
--- cpukit/score/src/threadinitialize.c | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/cpukit/score/src/threadinitialize.c b/cpukit/score/src/threadinitialize.c index e10eb1af88..81199a7044 100644 --- a/cpukit/score/src/threadinitialize.c +++

[PATCH] score: Simplify _Thread_Try_initialize()

2021-09-21 Thread Sebastian Huber
Move a code block to its own new function _Thread_Initialize_scheduler_and_wait_nodes(). Add comments. --- cpukit/score/src/threadinitialize.c | 180 +--- 1 file changed, 108 insertions(+), 72 deletions(-) diff --git a/cpukit/score/src/threadinitialize.c

Re: Remove old build system

2021-09-21 Thread Sebastian Huber
On 16/09/2021 15:31, Sebastian Huber wrote: Hello, I updated the commit which removes the old build system: https://git.rtems.org/sebh/rtems.git/commit/?h=remove-old-build-system=a6dbaeeeb34bbb10922f6a75590d05333599075c I updated to the latest RSB (Autoconf/Automake is no longer installed

Re: [PATCH v2 5/5] cpukit: Add AArch64 SMP Support

2021-09-20 Thread Sebastian Huber
. The patch set looks good. The name of the BSP option BSP_CPU_ON_SMC could be a bit more descriptive. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht

Re: [PATCH v1 2/5] testsuites/smpmulticast01: Enforce step ordering

2021-09-20 Thread Sebastian Huber
); _Thread_Dispatch_enable(cpu_self); This patch is fine. It seems that there could be a delay before the interrupt issued by _SMP_Send_message() is actually serviced on this platform. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de

[PATCH] libtest: Improve T_now_tick()

2021-09-17 Thread Sebastian Huber
The T_now_tick() is a fall back time measurement using the CPU counter in case no Clock Driver is configured. Some CPU counter may overflow during the test execution. Accumulate the elapsed time to reduce the chance of CPU counter overflows. --- cpukit/libtest/t-test-time.c | 45

[PATCH 3/5] score: Provide two thread pin/unpin defaults

2021-09-17 Thread Sebastian Huber
The uniprocessor schedulers do not support systems with more than more processors. So they rivially support thread pinning and thus the SMP_FATAL_SCHEDULER_PIN_OR_UNPIN_NOT_SUPPORTED cannot happen. Add a second default implementation for SMP schedulers which do not support thread pinning.

[PATCH 1/5] score: SCHEDULER_OPERATION_DEFAULT_ASK_FOR_HELP

2021-09-17 Thread Sebastian Huber
Rename SCHEDULER_OPERATION_DEFAULT_ASK_FOR_HELP in SCHEDULER_DEFAULT_SMP_OPERATIONS. Add a Doxygen comment. --- cpukit/include/rtems/score/scheduler.h | 15 +-- cpukit/include/rtems/score/schedulercbs.h | 2 +- cpukit/include/rtems/score/scheduleredf.h | 2 +-

[PATCH 4/5] score: Ensure only one CPU if required

2021-09-17 Thread Sebastian Huber
Issue the new fatal SMP error SMP_FATAL_SCHEDULER_REQUIRES_EXACTLY_ONE_PROCESSOR if the system starts with not exactly one processor and an uniprocessor scheduler is configured. --- cpukit/include/rtems/score/smpimpl.h | 3 ++- cpukit/include/rtems/sysinit.h| 1 +

[PATCH 2/5] score: SCHEDULER_OPERATION_DEFAULT_GET_SET_AFFINITY

2021-09-17 Thread Sebastian Huber
Rename SCHEDULER_OPERATION_DEFAULT_GET_SET_AFFINITY in SCHEDULER_DEFAULT_SET_AFFINITY_OPERATION. Add Doxygen comment. --- cpukit/include/rtems/score/scheduler.h | 16 ++-- cpukit/include/rtems/score/schedulercbs.h| 2 +- cpukit/include/rtems/score/scheduleredf.h

[PATCH 0/5] SMP related scheduler clean up

2021-09-17 Thread Sebastian Huber
This patch set adds a bit of Doxygen and removes dead code. Sebastian Huber (5): score: SCHEDULER_OPERATION_DEFAULT_ASK_FOR_HELP score: SCHEDULER_OPERATION_DEFAULT_GET_SET_AFFINITY score: Provide two thread pin/unpin defaults score: Ensure only one CPU if required score: Remove unused

[PATCH 5/5] score: Remove unused default scheduler ops

2021-09-17 Thread Sebastian Huber
If SMP support is enabled and the system has exactly one processor, then it may use an uniprocessor scheduler. The ask for help, reconsider help request, and withdraw node operations can be NULL in this case, since they are only used if a thread has at least one helping scheduler node. At least

Re: [PATCH] cpukit/smp: Prevent premature thread dispatch

2021-09-16 Thread Sebastian Huber
scenario caused a problem here? I guess there is a second bug involved, since maskable interrupt should be disabled for this code path. How could there be a race condition? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de

Remove old build system

2021-09-16 Thread Sebastian Huber
Hello, I updated the commit which removes the old build system: https://git.rtems.org/sebh/rtems.git/commit/?h=remove-old-build-system=a6dbaeeeb34bbb10922f6a75590d05333599075c -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded

Re: [PATCH] eng: Add register block specification types

2021-09-15 Thread Sebastian Huber
On 16/09/2021 01:47, Chris Johns wrote: On 15/9/21 3:33 pm, Sebastian Huber wrote: On 15/09/2021 00:48, Chris Johns wrote: On 14/9/21 8:08 pm, Sebastian Huber wrote: On 10/09/2021 16:41, Sebastian Huber wrote: A register block may be used to specify the memory-mapped interface

Re: [PATCH v1] bsps/riscv: Give enough time for clock driver initialization

2021-09-15 Thread Sebastian Huber
hardware do you have this problem with? Yes, instead of using a magic number it would be better to make this adaptive. I guess on real hardware there are no issues. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone

Re: [PATCH v2] c-user: Define lower and higher priority

2021-09-15 Thread Sebastian Huber
://git.rtems.org/rtems-central/commit/?id=4cd035ab1160394172d2669dd2ac22668b365991 -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München

[PATCH] rtems: Fix message manager documentation

2021-09-15 Thread Sebastian Huber
Correct the description of the ``count`` parameter of rtems_message_queue_flush(). Update #4508. --- cpukit/include/rtems/rtems/message.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/include/rtems/rtems/message.h b/cpukit/include/rtems/rtems/message.h index

Re: [PATCH] eng: Add register block specification types

2021-09-14 Thread Sebastian Huber
On 15/09/2021 00:48, Chris Johns wrote: On 14/9/21 8:08 pm, Sebastian Huber wrote: On 10/09/2021 16:41, Sebastian Huber wrote: A register block may be used to specify the memory-mapped interface to the hardware.  Register blocks consist of register block members. Register block members

[PATCH] c-user: Clarify task priorities

2021-09-14 Thread Sebastian Huber
--- c-user/scheduling-concepts/background.rst | 5 + c-user/scheduling-concepts/smp-schedulers.rst | 9 + c-user/task/background.rst| 14 ++ 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/c-user/scheduling-concepts/background.rst

[PATCH v2] c-user: Define lower and higher priority

2021-09-14 Thread Sebastian Huber
--- c-user/glossary.rst | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index 16a8b8d..94bf773 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -398,6 +398,10 @@ Glossary

[PATCH] c-user: Fix message manager documentation

2021-09-14 Thread Sebastian Huber
Remove bogus return status from rtems_message_queue_receive(). Clarify rtems_message_queue_flush(). Close #4508. --- c-user/message/directives.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/c-user/message/directives.rst

[PATCH] c-user: Define lower and higher priority

2021-09-14 Thread Sebastian Huber
--- c-user/glossary.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index 16a8b8d..b0cf7df 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -398,6 +398,17 @@ Glossary heterogeneous A

Re: [PATCH] eng: Add register block specification types

2021-09-14 Thread Sebastian Huber
On 10/09/2021 16:41, Sebastian Huber wrote: A register block may be used to specify the memory-mapped interface to the hardware. Register blocks consist of register block members. Register block members are either instances of registers or instances of other register blocks. Registers consists

Re: [PATCH] c-user: Add "Cache Manager" chapter

2021-09-13 Thread Sebastian Huber
On 10/09/2021 10:49, Sebastian Huber wrote: The Cache Manager directives are available via . Document most of them in the Classic API Guide. Not documented are the following directive since the API is not yet stable: * rtems_cache_coherent_allocate() * rtems_cache_coherent_free

Re: The compiler settings for Cortex-M4

2021-09-13 Thread Sebastian Huber
Hello Andrei, I modified the flags, could you please check if this fixed the problem? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht

Re: [PATCH] eng: Add register block specification types

2021-09-13 Thread Sebastian Huber
On 13/09/2021 10:43, Chris Johns wrote: On 13/9/21 4:38 pm, Sebastian Huber wrote: This approach is not limited to memory mapped register blocks. I think it is. I would like to understand how bus types other than "memory" are specified for a generic device driver that needs to

Re: [PATCH] eng: Add register block specification types

2021-09-13 Thread Sebastian Huber
On 12/09/2021 03:32, Chris Johns wrote: On 11/9/21 12:41 am, Sebastian Huber wrote: A register block may be used to specify the memory-mapped interface to the hardware. Register blocks consist of register block members. Register block members are either instances of registers or instances

Re: [PATCH] eng: Add register block specification types

2021-09-13 Thread Sebastian Huber
On 11/09/2021 19:59, Joel Sherrill wrote: On Fri, Sep 10, 2021, 9:41 AM Sebastian Huber <mailto:sebastian.hu...@embedded-brains.de>> wrote: A register block may be used to specify the memory-mapped interface to the hardware.  Register blocks consist of register bloc

Re: [PATCH] eng: Add register block specification types

2021-09-13 Thread Sebastian Huber
brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas

[PATCH] eng: Add register block specification types

2021-09-10 Thread Sebastian Huber
A register block may be used to specify the memory-mapped interface to the hardware. Register blocks consist of register block members. Register block members are either instances of registers or instances of other register blocks. Registers consists of bit fields. Update #3715. --- For

Re: [PATCH] rtems: Generate

2021-09-10 Thread Sebastian Huber
Hello Chris, thanks for the review. On 10/09/2021 10:55, Chris Johns wrote: Nice set of changes. My comments are below On 10/9/21 6:11 pm, Sebastian Huber wrote: Remove the duplicated description which is an out dated copy and paste from the Classic API Guide. Instead, thoroughly

[PATCH] c-user: Add "Cache Manager" chapter

2021-09-10 Thread Sebastian Huber
The Cache Manager directives are available via . Document most of them in the Classic API Guide. Not documented are the following directive since the API is not yet stable: * rtems_cache_coherent_allocate() * rtems_cache_coherent_free() * rtems_cache_coherent_add_area() Not documented are the

[PATCH] rtems: Generate

2021-09-10 Thread Sebastian Huber
Remove the duplicated description which is an out dated copy and paste from the Classic API Guide. Instead, thoroughly document the individual extensions. Change license to BSD-2-Clause according to file histories and documentation re-licensing agreement. Update #3899. Update #3993. ---

[PATCH] rtems: Generate

2021-09-08 Thread Sebastian Huber
Change license to BSD-2-Clause according to file histories and documentation re-licensing agreement. Update #3899. Update #3993. --- cpukit/include/rtems/rtems/cache.h | 688 ++--- 1 file changed, 532 insertions(+), 156 deletions(-) diff --git

Re: Dies libbsd DHCP provide a private network address?

2021-09-08 Thread Sebastian Huber
libbsd is dhcpcd. It provides a IPv4 link-local address if no DHCP offer is received after a timeout. This is enabled by default. You can disable it via the "noipv4ll" configuration option. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastia

Re: [PATCH] testsuites/fstests: Fix uninitialized utimbuf structs

2021-09-06 Thread Sebastian Huber
make the structures "const" to check also that the utime() prototype uses a const parameter. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Regis

Re: [PATCH] testsuites: Wrap putchar

2021-09-06 Thread Sebastian Huber
On 07/09/2021 05:16, Alex White wrote: The linker flag to wrap putchar was lost in translation from make to waf. Looks good. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-06 Thread Sebastian Huber
On 07/09/2021 05:11, Chris Johns wrote: On 6/9/21 6:11 pm, Sebastian Huber wrote: On 06/09/2021 09:55, Chris Johns wrote: On 6/9/21 3:49 pm, Sebastian Huber wrote: On 04/09/2021 06:20, Joel Sherrill wrote:   > -    sc = _TOD_Validate(_tod, TOD_ENABLE_TICKS_VALIDATION);   > +

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-06 Thread Sebastian Huber
On 06/09/2021 09:55, Chris Johns wrote: On 6/9/21 3:49 pm, Sebastian Huber wrote: On 04/09/2021 06:20, Joel Sherrill wrote: > -    sc = _TOD_Validate(_tod, TOD_ENABLE_TICKS_VALIDATION); > +    sc = _TOD_Validate(_tod);     This has leaked out of the internal implemen

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-05 Thread Sebastian Huber
On 04/09/2021 06:20, Joel Sherrill wrote: On Fri, Sep 3, 2021, 11:01 PM Chris Johns <mailto:chr...@rtems.org>> wrote: On 3/9/21 11:33 pm, Sebastian Huber wrote: > The behaviour with respect to the handling of the ticks member in the *_when() > directives w

Re: [PATCH 6/7] score: Always validate ticks in _TOD_Validate()

2021-09-05 Thread Sebastian Huber
oticed this also. It needs an API. There is no RTEMS API to support writing realtime clock drivers currently. I am not that sure if this is really a high priority issue. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phon

[PATCH] score: Move _Thread_Dispatch()

2021-09-03 Thread Sebastian Huber
The _Thread_Dispatch() function was customized over time and now the work is done by _Thread_Do_dispatch() and specialized wrappers. The plain _Thread_Dispatch() is now only used in some CPU ports. Move it to a separate file to avoid dead code in the general. Change license to BSD-2-Clause

  1   2   3   4   5   6   7   8   9   10   >