Re: [PATCH 11/40] bsps/include/libchip/disp_hcms29xx.h: Manual file header clean up
Hello Heinz, thanks for reporting and analyzing it. And sorry for pushing a patch that broke it in the first place. I was just looking through the error messages whether there is a second error. I'll push a patch for the closing comment in the next few minutes. Best regards Christian Am 10.03.22 um 14:50 schrieb Heinz Junkes: Only the comment end ( */ ) is missing in bsps/include/libchip/disp_hcms29xx.h at line 14. Viele Grüße Heinz Junkes -- Experience directly varies with equipment ruined. On 10. Mar 2022, at 14:39, Heinz Junkes wrote: I get this at the moment when compiling the kernel: ... [ 48/4243] Compiling bsps/shared/freebsd/sys/arm/ti/am335x/am335x_scm_padconf.c [ 49/4243] Compiling bsps/shared/irq/irq-shell.c [ 50/4243] Compiling bsps/shared/irq/irq-info.c In file included from ../../../bsps/shared/dev/display/disp_hcms29xx.c:24: ../../../bsps/include/libchip/disp_hcms29xx.h:26:40: warning: "/*" within comment [-Wcomment] 26 | rtems_device_minor_number minor; /* minor device number */ devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel -- embedded brains GmbH Herr Christian MAUDERER Dornierstr. 4 82178 Puchheim Germany email: christian.maude...@embedded-brains.de phone: +49-89-18 94 741 - 18 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 11/40] bsps/include/libchip/disp_hcms29xx.h: Manual file header clean up
Only the comment end ( */ ) is missing in bsps/include/libchip/disp_hcms29xx.h at line 14. Viele Grüße Heinz Junkes -- Experience directly varies with equipment ruined. > On 10. Mar 2022, at 14:39, Heinz Junkes wrote: > > I get this at the moment when compiling the kernel: > > ... > [ 48/4243] Compiling > bsps/shared/freebsd/sys/arm/ti/am335x/am335x_scm_padconf.c > [ 49/4243] Compiling bsps/shared/irq/irq-shell.c > [ 50/4243] Compiling bsps/shared/irq/irq-info.c > In file included from ../../../bsps/shared/dev/display/disp_hcms29xx.c:24: > ../../../bsps/include/libchip/disp_hcms29xx.h:26:40: warning: "/*" within > comment [-Wcomment] > 26 | rtems_device_minor_number minor; /* minor device number > */ > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 11/40] bsps/include/libchip/disp_hcms29xx.h: Manual file header clean up
I get this at the moment when compiling the kernel:
...
[ 48/4243] Compiling bsps/shared/freebsd/sys/arm/ti/am335x/am335x_scm_padconf.c
[ 49/4243] Compiling bsps/shared/irq/irq-shell.c
[ 50/4243] Compiling bsps/shared/irq/irq-info.c
In file included from ../../../bsps/shared/dev/display/disp_hcms29xx.c:24:
../../../bsps/include/libchip/disp_hcms29xx.h:26:40: warning: "/*" within
comment [-Wcomment]
26 | rtems_device_minor_number minor; /* minor device number
*/
|
../../../bsps/include/libchip/disp_hcms29xx.h:30:22: error:
'DISP_HCMS29XX_TEXT_CNT' undeclared here (not in a function)
30 | char disp_buffer[DISP_HCMS29XX_TEXT_CNT];
| ^~
../../../bsps/include/libchip/disp_hcms29xx.h:45:3: error: expected identifier
or '(' before '}' token
45 | } spi_disp_hcms29xx_param_t;
| ^
../../../bsps/include/libchip/disp_hcms29xx.h:45:5: warning: data definition
has no type or storage class
45 | } spi_disp_hcms29xx_param_t;
| ^
../../../bsps/include/libchip/disp_hcms29xx.h:45:5: warning: type defaults to
'int' in declaration of 'spi_disp_hcms29xx_param_t' [-Wimplicit-int]
../../../bsps/include/libchip/disp_hcms29xx.h:49:5: error: expected
specifier-qualifier-list before 'spi_disp_hcms29xx_param_t'
49 | spi_disp_hcms29xx_param_t disp_param;
| ^
../../../bsps/include/libchip/disp_hcms29xx.h:150:2: error: #endif without #if
150 | #endif /* _DISP_HCMS29XX_H */
| ^
../../../bsps/shared/dev/display/disp_hcms29xx.c: In function
'disp_hcms29xx_send_to_display':
../../../bsps/shared/dev/display/disp_hcms29xx.c:332:43: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
332 | rc = rtems_libi2c_send_start(softc_ptr->disp_param.minor);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:338:39: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
338 | rc = -rtems_libi2c_ioctl(softc_ptr->disp_param.minor,
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:347:42: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
347 | rc = rtems_libi2c_send_addr(softc_ptr->disp_param.minor,true);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:355:16: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
355 | softc_ptr->disp_param.rotate
|^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:385:46: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
385 | ret_cnt = rtems_libi2c_write_bytes(softc_ptr->disp_param.minor,
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:397:42: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
397 | rc = rtems_libi2c_send_stop(softc_ptr->disp_param.minor);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c: In function
'disp_hcms29xx_send_to_control':
../../../bsps/shared/dev/display/disp_hcms29xx.c:453:40: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
453 | rc = rtems_libi2c_send_start(softc_ptr->disp_param.minor);
|^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:459:36: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
459 | rc = -rtems_libi2c_ioctl(softc_ptr->disp_param.minor,
|^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:468:39: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
468 | rc = rtems_libi2c_send_addr(softc_ptr->disp_param.minor,true);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:475:46: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
475 | ret_cnt = rtems_libi2c_write_bytes(softc_ptr->disp_param.minor,
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c:488:42: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
488 | rc = rtems_libi2c_send_stop(softc_ptr->disp_param.minor);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c: In function
'disp_hcms29xx_timer_sr':
../../../bsps/shared/dev/display/disp_hcms29xx.c:515:29: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
515 | rtems_event_send(softc_ptr->disp_param.task_id,
DISP_HCMS29XX_EVENT_TIMER);
| ^~
../../../bsps/shared/dev/display/disp_hcms29xx.c: In function
'disp_hcms29xx_update_task':
../../../bsps/shared/dev/display/disp_hcms29xx.c:584:39: error:
'disp_hcms29xx_drv_t' has no member named 'disp_param'
584 | rc = rtems_semaphore_obtain(softc_ptr->disp_param.trns_sema_id,
|
[PATCH 11/40] bsps/include/libchip/disp_hcms29xx.h: Manual file header clean up
From: Joel Sherrill Updates #4625. --- bsps/include/libchip/disp_hcms29xx.h | 32 +++- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/bsps/include/libchip/disp_hcms29xx.h b/bsps/include/libchip/disp_hcms29xx.h index 84b74b6910..bcaf25f46e 100644 --- a/bsps/include/libchip/disp_hcms29xx.h +++ b/bsps/include/libchip/disp_hcms29xx.h @@ -1,22 +1,16 @@ -/*===*\ -| Project: display driver for HCMS29xx| -+-+ -| File: disp_hcms29xx.h | -+-+ -|Copyright (c) 2008 | -|Embedded Brains GmbH | -|Obere Lagerstr. 30 | -|D-82178 Puchheim | -|Germany | -|rt...@embedded-brains.de | -+-+ -| The license and distribution terms for this file may be | -| found in the file LICENSE in this distribution or at| -| http://www.rtems.org/license/LICENSE. | -+-+ -| this file declares the SPI based driver for a HCMS29xx 4 digit | -| alphanumeric LED display| -\*===*/ +/* + * Display driver for HCMS29xx + * + * This file declares the SPI based driver for a HCMS29xx 4 digit + * alphanumeric LED display + */ + +/* + * Copyright (c) 2008 embedded brains GmbH. All rights reserved. + * + * The license and distribution terms for this file may be + * found in the file LICENSE in this distribution or at + * http://www.rtems.org/license/LICENSE. #ifndef _DISP_HCMS29XX_H #define _DISP_HCMS29XX_H -- 2.34.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
