Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-05 Thread Vijay Kumar Banerjee
On Tue, 5 Feb 2019 at 21:33, Hesham Almatary wrote: > On Fri, 1 Feb 2019 at 14:53, Vijay Kumar Banerjee > wrote: > > > > --- > > tester/covoar/TargetFactory.cc | 2 + > > tester/covoar/Target_riscv.cc| 82 > > tester/covoar/Target_riscv.h

Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-05 Thread Hesham Almatary
On Fri, 1 Feb 2019 at 14:53, Vijay Kumar Banerjee wrote: > > --- > tester/covoar/TargetFactory.cc | 2 + > tester/covoar/Target_riscv.cc| 82 > tester/covoar/Target_riscv.h | 98 > tester/covoar/wscript

Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-05 Thread Vijay Kumar Banerjee
Thanks for the reviews. I'll correct the formatting and post a v2. On Tue, 5 Feb 2019 at 05:45, Joel Sherrill wrote: > The C++ looks OK. Being a RISC architecture, I am assuming that there is > only one nop and it was easy to list all the branch variants. :) > That's all I could find in one

Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-04 Thread Joel Sherrill
The C++ looks OK. Being a RISC architecture, I am assuming that there is only one nop and it was easy to list all the branch variants. :) On Fri, Feb 1, 2019 at 8:53 AM Vijay Kumar Banerjee < vijaykumar9...@gmail.com> wrote: > --- > tester/covoar/TargetFactory.cc | 2 + >

Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-04 Thread Chris Johns
On 2/2/19 1:49 am, Vijay Kumar Banerjee wrote: > --- > tester/covoar/TargetFactory.cc | 2 + > tester/covoar/Target_riscv.cc| 82 > tester/covoar/Target_riscv.h | 98 > tester/covoar/wscript

Re: [PATCH] Coverage : Add coverage support for RISCV

2019-02-01 Thread Vijay Kumar Banerjee
On Fri, 1 Feb 2019 at 20:23, Vijay Kumar Banerjee wrote: > --- > tester/covoar/TargetFactory.cc | 2 + > tester/covoar/Target_riscv.cc| 82 > tester/covoar/Target_riscv.h | 98 > tester/covoar/wscript

[PATCH] Coverage : Add coverage support for RISCV

2019-02-01 Thread Vijay Kumar Banerjee
--- tester/covoar/TargetFactory.cc | 2 + tester/covoar/Target_riscv.cc| 82 tester/covoar/Target_riscv.h | 98 tester/covoar/wscript| 3 +- tester/rtems/testing/bsps/griscv-sis-cov.ini |