Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files
Hello Karel, with this change, it seems that I can't install an ARM BSP anymore. The core_cmFunc.h and similar files are missing now. I assume that some old headers have to be removed, and new headers added to the yml files. Is it necessary to install all the new headers or only some of them? Best regards Christian On 2023-07-13 23:05, Karel Gardas wrote: CAVEAT: license change from BSD to Apache2 license! Explanation: The imported files come from CMSIS v5 project available on: https://github.com/ARM-software/CMSIS_5/tree/develop The files imported are located inside the CMSIS/Core/Include project sub-directory. The project does not provide any NOTICE file in its root directory nor in the directory of the imported files. The NOTICE file and its usage in the Apache 2 license was/is so far the only issue mentioned in discussion of RTEMS developers/users when considering inclusion of the code under Apache 2 license into the RTEMS project. Since the CMSIS v5 project is free from this legal hinder, we may freely use it and update files to the latest version. Technical: the patch replaces code from 2015 with the latest version which brings quite a lot of bug fixes and most importantly opens possibilities to support MCUs based on new ARM cores. --- bsps/arm/include/cachel1_armv7.h | 441 +++ bsps/arm/include/cmsis_compiler.h | 303 ++ bsps/arm/include/cmsis_gcc.h | 3592 + bsps/arm/include/cmsis_version.h | 39 + bsps/arm/include/core_cm4.h | 629 ++-- bsps/arm/include/core_cm7.h | 4922 ++--- bsps/arm/include/core_cmFunc.h| 87 - bsps/arm/include/core_cmInstr.h | 88 - bsps/arm/include/core_cmSimd.h| 97 - bsps/arm/include/mpu_armv7.h | 275 ++ 10 files changed, 6113 insertions(+), 4360 deletions(-) create mode 100644 bsps/arm/include/cachel1_armv7.h create mode 100644 bsps/arm/include/cmsis_compiler.h create mode 100644 bsps/arm/include/cmsis_version.h delete mode 100644 bsps/arm/include/core_cmFunc.h delete mode 100644 bsps/arm/include/core_cmInstr.h delete mode 100644 bsps/arm/include/core_cmSimd.h create mode 100644 bsps/arm/include/mpu_armv7.h -- embedded brains GmbH & Co. KG Herr Christian MAUDERER Dornierstr. 4 82178 Puchheim Germany email: christian.maude...@embedded-brains.de phone: +49-89-18 94 741 - 18 mobile: +49-176-152 206 08 Registergericht: Amtsgericht München Registernummer: HRA 117265 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files
If someone doesn't pipe up with complaints or questions in the next few days, go ahead andcommit this. --joel On Fri, Jul 14, 2023 at 3:55 AM Karel Gardas wrote: > On 7/14/23 01:24, Joel Sherrill wrote: > > On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas > > wrote: > > > > > >Folks, > > > > please take this patch as an attempt to renew old discussion or > rather > > start a new one focused solely on importing new ARM CMSIS code which > is > > (i) under Apache 2 license but (ii) without any NOTICE file. > > > > > > The absence of a NOTICE file is OK. If they had one, we would just have > > to pass it along. > > > > I recall the issue is that "You must cause any modified files to carry > > prominent > > notices stating that You changed the files" > > > > OK, but this is even easier since I have not modified files at all. They > are just verbatim copy. > > > My reading is that we would need to pass the NOTICE file along. I > personally > > do not see that as a burden unless it contains more than credit or > > permissively > > license info. > > OK! I think decision process itself of "unless it contains more than..." > may be seen as a burden. But, fortunately no NOTICE file there, hence no > issue... > > > The patch itself is clear replace of existing files with a new files, > > plus required files added and old one not needed anymore removed. > > > > The patch was very lightly tested by building several ARM BSPs > > especially those affected by the change. > > > > > > Did you have any BSPs to actually test on? What ones can be tested > > for this? > > Yes, I can run testsuite on 2 boards I have sitting idle here: > stm32h747i-disco and stm32h7b3i-dk where 747 would test both M7 and M4 > variants. By comparing results from current tree and current tree + > patch we may see any unexpected breakage... > > > Thanks for any comments! > > > > > > I'm happy with the update and think it is OK license wise. Technically, > > it you > > trust it, I'm ok with it. > > Cool! Thanks, > > Karel > > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files
On 7/14/23 01:24, Joel Sherrill wrote: On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas wrote: Folks, please take this patch as an attempt to renew old discussion or rather start a new one focused solely on importing new ARM CMSIS code which is (i) under Apache 2 license but (ii) without any NOTICE file. The absence of a NOTICE file is OK. If they had one, we would just have to pass it along. I recall the issue is that "You must cause any modified files to carry prominent notices stating that You changed the files" OK, but this is even easier since I have not modified files at all. They are just verbatim copy. My reading is that we would need to pass the NOTICE file along. I personally do not see that as a burden unless it contains more than credit or permissively license info. OK! I think decision process itself of "unless it contains more than..." may be seen as a burden. But, fortunately no NOTICE file there, hence no issue... The patch itself is clear replace of existing files with a new files, plus required files added and old one not needed anymore removed. The patch was very lightly tested by building several ARM BSPs especially those affected by the change. Did you have any BSPs to actually test on? What ones can be tested for this? Yes, I can run testsuite on 2 boards I have sitting idle here: stm32h747i-disco and stm32h7b3i-dk where 747 would test both M7 and M4 variants. By comparing results from current tree and current tree + patch we may see any unexpected breakage... Thanks for any comments! I'm happy with the update and think it is OK license wise. Technically, it you trust it, I'm ok with it. Cool! Thanks, Karel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files
On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas wrote: > > Folks, > > please take this patch as an attempt to renew old discussion or rather > start a new one focused solely on importing new ARM CMSIS code which is > (i) under Apache 2 license but (ii) without any NOTICE file. > The absence of a NOTICE file is OK. If they had one, we would just have to pass it along. I recall the issue is that "You must cause any modified files to carry prominent notices stating that You changed the files" If all changes are inside ifdef __rtems__ blocks like we do elsewhere would this be sufficient? If we don't think that's "prominent", then adding a single like at the top of each file with the rtems conditional should be enough. Something like this: /* Contains modifications for RTEMS */ > > I hope technical advantages are huge and there is no hinder involved > like with other possible Apache2 licensed projects with NOTICE file > presented. > My reading is that we would need to pass the NOTICE file along. I personally do not see that as a burden unless it contains more than credit or permissively license info. > > The patch itself is clear replace of existing files with a new files, > plus required files added and old one not needed anymore removed. > > The patch was very lightly tested by building several ARM BSPs > especially those affected by the change. > Did you have any BSPs to actually test on? What ones can be tested for this? > > Thanks for any comments! > I'm happy with the update and think it is OK license wise. Technically, it you trust it, I'm ok with it. > > Karel > > On 7/13/23 23:05, Karel Gardas wrote: > > CAVEAT: license change from BSD to Apache2 license! > > > > Explanation: > > The imported files come from CMSIS v5 project available on: > > > > https://github.com/ARM-software/CMSIS_5/tree/develop > > > > The files imported are located inside the CMSIS/Core/Include > > project sub-directory. > > > > The project does not provide any NOTICE file in its root directory nor > > in the directory of the imported files. > > The NOTICE file and its usage in the Apache 2 license was/is > > so far the only issue mentioned in discussion of RTEMS developers/users > > when considering inclusion of the code under Apache 2 license > > into the RTEMS project. > > Since the CMSIS v5 project is free from this legal hinder, we may freely > > use it and update files to the latest version. > > > > Technical: the patch replaces code from 2015 with the latest version > > which brings quite a lot of bug fixes and most importantly opens > > possibilities to support MCUs based on new ARM cores. > > --- > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files
Folks, please take this patch as an attempt to renew old discussion or rather start a new one focused solely on importing new ARM CMSIS code which is (i) under Apache 2 license but (ii) without any NOTICE file. I hope technical advantages are huge and there is no hinder involved like with other possible Apache2 licensed projects with NOTICE file presented. The patch itself is clear replace of existing files with a new files, plus required files added and old one not needed anymore removed. The patch was very lightly tested by building several ARM BSPs especially those affected by the change. Thanks for any comments! Karel On 7/13/23 23:05, Karel Gardas wrote: CAVEAT: license change from BSD to Apache2 license! Explanation: The imported files come from CMSIS v5 project available on: https://github.com/ARM-software/CMSIS_5/tree/develop The files imported are located inside the CMSIS/Core/Include project sub-directory. The project does not provide any NOTICE file in its root directory nor in the directory of the imported files. The NOTICE file and its usage in the Apache 2 license was/is so far the only issue mentioned in discussion of RTEMS developers/users when considering inclusion of the code under Apache 2 license into the RTEMS project. Since the CMSIS v5 project is free from this legal hinder, we may freely use it and update files to the latest version. Technical: the patch replaces code from 2015 with the latest version which brings quite a lot of bug fixes and most importantly opens possibilities to support MCUs based on new ARM cores. --- ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
