Re: [PATCH] bsps/microblaze: Fix build option definition order
On 07.07.22 21:19, Alex White wrote: The build option definitions were rearranged such that the option definitions used in the linker script were not available. This caused linker errors when building. Sorry for breaking the BSP. The patch looks good. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/microblaze: Fix build option definition order
On Thu, Jul 7, 2022, 7:42 PM Chris Johns wrote: > On 8/7/2022 5:26 am, Joel Sherrill wrote: > > I'm ok with this but since you said Sebastian committed something which > broke > > this, it would be good for him to ack as well. > > > > Are there other BSPs which might have this issue? > > I am also wondering this. There is another patch Duc posted for ARM and > compiler > flags that I have not seen. > > Would your builder catch any issues? > Your builder? :) There was an RTEMS bsp builder run from a few days ago with odd failures. I don't remember if I poked Alex or not but the Microblaze was failing. https://lists.rtems.org/pipermail/build/2022-July/034727.html There are a few others but I don't think there are related to this. --joel > Chris > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/microblaze: Fix build option definition order
On 8/7/2022 5:26 am, Joel Sherrill wrote: > I'm ok with this but since you said Sebastian committed something which broke > this, it would be good for him to ack as well. > > Are there other BSPs which might have this issue? I am also wondering this. There is another patch Duc posted for ARM and compiler flags that I have not seen. Would your builder catch any issues? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH] bsps/microblaze: Fix build option definition order
I'm ok with this but since you said Sebastian committed something which broke this, it would be good for him to ack as well. Are there other BSPs which might have this issue? On Thu, Jul 7, 2022 at 2:20 PM Alex White wrote: > The build option definitions were rearranged such that the option > definitions used in the linker script were not available. This caused > linker errors when building. > --- > spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml | 2 -- > spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml | 2 -- > spec/build/bsps/microblaze/microblaze_fpga/grp.yml| 2 ++ > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml > b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml > index c31ca37e9b..9ec29f49f6 100644 > --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml > +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml > @@ -11,8 +11,6 @@ family: microblaze_fpga > includes: [] > install: [] > links: > -- role: build-dependency > - uid: linkcmds > - role: build-dependency >uid: tstkcu105_qemu > - role: build-dependency > diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml > b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml > index 39a5ca35d1..9a1147297a 100644 > --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml > +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml > @@ -11,8 +11,6 @@ family: microblaze_fpga > includes: [] > install: [] > links: > -- role: build-dependency > - uid: linkcmds > - role: build-dependency >uid: tstkcu105_qemu > - role: build-dependency > diff --git a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml > b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml > index 2473ab8fe8..5fa21e4fa3 100644 > --- a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml > +++ b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml > @@ -60,6 +60,8 @@ links: >uid: ../../objirq > - role: build-dependency >uid: ../../objmem > +- role: build-dependency > + uid: linkcmds > - role: build-dependency >uid: ../../bspopts > type: build > -- > 2.32.0 > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH] bsps/microblaze: Fix build option definition order
The build option definitions were rearranged such that the option definitions used in the linker script were not available. This caused linker errors when building. --- spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml | 2 -- spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml | 2 -- spec/build/bsps/microblaze/microblaze_fpga/grp.yml| 2 ++ 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml index c31ca37e9b..9ec29f49f6 100644 --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105.yml @@ -11,8 +11,6 @@ family: microblaze_fpga includes: [] install: [] links: -- role: build-dependency - uid: linkcmds - role: build-dependency uid: tstkcu105_qemu - role: build-dependency diff --git a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml index 39a5ca35d1..9a1147297a 100644 --- a/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml +++ b/spec/build/bsps/microblaze/microblaze_fpga/bspkcu105_qemu.yml @@ -11,8 +11,6 @@ family: microblaze_fpga includes: [] install: [] links: -- role: build-dependency - uid: linkcmds - role: build-dependency uid: tstkcu105_qemu - role: build-dependency diff --git a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml index 2473ab8fe8..5fa21e4fa3 100644 --- a/spec/build/bsps/microblaze/microblaze_fpga/grp.yml +++ b/spec/build/bsps/microblaze/microblaze_fpga/grp.yml @@ -60,6 +60,8 @@ links: uid: ../../objirq - role: build-dependency uid: ../../objmem +- role: build-dependency + uid: linkcmds - role: build-dependency uid: ../../bspopts type: build -- 2.32.0 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
