Re: [PATCH] cpukit/dev/can: Added CAN support

2022-08-08 Thread Christian MAUDERER
Hello Prashanth, Am 08.08.22 um 15:49 schrieb Prashanth S: Hi Christian, We have Chris Johns and Christian Mauderer on the list. In this case Chris has sent the mail. To avoid confusion, I never use a short form of my name on the list. But it's easy to mix up so don't worry about it.

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-08-08 Thread Prashanth S
Hi Christian, Oops, I apologize. I think I used gmail style quotes that might have added html. I will not use it. Regards Prashanth S On Mon, 8 Aug 2022 at 05:31, Chris Johns wrote: > Hi > > Could you please configure your email client to not send HTML emails to > the list? > > I am reluctant

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-08-07 Thread Chris Johns
Hi Could you please configure your email client to not send HTML emails to the list? I am reluctant to enable filtering in mailman and have managed to avoid it so far. Thanks Chris ___ devel mailing list devel@rtems.org

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-08-07 Thread Prashanth S
Hi Christian, general note: You add an API to cpukit. Most APIs there should have a > test case in the testsuite. In this case the test case would have to > create some dummy CAN driver and check whether everything works like > expected. As an example take a look at the SPI test: > >

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-08-02 Thread oss
Hello Duc, general note: You add an API to cpukit. Most APIs there should have a test case in the testsuite. In this case the test case would have to create some dummy CAN driver and check whether everything works like expected. As an example take a look at the SPI test:

[PATCH] cpukit/dev/can: Added CAN support (Prashanth S)

2022-07-31 Thread Prashanth S
Re: [PATCH v5 1/4] bsps/stm32f4 Include STM32F4 HAL > (o...@c-mauderer.de) >3. [PATCH] cpukit/dev/can: Added CAN support (Prashanth S) > > > -- > > Message: 1 > Date: Sat, 30 Jul 2022 21:41:19 +02

[PATCH] cpukit/dev/can: Added CAN support

2022-07-31 Thread Prashanth S
--- cpukit/dev/can/can.c | 514 + cpukit/include/dev/can/can-msg.h | 55 +++ cpukit/include/dev/can/can-queue.h | 127 +++ cpukit/include/dev/can/can.h | 102 ++ spec/build/cpukit/librtemscpu.yml | 6 + 5 files changed, 804

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-07-19 Thread Christian Mauderer
Hello Prashanth, Am 19.07.22 um 15:09 schrieb Prashanth S: Hi Christian, This is to reply to review comments. first question: You also worked on a driver for beagle DCAN. Did you already adapt that driver to this API? If yes, it would be usefull to post that as a patch too so that the

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-07-19 Thread Prashanth S
Hi Christian, This is to reply to review comments. > first question: You also worked on a driver for beagle DCAN. Did you > already adapt that driver to this API? If yes, it would be usefull to > post that as a patch too so that the direction and the method how it > will be used is more clear.

Re: [PATCH] cpukit/dev/can: Added CAN support

2022-07-19 Thread oss
Hello Prashanth, first question: You also worked on a driver for beagle DCAN. Did you already adapt that driver to this API? If yes, it would be usefull to post that as a patch too so that the direction and the method how it will be used is more clear. Note that some of my comments might

[PATCH] cpukit/dev/can: Added CAN support

2022-07-15 Thread Prashanth S
--- cpukit/dev/can/can-queue.c| 112 +++ cpukit/dev/can/can.c | 480 ++ cpukit/include/dev/can/can.h | 115 +++ spec/build/cpukit/librtemscpu.yml | 5 + 4 files changed, 712 insertions(+) create mode 100644