Re: [PATCH] improved error checking in ticks per timeslice

[Sebastian Huber]

On 18.03.24 21:31, Kinsey Moore wrote:
Sorry, I didn't realize I had tests turned off in my local build when I 
checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well.


This is fine for fixing the build, but I would rather fix the tests. 
Applications may have there own clock driver for example.


--
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Joel Sherrill]

No. Just a lesson to remember -- Everyone along the path should have built
rtems with all tests enabled.

This is something that should never happen after the upcoming transition to
GitLab. It definitely shows we need to build at least one BSP with tests
enabled.


On Mon, Mar 18, 2024, 7:45 PM zack leung  wrote:

>  Do I need to do anything?
>
>
> On Mon, 18 Mar 2024 at 16:38, Kinsey Moore 
> wrote:
>
>> Sorry, I didn't realize I had tests turned off in my local build when I
>> checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well.
>>
>> Kinsey
>>
>> On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber <
>> sebastian.hu...@embedded-brains.de> wrote:
>>
>>> This patch breaks the build:
>>>
>>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>>   from
>>> ../../../testsuites/rhealstone/rhdeadlockbrk/deadlockbrk.c:215:
>>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>>|^
>>>
>>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>>   from
>>> ../../../testsuites/rhealstone/rhmlatency/mlatency.c:158:
>>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>>|^
>>>
>>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>>   from
>>> ../../../testsuites/rhealstone/rhtaskswitch/taskswitch.c:122:
>>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>>|^
>>>
>>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>>   from
>>> ../../../testsuites/rhealstone/rhilatency/ilatency.c:29:
>>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>>|^
>>>
>>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>>   from
>>> ../../../testsuites/rhealstone/rhtaskpreempt/taskpreempt.c:120:
>>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>>|^
>>>
>>> --
>>> embedded brains GmbH & Co. KG
>>> Herr Sebastian HUBER
>>> Dornierstr. 4
>>> 82178 Puchheim
>>> Germany
>>> email: sebastian.hu...@embedded-brains.de
>>> phone: +49-89-18 94 741 - 16
>>> fax:   +49-89-18 94 741 - 08
>>>
>>> Registergericht: Amtsgericht München
>>> Registernummer: HRB 157899
>>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>>> Unsere Datenschutzerklärung finden Sie hier:
>>> https://embedded-brains.de/datenschutzerklaerung/
>>> ___
>>> devel mailing list
>>> devel@rtems.org
>>> http://lists.rtems.org/mailman/listinfo/devel
>>
>> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

 Do I need to do anything?


On Mon, 18 Mar 2024 at 16:38, Kinsey Moore  wrote:

> Sorry, I didn't realize I had tests turned off in my local build when I
> checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well.
>
> Kinsey
>
> On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
>
>> This patch breaks the build:
>>
>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>   from
>> ../../../testsuites/rhealstone/rhdeadlockbrk/deadlockbrk.c:215:
>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>> zero"
>>|^
>>
>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>   from
>> ../../../testsuites/rhealstone/rhmlatency/mlatency.c:158:
>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>> zero"
>>|^
>>
>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>   from
>> ../../../testsuites/rhealstone/rhtaskswitch/taskswitch.c:122:
>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>> zero"
>>|^
>>
>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>   from
>> ../../../testsuites/rhealstone/rhilatency/ilatency.c:29:
>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>> zero"
>>|^
>>
>> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>>   from
>> ../../../testsuites/rhealstone/rhtaskpreempt/taskpreempt.c:120:
>> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
>> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>> zero"
>>|^
>>
>> --
>> embedded brains GmbH & Co. KG
>> Herr Sebastian HUBER
>> Dornierstr. 4
>> 82178 Puchheim
>> Germany
>> email: sebastian.hu...@embedded-brains.de
>> phone: +49-89-18 94 741 - 16
>> fax:   +49-89-18 94 741 - 08
>>
>> Registergericht: Amtsgericht München
>> Registernummer: HRB 157899
>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>> Unsere Datenschutzerklärung finden Sie hier:
>> https://embedded-brains.de/datenschutzerklaerung/
>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Kinsey Moore]

Sorry, I didn't realize I had tests turned off in my local build when I
checked this. The test is now gated behind NEEDS_CLOCK_DRIVER as well.

Kinsey

On Mon, Mar 18, 2024 at 4:15 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

> This patch breaks the build:
>
> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>   from
> ../../../testsuites/rhealstone/rhdeadlockbrk/deadlockbrk.c:215:
> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
> zero"
>|^
>
> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>   from
> ../../../testsuites/rhealstone/rhmlatency/mlatency.c:158:
> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
> zero"
>|^
>
> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>   from
> ../../../testsuites/rhealstone/rhtaskswitch/taskswitch.c:122:
> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
> zero"
>|^
>
> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>   from
> ../../../testsuites/rhealstone/rhilatency/ilatency.c:29:
> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
> zero"
>|^
>
> In file included from ../../../cpukit/include/rtems/confdefs.h:64,
>   from
> ../../../testsuites/rhealstone/rhtaskpreempt/taskpreempt.c:120:
> ../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error
> "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> 74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
> zero"
>|^
>
> --
> embedded brains GmbH & Co. KG
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.hu...@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Sebastian Huber]

This patch breaks the build:

In file included from ../../../cpukit/include/rtems/confdefs.h:64,
 from 
../../../testsuites/rhealstone/rhdeadlockbrk/deadlockbrk.c:215:
../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error 
"CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"

   74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
  |^

In file included from ../../../cpukit/include/rtems/confdefs.h:64,
 from 
../../../testsuites/rhealstone/rhmlatency/mlatency.c:158:
../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error 
"CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"

   74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
  |^

In file included from ../../../cpukit/include/rtems/confdefs.h:64,
 from 
../../../testsuites/rhealstone/rhtaskswitch/taskswitch.c:122:
../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error 
"CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"

   74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
  |^

In file included from ../../../cpukit/include/rtems/confdefs.h:64,
 from 
../../../testsuites/rhealstone/rhilatency/ilatency.c:29:
../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error 
"CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"

   74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
  |^

In file included from ../../../cpukit/include/rtems/confdefs.h:64,
 from 
../../../testsuites/rhealstone/rhtaskpreempt/taskpreempt.c:120:
../../../cpukit/include/rtems/confdefs/clock.h:74:4: error: #error 
"CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"

   74 |   #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
  |^

--
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Kinsey Moore]

It should be in the repo now.

On Thu, Mar 14, 2024 at 12:50 PM zack leung 
wrote:

> Did you check in the code?
>
> Il mar 12 mar 2024, 21:55 Kinsey Moore  ha
> scritto:
>
>> Sorry, I missed this in the deluge of emails. Looks good to me.
>>
>> Kinsey
>>
>> On Tue, Mar 12, 2024 at 8:17 PM zack leung 
>> wrote:
>>
>>> ping
>>>
>>> On Fri, 8 Mar 2024 at 22:03,  wrote:
>>>
 From: Zack leung 

 ---
  cpukit/doxygen/appl-config.h  | 3 +--
  cpukit/include/rtems/confdefs/clock.h | 4 
  2 files changed, 5 insertions(+), 2 deletions(-)

 diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
 index bd7cde628f..f843ebbd39 100644
 --- a/cpukit/doxygen/appl-config.h
 +++ b/cpukit/doxygen/appl-config.h
 @@ -3312,8 +3312,7 @@
   * @parblock
   * The following constraints apply to this configuration option:
   *
 - * * The value of the configuration option shall be greater than or
 equal to
 - *   zero.
 + * * The value of the configuration option shall be greater than
 zero.
   *
   * * The value of the configuration option shall be less than or equal
 to >>>   *   href="https://en.cppreference.com/w/c/types/integer
 ">UINT32_MAX.
 diff --git a/cpukit/include/rtems/confdefs/clock.h
 b/cpukit/include/rtems/confdefs/clock.h
 index 26519cc70b..bb6c7e0b68 100644
 --- a/cpukit/include/rtems/confdefs/clock.h
 +++ b/cpukit/include/rtems/confdefs/clock.h
 @@ -70,6 +70,10 @@
#warning "The clock ticks per second is not an integer"
  #endif

 +#if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
 CONFIGURE_TICKS_PER_TIMESLICE <= 0
 +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
 +#endif
 +
  #if CONFIGURE_MICROSECONDS_PER_TICK <= 0
#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
  #endif
 --
 2.43.0

 ___
>>> devel mailing list
>>> devel@rtems.org
>>> http://lists.rtems.org/mailman/listinfo/devel
>>
>> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

Did you check in the code?

Il mar 12 mar 2024, 21:55 Kinsey Moore  ha
scritto:

> Sorry, I missed this in the deluge of emails. Looks good to me.
>
> Kinsey
>
> On Tue, Mar 12, 2024 at 8:17 PM zack leung 
> wrote:
>
>> ping
>>
>> On Fri, 8 Mar 2024 at 22:03,  wrote:
>>
>>> From: Zack leung 
>>>
>>> ---
>>>  cpukit/doxygen/appl-config.h  | 3 +--
>>>  cpukit/include/rtems/confdefs/clock.h | 4 
>>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
>>> index bd7cde628f..f843ebbd39 100644
>>> --- a/cpukit/doxygen/appl-config.h
>>> +++ b/cpukit/doxygen/appl-config.h
>>> @@ -3312,8 +3312,7 @@
>>>   * @parblock
>>>   * The following constraints apply to this configuration option:
>>>   *
>>> - * * The value of the configuration option shall be greater than or
>>> equal to
>>> - *   zero.
>>> + * * The value of the configuration option shall be greater than zero.
>>>   *
>>>   * * The value of the configuration option shall be less than or equal
>>> to >>   *   href="https://en.cppreference.com/w/c/types/integer
>>> ">UINT32_MAX.
>>> diff --git a/cpukit/include/rtems/confdefs/clock.h
>>> b/cpukit/include/rtems/confdefs/clock.h
>>> index 26519cc70b..bb6c7e0b68 100644
>>> --- a/cpukit/include/rtems/confdefs/clock.h
>>> +++ b/cpukit/include/rtems/confdefs/clock.h
>>> @@ -70,6 +70,10 @@
>>>#warning "The clock ticks per second is not an integer"
>>>  #endif
>>>
>>> +#if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
>>> CONFIGURE_TICKS_PER_TIMESLICE <= 0
>>> +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> +#endif
>>> +
>>>  #if CONFIGURE_MICROSECONDS_PER_TICK <= 0
>>>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>>>  #endif
>>> --
>>> 2.43.0
>>>
>>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Kinsey Moore]

Sorry, I missed this in the deluge of emails. Looks good to me.

Kinsey

On Tue, Mar 12, 2024 at 8:17 PM zack leung  wrote:

> ping
>
> On Fri, 8 Mar 2024 at 22:03,  wrote:
>
>> From: Zack leung 
>>
>> ---
>>  cpukit/doxygen/appl-config.h  | 3 +--
>>  cpukit/include/rtems/confdefs/clock.h | 4 
>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
>> index bd7cde628f..f843ebbd39 100644
>> --- a/cpukit/doxygen/appl-config.h
>> +++ b/cpukit/doxygen/appl-config.h
>> @@ -3312,8 +3312,7 @@
>>   * @parblock
>>   * The following constraints apply to this configuration option:
>>   *
>> - * * The value of the configuration option shall be greater than or
>> equal to
>> - *   zero.
>> + * * The value of the configuration option shall be greater than zero.
>>   *
>>   * * The value of the configuration option shall be less than or equal
>> to >   *   href="https://en.cppreference.com/w/c/types/integer
>> ">UINT32_MAX.
>> diff --git a/cpukit/include/rtems/confdefs/clock.h
>> b/cpukit/include/rtems/confdefs/clock.h
>> index 26519cc70b..bb6c7e0b68 100644
>> --- a/cpukit/include/rtems/confdefs/clock.h
>> +++ b/cpukit/include/rtems/confdefs/clock.h
>> @@ -70,6 +70,10 @@
>>#warning "The clock ticks per second is not an integer"
>>  #endif
>>
>> +#if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
>> CONFIGURE_TICKS_PER_TIMESLICE <= 0
>> +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> +#endif
>> +
>>  #if CONFIGURE_MICROSECONDS_PER_TICK <= 0
>>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>>  #endif
>> --
>> 2.43.0
>>
>> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

ping

On Fri, 8 Mar 2024 at 22:03,  wrote:

> From: Zack leung 
>
> ---
>  cpukit/doxygen/appl-config.h  | 3 +--
>  cpukit/include/rtems/confdefs/clock.h | 4 
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
> index bd7cde628f..f843ebbd39 100644
> --- a/cpukit/doxygen/appl-config.h
> +++ b/cpukit/doxygen/appl-config.h
> @@ -3312,8 +3312,7 @@
>   * @parblock
>   * The following constraints apply to this configuration option:
>   *
> - * * The value of the configuration option shall be greater than or equal
> to
> - *   zero.
> + * * The value of the configuration option shall be greater than zero.
>   *
>   * * The value of the configuration option shall be less than or equal to
>*   href="https://en.cppreference.com/w/c/types/integer;>UINT32_MAX.
> diff --git a/cpukit/include/rtems/confdefs/clock.h
> b/cpukit/include/rtems/confdefs/clock.h
> index 26519cc70b..bb6c7e0b68 100644
> --- a/cpukit/include/rtems/confdefs/clock.h
> +++ b/cpukit/include/rtems/confdefs/clock.h
> @@ -70,6 +70,10 @@
>#warning "The clock ticks per second is not an integer"
>  #endif
>
> +#if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
> CONFIGURE_TICKS_PER_TIMESLICE <= 0
> +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> +#endif
> +
>  #if CONFIGURE_MICROSECONDS_PER_TICK <= 0
>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>  #endif
> --
> 2.43.0
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

From: Zack leung 

---
 cpukit/doxygen/appl-config.h  | 3 +--
 cpukit/include/rtems/confdefs/clock.h | 4 
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..f843ebbd39 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,8 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
- *   zero.
+ * * The value of the configuration option shall be greater than zero.  
  *
  * * The value of the configuration option shall be less than or equal to https://en.cppreference.com/w/c/types/integer;>UINT32_MAX.
diff --git a/cpukit/include/rtems/confdefs/clock.h 
b/cpukit/include/rtems/confdefs/clock.h
index 26519cc70b..bb6c7e0b68 100644
--- a/cpukit/include/rtems/confdefs/clock.h
+++ b/cpukit/include/rtems/confdefs/clock.h
@@ -70,6 +70,10 @@
   #warning "The clock ticks per second is not an integer"
 #endif
 
+#if defined(CONFIGURE_TICKS_PER_TIMESLICE) && CONFIGURE_TICKS_PER_TIMESLICE <= 0
+  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
+#endif
+
 #if CONFIGURE_MICROSECONDS_PER_TICK <= 0
   #error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
 #endif
-- 
2.43.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Will]

Hey Zack,
Sebastian posted exactly what he thought those lines should be to match the
surrounding coding style:
#if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
   CONFIGURE_TICKS_PER_TIMESLICE <= 0

It should just be a single #if like that and with that order of
conditionals. You'll of course need to remove the second #endif since
you're going to 1 #if.

Kinsey

On Tue, Mar 5, 2024 at 8:44 PM  wrote:

> From: Zack leung 
>
> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
> index bd7cde628f..d480eb3971 100644
> --- a/cpukit/doxygen/appl-config.h
> +++ b/cpukit/doxygen/appl-config.h
> @@ -3312,7 +3312,7 @@
>   * @parblock
>   * The following constraints apply to this configuration option:
>   *
> - * * The value of the configuration option shall be greater than or equal
> to
> + * * The value of the configuration option shall be greater than
>   *   zero.
>   *
>   * * The value of the configuration option shall be less than or equal to
>  diff --git a/cpukit/include/rtems/confdefs/clock.h
> b/cpukit/include/rtems/confdefs/clock.h
> index 26519cc70b..bcca02bd43 100644
> --- a/cpukit/include/rtems/confdefs/clock.h
> +++ b/cpukit/include/rtems/confdefs/clock.h
> @@ -74,6 +74,12 @@
>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>  #endif
>
> +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0
> +  #if defined(CONFIGURE_TICKS_PER_TIMESLICE)
> +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> +  #endif
> +#endif
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> --
> 2.43.0
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

Hey i've replied with another patch :)

On Tue, 5 Mar 2024 at 10:42, Kinsey Moore  wrote:

> Zack,
> It looks like there's been a little confusion here. Sebastian was
> requesting that you condense the pair of #ifs into a single #if with && and
> the defined check still coming first. It is mostly trivial in this
> instance, but virtually every other example in the related files is of a
> multi-conditional #if versus nested #ifs where possible. Technically, I
> think what you have is fine as the RTEMS coding conventions don't directly
> express a preference on split #ifs versus compound #ifs but it doesn't
> match the style of the surrounding code.
>
> Kinsey
>
> On Mon, Mar 4, 2024 at 7:39 PM zack leung 
> wrote:
>
>> ping
>>
>>
>> On Tue, 27 Feb 2024 at 21:33, zack leung 
>> wrote:
>>
>>>
>>> joel said:
>>>+#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
>>> > defined(CONFIGURE_TICKS_PER_TIMESLICE)
>>> > +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than
>>> zero"
>>> > +#endif
>>> > +
>>> >
>>> >
>>> > This is modifying the right file but I think it is safer to check that
>>> > it is defined
>>> > before checking its value.
>>>
>>> Yes, the defined() check should be first. - sebestian
>>>
>>> You said this in relation to joel's comment in my previous thread. You
>>> can check in either one.  The  previous one used the "and" statement.
>>>
>>> Zack
>>>
>>> On Tue, 27 Feb 2024 at 02:08, Sebastian Huber <
>>> sebastian.hu...@embedded-brains.de> wrote:
>>>
 On 19.02.24 03:13, zakthertems...@gmail.com wrote:
 > +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
 > +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
 > +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
 > +  #endif
 > +#endif

 This should be

 #if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
 CONFIGURE_TICKS_PER_TIMESLICE <= 0

 from my point of view. Just check the style of the related header files
 for a reference.

 --
 embedded brains GmbH & Co. KG
 Herr Sebastian HUBER
 Dornierstr. 4
 82178 Puchheim
 Germany
 email: sebastian.hu...@embedded-brains.de
 phone: +49-89-18 94 741 - 16
 fax:   +49-89-18 94 741 - 08

 Registergericht: Amtsgericht München
 Registernummer: HRB 157899
 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
 Unsere Datenschutzerklärung finden Sie hier:
 https://embedded-brains.de/datenschutzerklaerung/

>>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

From: Zack leung 

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
+ * * The value of the configuration option shall be greater than 
  *   zero.
  *
  * * The value of the configuration option shall be less than or equal to http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Kinsey Moore]

Zack,
It looks like there's been a little confusion here. Sebastian was
requesting that you condense the pair of #ifs into a single #if with && and
the defined check still coming first. It is mostly trivial in this
instance, but virtually every other example in the related files is of a
multi-conditional #if versus nested #ifs where possible. Technically, I
think what you have is fine as the RTEMS coding conventions don't directly
express a preference on split #ifs versus compound #ifs but it doesn't
match the style of the surrounding code.

Kinsey

On Mon, Mar 4, 2024 at 7:39 PM zack leung  wrote:

> ping
>
>
> On Tue, 27 Feb 2024 at 21:33, zack leung  wrote:
>
>>
>> joel said:
>>+#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
>> > defined(CONFIGURE_TICKS_PER_TIMESLICE)
>> > +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> > +#endif
>> > +
>> >
>> >
>> > This is modifying the right file but I think it is safer to check that
>> > it is defined
>> > before checking its value.
>>
>> Yes, the defined() check should be first. - sebestian
>>
>> You said this in relation to joel's comment in my previous thread. You
>> can check in either one.  The  previous one used the "and" statement.
>>
>> Zack
>>
>> On Tue, 27 Feb 2024 at 02:08, Sebastian Huber <
>> sebastian.hu...@embedded-brains.de> wrote:
>>
>>> On 19.02.24 03:13, zakthertems...@gmail.com wrote:
>>> > +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
>>> > +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
>>> > +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>>> > +  #endif
>>> > +#endif
>>>
>>> This should be
>>>
>>> #if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
>>> CONFIGURE_TICKS_PER_TIMESLICE <= 0
>>>
>>> from my point of view. Just check the style of the related header files
>>> for a reference.
>>>
>>> --
>>> embedded brains GmbH & Co. KG
>>> Herr Sebastian HUBER
>>> Dornierstr. 4
>>> 82178 Puchheim
>>> Germany
>>> email: sebastian.hu...@embedded-brains.de
>>> phone: +49-89-18 94 741 - 16
>>> fax:   +49-89-18 94 741 - 08
>>>
>>> Registergericht: Amtsgericht München
>>> Registernummer: HRB 157899
>>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>>> Unsere Datenschutzerklärung finden Sie hier:
>>> https://embedded-brains.de/datenschutzerklaerung/
>>>
>> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

ping


On Tue, 27 Feb 2024 at 21:33, zack leung  wrote:

>
> joel said:
>+#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
> > defined(CONFIGURE_TICKS_PER_TIMESLICE)
> > +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> > +#endif
> > +
> >
> >
> > This is modifying the right file but I think it is safer to check that
> > it is defined
> > before checking its value.
>
> Yes, the defined() check should be first. - sebestian
>
> You said this in relation to joel's comment in my previous thread. You can
> check in either one.  The  previous one used the "and" statement.
>
> Zack
>
> On Tue, 27 Feb 2024 at 02:08, Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
>
>> On 19.02.24 03:13, zakthertems...@gmail.com wrote:
>> > +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
>> > +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
>> > +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> > +  #endif
>> > +#endif
>>
>> This should be
>>
>> #if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
>> CONFIGURE_TICKS_PER_TIMESLICE <= 0
>>
>> from my point of view. Just check the style of the related header files
>> for a reference.
>>
>> --
>> embedded brains GmbH & Co. KG
>> Herr Sebastian HUBER
>> Dornierstr. 4
>> 82178 Puchheim
>> Germany
>> email: sebastian.hu...@embedded-brains.de
>> phone: +49-89-18 94 741 - 16
>> fax:   +49-89-18 94 741 - 08
>>
>> Registergericht: Amtsgericht München
>> Registernummer: HRB 157899
>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>> Unsere Datenschutzerklärung finden Sie hier:
>> https://embedded-brains.de/datenschutzerklaerung/
>>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

joel said:
   +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
> defined(CONFIGURE_TICKS_PER_TIMESLICE)
> +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> +#endif
> +
>
>
> This is modifying the right file but I think it is safer to check that
> it is defined
> before checking its value.

Yes, the defined() check should be first. - sebestian

You said this in relation to joel's comment in my previous thread. You can
check in either one.  The  previous one used the "and" statement.

Zack

On Tue, 27 Feb 2024 at 02:08, Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

> On 19.02.24 03:13, zakthertems...@gmail.com wrote:
> > +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
> > +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
> > +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> > +  #endif
> > +#endif
>
> This should be
>
> #if defined(CONFIGURE_TICKS_PER_TIMESLICE) &&
> CONFIGURE_TICKS_PER_TIMESLICE <= 0
>
> from my point of view. Just check the style of the related header files
> for a reference.
>
> --
> embedded brains GmbH & Co. KG
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.hu...@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Sebastian Huber]

On 19.02.24 03:13, zakthertems...@gmail.com wrote:

+#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
+  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
+#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
+  #endif
+#endif


This should be

#if defined(CONFIGURE_TICKS_PER_TIMESLICE) && 
CONFIGURE_TICKS_PER_TIMESLICE <= 0


from my point of view. Just check the style of the related header files 
for a reference.


--
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

ping


On Tue, 20 Feb 2024 at 20:25, zack leung  wrote:

> ping
>
> On Sun, 18 Feb 2024 at 21:15,  wrote:
>
>> ---
>>  cpukit/doxygen/appl-config.h  | 2 +-
>>  cpukit/include/rtems/confdefs/clock.h | 6 ++
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
>> index bd7cde628f..d480eb3971 100644
>> --- a/cpukit/doxygen/appl-config.h
>> +++ b/cpukit/doxygen/appl-config.h
>> @@ -3312,7 +3312,7 @@
>>   * @parblock
>>   * The following constraints apply to this configuration option:
>>   *
>> - * * The value of the configuration option shall be greater than or
>> equal to
>> + * * The value of the configuration option shall be greater than
>>   *   zero.
>>   *
>>   * * The value of the configuration option shall be less than or equal
>> to > diff --git a/cpukit/include/rtems/confdefs/clock.h
>> b/cpukit/include/rtems/confdefs/clock.h
>> index 26519cc70b..f4c4575057 100644
>> --- a/cpukit/include/rtems/confdefs/clock.h
>> +++ b/cpukit/include/rtems/confdefs/clock.h
>> @@ -74,6 +74,12 @@
>>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>>  #endif
>>
>> +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
>> +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
>> +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> +  #endif
>> +#endif
>> +
>>  #ifdef __cplusplus
>>  extern "C" {
>>  #endif
>> --
>> 2.43.0
>>
>>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

ping

On Sun, 18 Feb 2024 at 21:15,  wrote:

> ---
>  cpukit/doxygen/appl-config.h  | 2 +-
>  cpukit/include/rtems/confdefs/clock.h | 6 ++
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
> index bd7cde628f..d480eb3971 100644
> --- a/cpukit/doxygen/appl-config.h
> +++ b/cpukit/doxygen/appl-config.h
> @@ -3312,7 +3312,7 @@
>   * @parblock
>   * The following constraints apply to this configuration option:
>   *
> - * * The value of the configuration option shall be greater than or equal
> to
> + * * The value of the configuration option shall be greater than
>   *   zero.
>   *
>   * * The value of the configuration option shall be less than or equal to
>  diff --git a/cpukit/include/rtems/confdefs/clock.h
> b/cpukit/include/rtems/confdefs/clock.h
> index 26519cc70b..f4c4575057 100644
> --- a/cpukit/include/rtems/confdefs/clock.h
> +++ b/cpukit/include/rtems/confdefs/clock.h
> @@ -74,6 +74,12 @@
>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>  #endif
>
> +#if defined(CONFIGURE_TICKS_PER_TIMESLICE)
> +  #if CONFIGURE_TICKS_PER_TIMESLICE <= 0
> +#error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> +  #endif
> +#endif
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> --
> 2.43.0
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Gedare Bloom]

On Sun, Feb 18, 2024 at 3:31 PM Chris Johns  wrote:
>
> On 18/2/2024 4:42 am, Gedare Bloom wrote:
> > Is there a simple way we can add some checks for modification of
> > generated files into a commit hook? And then, point to a documentation
> > that helps explain where to go for more guidance depending on the code
> > generation source?
>
> We are moving to GitLab so I think avoiding git hooks is something we should
> avoid at this point in time. And there are security issues with them. Could a
> stage in a CI pipeline handle this? The PR would fail.
>
OK

> > I would use this for all rtems-central generated stuff, and also for
> > 3rd party sources where there's an active upstream. I can add such a
> > plan to follow #4663 Third-Party Sources Manifest
>
> You would need to find a way to add these files to the repo. Separating the
> mapping from the repo would create an external dependency I would prefer we do
> not have.
>

I'm not sure I followed your point here. I simply meant that any
existing files in rtems.git that are generated (or imported) from
elsewhere should be tracked and should not be accidentally modified by
directly writing them.

> Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

---
 cpukit/doxygen/appl-config.h  | 2 +-
 cpukit/include/rtems/confdefs/clock.h | 6 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
+ * * The value of the configuration option shall be greater than 
  *   zero.
  *
  * * The value of the configuration option shall be less than or equal to http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Chris Johns]

On 18/2/2024 4:42 am, Gedare Bloom wrote:
> Is there a simple way we can add some checks for modification of
> generated files into a commit hook? And then, point to a documentation
> that helps explain where to go for more guidance depending on the code
> generation source?

We are moving to GitLab so I think avoiding git hooks is something we should
avoid at this point in time. And there are security issues with them. Could a
stage in a CI pipeline handle this? The PR would fail.

> I would use this for all rtems-central generated stuff, and also for
> 3rd party sources where there's an active upstream. I can add such a
> plan to follow #4663 Third-Party Sources Manifest

You would need to find a way to add these files to the repo. Separating the
mapping from the repo would create an external dependency I would prefer we do
not have.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

From: Zack leung 

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
+ * * The value of the configuration option shall be greater than 
  *   zero.
  *
  * * The value of the configuration option shall be less than or equal to http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Gedare Bloom]

On Sat, Feb 17, 2024 at 10:35 AM Sebastian Huber
 wrote:
>
> On 17.02.24 18:11, Joel Sherrill wrote:
> >
> > On Wed, Feb 14, 2024, 9:54 PM zack leung  > > wrote:
> >
> > > This file is generated from something in rtems-central. This was at 
> > the
> > > top of the file:
> > >
> > >   * This file is part of the RTEMS quality process and was 
> > automatically
> > >   * generated.  If you find something that needs to be fixed or
> > >   * worded better please post a report or patch to an RTEMS mailing 
> > list
> >
> > No, problem. I can fix this before I check in the patch.
> >
> > re: this do you need me to change it to something?
> >
> >
> > I'm hoping Sebastian has some guidance for you on what to edit for this
> > and how to propagate it dull.
>
> Just for this patch it would be a bit of on overkill. I will take care
> of this when I check in the patch.
>

Is there a simple way we can add some checks for modification of
generated files into a commit hook? And then, point to a documentation
that helps explain where to go for more guidance depending on the code
generation source?

I would use this for all rtems-central generated stuff, and also for
3rd party sources where there's an active upstream. I can add such a
plan to follow #4663 Third-Party Sources Manifest

Gedare
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Sebastian Huber]

On 17.02.24 18:11, Joel Sherrill wrote:


On Wed, Feb 14, 2024, 9:54 PM zack leung > wrote:


> This file is generated from something in rtems-central. This was at the 
> top of the file:
> 
>   * This file is part of the RTEMS quality process and was automatically

>   * generated.  If you find something that needs to be fixed or
>   * worded better please post a report or patch to an RTEMS mailing list

No, problem. I can fix this before I check in the patch.

re: this do you need me to change it to something?


I'm hoping Sebastian has some guidance for you on what to edit for this 
and how to propagate it dull.


Just for this patch it would be a bit of on overkill. I will take care 
of this when I check in the patch.


--
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Joel Sherrill]

On Wed, Feb 14, 2024, 9:54 PM zack leung  wrote:

> > This file is generated from something in rtems-central. This was at the
> > top of the file:
> >
> >   * This file is part of the RTEMS quality process and was automatically
> >   * generated.  If you find something that needs to be fixed or
> >   * worded better please post a report or patch to an RTEMS mailing list
>
> No, problem. I can fix this before I check in the patch.
>
> re: this do you need me to change it to something?
>

I'm hoping Sebastian has some guidance for you on what to edit for this and
how to propagate it dull.

>
>
> On Wed, 14 Feb 2024 at 09:28, Sebastian Huber <
> sebastian.hu...@embedded-brains.de> wrote:
>
>>
>>
>> On 14.02.24 15:18, Joel Sherrill wrote:
>> > I'm cc'ing Sebastian because you edited the text in a generated file.
>> He
>> > should be able to point us to the right place to fix it.
>> >
>> > On Mon, Feb 12, 2024 at 8:26 PM > > > wrote:
>> >
>> > From: Zack leung mailto:z.liang...@gmail.com
>> >>
>> >
>> > diff --git a/cpukit/doxygen/appl-config.h
>> b/cpukit/doxygen/appl-config.h
>> > index bd7cde628f..d480eb3971 100644
>> > --- a/cpukit/doxygen/appl-config.h
>> > +++ b/cpukit/doxygen/appl-config.h
>> > @@ -3312,7 +3312,7 @@
>> >* @parblock
>> >* The following constraints apply to this configuration option:
>> >*
>> > - * * The value of the configuration option shall be greater than or
>> > equal to
>> > + * * The value of the configuration option shall be greater than
>> >*   zero.
>> >
>> >
>> >
>> > This file is generated from something in rtems-central. This was at the
>> > top of the file:
>> >
>> >   * This file is part of the RTEMS quality process and was automatically
>> >   * generated.  If you find something that needs to be fixed or
>> >   * worded better please post a report or patch to an RTEMS mailing list
>>
>> No, problem. I can fix this before I check in the patch.
>>
>> >
>> >*
>> >* * The value of the configuration option shall be less than or
>> > equal to > > diff --git a/cpukit/include/rtems/confdefs/clock.h
>> > b/cpukit/include/rtems/confdefs/clock.h
>> > index 26519cc70b..d0d7c453bc 100644
>> > --- a/cpukit/include/rtems/confdefs/clock.h
>> > +++ b/cpukit/include/rtems/confdefs/clock.h
>> > @@ -74,6 +74,10 @@
>> > #error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>> >   #endif
>> >
>> > +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
>> > defined(CONFIGURE_TICKS_PER_TIMESLICE)
>> > +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
>> > +#endif
>> > +
>> >
>> >
>> > This is modifying the right file but I think it is safer to check that
>> > it is defined
>> > before checking its value.
>>
>> Yes, the defined() check should be first.
>>
>> --
>> embedded brains GmbH & Co. KG
>> Herr Sebastian HUBER
>> Dornierstr. 4
>> 82178 Puchheim
>> Germany
>> email: sebastian.hu...@embedded-brains.de
>> phone: +49-89-18 94 741 - 16
>> fax:   +49-89-18 94 741 - 08
>>
>> Registergericht: Amtsgericht München
>> Registernummer: HRB 157899
>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>> Unsere Datenschutzerklärung finden Sie hier:
>> https://embedded-brains.de/datenschutzerklaerung/
>>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[zack leung]

 > This file is generated from something in rtems-central. This was at the
> top of the file:
>
>   * This file is part of the RTEMS quality process and was automatically
>   * generated.  If you find something that needs to be fixed or
>   * worded better please post a report or patch to an RTEMS mailing list

No, problem. I can fix this before I check in the patch.

re: this do you need me to change it to something?

On Wed, 14 Feb 2024 at 09:28, Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

>
>
> On 14.02.24 15:18, Joel Sherrill wrote:
> > I'm cc'ing Sebastian because you edited the text in a generated file. He
> > should be able to point us to the right place to fix it.
> >
> > On Mon, Feb 12, 2024 at 8:26 PM  > > wrote:
> >
> > From: Zack leung mailto:z.liang...@gmail.com
> >>
> >
> > diff --git a/cpukit/doxygen/appl-config.h
> b/cpukit/doxygen/appl-config.h
> > index bd7cde628f..d480eb3971 100644
> > --- a/cpukit/doxygen/appl-config.h
> > +++ b/cpukit/doxygen/appl-config.h
> > @@ -3312,7 +3312,7 @@
> >* @parblock
> >* The following constraints apply to this configuration option:
> >*
> > - * * The value of the configuration option shall be greater than or
> > equal to
> > + * * The value of the configuration option shall be greater than
> >*   zero.
> >
> >
> >
> > This file is generated from something in rtems-central. This was at the
> > top of the file:
> >
> >   * This file is part of the RTEMS quality process and was automatically
> >   * generated.  If you find something that needs to be fixed or
> >   * worded better please post a report or patch to an RTEMS mailing list
>
> No, problem. I can fix this before I check in the patch.
>
> >
> >*
> >* * The value of the configuration option shall be less than or
> > equal to  > diff --git a/cpukit/include/rtems/confdefs/clock.h
> > b/cpukit/include/rtems/confdefs/clock.h
> > index 26519cc70b..d0d7c453bc 100644
> > --- a/cpukit/include/rtems/confdefs/clock.h
> > +++ b/cpukit/include/rtems/confdefs/clock.h
> > @@ -74,6 +74,10 @@
> > #error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
> >   #endif
> >
> > +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
> > defined(CONFIGURE_TICKS_PER_TIMESLICE)
> > +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> > +#endif
> > +
> >
> >
> > This is modifying the right file but I think it is safer to check that
> > it is defined
> > before checking its value.
>
> Yes, the defined() check should be first.
>
> --
> embedded brains GmbH & Co. KG
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.hu...@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Sebastian Huber]

On 14.02.24 15:18, Joel Sherrill wrote:
I'm cc'ing Sebastian because you edited the text in a generated file. He 
should be able to point us to the right place to fix it.


On Mon, Feb 12, 2024 at 8:26 PM > wrote:


From: Zack leung mailto:z.liang...@gmail.com>>

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
   * @parblock
   * The following constraints apply to this configuration option:
   *
- * * The value of the configuration option shall be greater than or
equal to
+ * * The value of the configuration option shall be greater than
   *   zero.



This file is generated from something in rtems-central. This was at the 
top of the file:


  * This file is part of the RTEMS quality process and was automatically
  * generated.  If you find something that needs to be fixed or
  * worded better please post a report or patch to an RTEMS mailing list


No, problem. I can fix this before I check in the patch.



   *
   * * The value of the configuration option shall be less than or
equal to This is modifying the right file but I think it is safer to check that 
it is defined

before checking its value.


Yes, the defined() check should be first.

--
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] improved error checking in ticks per timeslice

[Joel Sherrill]

I'm cc'ing Sebastian because you edited the text in a generated file. He
should be able to point us to the right place to fix it.

On Mon, Feb 12, 2024 at 8:26 PM  wrote:

> From: Zack leung 
>
> diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
> index bd7cde628f..d480eb3971 100644
> --- a/cpukit/doxygen/appl-config.h
> +++ b/cpukit/doxygen/appl-config.h
> @@ -3312,7 +3312,7 @@
>   * @parblock
>   * The following constraints apply to this configuration option:
>   *
> - * * The value of the configuration option shall be greater than or equal
> to
> + * * The value of the configuration option shall be greater than
>   *   zero.
>


This file is generated from something in rtems-central. This was at the top
of the file:

 * This file is part of the RTEMS quality process and was automatically
 * generated.  If you find something that needs to be fixed or
 * worded better please post a report or patch to an RTEMS mailing list



>   *
>   * * The value of the configuration option shall be less than or equal to
>  diff --git a/cpukit/include/rtems/confdefs/clock.h
> b/cpukit/include/rtems/confdefs/clock.h
> index 26519cc70b..d0d7c453bc 100644
> --- a/cpukit/include/rtems/confdefs/clock.h
> +++ b/cpukit/include/rtems/confdefs/clock.h
> @@ -74,6 +74,10 @@
>#error "CONFIGURE_MICROSECONDS_PER_TICK must be positive"
>  #endif
>
> +#if CONFIGURE_TICKS_PER_TIMESLICE <= 0 &&
> defined(CONFIGURE_TICKS_PER_TIMESLICE)
> +  #error "CONFIGURE_TICKS_PER_TIMESLICE shall be greater than zero"
> +#endif
> +
>

This is modifying the right file but I think it is safer to check that it
is defined
before checking its value.

--joel


>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> --
> 2.43.0
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

From: Zack leung 

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
+ * * The value of the configuration option shall be greater than 
  *   zero.
  *
  * * The value of the configuration option shall be less than or equal to http://lists.rtems.org/mailman/listinfo/devel

[PATCH] improved error checking in ticks per timeslice

[zakthertemsdev]

From: Zack leung 

diff --git a/cpukit/doxygen/appl-config.h b/cpukit/doxygen/appl-config.h
index bd7cde628f..d480eb3971 100644
--- a/cpukit/doxygen/appl-config.h
+++ b/cpukit/doxygen/appl-config.h
@@ -3312,7 +3312,7 @@
  * @parblock
  * The following constraints apply to this configuration option:
  *
- * * The value of the configuration option shall be greater than or equal to
+ * * The value of the configuration option shall be greater than 
  *   zero.
  *
  * * The value of the configuration option shall be less than or equal to http://lists.rtems.org/mailman/listinfo/devel