Re: [PATCH] libdebugger/arm: Fix build for atsam.

2019-10-18 Thread Chris Johns
On 17/10/19 4:51 pm, Christian Mauderer wrote: > after a hint from Chris I took a more detailed look at the patch. > There is at least one thing that I should change: The > > #if !ARM_THUMB_ONLY && defined(__thumb__) > > case is most likely not necessary. Thanks for this. After discussing

Re: [PATCH] libdebugger/arm: Fix build for atsam.

2019-10-17 Thread Chris Johns
> On 17 Oct 2019, at 7:51 am, Christian Mauderer > wrote: > > Hello, > > after a hint from Chris I took a more detailed look at the patch. > There is at least one thing that I should change: The > >#if !ARM_THUMB_ONLY && defined(__thumb__) > > case is most likely not necessary. Yes.

Re: [PATCH] libdebugger/arm: Fix build for atsam.

2019-10-16 Thread Christian Mauderer
Hello, after a hint from Chris I took a more detailed look at the patch. There is at least one thing that I should change: The #if !ARM_THUMB_ONLY && defined(__thumb__) case is most likely not necessary. Some explanation: In rtems-debugger-arm.c there are the following defines #if

[PATCH] libdebugger/arm: Fix build for atsam.

2019-10-15 Thread Christian Mauderer
--- cpukit/libdebugger/rtems-debugger-arm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/cpukit/libdebugger/rtems-debugger-arm.c b/cpukit/libdebugger/rtems-debugger-arm.c index 3d5dea0ab7..a6aaca31f2 100644 --- a/cpukit/libdebugger/rtems-debugger-arm.c +++