Re: [PATCH] shell: Remove not functioning fdisk mount/unmount command

2020-10-11 Thread Chris Johns
Frank, As Gedare has said great analysis. Thank you. I have no idea why I did not test the `fdisk mound/unmount` command, maybe I did not know it existed, but it has proved to be a good way for us to know the old interface is not used. The change is OK to push. On 10/10/20 3:03 am, Peter

Re: [PATCH] shell: Remove not functioning fdisk mount/unmount command

2020-10-09 Thread Peter Dufault
Yes, and you don't want to support two ways to do something if it hasn't been noticed in ten years. > On Oct 9, 2020, at 11:37 , Gedare Bloom wrote: > > Excellent analysis. I would like Chris to weigh in, but the rationale > to remove instead of try to fix makes sense because it is basically

Re: [PATCH] shell: Remove not functioning fdisk mount/unmount command

2020-10-09 Thread Gedare Bloom
Excellent analysis. I would like Chris to weigh in, but the rationale to remove instead of try to fix makes sense because it is basically an undocumented shell API. On Fri, Oct 9, 2020 at 7:38 AM Frank Kuehndel wrote: > > The shell has an 'fdisk' command which has sub-commands 'mount' and

[PATCH] shell: Remove not functioning fdisk mount/unmount command

2020-10-09 Thread Frank Kuehndel
The shell has an 'fdisk' command which has sub-commands 'mount' and 'unmount'. These two sub-commands have a bug which causes them to be not able to mount anything. This proposed patch removes the buggy file cpukit/libblock/src/bdpart-mount.c and the mount/unmount commands from 'fdisk' as bug fix.