Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-24 Thread Daniel Hellstrom
Ok, Thanks! DanielH On 24 November 2014 17:15:03 CET, Jiri Gaisler wrote: >On 11/24/2014 05:02 PM, Daniel Hellstrom wrote: >> Ok, what about ERC32 which has the same macros? > >ERC32 is correctly defined. The leon2/3 were wrong because the >defines were copied from ERC32, but the mask bits have

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-24 Thread Jiri Gaisler
On 11/24/2014 05:02 PM, Daniel Hellstrom wrote: > Ok, what about ERC32 which has the same macros? ERC32 is correctly defined. The leon2/3 were wrong because the defines were copied from ERC32, but the mask bits have opposite meaning ... Jiri. > > On 11/24/2014 04:41 PM, Gedare Bloom wrote: >> D

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-24 Thread Daniel Hellstrom
Ok, what about ERC32 which has the same macros? On 11/24/2014 04:41 PM, Gedare Bloom wrote: Daniel commit these if you agree with the assessment. On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler wrote: Condition needs to be inverted, as a 1 in the mask register means that the interrupt

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-24 Thread Gedare Bloom
Daniel commit these if you agree with the assessment. On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler wrote: > Condition needs to be inverted, as a 1 in the mask register means > that the interrupt is enabled. Solves ticket #1959 in trac. > --- > c/src/lib/libbsp/sparc/leon2/include/leon.h

[PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-23 Thread Jiri Gaisler
Condition needs to be inverted, as a 1 in the mask register means that the interrupt is enabled. Solves ticket #1959 in trac. --- c/src/lib/libbsp/sparc/leon2/include/leon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/sparc/leon2/include/leon.h b/c