Re: [PATCH 2/3] rbtree: Remove superfluous NULL pointer checks

2014-07-21 Thread Joel Sherrill
On 7/21/2014 12:52 PM, Sebastian Huber wrote: > On 07/21/2014 06:59 PM, Joel Sherrill wrote: >>> -/** @brief Extract a Node (unprotected) - * - * This routine extracts (removes) @a the_node from @a the_rbtree. - * - * @note It does NOT disable interrupts to ensure the atomici

Re: [PATCH 2/3] rbtree: Remove superfluous NULL pointer checks

2014-07-21 Thread Sebastian Huber
On 07/21/2014 06:59 PM, Joel Sherrill wrote: -/** @brief Extract a Node (unprotected) >- * >- * This routine extracts (removes) @a the_node from @a the_rbtree. >- * >- * @note It does NOT disable interrupts to ensure the atomicity >- *of the extract operation. >- */ Is it assumed that

Re: [PATCH 2/3] rbtree: Remove superfluous NULL pointer checks

2014-07-21 Thread Joel Sherrill
One comment inline. On 7/21/2014 11:31 AM, Sebastian Huber wrote: > --- > cpukit/score/include/rtems/score/rbtree.h | 7 +++ > cpukit/score/src/rbtree.c | 3 --- > cpukit/score/src/rbtreeextract.c | 10 -- > cpukit/score/src/rbtreeinsert.c | 3 ---

[PATCH 2/3] rbtree: Remove superfluous NULL pointer checks

2014-07-21 Thread Sebastian Huber
--- cpukit/score/include/rtems/score/rbtree.h | 7 +++ cpukit/score/src/rbtree.c | 3 --- cpukit/score/src/rbtreeextract.c | 10 -- cpukit/score/src/rbtreeinsert.c | 3 --- testsuites/sptests/sprbtree01/init.c | 3 --- 5 files changed, 3 inse