Re: [PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

2023-07-25 Thread Kinsey Moore
Unfortunately, this board is not publicly advertised or available and so a dedicated BSP in RTEMS is not really appropriate. It seems that the current "stm32h7" BSP should be renamed to stm32h743i-eval for clarity, but I'm sure that would affect existing users. I'll just have to keep the BSP

Re: [PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

2023-07-25 Thread Karel Gardas
On 7/24/23 23:17, Kinsey Moore wrote: [...] There is no other UART1 connector provided on the board. So I do not see reason why you add all other UARTs into #ifdefs for this particular board/bsp variant? And hence my question about your motivation and where you are

Re: [PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

2023-07-24 Thread Kinsey Moore
On Mon, Jul 24, 2023 at 3:30 PM Karel Gardas wrote: > > Hello Kinsey, > > honestly I don't know what to do about this patch. Let me explain a bit > history behind STM32h7. It was originally submitted by embedded brains > guys (Sebastian main, Christian added few things later) supporting the >

Re: [PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

2023-07-24 Thread Karel Gardas
Hello Kinsey, honestly I don't know what to do about this patch. Let me explain a bit history behind STM32h7. It was originally submitted by embedded brains guys (Sebastian main, Christian added few things later) supporting the only eval board of that time stm32h743-eval(2). Sebastian also

[PATCH v1 2/2] bsps/stm32h7: Configure UART clocks when enabled

2023-07-24 Thread Kinsey Moore
This change allows configuration of all enabled UART clocks without direct modificaton of the exiting BSP. --- .../stm/stm32h743i-eval/stm32h7-config-per.c | 41 +-- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git