Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Sebastian Huber
On 14/07/2021 10:44, Chris Johns wrote: Can I add `default-by-family: []` before `default-by-variant` in the spec files? Yes, the attributes should alphabetically sorted. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Chris Johns
On 14/7/21 5:01 pm, Sebastian Huber wrote: > On 14/07/2021 08:51, chr...@rtems.org wrote: >> @@ -695,12 +692,18 @@ class OptionItem(Item): >>   return True >>   return False >>   -    def default_value(self, variant): >> +    def default_value(self, variant, family): >>

Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Chris Johns
On 14/7/21 5:24 pm, Sebastian Huber wrote: > On 14/07/2021 09:21, Chris Johns wrote: >> Is there a nice way to catch any missing fields and report them? The waf >> conf is >> not present and I am not sure if we catch any standard python exception and >> report them by waf? > > The current

Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Sebastian Huber
On 14/07/2021 09:21, Chris Johns wrote: Is there a nice way to catch any missing fields and report them? The waf conf is not present and I am not sure if we catch any standard python exception and report them by waf? The current approach is to check the user input (e.g. config.ini) and report

Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Chris Johns
On 14/7/21 5:01 pm, Sebastian Huber wrote: > On 14/07/2021 08:51, chr...@rtems.org wrote: >> @@ -695,12 +692,18 @@ class OptionItem(Item): >>   return True >>   return False >>   -    def default_value(self, variant): >> +    def default_value(self, variant, family): >>

Re: [PATCH v2] build: Use BSP family for options

2021-07-14 Thread Sebastian Huber
On 14/07/2021 08:51, chr...@rtems.org wrote: @@ -695,12 +692,18 @@ class OptionItem(Item): return True return False -def default_value(self, variant): +def default_value(self, variant, family): value = self.data["default"] for default

[PATCH v2] build: Use BSP family for options

2021-07-14 Thread chrisj
From: Chris Johns - Optionally add support for 'default-by-family' to allow option to be set by a family and so all related BSPs Close #4468 --- wscript | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/wscript b/wscript index