Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-21 Thread Chris Johns
On 21/7/19 6:09 pm, Christian Mauderer wrote: > On 21/07/2019 04:46, Chris Johns wrote: >> On 20/7/19 4:50 pm, Christian Mauderer wrote: >>> On 19/07/2019 20:59, Vijay Kumar Banerjee wrote: On Fri, Jul 19, 2019 at 10:32 PM Christian Mauderer >>> > wrote:

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-20 Thread Chris Johns
On 20/7/19 4:50 pm, Christian Mauderer wrote: > On 19/07/2019 20:59, Vijay Kumar Banerjee wrote: >> On Fri, Jul 19, 2019 at 10:32 PM Christian Mauderer > > wrote: >> >> On 19/07/2019 18:21, Gedare Bloom wrote: >> > Looks good to me. I'm currently not able to

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-20 Thread Chris Johns
On 20/7/19 3:02 pm, Gedare Bloom wrote: > Good rules. Thanks and thanks for raising this. > If you get a chance please add them to the README for now. I will. > #1 should be for contributors, #3 is for Maintainers. #2 is optional. > :) Nice, I will include this. Chris

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-20 Thread Christian Mauderer
On 19/07/2019 20:59, Vijay Kumar Banerjee wrote: > > > On Fri, Jul 19, 2019 at 10:32 PM Christian Mauderer > wrote: > > On 19/07/2019 18:21, Gedare Bloom wrote: > > Looks good to me. I'm currently not able to apply it, verify the doc > > build, and push

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Gedare Bloom
On Fri, Jul 19, 2019 at 7:27 PM Chris Johns wrote: > > On 20/7/19 6:41 am, Gedare Bloom wrote: > > On Fri, Jul 19, 2019 at 11:02 AM Christian Mauderer > > wrote: > >> > >> On 19/07/2019 18:21, Gedare Bloom wrote: > >>> Looks good to me. I'm currently not able to apply it, verify the doc > >>>

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Chris Johns
On 20/7/19 6:41 am, Gedare Bloom wrote: > On Fri, Jul 19, 2019 at 11:02 AM Christian Mauderer > wrote: >> >> On 19/07/2019 18:21, Gedare Bloom wrote: >>> Looks good to me. I'm currently not able to apply it, verify the doc >>> build, and push it though. (Workstation issues.) >>> >> >> I agree

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Gedare Bloom
On Fri, Jul 19, 2019 at 11:02 AM Christian Mauderer wrote: > > On 19/07/2019 18:21, Gedare Bloom wrote: > > Looks good to me. I'm currently not able to apply it, verify the doc > > build, and push it though. (Workstation issues.) > > > > I agree that it looks OK. Thanks from me too for

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Vijay Kumar Banerjee
On Fri, Jul 19, 2019 at 10:32 PM Christian Mauderer wrote: > On 19/07/2019 18:21, Gedare Bloom wrote: > > Looks good to me. I'm currently not able to apply it, verify the doc > > build, and push it though. (Workstation issues.) > > > > I agree that it looks OK. Thanks from me too for

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Christian Mauderer
On 19/07/2019 18:21, Gedare Bloom wrote: > Looks good to me. I'm currently not able to apply it, verify the doc > build, and push it though. (Workstation issues.) > I agree that it looks OK. Thanks from me too for contributing to the documentation. It's something that most developers don't like

Re: [PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Gedare Bloom
Looks good to me. I'm currently not able to apply it, verify the doc build, and push it though. (Workstation issues.) On Fri, Jul 19, 2019 at 2:07 AM Vijay Kumar Banerjee wrote: > > --- > user/bsps/arm/beagle.rst | 110 ++- > 1 file changed, 108

[PATCH v2] user/bsps : Add documentation for Beagle

2019-07-19 Thread Vijay Kumar Banerjee
--- user/bsps/arm/beagle.rst | 110 ++- 1 file changed, 108 insertions(+), 2 deletions(-) diff --git a/user/bsps/arm/beagle.rst b/user/bsps/arm/beagle.rst index a36efde..eb4ecfb 100644 --- a/user/bsps/arm/beagle.rst +++ b/user/bsps/arm/beagle.rst @@ -1,8