RE: [PATCH v3] covoar: Handle periods in symbols from objdump

> -Original Message- > From: Chris Johns > Sent: Tuesday, March 16, 2021 7:18 PM > To: j...@rtems.org; Alex White > Cc: rtems-de...@rtems.org > Subject: Re: [PATCH v3] covoar: Handle periods in symbols from objdump > > On 17/3/21 9:56 am, Joel Sherrill wrote:

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021, 7:15 PM Chris Johns wrote: > On 17/3/21 8:16 am, Alex White wrote: > > Assuming I'm sending a v4 of this patch out, should I add the > explanation of the compiler-generated suffixes to the commit message or > perhaps as a comment in the code? > > Yes if you think it helps.

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 9:56 am, Joel Sherrill wrote: > On Tue, Mar 16, 2021, 4:47 PM Alex White > wrote: > > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 8:16 am, Alex White wrote: > Assuming I'm sending a v4 of this patch out, should I add the explanation of > the compiler-generated suffixes to the commit message or perhaps as a comment > in the code? Yes if you think it helps. In the end what you are doing makes the tool work and

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021, 4:47 PM Alex White wrote: > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm build/i386/pc686/testsuites/libtests/block08.exe | grep " > \." > 0011bdd2 t .check_stack_switch > > I don't think there are any

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

> Do any non-compiler-generated symbols include "."? Yes, according to the output of nm: $ i386-rtems6-nm build/i386/pc686/testsuites/libtests/block08.exe | grep " \." 0011bdd2 t .check_stack_switch I don't think there are any function symbols that include ".", though. > > Are there symbols

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

t; To: Chris Johns ; j...@rtems.org > Cc: rtems-de...@rtems.org > Subject: RE: [PATCH v3] covoar: Handle periods in symbols from objdump > > > I have lost of the context of why covoar would like to strip the > > suffixes and use only the base symbol name. Could you please e

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

> I have lost of the context of why covoar would like to strip the suffixes and > use only the base symbol name. Could you please explain why this is being > done? Sure. The symbol names in the DWARF info never contain these suffixes. Covoar strips the suffixes while reading the objdump output

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 2:05 am, Alex White wrote: > I’m not sure if I have seen an example of method split into more than one > piece. > It has been a while since I made this fix. > > A specific test executable that shows the suffixes is > testsuites/libtests/block08.exe, but most (if not all) of them

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021 at 8:25 AM Alex White wrote: > > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > These symbol suffixes are only found in the ELF symbol table; the > symbols appear to be normal in the

RE: [PATCH v3] covoar: Handle periods in symbols from objdump

: [PATCH v3] covoar: Handle periods in symbols from objdump On Tue, Mar 16, 2021 at 9:25 AM Alex White mailto:alex.wh...@oarcorp.com>> wrote: Occasionally the compiler will generate symbols that look similar to symbols defined in RTEMS code except that they contain some suffix. These

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On Tue, Mar 16, 2021 at 9:25 AM Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > These symbol suffixes are only found in the ELF symbol table; the > symbols appear to be normal in the

[PATCH v3] covoar: Handle periods in symbols from objdump

Occasionally the compiler will generate symbols that look similar to symbols defined in RTEMS code except that they contain some suffix. These symbol suffixes are only found in the ELF symbol table; the symbols appear to be normal in the DWARF info. This appears to be happening on all