Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Jiri Gaisler
On 1/21/19 1:11 PM, Sebastian Huber wrote: > On 21/01/2019 12:56, Jiri Gaisler wrote: >> On 1/21/19 11:33 AM, Sebastian Huber wrote: >>> On 21/01/2019 11:30, Jiri Gaisler wrote: diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index fbaadd1e13..7d99831e71

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Sebastian Huber
On 21/01/2019 12:56, Jiri Gaisler wrote: On 1/21/19 11:33 AM, Sebastian Huber wrote: On 21/01/2019 11:30, Jiri Gaisler wrote: diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index fbaadd1e13..7d99831e71 100644 --- a/bsps/shared/grlib/spw/grspw.c +++

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Jiri Gaisler
On 1/21/19 11:33 AM, Sebastian Huber wrote: > On 21/01/2019 11:30, Jiri Gaisler wrote: >> diff --git a/bsps/shared/grlib/spw/grspw.c >> b/bsps/shared/grlib/spw/grspw.c >> index fbaadd1e13..7d99831e71 100644 >> --- a/bsps/shared/grlib/spw/grspw.c >> +++ b/bsps/shared/grlib/spw/grspw.c >> @@ -25,8

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Sebastian Huber
On 21/01/2019 11:30, Jiri Gaisler wrote: diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index fbaadd1e13..7d99831e71 100644 --- a/bsps/shared/grlib/spw/grspw.c +++ b/bsps/shared/grlib/spw/grspw.c @@ -25,8 +25,8 @@ #include -#ifndef CPU_SPARC_HAS_SNOOPING

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Sebastian Huber
On 21/01/2019 11:16, Jiri Gaisler wrote: On 1/21/19 7:26 AM, Sebastian Huber wrote: On 18/01/2019 23:34, Jiri Gaisler wrote:    */   -extern int   CPU_SPARC_HAS_SNOOPING; +extern int   GRLIB_DMA_IS_CACHE_COHERENT; I would leave the SPARC BSPs as is. Maybe someone uses this

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-21 Thread Jiri Gaisler
On 1/21/19 7:26 AM, Sebastian Huber wrote: > On 18/01/2019 23:34, Jiri Gaisler wrote: >>    */ >>   -extern int   CPU_SPARC_HAS_SNOOPING; >> +extern int   GRLIB_DMA_IS_CACHE_COHERENT; > > I would leave the SPARC BSPs as is. Maybe someone uses this > CPU_SPARC_HAS_SNOOPING in external drivers or

Re: [PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-20 Thread Sebastian Huber
On 18/01/2019 23:34, Jiri Gaisler wrote: --- bsps/shared/grlib/spw/grspw.c | 6 +++--- bsps/sparc/leon2/include/bsp.h| 2 +- bsps/sparc/leon2/start/bspstart.c | 4 ++-- bsps/sparc/leon3/include/bsp.h| 2 +- bsps/sparc/leon3/start/bspstart.c | 4 ++-- 5 files changed, 9

[PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-18 Thread Jiri Gaisler
--- bsps/shared/grlib/spw/grspw.c | 6 +++--- bsps/sparc/leon2/include/bsp.h| 2 +- bsps/sparc/leon2/start/bspstart.c | 4 ++-- bsps/sparc/leon3/include/bsp.h| 2 +- bsps/sparc/leon3/start/bspstart.c | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v3 7/8] grlib: make memory coherency cpu-independent

2019-01-18 Thread Jiri Gaisler
--- bsps/shared/grlib/spw/grspw.c | 6 +++--- bsps/sparc/leon2/include/bsp.h| 2 +- bsps/sparc/leon2/start/bspstart.c | 4 ++-- bsps/sparc/leon3/include/bsp.h| 2 +- bsps/sparc/leon3/start/bspstart.c | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git