Re: Is rtems/bsd/test/network-config.h supposed to be installed?
> On Jul 6, 2021, at 06:42 , Chris Johns wrote: > >> On 3 Jul 2021, at 5:14 am, Peter Dufault wrote: >> >> I updated my libbsd today and an application is failing to build because it >> can't find the include file "rtems/bsd/test/network-config.h". It was added >> yesterday to "rtemsbsd/include/bsp/nexus-devices.h". "nexus-devices.h" the >> only file outside of the testsuite directory that includes >> "network-config.h", and that network-config.h file is in .gitignore. Or am >> I missing a build step? > > I think including it in a user facing header is a mistake. It is a tool to > handle the tests that are internal to libbsd. > > Chris > That was my impression as well. signature.asc Description: Message signed with OpenPGP ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Is rtems/bsd/test/network-config.h supposed to be installed?
> On 3 Jul 2021, at 5:14 am, Peter Dufault wrote: > > I updated my libbsd today and an application is failing to build because it > can't find the include file "rtems/bsd/test/network-config.h". It was added > yesterday to "rtemsbsd/include/bsp/nexus-devices.h". "nexus-devices.h" the > only file outside of the testsuite directory that includes > "network-config.h", and that network-config.h file is in .gitignore. Or am I > missing a build step? I think including it in a user facing header is a mistake. It is a tool to handle the tests that are internal to libbsd. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Is rtems/bsd/test/network-config.h supposed to be installed?
That's an oversight on my part since the discussion around this was so focused on tests and not application code. I'll post a patch to install it properly. Kinsey On 7/2/2021 14:14, Peter Dufault wrote: I updated my libbsd today and an application is failing to build because it can't find the include file "rtems/bsd/test/network-config.h". It was added yesterday to "rtemsbsd/include/bsp/nexus-devices.h". "nexus-devices.h" the only file outside of the testsuite directory that includes "network-config.h", and that network-config.h file is in .gitignore. Or am I missing a build step? Build failure: -- Waf: Entering directory `XXX/build/arm-rtems6-imxrt1052' [6/9] Compiling demo/init.c In file included from /opt/flatland/opt/rtems-6/arm-rtems6/imxrt1052/lib/include/machine/rtems-bsd-config.h:230, from ../../demo/init.c:695: /opt/flatland/opt/rtems-6/arm-rtems6/imxrt1052/lib/include/bsp/nexus-devices.h:41:10: fatal error: rtems/bsd/test/network-config.h: No such file or directory 41 | #include | ^ compilation terminated. "rtems/bsd/test/network-config.h" was added to "rtemsbsd/include/bsp/nexus-devices.h" Committed yesterday by Joel at 11:30: -- Module:rtems-libbsd Branch:6-freebsd-12 Commit:b0c8153d54f7b14ed305f0da23a3dc2e207a0968 Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=b0c8153d54f7b14ed305f0da23a3dc2e207a0968 Author:Kinsey Moore Date: Wed Jun 30 15:00:58 2021 -0500 rtemsbsd: Use config.inc to control ZynqMP ethernet This alters the selection of the 4 Cadence GEM interfaces on the Zynq Ultrascale+ MPSoC BSP to be provided by config.inc instead of being provided by options in the RTEMS BSP itself since those options appear to be dead code when not used in conjunction with LibBSD. --- rtemsbsd/include/bsp/nexus-devices.h | 9 + testsuite/include/rtems/bsd/test/network-config.h.in | 8 waf_libbsd.py| 4 +++- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/rtemsbsd/include/bsp/nexus-devices.h b/rtemsbsd/include/bsp/nexus-devices.h index 5c1bab4..cbb3f48 100644 --- a/rtemsbsd/include/bsp/nexus-devices.h +++ b/rtemsbsd/include/bsp/nexus-devices.h @@ -38,6 +38,7 @@ #include #include +#include #include ... ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Is rtems/bsd/test/network-config.h supposed to be installed?
I updated my libbsd today and an application is failing to build because it can't find the include file "rtems/bsd/test/network-config.h". It was added yesterday to "rtemsbsd/include/bsp/nexus-devices.h". "nexus-devices.h" the only file outside of the testsuite directory that includes "network-config.h", and that network-config.h file is in .gitignore. Or am I missing a build step? Build failure: -- Waf: Entering directory `XXX/build/arm-rtems6-imxrt1052' [6/9] Compiling demo/init.c In file included from /opt/flatland/opt/rtems-6/arm-rtems6/imxrt1052/lib/include/machine/rtems-bsd-config.h:230, from ../../demo/init.c:695: /opt/flatland/opt/rtems-6/arm-rtems6/imxrt1052/lib/include/bsp/nexus-devices.h:41:10: fatal error: rtems/bsd/test/network-config.h: No such file or directory 41 | #include | ^ compilation terminated. "rtems/bsd/test/network-config.h" was added to "rtemsbsd/include/bsp/nexus-devices.h" Committed yesterday by Joel at 11:30: -- Module:rtems-libbsd Branch:6-freebsd-12 Commit:b0c8153d54f7b14ed305f0da23a3dc2e207a0968 Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=b0c8153d54f7b14ed305f0da23a3dc2e207a0968 Author:Kinsey Moore Date: Wed Jun 30 15:00:58 2021 -0500 rtemsbsd: Use config.inc to control ZynqMP ethernet This alters the selection of the 4 Cadence GEM interfaces on the Zynq Ultrascale+ MPSoC BSP to be provided by config.inc instead of being provided by options in the RTEMS BSP itself since those options appear to be dead code when not used in conjunction with LibBSD. --- rtemsbsd/include/bsp/nexus-devices.h | 9 + testsuite/include/rtems/bsd/test/network-config.h.in | 8 waf_libbsd.py| 4 +++- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/rtemsbsd/include/bsp/nexus-devices.h b/rtemsbsd/include/bsp/nexus-devices.h index 5c1bab4..cbb3f48 100644 --- a/rtemsbsd/include/bsp/nexus-devices.h +++ b/rtemsbsd/include/bsp/nexus-devices.h @@ -38,6 +38,7 @@ #include #include +#include #include ... signature.asc Description: Message signed with OpenPGP ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
