Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Waldemar Brodkorb
Hi Thomas, Anthony, Anthony G. Basile wrote, > On 6/22/17 9:06 AM, Thomas Petazzoni wrote: > > Hello, > > > > On Thu, 22 Jun 2017 08:47:06 -0400, Anthony G. Basile wrote: > > > >> Yes, I'm worried about regressions. __FAVOR_BSD is still used in the > >> following: > >> > >> include/setjmp.h >

Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Anthony G. Basile
On 6/22/17 9:06 AM, Thomas Petazzoni wrote: > Hello, > > On Thu, 22 Jun 2017 08:47:06 -0400, Anthony G. Basile wrote: > >> Yes, I'm worried about regressions. __FAVOR_BSD is still used in the >> following: >> >> include/setjmp.h >> include/unistd.h >> include/signal.h >> include/features.h >> i

Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Thomas Petazzoni
Hello, On Thu, 22 Jun 2017 08:47:06 -0400, Anthony G. Basile wrote: > Yes, I'm worried about regressions. __FAVOR_BSD is still used in the > following: > > include/setjmp.h > include/unistd.h > include/signal.h > include/features.h > include/netinet/udp.h > > and deals with the differences in

Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Anthony G. Basile
On 6/22/17 8:37 AM, Thomas Petazzoni wrote: > Hello, > > On Thu, 22 Jun 2017 08:33:31 -0400, Anthony G. Basile wrote: > >> I just did a grep of glibc master/HEAD and it looks like __FAVOR_BSD has >> been removed. If we remove __FAVOR_BSD from uclibc, will buildroot >> stuff build fine? You can te

Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Thomas Petazzoni
Hello, On Thu, 22 Jun 2017 08:33:31 -0400, Anthony G. Basile wrote: > I just did a grep of glibc master/HEAD and it looks like __FAVOR_BSD has > been removed. If we remove __FAVOR_BSD from uclibc, will buildroot > stuff build fine? You can test by just removing those lines from > features.h and

Re: [uclibc-ng-devel] [PATCH] include/features.h: add _DEFAULT_SOURCE macro

2017-06-22 Thread Anthony G. Basile
On 6/21/17 4:11 PM, Waldemar Brodkorb wrote: > Hi, > Thomas Petazzoni wrote, > >> Hello, >> >> On Wed, 31 May 2017 23:41:26 +, Anthony G. Basile wrote: >>> From: "Anthony G. Basile" >>> >>> man feature_test_macros(7) specifies that _BSD_SOURCE and _SVID_SOURCE have >>> been deprecated in favor