Re: [uclibc-ng-devel] [PATCH] bugfix: ARM: memset.S: use unsigned comparisons

2016-06-26 Thread Waldemar Brodkorb
Hi Lucian, Lucian Cojocar wrote, > Waldemar Brodkorb ucibc-ng.org> writes: > > > > > Hi Lucian, > > Lucian Cojocar wrote, > > > > > Hi, > > > > > > Any follow-up on this patch? > > > > Not yet. You are saying the second segmentation fault would be > > expected. What is then the exact benefit

Re: [uclibc-ng-devel] [PATCH] bugfix: ARM: memset.S: use unsigned comparisons

2016-06-19 Thread Lucian Cojocar
Waldemar Brodkorb ucibc-ng.org> writes: > > Hi Lucian, > Lucian Cojocar wrote, > > > Hi, > > > > Any follow-up on this patch? > > Not yet. You are saying the second segmentation fault would be > expected. What is then the exact benefit of the patch, if the result > is a segfault? 'memset' w

Re: [uclibc-ng-devel] [PATCH] bugfix: ARM: memset.S: use unsigned comparisons

2016-06-19 Thread Waldemar Brodkorb
Hi Lucian, Lucian Cojocar wrote, > Hi, > > Any follow-up on this patch? Not yet. You are saying the second segmentation fault would be expected. What is then the exact benefit of the patch, if the result is a segfault? Or do you have a simple testcase showing breakage before your patch and non-

Re: [uclibc-ng-devel] [PATCH] bugfix: ARM: memset.S: use unsigned comparisons

2016-06-19 Thread Lucian Cojocar
Hi, Any follow-up on this patch? Thanks, Lucian On 06/10/2016 06:44 PM, Lucian Cojocar wrote: > The 'BLT' instruction checks for *signed* values. So if a3, length > parameter of memset, is negative, then value added to the PC will be > large. > > memset(buf, 0xaa, 0x) triggers the bug.