Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: The following CVS commit, made by Thomas Dickey, has no indication that Thomas was either a) not involved at all in the patch or b) that Thomas found Ralf Habacker's patch and committed a modified version of that patch. The CVS log message says:

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: The following CVS commit, made by Thomas Dickey, has no indication that Thomas was either a) not involved at all in the patch or b) that Thomas found Ralf Habacker's patch and committed a modified version of that patch. The CVS

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: Your commit didn't mention this either. Our change log is in our release notes, where the changes were attributed to Ralf Habacker: tsk, tsk: the actual commit on the code change bears only your name. A casual reader of that commit (and of this

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: XFree86 should be taking care not to steal credit for our patches by committing them without proper attribution. your standards are inconsistent: your committing the change rather than offering commit access to someone who solved a problem that

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Your commit didn't mention this either. Our change log is in our release notes, where the changes were attributed to Ralf Habacker: tsk, tsk: the actual commit on the code change bears only your name. A casual reader of that

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: indeed. you have made it onto that select list of people whose patches I have to scrutinize. -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list [EMAIL

Re: Proper attribution of patches

2003-12-23 Thread David Dawes
On Tue, Dec 23, 2003 at 01:25:52PM -0500, Harold L Hunt II wrote: The following CVS commit, made by Thomas Dickey, has no indication that Thomas was either a) not involved at all in the patch or b) that Thomas found Ralf Habacker's patch and committed a modified version of that patch. The CVS

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Your commit didn't mention this either. Our change log is in our release notes, where the changes were attributed to Ralf Habacker: tsk, tsk: the actual commit on the

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: XFree86 should be taking care not to steal credit for our patches by committing them without proper attribution. your standards are inconsistent: your committing the change rather than offering commit access to someone who

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Your commit didn't mention this either. Our change log is in our release notes, where the changes were attributed to Ralf Habacker: tsk, tsk: the actual

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Eric Anholt wrote: The only responsible thing for you to do would be to correct the ChangeLog to attribute it to the patch's author. well that's polite enough. unlike Harold. no problem. -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: No, that is not good enough. You should amend your change log entry to attribute the patch to Ralf and you should apologize to the X community at large for being so sloppy with attributing credit. yes, you're right. now I'll have to scrutinize

Re: Proper attribution of patches

2003-12-23 Thread Alan Hourihane
On Tue, Dec 23, 2003 at 02:02:20PM -0500, Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: The following CVS commit, made by Thomas Dickey, has no indication that Thomas was either a) not involved at all in the patch or b) that Thomas found Ralf Habacker's patch and

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Alan Hourihane wrote: On Tue, Dec 23, 2003 at 02:02:20PM -0500, Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: The following CVS commit, made by Thomas Dickey, has no indication that Thomas was either a) not involved at all in the patch or b) that Thomas found Ralf

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Alan Hourihane wrote: Thomas, If you did get this code directly from Cygwin/X's tree then I'd of expected at least the credit to be apportioned to Harold at the very least, rather than putting your name against it. Ralf's name could have been corrected later, with a

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: Thomas Dickey wrote: On Tue, 23 Dec 2003, Eric Anholt wrote: The only responsible thing for you to do would be to correct the ChangeLog to attribute it to the patch's author. well that's polite enough. unlike Harold. I have not been

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Thomas Dickey wrote: On Tue, 23 Dec 2003, Eric Anholt wrote: The only responsible thing for you to do would be to correct the ChangeLog to attribute it to the patch's author. well that's polite enough. unlike Harold. I

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: No, that is not good enough. You should amend your change log entry to attribute the patch to Ralf and you should apologize to the X community at large for being so sloppy with attributing credit. yes, you're right. Thanks.

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Eric Anholt wrote: I see only minor inconsitency on his part, that the original commit of that code didn't attribute it to its author in the CVS logs, while at least some other commits do note authors of patches. However, he didn't explicitly take credit for it, like you

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: Put Ralf's name in the change log!!! you first. (hmm - that's an appropriate pun). -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list [EMAIL PROTECTED]

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: been corrected later, with a follow email from Harold. It's a simple change to put that right in the CHANGELOG. So I'll do that. I had that on my next set of commits. Then why not say so earlier? There was no point in doing so. -- Thomas

Re: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Harold L Hunt II wrote: a lot of words. -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net ___ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel

Re: Proper attribution of patches

2003-12-23 Thread Harold L Hunt II
Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: been corrected later, with a follow email from Harold. It's a simple change to put that right in the CHANGELOG. So I'll do that. I had that on my next set of commits. Then why not say so earlier? There was no point in doing

RE: Proper attribution of patches

2003-12-23 Thread Armbrust, Daniel C.
] Cc: [EMAIL PROTECTED] Subject: Re: Proper attribution of patches On Tue, 23 Dec 2003, Harold L Hunt II wrote: Thomas Dickey wrote: On Tue, 23 Dec 2003, Harold L Hunt II wrote: Your commit didn't mention this either. Our change log is in our release notes, where the changes were

RE: Proper attribution of patches

2003-12-23 Thread Thomas Dickey
On Tue, 23 Dec 2003, Armbrust, Daniel C. wrote: I've seen your postings before, and have no use for your opinions. (that seems to be a common trait of Harold's friends - I don't have to address each one of them). -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net

RE: Proper attribution of patches

2003-12-23 Thread Armbrust, Daniel C.
]' Subject: RE: Proper attribution of patches On Tue, 23 Dec 2003, Armbrust, Daniel C. wrote: I've seen your postings before, and have no use for your opinions. (that seems to be a common trait of Harold's friends - I don't have to address each one of them). -- Thomas E. Dickey http://invisible