Re: [edk2-devel] [patch V2 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg

2019-04-08 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Bi, Dandan > Sent: Monday, April 08, 2019 1:41 PM > To: devel@edk2.groups.io > Cc: Ni, Ray; Wu, Hao A > Subject: [patch V2 5/7] Nt32Pkg: Update to use UefiDecompressLib in > MdeModulePkg > > REF:

Re: [edk2-devel] [PATCH] UefiCpuPkg/Cpuid.h: Update CPUID.7H.ECX structure for 5-level paging

2019-04-08 Thread Dong, Eric
Hi Ray, Please use new Reserved7 for the reserved field because Reserve6 bit width has change. Thanks, Eric > -Original Message- > From: Ni, Ray > Sent: Monday, April 8, 2019 3:33 PM > To: devel@edk2.groups.io > Cc: Dong, Eric > Subject: [PATCH] UefiCpuPkg/Cpuid.h: Update CPUID.7H.ECX

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-08 Thread Sun, Zailiang
For Vlv2TbltDevicePkg and Vlv2DeviceRefCodePkg Reviewed-by: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Saturday, April 06, 2019 5:40 AM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: Re:

Re: [edk2-devel] [patch 7/7] Vlv2TbltDevicePkg: Update to use UefiDecompressLib in MdeModulePkg

2019-04-08 Thread Qian, Yi
Reviewed by Qian, Yi Thanks Qian Yi > -Original Message- > From: Bi, Dandan > Sent: Thursday, April 04, 2019 9:52 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [patch 7/7] Vlv2TbltDevicePkg: Update to use UefiDecompressLib in > MdeModulePkg > > REF:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38651): https://edk2.groups.io/g/devel/message/38651 Mute This Topic: https://groups.io/mt/30921469/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38648): https://edk2.groups.io/g/devel/message/38648 Mute This Topic: https://groups.io/mt/30893897/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] > KabylakeOpenBoardPkg/KBLRvp3: Remove

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-08 Thread Chiu, Chasel
I'm ok with the changes in below packages. Thanks! Chasel Reviewed-by: Chasel Chiu For IntelFspPkg IntelFspWrapperPkg IntelFsp2Pkg IntelFsp2WrapperPkg > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Monday, April 8,

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: > Remove unused PCD

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38649): https://edk2.groups.io/g/devel/message/38649 Mute This Topic: https://groups.io/mt/30893898/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38637): https://edk2.groups.io/g/devel/message/38637 Mute This Topic: https://groups.io/mt/30893899/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38647): https://edk2.groups.io/g/devel/message/38647 Mute This Topic: https://groups.io/mt/30893896/21656 Group Owner:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] > KabylakeSiliconPkg/SiPkg.dec: Remove

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] > KabylakeOpenBoardPkg/KBLRvp3: Remove

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-08 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu < chasel.c...@intel.com > for below packages: IntelFspPkg IntelFspWrapperPkg IntelFsp2Pkg IntelFsp2WrapperPkg -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38641): https://edk2.groups.io/g/devel/message/38641

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-08 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Friday, April 5, 2019 5:05 PM > To: rebe...@bluestop.org; Gao, Liming > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and

[edk2-devel] TianoCore Bug Triage - EMEA / NAMO - Mon, 04/08/2019 7:00am-8:00am #cal-reminder

2019-04-08 Thread devel@edk2.groups.io Calendar
"TianoCore Bug Triage - EMEA / NAMO" Reminder When: Monday, 8 April 2019 7:00am to 8:00am (GMT-07:00) America/Los Angeles Where: https://zoom.us/j/670172897 Description: Join Zoom Meeting https://zoom.us/j/670172897 ( https://zoom.us/j/670172897 )   One tap mobile

Re: [edk2-devel] [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg

2019-04-08 Thread Michael D Kinney
Ray, There is already a BZ to move that platform out of edk2 repo. https://bugzilla.tianocore.org/show_bug.cgi?id=1374 Mike From: Ni, Ray Sent: Sunday, April 7, 2019 9:59 PM To: 'devel@edk2.groups.io' Cc: Kinney, Michael D ; Steele, Kelly Subject: [RFC] Propose to remove QuarkPlatformPkg

Re: [edk2-devel] [RFC] Propose to remove QuarkPlatformPkg and QuarkSocPkg

2019-04-08 Thread Ni, Ray
Mike, This RFC is to see whether people have concern if completely removing QuarkPlatformPkg and QuarkSocPkg. Thanks, Ray From: Kinney, Michael D Sent: Monday, April 8, 2019 10:41 PM To: Ni, Ray ; 'devel@edk2.groups.io' ; Kinney, Michael D Cc: Steele, Kelly Subject: RE: [RFC] Propose to

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

2019-04-08 Thread Michael D Kinney
EDK II Maintainers and Reviewers, I have rebased the patch series as of April 8, 2019, and I have added the Reviewed-by tags I have received. Please review the commit messages in the V3a branch verify that I have not missed any reviewers. I have also verified that no files have been

Re: [edk2-devel] Why is specified -mno-sse on clang x64?

2019-04-08 Thread Gary Zibrat via Groups.Io
I've messed around with it locally and nothing seemed to stop working. Would there be any interest in adding a newer clang configuration with -mno-sse removed? On Thu, Apr 4, 2019 at 1:12 PM Andrew Fish wrote: > > > On Apr 4, 2019, at 1:09 PM, Gary Zibrat via Groups.Io < >

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/Cpuid.h: Update CPUID.7H.ECX structure for 5-level paging

2019-04-08 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Monday, April 8, 2019 5:11 PM > To: devel@edk2.groups.io > Cc: Dong, Eric > Subject: [PATCH v2] UefiCpuPkg/Cpuid.h: Update CPUID.7H.ECX structure > for 5-level paging > > Reserved6 is changed to Reserved7 because the

Re: [edk2-devel] [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function

2019-04-08 Thread Liming Gao
If so, the change is good to me. Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, April 3, 2019 10:56 AM > To: Gao, Liming > Cc: edk2-de...@lists.01.org > Subject: RE: [Patch V2] BaseTools: Fixed issue in MultiThread Genfds function > > If user does

Re: [edk2-devel] [edk2][PATCH V2] BaseTools:GenMakeFile Complete the task using CC Tool multithreading

2019-04-08 Thread Liming Gao
Zhiju: Why use /MP1? Can use /MP? Besides, if build_rule.txt is not updated to new one, build tool is updated. What will happen? Thanks Liming > -Original Message- > From: Fan, ZhijuX > Sent: Wednesday, April 3, 2019 3:59 PM > To: edk2-de...@lists.01.org > Cc: Gao, Liming ; Feng,

Re: [edk2-devel] [edk2-announce] Welcome to the new mailing list!

2019-04-08 Thread Stephano Cetola
On 4/8/2019 10:40 AM, Laszlo Ersek wrote:> Unfortunately, the current mailing list seems to have been disabled too early. Hmm, they should have kept this enabled. I specifically mentioned this in the ticket. https://lists.01.org/pipermail/edk2-bugs/2019-April/006787.html I seem to have

Re: [edk2-devel] ASL build tools - EDKII trim tool questions

2019-04-08 Thread Liming Gao
The full preprocessor means to support C style syntax in ASL code, such as #include “xxx.h” or #define ASL_MACRO 10. Do you want to support it? Thanks Liming From: Schmauss, Erik Sent: Tuesday, April 9, 2019 12:45 AM To: Gao, Liming ; devel@edk2.groups.io; fel...@ami.com Cc: Moore, Robert

Re: [edk2-devel] [edk2] [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h

2019-04-08 Thread Zhang, Shenglei
Hi All, I'd like to know if you have any comment on this change. Thanks, Shenglei > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Shenglei Zhang > Sent: Friday, March 29, 2019 9:41 AM > To: edk2-de...@lists.01.org > Cc: Justen, Jordan L ;

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

2019-04-08 Thread Wu, Hao A
Michael and Chasel, Thanks for the review. The series has been pushed at: a496938e7b..889da83ddf (devel-MinPlatform branch) Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, April 04, 2019

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Drop the consume of 8259 PIC driver

2019-04-08 Thread Wu, Hao A
The commit will: A) Add explicit logic to disable the 8259 interrupts in BoardInitLib; B) Remove the consumption of 8259 PIC driver from the DSC/FDF files for the BoardMtOlympus platform. Cc: Xiaohu Zhou Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu

[edk2-devel] [PATCH 1/3] MdePkg/BaseIoLibIntrinsic: Remove IoLibIcc.c

2019-04-08 Thread Zhang, Shenglei
As ICC tool chain will be removed, IoLibIcc.c should also be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1666 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf

[edk2-devel] [PATCH 0/3] Remove ICC tool chain

2019-04-08 Thread Zhang, Shenglei
There is no Intel complier test. So suggest to remove ICC tool chain from tools_def.template and remove support of Intel tool chain in BaseLib. And also IoLibIcc.c in MdePkg should update to be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1666 Cc: Michael D Kinney Cc: Bob Feng Cc:

[edk2-devel] [PATCH 2/3] MdePkg/BaseLib: Remove support of INTEL tool chain

2019-04-08 Thread Zhang, Shenglei
As Intel tool chain will be removed, support of INTEL tool chain should be removed first. https://bugzilla.tianocore.org/show_bug.cgi?id=1666 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2-devel] [PATCH] MdePkg/BaseLib: Remove LongJump.c and SetJump.c

2019-04-08 Thread Zhang, Shenglei
MdePkg BaseLib still uses the inline X86 assembly code in C code files.For now, inline SetJump/LongJump() can be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1163 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang

Re: [edk2-devel] [PATCH] Marvell/Armada7k8k: Remove SPCR baud rate setting

2019-04-08 Thread Jeremy Linton
Hi Marcin, On 4/8/19 8:31 PM, Marcin Wojtas wrote: Hi Jeremy, Thanks for the patch. However I played with booting with ACPI with and without your patch - I may be missing something, but I don't see a difference, when using earlycon (both 'earlycon=uart,mmio32,0xf0512000' and

Re: [edk2-devel] [Patch V2 3/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V2 3/4] BaseTools: Fix corner-cases of --hash feature BZ:

Re: [edk2-devel] [Patch V2 1/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V2 1/4] BaseTools: Fix corner-cases of --hash feature BZ:

Re: [edk2-devel] [Patch V2 4/4] BaseTools: Fix corner-cases of --hash feature

2019-04-08 Thread BobCF
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Christian Rodriguez Sent: Friday, April 5, 2019 12:04 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [edk2-devel] [Patch V2 4/4]

Re: [edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

2019-04-08 Thread Gao, Zhichao
The patch code looks good to me. But while I apply this patch, it will shows "error: corrupt patch at line 24" and " error: could not build fake ancestor". Maybe you direct change the patch file and remove some blank lines. For Uefi BdsDxe driver, the variable "PlatfomLang" would be initialize

Re: [edk2-devel] [edk2][PATCH V2] BaseTools:GenMakeFile Complete the task using CC Tool multithreading

2019-04-08 Thread Liming Gao
Zhiju: Thanks for your update on build_rule.txt. On MP option, https://docs.microsoft.com/en-us/cpp/build/reference/mp-build-with-multiple-processes?view=vs-2019 /MP[processMax], processMax is optional. If you omit the processMax argument, the compiler retrieves the number of effective