Hi Siyuan,
Please help to review this? Thanks
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
ShengfengX
Sent: Monday, April 15, 2019 4:14 PM
To: devel@edk2.groups.io
Cc: Xue; Xue, ShengfengX
Subject: [edk2-devel] [PATCH]
Hi, Shengfeng
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
> ShengfengX
> Sent: Monday, April 15, 2019 4:14 PM
> To: devel@edk2.groups.io
> Cc: Xue; Xue, ShengfengX
> Subject: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1718
BaseTools\Scripts\ConvertFceToStructurePcd.py
This script is for sorting the PCD order them
base on PcdName, then base on Pcd field name.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
On Mon, Apr 15, 2019 at 01:23:11AM +, Wu, Hao A wrote:
> > + This program and the accompanying materials are licensed and made
> > available
> > + under the terms and conditions of the BSD License which accompanies this
> > + distribution. The full text of the license may be found at
> > +
Please see below comments inline.
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 15, 2019 11:08 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5]
> KabylakeSiliconPkg/BaseResetSystemLib: Add
Some bikeshedding below:
On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97
Does this permit execution of both IA32 and X64 code? If so, the name
makes sense (but the
Small comments are added inline. With them handled, Reviewed-by: Star Zeng
.
You do not need to send an extra patch for them specifically if no other
comment will be received from other.
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, April 15, 2019 2:09 PM
> To:
Please refer this link for defail.
https://bugzilla.tianocore.org/show_bug.cgi?id=1695
Some Platform setup need provide a item for user to Enabled/Disabled IPV4/IPV6
PXE boot, but Origin UefiPxeBcDxe driver doesn't have such interface.
So attached code review added two PCD to control IPV4/IPV6
Hi Zhichao,
Thanks for this.
On Mon, Apr 15, 2019 at 11:06:01AM +0800, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this
Same as previous patch - if you drop the space before ;,
Reviewed-by: Leif Lindholm
On Mon, Apr 15, 2019 at 11:06:08AM +0800, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic
Hi Ard,
pt., 12 kwi 2019 o 23:15 Ard Biesheuvel napisał(a):
>
> On Fri, 12 Apr 2019 at 03:20, Marcin Wojtas wrote:
> >
> > In order to provide special handling for DT environment,
> > implement custom version of DtLoaderLib, which registers
> > ExitBootServices event upon generic 'DtAcpiPref'
All Styx platforms in the tree (and the world) use
ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
these days, but somehow this orphaned .inf was left around - drop it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
+Thomas for info
Zhichao - please update subject line to
Platform/ARM: Add a new API ResetSystem to VExpress ResetSystemLib
and drop the spaces before ;.
With that:
Reviewed-by: Leif Lindholm
On Mon, Apr 15, 2019 at 11:07:35AM +0800, Zhichao Gao wrote:
> REF:
Hi, Shengfeng
I gave 4 review comments to your V1 patch, but you only fixed the patch
description.
Also, an updated patch should be prefixed with [PATCH v2]
BestRegards
Fu Siyuan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue,
>
Hi Maciej,
Please help review this code from PCH perspective.
If you approve this change , please also help cherry pick this change to
ServerSiliconPkg\Pch\SouthClusterLbg pkg @10nm trunk.
Thanks,
Amos
UEFI FW, IAFW or System Firmware is more generic & accurate
it's not BIOS anymore!
Due to the tight schedule, we plan to upstream code to staging earlier if there
is no more comments. The due date will change to Apr 16th.
You can continue to evaluate the feature and provide feedback when this feature
stays in staging.
BR,
Wei Xu
From: Xu, Wei6
Sent: Friday, April 12, 2019
Recent modification of the Armada7k8k SPCR to ARM_GAS8 broke the OpenBSD
booting with ACPI, as the initial console could mistakenly
interpret (with the reg-shift=0), that the registers are 8-bits apart.
Fix that by restoring 32-bit register width, however leaving
the AccessSize field
Hi Leif,
This is not a macro that is to be used by C code. It is a technique
to prevent recursive includes on a .h file. As a result, we do not want
to use the C Coding Standard macro style.
Are there other techniques to prevent recursive includes?
I agree that macros/symbols that start with
Hi Zhichao,
On 04/13/19 09:52, Gao, Zhichao wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Friday, April 12, 2019 4:06 PM
>> To: devel@edk2.groups.io; Gao, Zhichao
>> Cc: Wang, Jian J ; Wu, Hao A ;
>> Ni, Ray ; Zeng, Star ; Gao, Liming
>> ;
Wei Xu,
Thanks for providing this request for a new edk2-staging branch.
Please add the branch maintainers to the Readme along with the criteria that
must be met for the feature to be considered a candidate for edk2/master.
With those updates, Reviewed-by: Michael D Kinney
On 04/14/19 09:19, Jordan Justen wrote:
> On 2019-04-12 16:31:20, Laszlo Ersek wrote:
>> RH covscan justifiedly reports that accessing
>> "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a
>> (UINT32*), is undefined behavior:
>>
>>> Error: OVERRUN (CWE-119):
>>>
On 04/15/19 05:06, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
>
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers
> use
On 4/13/19 1:31 AM, Laszlo Ersek wrote:
> RH covscan emits the following false positive:
>
>> Error: CLANG_WARNING:
>> edk2-89910a39dcfd/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c:182:14:
>> warning: Dereference of undefined pointer value
>> #Status = FwVol->ReadSection (
>> #
On 4/13/19 1:31 AM, Laszlo Ersek wrote:
> RH covscan justifiedly reports a path through InstallXenTables() where
> DsdtTable can technically remain NULL.
>
> If this occurs in practice, then the guest and the VMM are out of sync on
> the interface contract. Catch the situation with a code snippet
On Mon, 15 Apr 2019 at 02:17, Leif Lindholm wrote:
>
> Some bikeshedding below:
>
> On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97
>
> Does this permit execution of
On Mon, Apr 15, 2019 at 10:57:53AM -0700, Ard Biesheuvel wrote:
> On Mon, 15 Apr 2019 at 02:17, Leif Lindholm wrote:
> >
> > Some bikeshedding below:
> >
> > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> > > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> > >
Add a binary RELEASE build targeting AARCH64 systems, created with
Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems
to dispatch and execute option ROMs and other drivers built for the
X64 architecture.
Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git
Commit:
On Mon, 15 Apr 2019 at 03:15, Leif Lindholm wrote:
>
> All Styx platforms in the tree (and the world) use
> ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> these days, but somehow this orphaned .inf was left around - drop it.
>
> Contributed-under: TianoCore Contribution
On Mon, 15 Apr 2019 at 02:52, Marcin Wojtas wrote:
>
> Hi Ard,
>
>
> pt., 12 kwi 2019 o 23:15 Ard Biesheuvel
> napisał(a):
> >
> > On Fri, 12 Apr 2019 at 03:20, Marcin Wojtas wrote:
> > >
> > > In order to provide special handling for DT environment,
> > > implement custom version of
On Mon, Apr 15, 2019 at 11:22:59AM -0700, Ard Biesheuvel wrote:
> Add a binary RELEASE build targeting AARCH64 systems, created with
> Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems
> to dispatch and execute option ROMs and other drivers built for the
> X64 architecture.
>
>
On Mon, 15 Apr 2019 at 12:06, Leif Lindholm wrote:
>
> On Mon, Apr 15, 2019 at 11:22:59AM -0700, Ard Biesheuvel wrote:
> > Add a binary RELEASE build targeting AARCH64 systems, created with
> > Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems
> > to dispatch and execute option
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Sunday, April 14, 2019 12:53 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Andrew Fish ; Leif
> Lindholm ; Zeng, Star ;
>
On 2019-04-11 08:51:22, Guo Dong wrote:
> CorebootModulePkg and CorebootPayloadPkg originally supports coreboot only.
> In order to support other bootloaders, such as Slim Bootloader, they need
> be updated to be more generic.
> UEFI Payload (UefiPayloadPkg) a converged package from
Add a conditional build time include of the prebuild X64 PE/COFF emulator
binary to some platforms that will be able to make use of it (i.e., have
usable PCI slots)
Ard Biesheuvel (3):
Platform/DeveloperBox: conditionally include the X64 PE/COFF emulator
Platform/Overdrive: conditionally
For now, no driver consumes ResetSystem. But some drivers in edk repo, such as
CapsuleRuntimeDxe would use it in the further. If the platform support this
driver and do not use the ResetSystemLib instance in MdeModulePkg, a link error
would be caused.
Thanks,
Zhichao
> -Original
Hi, Jordan
That is a good point. Smaller patch will always help the review easier.
Thank you for pointing it out.
Thanks
Maurice
> -Original Message-
> From: Justen, Jordan L
> Sent: Monday, April 15, 2019 15:28
> To: Dong, Guo ; Ma, Maurice
> ; devel@edk2.groups.io
> Cc: Agyeman,
Thanks Jordan for the comments.
This patch adds a new package instead of updating existing code.
I thought it was difficult to separate this patch into multiple sub-patches
while keeping each chunk to be able to compile and function.
Will consider this in the future.
Thanks,
Guo
>
I agree w/ your comments Jian. Great input from Lazlo, too.
I also want to let the community know that this specific process posting has 2
parts.
This first was to post the process used by infosec bz team today, which Jian
did well with
Hi All,
There is no Intel compiler test. I suggest to remove ICC tool chain from
tools_def.template. After this update, INTEL tool family is not used. So,
MdePkg library can be updated to remove it. And also MS ASL is not verified
now. I suggest to remove tool chain with ASL tool. They are:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, April 15, 2019 11:56 PM
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Liming
> ; Sean Brogan ;
> Michael Turner ; Bret Barkelew
>
> Subject:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 15, 2019 11:08 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Gao, Liming
> Subject: [edk2-platforms/devel-MinPlatform][PATCH 2/5]
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 15, 2019 11:08 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Gao, Liming
> Subject: [edk2-platforms/devel-MinPlatform][PATCH 4/5]
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, April 15, 2019 11:08 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5]
> KabylakeSiliconPkg/BaseResetSystemLib: Add a new
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Sunday, April 14, 2019 8:08 PM
> To: devel@edk2.groups.io
> Cc: Piwko; Piwko, Maciej ; Bu; Bu, Daocheng
> ; Oram; Oram, Isaac W ;
> Chiu,
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1672
The /MP option of MSVC compiler can reduce the total time to compile the
source files on the command line.
This patch is going to enable this MSVC option in BaseTools.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution
Hi Ard,
wt., 16 kwi 2019 o 00:43 Ard Biesheuvel napisał(a):
>
> Add the X64 emulator to the build if '-D X64EMU_ENABLE=TRUE' is passed
> on the build command line. Note that this only works on AARCH64 builds.
> Also note that the edk2-non-osi repository needs to be listed in the
> PACKAGES_PATH
Fix the 1nd issue mentioned in
https://bugzilla.tianocore.org/show_bug.cgi?id=1525
Update the ESRT entry with the last attempt status and last attempt
version from the first FMP instance whose last attempt status is not
SUCCESS. If all FMP instances are SUCCESS, then set last attempt version
to
47 matches
Mail list logo
