On 06/28/19 08:47, Ni, Ray wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1946
>
> The patch changes SMM environment to use 5 level paging when CPU
> supports it.
>
> Signed-off-by: Ray Ni
> Cc: Eric Dong
> ---
> .../PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 20 +-
>
On 06/28/19 05:57, Gao, Zhichao wrote:
> Adjust the code style for better view.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Signed-off-by: Zhichao Gao
> ---
> MdePkg/Library/BaseLib/String.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
Sorry about sending individual
On 06/28/19 05:57, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
>
> While the convertion Base64 ascii string is null string (the
> string only contain white space would be regard as null string),
> there would be no decodeable data. Set *DestinationSize to zero
>
Xiaoyu:
This is a new module type. Please submit BZ for INF spec update first.
And, also submit BZ for code change. In BZ, please specify this type usage
model.
Thanks
Liming
>-Original Message-
>From: Lu, XiaoyuX
>Sent: Monday, July 01, 2019 6:13 PM
>To: devel@edk2.groups.io
>Cc:
In XenBusDxe, the XenBusAddDevice() opens the gXenIoProtocolGuid on
behalf of child controllers. It is never closed and prevents us from
uninstalling the protocol.
Close it where we stop all the children in XenBusDxe->Stop().
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
On 06/28/19 05:57, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
>
> DestinationSize is decripted as 'Set to bytes stored on return'.
> Before return the status, set its converted bytes to be complied
> to the decriptions.
> DestinationIndex may be overflow if the
On 06/28/19 05:57, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
>
> Adjust the coding style.
> Set DestinationSize before return.
> Add addition decription for the RETURN_SUCCESS case.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Marvin Hauser
> Cc: Laszlo
On Sun, Jun 30, 2019 at 12:56:57PM +0200, Laszlo Ersek wrote:
> (5) Side remark (no need to do anything about it in the scope of this
> patch): I think the DisconnectController() call in
> XenBusDxeDriverBindingStop() is superfluous. That kind of disconnection
> is not the job of
REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=1847)
FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=1848)
Changes are committed in forked repository:
https://github.com/shenglei10/edk2/commits/movetool
FCE & FMMT tools are in https://firmware.intel.com/develop
Intel UEFI tools
I have to revise my previous R-b for this patch. The patch is not wrong,
but it's not complete:
On 06/28/19 05:57, Gao, Zhichao wrote:
> Adjust the code style for better view.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Signed-off-by: Zhichao Gao
> ---
> MdePkg/Library/BaseLib/String.c | 12
This issue happens when using Structured PCD.
Build tool use set to store the cflags for compile PcdValueInit.c,
that is the order of cflags is disorder.
This patch make -U, /U flags appear before -D, /D
Cc: Liming Gao
Signed-off-by: Bob Feng
---
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Monday, July 01, 2019 3:10 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [PATCH] Silicon/Tools: Replace white spaces with tabs in
>GNUmakefile
>
>The tools can't be complied successfully
From: Jiewen Yao
It can be used to indicate a module can be build to run
as OS application and run in OS environment.
Cc: Bob Feng
Cc: Liming Gao
Cc: Jiewen Yao
Signed-off-by: Xiaoyu Lu
---
BaseTools/Conf/build_rule.template| 2 +-
BaseTools/Source/Python/AutoGen/AutoGen.py
Calling DisconnectController() on children isn't part of the job of
EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
resources allocated in Start(). The disconnection will happen when
both DevicePath and XenBus protocols gets uninstalled.
Reported-by: Laszlo Ersek
Signed-off-by:
For the second issue, you have to set the NASM_PREFIX to a path which ends with
a slash.
For the first one, could you provide the steps to reproduce it?
Thanks,
Bob
From: Ni, Ray
Sent: Sunday, June 30, 2019 9:23 PM
To: Feng, Bob C
Cc: 戴，曉政 ; Justen, Jordan L
; af...@apple.com;
On 07/01/19 13:14, Anthony PERARD wrote:
> Calling DisconnectController() on children isn't part of the job of
> EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
> resources allocated in Start(). The disconnection will happen when
> both DevicePath and XenBus protocols gets
On 07/01/19 12:50, Anthony PERARD wrote:
> In XenBusDxe, the XenBusAddDevice() opens the gXenIoProtocolGuid on
> behalf of child controllers. It is never closed and prevents us from
> uninstalling the protocol.
>
> Close it where we stop all the children in XenBusDxe->Stop().
>
> Signed-off-by:
On 07/01/19 13:14, Anthony PERARD wrote:
> Calling DisconnectController() on children isn't part of the job of
> EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate
> resources allocated in Start(). The disconnection will happen when
> both DevicePath and XenBus protocols gets
I have created a branch in my fork edk2-staging
(https://github.com/xiaoyuxlu/edk2-staging/tree/edk2-host-test).
Edk2-host-test is separated from
https://github.com/tianocore/edk2-staging/tree/HBFA. You can refer this for
detail:
Hi Gary,
I recommend you rebase on top of this series.
I have verified Linux boots and I have been working
on the GCC and Linux build scripts as well.
Please let me know if you see any issues with this
series applied and I can help get them fixed.
Thanks,
Mike
> -Original Message-
>
From: "Fan, Zhiju"
The env file content can not be retrieved by using the
original method, so we change the way to read the content.
And we change the env file to original format.
This patch is going to fix the issue.
Cc: Liming Gao
Cc: Bob Feng
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc:
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject: [edk2-devel] [edk2-platforms Patch 1/4]
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
Platform/Intel/QuarkPlatformPkg/Quark.dsc| 8
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
* Add SMRAM Memory Reserve GUID to QuarkSocPkg
* Add SMM ICHN Dispatch Protocol to QuarkSocPkg
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
.../Include/Guid/SmramMemoryReserve.h | 54 ++
.../Include/Protocol/SmmIchnDispatch.h
Adjust size of bins in Memory Type Information HOB to eliminate
extra reboot after first boot.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Ray Ni
Cc: Kelly Steele
Signed-off-by: Michael D Kinney
---
.../Platform/Pei/PlatformInit/MrcWrapper.h | 9 -
1 file changed, 4
Hao:
I am OK for this change. Reviewed-by: Liming Gao
Please submit this patch until all platforms have been updated to drop the
dependency of IntelFramework[Module]Pkg.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
Reviewed-by: Ray Ni
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject: [edk2-platforms Patch 2/4] QuarkSocPkg: Remove Intel Framework
> dependencies
>
> *
Patch is attached from group.io.
Since ECR785, which is added UEFI 2.3.1 errata A, enrolling a PK in setup mode
doesn't need to verify the PK.
Below is the sentence about it in UEFI spec
```
3. If the firmware is in setup mode and the variable is one of:
- The global PK variable;
- The global KEK
OK. Got it.
Series: Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Monday, July 1, 2019 3:29 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: nd
> Subject: RE: [edk2-devel] [PATCH v1 1/4] ShellPkg:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1953
For commit 63f9b9b9312f3e08c92a2ea3cdbe01e723ef653b, the use of module
EmulatorPkg/MiscSubClassPlatformDxe/MiscSubClassDriver.inf
was replaced by:
EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
in platform DSC/FDF files.
This commit
Mike,
I gave the R-b and pushed all 4 patches.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject:
Reviewed-By: Zailiang Sun
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject: [edk2-platforms Patch 4/4] QuarkPkatformPkg: Update
> MemoryTypeInformation to
Reviewed-By: Zailiang Sun
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject: [edk2-platforms Patch 1/4] QuarkPlatformPkg: Update network
> library mappings
Hello all,
So far, this RFC series has received the below feedbacks:
* Ack tag from Laszlo Ersek:
https://edk2.groups.io/g/devel/message/42382
* Reviewed-by tag from Liming Gao:
https://edk2.groups.io/g/devel/message/43144
Also, the latest status is that all the known platforms/packages
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Tuesday, July 2, 2019 7:01 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ; Ni,
> Ray ; Steele, Kelly
> Subject: [edk2-devel] [edk2-platforms Patch 4/4]
Reviewed-by: Ray Ni
Because this patch doesn't cause any functionality issue (removing an unused
module),
I pushed the patch directly.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Tuesday, July 2, 2019 10:31 AM
> To: devel@edk2.groups.io
> Cc: Wu,
https://bugzilla.tianocore.org/show_bug.cgi?id=1930
Updated FSP Python script to support both 2.x and
3.x.
Test:
. Verified with Python 2.7.12 and 3.6.6.
. Verified tool result is the same before the change.
. Both py -2 and py -3 built binary can boot.
Cc: Michael Kubacki
Cc: Nate
https://bugzilla.tianocore.org/show_bug.cgi?id=1930
Updated FSP Python scripts to support both 2.x and
3.x.
Test:
. Verified with Python 2.7.12 and 3.6.6.
. Verified tool result is the same before the change.
. Both py -2 and py -3 built binary can boot.
Cc: Maurice Ma
Cc: Nate DeSimone
The tools can't be complied successfully because of the white spaces
in GNUmakefile. So replace them with tabs.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Silicon/Intel/Tools/GNUmakefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi Zhichao,
Thank you for the review. You can see my responses in line with your comments
marked with [Krzysztof]
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
Groups.Io
Sent: Monday, July 1, 2019 4:49
To: Krzysztof Koch ;
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, June 18, 2019 10:28 AM
> To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; Javeed, Ashraf
> Cc: Wang, Jian J
> Subject: RE: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
>
> > -Original
Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Monday, July 1, 2019 2:20 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSP Python scripts to support 3.x.
42 matches
Mail list logo
