On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock@intel.com wrote:
> From: "Tien Hock, Loh"
>
> Changelog:
> v3:
> * Fix an issue in NonDiscoverableDeviceDxe driver where it did not
> invalidate
> cache before copying the memory.
> v2:
> *Split DwMmcHcDxe driver into two patches.
Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, July 24, 2019 3:07 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch v3 6/6] UefiCpuPkg/RegisterCpuFeaturesLib: Start all
> processors
On Thu, Jul 25, 2019 at 11:08:29AM +0200, Roger Pau Monné wrote:
> On Wed, Jul 24, 2019 at 05:17:59PM +0100, Anthony PERARD wrote:
> > On Tue, Jul 23, 2019 at 11:42:07AM +0200, Roger Pau Monné wrote:
> > > On Mon, Jul 22, 2019 at 03:53:19PM +0100, Anthony PERARD wrote:
> > > > On Mon, Jul 15, 2019
With file name changing from Mp2Pei.c to CpuMp2Pei.c, Reviewed-by: Ray Ni
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, July 24, 2019 3:07 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch v3 5/6]
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, July 24, 2019 3:07 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch v3 4/6] UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI
>
> REF:
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dong,
> Eric
> Sent: Wednesday, July 24, 2019 3:07 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [edk2-devel] [Patch v3 3/6]
On Wed, Jul 24, 2019 at 05:17:59PM +0100, Anthony PERARD wrote:
> On Tue, Jul 23, 2019 at 11:42:07AM +0200, Roger Pau Monné wrote:
> > On Mon, Jul 22, 2019 at 03:53:19PM +0100, Anthony PERARD wrote:
> > > On Mon, Jul 15, 2019 at 04:15:21PM +0200, Roger Pau Monné wrote:
> > > > On Thu, Jul 04, 2019
Most functions in FdtDxe currently return VOID and report errors using
only DEBUG. Update functions to return EFI_STATUS and report errors
using Print() so that errors are at least visible in non-debug builds.
Signed-off-by: Michael Brown
---
.../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102
>>> ...would it be worth having a return value here and Print()ing a
>>> message visible regardless of build profile if this function fails?
>>
>> Yes, I think that would be very sensible, but it would also be inconsistent
>> with the rest of the code: all of the other device-tree-modifying
Hi Fan,
On 7/25/19 5:04 AM, Fan, ZhijuX wrote:
> From: Matthew Carlson
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2016
>
> Added arch output to build report so it's easy to tell
> which arch is being generated. Useful when multiple versions
> of a single module is being emitted for
This documents the installation of vanilla Debian 10.0 ARM64 (netinst),
which we validated for both Model B and Model B+.
Also fix an erroneous reference in an RPi3.fdf comment.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
Platform/RaspberryPi/RPi3/Readme.md |
Nit in subject, "BaseTools:Add extra debugging message"
On 7/25/19 5:02 AM, Fan, ZhijuX wrote:
> From: Max Knutsen
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014
>
> Add extra debugging to improve error identification.
> Error while processing file if the file is read incorrectly
>
On Thu, Jul 25, 2019 at 11:05:34AM +0100, Anthony PERARD wrote:
> On Thu, Jul 25, 2019 at 11:08:29AM +0200, Roger Pau Monné wrote:
> > On Wed, Jul 24, 2019 at 05:17:59PM +0100, Anthony PERARD wrote:
> > > On Tue, Jul 23, 2019 at 11:42:07AM +0200, Roger Pau Monné wrote:
> > > > On Mon, Jul 22, 2019
On 7/24/19 11:44 PM, rebe...@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file
Hi Rebecca,
It would be quicker to reply to your series if you use a cover letter.
(I'd have replied "series: Reviewed-by" instead of going thru each patch).
On 7/24/19 11:44 PM, rebe...@bsdio.com wrote:
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 10 +-
> 1 file changed,
On 7/24/19 11:44 PM, rebe...@bsdio.com wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.
Finally :)
Should we also update the wiki documentation?
Reviewed-by: Philippe Mathieu-Daude
>
> Signed-off-by:
On 7/25/19 5:00 AM, Fan, ZhijuX wrote:
> From: Sean Brogan
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013
>
> chinese quotation mark are used in the file
> This patch is going to fix that issue.
>
> Cc: Bob Feng
> Cc: Liming Gao
> Signed-off-by: Zhiju.Fan
> ---
>
On 2019-07-25 05:07, Philippe Mathieu-Daudé wrote:
> It would be quicker to reply to your series if you use a cover letter.
> (I'd have replied "series: Reviewed-by" instead of going thru each patch).
Thanks, I'll try and remember that in future. I'm still learning how
best to send patches using
On Wed, Jul 24, 2019 at 10:43:42PM +0100, Leif Lindholm wrote:
> On Wed, Jul 24, 2019 at 09:53:00PM +0100, Michael Brown wrote:
> > On 24/07/2019 19:53, Leif Lindholm wrote:
> > > > SanitizePSCI ();
> > > > CleanMemoryNodes ();
> > > > CleanSimpleFramebuffer ();
> > > > +
On 7/25/19 2:45 PM, rebe...@bsdio.com wrote:
> On 2019-07-25 05:07, Philippe Mathieu-Daudé wrote:
>> It would be quicker to reply to your series if you use a cover letter.
>> (I'd have replied "series: Reviewed-by" instead of going thru each patch).
>
> Thanks, I'll try and remember that in
Ashraf:
These two protocols are new added. They are not defined in current PI spec.
Can you update file header to remove below comments?
> + This Protocol is defined in UEFI Platform Initialization Specification 1.2
> + Volume 5: Standards
Thanks
Liming
> -Original Message-
>
Sure Liming!
Thanks
Ashraf
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, July 25, 2019 7:15 PM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Kinney, Michael D ; Ni, Ray
>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH]
> MdePkg/Protocols: New
I agree the structure update in PciExpress21.h. I also see some new macro
definitions. Can they be added to PciExpress40.h, for example:
#define PCIE_MAX_PAYLOAD_SIZE_128B 0
#define PCIE_MAX_PAYLOAD_SIZE_256B 1
#define PCIE_MAX_PAYLOAD_SIZE_512B 2
#define PCIE_MAX_PAYLOAD_SIZE_1024B 3
That make sense. In the commit message, can you update the message to describe
which change bases on PCI Express Base Specification Revision 4.0?
Thanks
Liming
> -Original Message-
> From: Javeed, Ashraf
> Sent: Thursday, July 25, 2019 11:30 PM
> To: Gao, Liming ; devel@edk2.groups.io
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954
In V2: Correction made to header sections of source files
New interface added to PCI Platform Protocol / PCI Override Protocol to
retrieve device-specific platform policy for the following PCI standard
features, like Maximum Payload Size
Sending a v2 that fixes a few typos:
"In that is the case" -> "If that is the case"
"that you can safely ignore it by selecting" -> "that you can safely ignore by
selecting"
"prevents the same partition to be remounted" -> "prevents the same partition
from being remounted"
Pete Batard (1):
This documents the installation of vanilla Debian 10.0 ARM64 (netinst),
which we validated for both Model B and Model B+.
Also fix an erroneous reference in an RPi3.fdf comment.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
Platform/RaspberryPi/RPi3/Readme.md |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2018
Current FSP SEC_IDT_TABLE structure is not natural aligned:
typedef struct _SEC_IDT_TABLE {
EFI_PEI_SERVICES *PeiService;
UINT64IdtTable[];
} SEC_IDT_TABLE;
Compiler will insert DWORD padding between 2 elements and
Ashraf:
So, those update base on PCI Express Base Specification Revision 4.0. If new
definitions are in version 4.0, they can be added into PciExpress40.h. If the
existing structure is extended, they can be kept in PciExpress21.h.
Thanks
Liming
> -Original Message-
> From: Javeed,
V2 is still full patch. It is not the change delta since the first patch. If
this patch pass review, it will push. The final push patch should be same to
the reviewed patch.
Thanks
Liming
> -Original Message-
> From: Javeed, Ashraf
> Sent: Thursday, July 25, 2019 11:42 PM
> To: Gao,
On 2019-07-24 10:53, Michael D Kinney wrote:
> Rebecca,
>
> If you are interested, I prototyped using a python
> script and POSTBUILD statement in the DSC file to
> support 'run' targets for OVMF in the following
> branch. This potentially allows the same code to
> be used for all host OS
Ray,
I prefer to add a Vendor to the path based
on the vendor who published the specification.
Adding the vendor to the path will allow
include files to be added in the future with
clear names.
The UefiCpuPkg is an example of a poor choice
for the original Cpuid.h file. It should have
been in
Yes. I mean highlight those changes bases on PCI Express Base Specification
Revision 4.0.
Otherwise, I don't know where are they from.
Thanks
Liming
> -Original Message-
> From: Javeed, Ashraf
> Sent: Friday, July 26, 2019 12:05 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Kinney,
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954
New interface added to PCI Platform Protocol / PCI Override Protocol to
retrieve device-specific platform policy for the following PCI standard
features, like Maximum Payload Size (MPS), Maximum Read Request Size
(MRRS),Extended Tags, Relax
On 07/24/19 09:03, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Tuesday, July 23, 2019 5:23 PM
>> To: devel@edk2.groups.io; Ni, Ray
>> Cc: Dong, Eric
>> Subject: Re: [edk2-devel] [PATCH 2/4] UefiCpuPkg/CpuDxe: Support parsing
>> 5-level page table
>>
>> On
From: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
reviewed-by: Amy Chan
---
.../Microcode/MicrocodeUpdates.inf | 1 +
.../Microcode/mC0806E9_0030.mcb | Bin 0 -> 95232 bytes
2 files changed, 1 insertion(+)
create
- Merged Maintainers.txt from devel-MinPlatform branch with
Maintainers.txt in master branch and updated to match the maintainers
in the equivalent edk2-platforms Maintainers.txt
- Removed the old Contributions.txt files
- Updated the Kaby Lake microcode to the new Intel microcode license
While Minimum Platform development has transferred from
devel-MinPlatform branch to master branch on the edk2-platforms
repository, this has not yet occurred on the edk2-non-osi
repository.
This patch series cherry-picks the content from devel-MinPlatform
that has not yet been merged to master
These new macros definitions define PCI attributes which exist in the PCI
Express Base Specification Revision 2.1; hence placing this in the
PciExpress21.h align with the specification revision.
Thanks
Ashraf
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, July 25, 2019 8:05
Ashraf:
V2 is the updated full patch, not patch 2. I think you mean to create single
patch to include all changes instead of create two patches. Right?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Javeed,
> Ashraf
> Sent:
Liming,
The following are the 2 points summarizing the changes as per spec 4, and it is
already part of commit message...
> > > > > The PCIe Device capability register #2
> > > > > (PCI_REG_PCIE_DEVICE_CAPABILITY2) needs to be upgraded for
> > > > > the PCI features like - LN system CLS, 10b
Liming,
The existing structure are extended in PCI Express Base Specification Revision
4; hence I have made the change in PciExpress21.h.
Thanks
Ashraf
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, July 25, 2019 7:35 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc:
Liming,
I meant to create only second patch, I just appended the commit message with
the actual changes details from the previous patch.
> New interface added to PCI Platform Protocol / PCI Override Protocol
> to retrieve device-specific platform policy for the following PCI
> standard
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
The following two PCI Capability Structure registers are updated as per
the PCI Base Specification Revision 4:-
(1) The PCI Device capability register 2(PCI_REG_PCIE_DEVICE_CAPABILITY2)
needs to be upgraded for the PCI features like -
Hi Nate,
On 07/25/19 19:35, Nate DeSimone wrote:
> - Merged Maintainers.txt from devel-MinPlatform branch with
> Maintainers.txt in master branch and updated to match the maintainers
> in the equivalent edk2-platforms Maintainers.txt
>
> - Removed the old Contributions.txt files
>
> -
Please ignore this!
I shall amend the commit message, reformat and send the patch again.
Thanks
Ashraf
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Javeed,
> Ashraf
> Sent: Thursday, July 25, 2019 11:28 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao,
On 07/24/19 19:00, Leif Lindholm wrote:
> On Wed, Jul 24, 2019 at 03:17:56PM +, Gao, Liming wrote:
>>> Would it be feasible to update the --hash functionality to make use of
>>> the include dependencies extracted from the source files? (Clearly, we
>>> know when the source files change, so we
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
The following two PCI Capability Structure registers are updated as per
the PCI Base Specification Revision 4:-
(1) The PCI Device capability register 2(PCI_REG_PCIE_DEVICE_CAPABILITY2)
needs to be upgraded for the PCI features like -
Please ignore this!
Sent the patch with wrong commit message details.
Regards
Ashraf
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Javeed,
> Ashraf
> Sent: Thursday, July 25, 2019 11:47 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ni, Ray ;
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
The PCIe Device capability register #2 (PCI_REG_PCIE_DEVICE_CAPABILITY2)
needs to be upgraded for the PCI features like - LN system CLS, 10b Tag
completer/requester register fields, emergency power reduction support
and initialization
Hi Javeed,
On 07/25/19 20:23, Javeed, Ashraf wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
> The following two PCI Capability Structure registers are updated as per
> the PCI Base Specification Revision 4:-
> (1) The PCI Device capability register
Having the vendor name for cpu may cause confusion to customers.
AMD customer may found even their code is running in AMD processors
Intel/Cpuid.h is still included.
It may also be possible that Intel platform code has to include AMD/Cpuid.h.
The CPU is different from other hardwares. It is ok
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Thursday, 25 July 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/251103409
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=460284 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com
Hello Ashraf,
On 07/25/19 23:20, Laszlo Ersek wrote:
> Hi Javeed,
[...]
Sorry, I didn't mean to address you by surname.
(I find that the comma notation in names is totally useless. Some people
put surname first, some others given name -- same confusion as without
the comma.)
I should have
On 07/24/19 03:51, rebe...@bsdio.com wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/build.sh | 2 +-
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, July 25, 2019 8:51 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: PeiService pointer not reset to 0
in
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, July 26, 2019 1:36 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Laszlo Ersek ; Leif
> Lindholm ; Kinney, Michael D
> ; Kubacki, Michael A
> ; Sinha, Ankit ; Chiu,
> Chasel ; Yao, Jiewen ;
>
*Reminder:* TianoCore Design Meeting - APAC/NAMO
*When:* Thursday, 25 July 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/969264410
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=460287 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Chiu, Chasel
> Sent: Thursday, July 25, 2019 11:51 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: PeiService pointer not
Hi Laszlo,
I understand and I have no issues with it.
Regards
Ashraf
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, July 26, 2019 3:23 AM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ni, Ray ; Wu, Hao A
>
> Subject: Re: [edk2-devel]
Hi Laszlo,
Good catch!
I shall provide patch V2 with the suggested fix.
Everyone,
Any other input with this regard?
Thanks
Ashraf
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, July 26, 2019 2:51 AM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Kinney, Michael D ; Gao,
> -Original Message-
> From: Javeed, Ashraf
> Sent: Friday, July 26, 2019 9:47 AM
> To: Laszlo Ersek; devel@edk2.groups.io
> Cc: Kinney, Michael D; Gao, Liming; Ni, Ray; Wu, Hao A
> Subject: RE: [edk2-devel] [PATCH] MdePkg/PciExpress21.h: Fix the PCIe
> industry standard registers
>
> Hi
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2022
Added arch output to build report so it's easy to tell
which arch is being generated. Code change
https://bugzilla.tianocore.org/show_bug.cgi?id=2016
will be done.The spec change is also required.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by:
Gary,
See my comment below.
> -Original Message-
> From: West, Gary
> Sent: Tuesday, July 23, 2019 8:04 PM
> To: devel@edk2.groups.io
> Cc: West, Gary ; West, Gary ;
> Wang, Jian J ; Ye, Ting
> Subject: [PATCH 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF
> algorithm
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
When driver is unloaded, the ExitBootSerivesEvent must be closed at
the same time. Otherwise exception will occur when ExitBootServices.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Wei6 Xu
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
When driver is unloaded, the ExitBootSerivesEvent must be closed at
the same time. Otherwise exception will occur when ExitBootServices.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Wei6 Xu
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
When driver is unloaded, the ExitBootSerivesEvent must be closed at
the same time. Otherwise exception will occur when ExitBootServices.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Wei6 Xu
---
.../DebugLibConstructor.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
This patch set adds missing destructor for following libraries:
MdePkg\Library\UefiDebugLibStdErr
MdePkg\Library\UefiDebugLibConOut
MdePkg\Library\UefiDebugLibDebugPortProtocol
When driver is unloaded, the ExitBootSerivesEvent must be
68 matches
Mail list logo
