REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
If there are multiple FMP instances for the same GUID,
then merge them together into a single ESRT entry.
Generate DEBUG_ERROR message and ASSERT() if the same
GUID/HardwareInstance is produced by more than one FMP.
Cc: Sean Brogan
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
Update the ESRT entry with the last attempt status and last attempt
version from the first FMP instance whose last attempt status is not
SUCCESS. If all FMP instances are SUCCESS, then set last attempt version
to the smallest value from all
On 07/31/19 10:01, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1982
>
> MpInitLibInitialize in MpLib.c will be invoked on both PEI and DXE
> CPU code, MicrocodeDetect would be performed twice and copy
> Microcode from flash to memory twice as well, which consider as
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
Fix the following issues identified in #1525:
EsrtFmpDxe - The check for more than one instance of the same
GUID/HardwareInstance is not being done at the right point.
It is being done as EFI_FIRMWARE_IMAGE_DESCRIPTORs are being
Multiple Controllers Support solution
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
The patch set is to makes enhancement to the ESRT when multiple
same controllers exist in one system.
Eric Jin (3):
MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT
MdeModulePkg/EsrtFmpDxe:
Until now, during the USB device enumeration when its PortState
USB_PORT_STAT_CONNECTION bit was not set, the stack was not informed
that the device is not present. Fix that by returning appropriate
error code.
Change-Id: I588f82b987993e9755f64ce76cde9eb690ef1d54
Signed-off-by: Marcin Wojtas
---
Push@95fb75883d2917e985f960969f004ea63ad83adf
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, July 29, 2019 3:54 PM
>To: Javeed, Ashraf ; devel@edk2.groups.io
>Cc: Kinney, Michael D ; Ni, Ray
>; Wu, Hao A
>Subject: Re:
Push@d21e5dbbbf11589113d39619b3e01eb1e8966819
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Tuesday, July 30, 2019 11:21 AM
>To: Chen, Marc W ; devel@edk2.groups.io
>Cc: Kinney, Michael D ; Ni, Ray
>
>Subject: Re:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
Current debug message brings much restriction for the platform
which use this driver.
For PEI and DXE phase, platform mush link base DebugLib (without
using any pei/dxe services, even for its dependent libraries).
This patch default
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
Current debug message brings much restriction for the platform
which use this driver.
For PEI and DXE phase, platform mush link base DebugLib (without
using any pei/dxe services, even for its dependent libraries).
This patch default
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
Current debug message brings much restriction for the platform
which use this driver.
For PEI and DXE phase, platform mush link base DebugLib (without
using any pei/dxe services, even for its dependent libraries).
This patch default
Ashraf:
Thanks for your update. The change is good to be added into edk2-staging.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Javeed, Ashraf
>Sent: Wednesday, July 31, 2019 11:59 AM
>To: devel@edk2.groups.io; Javeed, Ashraf
>Cc: Kinney, Michael D ; Gao, Liming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1982
MpInitLibInitialize in MpLib.c will be invoked on both PEI and DXE
CPU code, MicrocodeDetect would be performed twice and copy
Microcode from flash to memory twice as well, which consider as
duplicate work to lead longer boot time.
This
On 07/30/19 17:20, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
>> Sent: Monday, July 29, 2019 7:33 PM
>> To: devel@edk2.groups.io; Ni, Ray
>> Subject: Re: [edk2-devel] [PATCH 1/3] UefiCpuPkg/PiSmmCpu: Add Internal
>> function
On 7/31/19 7:52 AM, Bob Feng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
>
> The WorkspaceAutoGen.__InitWorker function is too long, it's hard
> to read and understand.
> This patch is to separate the __InitWorker into multiple small ones.
>
> Cc: Liming Gao
>
On 07/31/19 08:25, Marcin Wojtas wrote:
> Until now, during the USB device enumeration when its PortState
> USB_PORT_STAT_CONNECTION bit was not set, the stack was not informed
> that the device is not present. Fix that by returning appropriate
> error code.
>
> Change-Id:
thanks laszlo, for the detail review
I have not gone through every line of code in detail. Some comment in general.
To answer Laszlo’s question on Mmio.
No, the Mmio cannot be used as communication buffer. But the smm must setup
page table for it because the smm device driver may need access
Hi Jiewen,
>
> I agree that we only need support #2 and #3.
>
> We need one PCD:
> 1) if it is set to TRUE, it locks SMM paging (make it static), only allows
> SMM access RSVD, ACPINVS, Runtime, as comm buffer,
> plus MMIO for device access. That is secure configuration.
> 2) it is FALSE, it
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
To support Ctrl+S and Ctrl+Q, we enable block queue
for log.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 6 ++-
BaseTools/Source/Python/Common/EdkLogger.py | 10 +++--
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The build config files are target.txt, build rule, tooldef
During a build, the config is not changed, so the object to
handle them need to be singleton.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
In order to improve the build performance, we implemented
multiple-processes AutoGen. This change will reduce 20% time
for AutoGen phase.
The design document can be got from:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Assign the Module AutoGen tasks into multiple
sub process.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 192 ++
BaseTools/Source/Python/AutoGen/DataPipe.py | 17 +-
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
python3 change the module name of Queue to queue.
python3 add a new log handler of QueueHandler.
This patch is to make Multiple process AutoGen
feature work for python2
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Add shared data for autogen processes.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++-
BaseTools/Source/Python/build/build.py | 10 ++
2 files changed, 8
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
AutoGen processes race the logfile. To resolve this issue,
this patch create a LogAgent thread in main process to write
the log content to console or file, Other process will send
the log content to the LogAgent.
Cc: Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The WorkspaceAutoGen.__InitWorker function is too long, it's hard
to read and understand.
This patch is to separate the __InitWorker into multiple small ones.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Build tool supports user to specify the conf folder.
To make the build options be evaluated at the beginning
of launching build, extract the buildoption function
from build.py to a new .py file.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
These functions are used for get platform scope
build options. They will be used in later patches.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-
On 08/01/19 01:13, Laszlo Ersek wrote:
> Hi Ray, Jiewen,
>
> I've got several comments / questions:
>
> On 07/31/19 18:38, Ni, Ray wrote:
>> This patch skips to update page table for non-SMRAM memory when
>> PcdCpuSmmAccessOut is TRUE.
>> So that when SMM accesses out, no page fault is triggered
On Wed, Jul 31, 2019 at 11:58 AM, Laszlo Ersek wrote:
>
> I'm sure I'm misremembering parts of this story (from several years
> distance), the moral is that debugging in a multiprocessing environment
> may easily require its own dedicated infrastructure. In edk2, we don't
> have anything like
Mike,
Thanks for the time for offline discussion.
I agree with the idea to have an Intel/Cpuid.h in MdePkg/Include/Register/
directory.
Do you prefer to move Amd/Cpuid.h to MdePkg/Include/Register/ in my V3 patch?
Thanks,
Ray
> -Original Message-
> From: Kinney, Michael D
> Sent:
Hi Mike,
Thanks for your comments. Actually this patch is the change under edk2-non-osi,
but I use wrong name(edk2-platforms) for it.
I will contact Lan driver team for license file.
Thanks
David
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, July 31, 2019 1:36 PM
To:
Hi Ray, Jiewen,
I've got several comments / questions:
On 07/31/19 18:38, Ni, Ray wrote:
> This patch skips to update page table for non-SMRAM memory when
> PcdCpuSmmAccessOut is TRUE.
> So that when SMM accesses out, no page fault is triggered at all.
>
> Signed-off-by: Ray Ni
> Cc: Eric Dong
On 08/01/19 01:46, Laszlo Ersek wrote:
> So ultimately, I would argue for the following patch series:
>
> - patch#1: Revert commit c60d36b4, and explain why, in the commit
> message.
>
> - patch#2: Introduce the new PCD, also mentioning MMIO.
>
> - Patch#3: modify *all* of the following
> Below is my thought, please correct if I am wrong.
> 1) StaticPaging=false, AccessOut=false: it seems invalid. If we don’t support
> access out, why we need dynamic paging?
> 2) StaticPaging=false, AccessOut=true: it seems valid. We need access out,
> but we only want a small paging in the
Pushed at
58cc0ffe68e249ffcc73ee3d8e2120be27793f28..05f8e85fa7d83222310e471c9a43a6d2ab532c95
Thanks,
Zhichao
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, July 29, 2019 2:30 PM
> To: devel@edk2.groups.io; 'krzysztof.k...@arm.com'
>
> Cc: Carsey, Jaben ; Ni, Ray ; nd
>
>
SmmAccessOut = SMM access memory outside SMRAM.
So, do we want to treat SMM access ACPI NVS, RSVD, Runtime, MMIO, to be
SmmAccessOut?
Thank you
Yao Jiewen
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, August 1, 2019 10:24 AM
> To: Yao, Jiewen ; devel@edk2.groups.io;
>
On 07/31/19 16:59, Eric Jin wrote:
> Multiple Controllers Support solution
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525
>
> The patch set is to makes enhancement to the ESRT when multiple
> same controllers exist in one system.
>
> Eric Jin (3):
> MdeModulePkg/EsrtFmpDxe:
On 07/31/19 18:38, Ni, Ray wrote:
> There is a requirement to allow SMM code access non-SMRAM memory
> after ReadyToLock.
> The requirement was expected to be satisfied by commit:
> c60d36b4d1ee1f69b7cca897d3621dfa951895c2
> * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used
>
I agree that we only need support #2 and #3.
We need one PCD:
1) if it is set to TRUE, it locks SMM paging (make it static), only allows SMM
access RSVD, ACPINVS, Runtime, as comm buffer, plus MMIO for device access.
That is secure configuration.
2) it is FALSE, it allows SMM to access OS
On 07/31/19 18:34, Brian J. Johnson wrote:
> I do wonder if there would be a clean way to let a DebugLib instance
> itself declare that AP_DEBUG() is safe. That way a platform would
> only need to override the DebugLib instance in the DSC file, rather
> than both the instance and the PCD. (I
Reviewed-by: Ankit Sinha
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
Chasel
Sent: Monday, July 29, 2019 4:07 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel] [PATCH 2/4]
Reviewed-by: Ankit Sinha
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
Chasel
Sent: Monday, July 29, 2019 4:07 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel] [PATCH 1/4]
On 7/31/19 7:43 AM, Laszlo Ersek wrote:
(adding Mike)
On 07/31/19 09:35, Eric Dong wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
Current debug message brings much restriction for the platform
which use this driver.
For PEI and DXE phase, platform mush link base DebugLib
> On Jul 31, 2019, at 9:34 AM, Brian J. Johnson wrote:
>
> On 7/31/19 7:43 AM, Laszlo Ersek wrote:
>> (adding Mike)
>> On 07/31/19 09:35, Eric Dong wrote:
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
>>>
>>> Current debug message brings much restriction for the platform
>>>
Add UNDI option ROM to provide the support for SIMICS quick start platform.
it uses X58/ICH10 and emulated by SIMICS model.
David Wei (1):
SimicsICH10SiliconBinPkg Add UNDI ROM for QSP
.../SimicsICH10SiliconBinPkg/UndiBinary/E0024X7.efi| Bin 0 -> 321184 bytes
1 file changed, 0
Hi David,
We should not put binaries into edk2-platforms repo.
We have the edk2-non-osi repo for binaries. Also,
binaries should have their own license file.
Best regards,
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of David Wei
Hi Laszlo,
I agree with your points of creating a new PCD.
It also reduces confusions. I just posted V2 patch. Please help to review.
Thanks,
Ray
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44689):
Reviewed-by: Ankit Sinha
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
Chasel
Sent: Monday, July 29, 2019 4:07 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel] [PATCH 3/4]
Reviewed-by: Ankit Sinha
-Original Message-
From: Chiu, Chasel
Sent: Monday, July 29, 2019 4:07 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Sinha, Ankit
; Desimone, Nathaniel L
; Gao, Liming
Subject: [PATCH 4/4] ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
REF:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804
The check to see if [Sources] section lists all the header type
files of a module is missing the exclusion of source files that
fall under the scope of Package includes. This change adds the
exclusions.
Signed-off-by: Christian Rodriguez
Ray Ni (2):
UefiCpuPkg: Add PCD PcdCpuSmmAccessOut to control SMM access out
UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 21 +
UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c| 2 +-
There is a requirement to allow SMM code access non-SMRAM memory
after ReadyToLock.
The requirement was expected to be satisfied by commit:
c60d36b4d1ee1f69b7cca897d3621dfa951895c2
* UefiCpuPkg/SmmCpu: Block access-out only when static paging is used
Commit c60d36b4 re-interpreted the
Marcin,
What does the failure look like without your fix?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Marcin Wojtas
> Sent: Wednesday, July 31, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org;
(adding Mike)
On 07/31/19 09:35, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
>
> Current debug message brings much restriction for the platform
> which use this driver.
>
> For PEI and DXE phase, platform mush link base DebugLib (without
> using any pei/dxe
Hi Phil,
I double checked your previous mail. I missed your comments inside the patch
content then. Sorry.
Platform.Pcds
Yes, this statement looks odd, but it's not an incorrect copy/paste. I think
the basetools code style is tend to lazy-evaluation, which means the Pcds will
be evaluated
56 matches
Mail list logo
