Yes. I was able to test Linux boots. I32 and X64.
Mike
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Jordan Justen
> Sent: Friday, August 9, 2019 4:08 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Andrew Fish ; Ni, Ray
>
>
Two patches looks fine for me.
For both,
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric Jin
Sent: Wednesday, August 7, 2019 5:08 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH 0/2] Enable Windows Firmware
Hi Leif,
czw., 8 sie 2019 o 19:53 Leif Lindholm napisał(a):
>
> On Thu, Aug 08, 2019 at 07:05:29PM +0200, Marcin Wojtas wrote:
> > > On a higher level, I confess to not being entirely convinced about the
> > > triplicate .dsc/.dsc.inc/.fdf.inc setup. (Of the three, the .dsc.inc
> > > is the one
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which detect current value before set new value.
Only set new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
---
.../CpuFeaturesInitialize.c |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Add below new micros which test the current value before set
the new value. Only set new value when current value not
same as new value.
CPU_REGISTER_TABLE_TEST_THEN_WRITE32
CPU_REGISTER_TABLE_TEST_THEN_WRITE64
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which detect current value before set new value.
Only set new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 135
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
Bits.Lock,
1
);
}
With below steps, the
Hi,
Please ignore this series. I have used wrong branch when generating patches. V3
will contain the fixes.
Thanks,
Mateusz
> -Original Message-
> From: Albecki, Mateusz
> Sent: Friday, August 9, 2019 2:21 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz ; Wu, Hao A
>
> Subject:
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
UfsExecUicCommand function has been refactored to allow
the caller to check the command results which is important
for commands such as UIC read.
Cc: Hao A Wu
Signed-off-by: Mateusz Albecki
---
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
EDKII_UFS_HC_PLATFORM_PROTOCOL will allow the platform to inject
platform specific logic into standard UFS flows. Right now we
support callbacks pre and post host controller enable and pre
and post link startup. Provided callbacks allow the
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
This commit adds EDKII_UFS_HC_PLATFORM_PROTOCOL implementation
in UfsPassThruDxe driver in version 1. Driver assumes that at
most one instance of the protocol exists in the system. Presence
of the protocol is not mandatory.
Cc: Hao A Wu
To cover additional host controller programming mentioned in the UFS
specification we have added an additional protocol that allows the UEFI driver
to give control to platform driver. This allows the platform to perform any
additional steps needed for the stable operation.
Changes in v3:
- UFS
Sure. Thanks Laszlo for your clarification.
-Bob
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, August 9, 2019 8:55 PM
To: Feng, Bob C ; Gao, Liming ;
devel@edk2.groups.io; leif.lindh...@linaro.org
Cc: Andrew Fish ; Kinney, Michael D
Subject: Re:
Leif:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Friday, August 9, 2019 9:29 PM
> To: Laszlo Ersek
> Cc: Feng, Bob C ; Gao, Liming ;
> devel@edk2.groups.io; Andrew Fish ;
> Kinney, Michael D
> Subject: Re:
On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote:
> On 08/09/19 03:37, Feng, Bob C wrote:
> > Thanks for your response.
> >
> > I'm going to push this patch set late today, if there is no more comments.
>
> Sorry, I have to disagree about that. There is a NACK standing from Leif
> --
Leif:
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Thursday, August 8, 2019 10:52 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A
> ; Cinnamon Shia
> ; af...@apple.com; Laszlo Ersek (ler...@redhat.com)
> ; Kinney,
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
Private data has been refactored to use EDKII_UFS_HC_INFO structure
to store host controller capabilities and version
information. Getting host controller data has been moved
into single place and is done before host controller enable.
Cc: Hao
On Fri, Aug 09, 2019 at 12:16:24AM +0100, Michael Brown wrote:
> On 06/08/2019 18:07, Leif Lindholm wrote:
> > Happy with all of this, except for the use of EFI_DEVICE_ERROR.
> >
> > Generally, EFI_DEVICE_ERROR is used as an i/o error type status.
> > Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER
Hi Tien Hock,
Given Mike's review, could you roll a v7 with all of the incorporated
feedback from Mike based on this (instead of submitting the v6 updates
as a separate patch, which I previously requested)?
Could you also roll in the following in that patch?:
diff --git a/Maintainers.txt
On Thu, Aug 08, 2019 at 02:30:48PM -0700, Nate DeSimone wrote:
> Updated Platform/Intel/Readme.md to point to master branch on
> edk2-non-osi instead of devel-MinPlatform
>
> Updated edk2-platforms/Readme.md to point to Platform/Intel/Readme.md
> for build instructions on Intel based Minimum
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
This commit adds EDKII_UFS_HC_PLATFORM_PROTOCOL implementation
in UfsPassThruDxe driver in version 1. Driver assumes that at
most one instance of the protocol exists in the system. Presence
of the protocol is not mandatory.
Cc: Hao A Wu
Thanks Evelyn
Comments below:
1) The EFIAPI is missing in library API. Please follow EDKII coding standard.
==
UINTN
GetGlobalVtdPmrAlignment (
);
==
Should be:
==
UINTN
EFIAPI
GetGlobalVtdPmrAlignment (
VOID
);
==
2) Because you added a new
Hi,
We also implement capsules to update optionROMs that use an embedded
driver in the capsule. The main reason for us is space - crypto library
is too large to fit into our flash so we don't provide fully functional
FMP in the optionROM driver, only a stub FMP that is enough to populate
the
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
Private data has been refactored to use EDKII_UFS_HC_INFO structure
to store host controller capabilities and version
information. Getting host controller data has been moved
into single place and is done before host controller enable.
Cc: Hao
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
EDKII_UFS_HC_PLATFORM_PROTOCOL will allow the platform to inject
platform specific logic into standard UFS flows. Right now we
support callbacks pre and post host controller enable and pre
and post link startup. We also allow the platform to
https://bugzilla.tianocore.org/show_bug.cgi?id=1343
UfsExecUicCommand function has been refactored to allow
the caller to check the command results which is important
for commands such as UIC read.
Cc: Hao A Wu
Signed-off-by: Mateusz Albecki
---
To cover additional host controller programming mentioned in the UFS
specification we have added an additional protocol
that allows the UEFI driver to give control to platform driver. This allows the
platform to perform any additional
steps needed for the stable operation.
Changes in v2:
- UFS
On 08/09/19 03:37, Feng, Bob C wrote:
> Thanks for your response.
>
> I'm going to push this patch set late today, if there is no more comments.
Sorry, I have to disagree about that. There is a NACK standing from Leif
-- he will have to rescind that NACK explicitly, for you to push the series.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1775
Removed batch build scripts as they are replaced
by build_bios.py
Signed-off-by: Agyeman
---
.../ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat | 79 ---
.../Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat| 159 -
Thanks Leif, I'll push the patches.
I file a BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2072 for the --hash
issue.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
Lindholm
Sent: Friday, August 9, 2019 9:29 PM
To: Laszlo
On 08/09/19 08:11, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
>
> Add below new micros which test the current value before set
> the new value. Only set new value when current value not
> same as new value.
> CPU_REGISTER_TABLE_TEST_THEN_WRITE32
>
On 08/09/19 08:11, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
>
> Supports new logic which detect current value before set new value.
> Only set new value when current value not same as new value.
>
> Signed-off-by: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
>
On Thu, Aug 08, 2019 at 07:39:14PM +0200, Laszlo Ersek wrote:
> On 08/07/19 19:41, Andrew Fish wrote:
> >> On Aug 7, 2019, at 10:29 AM, Laszlo Ersek wrote:
> >> ummm... not sure why, but I never got this email in my inbox. I only see
> >> it in my list folder. I see myself addressed on it as:
>
On Fri, Aug 09, 2019 at 02:54:28PM +, Gao, Liming wrote:
> > Thank you for the clarification, Laszlo.
> >
> > I would say this makes a fix for the --hash issue a hard requirement
> > for the stable tag.
>
> If --hash issue is the regression issue caused by this patch set, I agree it
> must
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nate DeSimone
> Sent: Thursday, August 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
>
> Subject: [edk2-devel]
Hi Gary,
I found that the regression was introduced at commit
https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
The issue is in Vlv2Tbl2DevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
The call to SetupInfo() was inadvertently removed from
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, August 7, 2019 10:56 PM
> To: devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Justen, Jordan L ; Andrew
> Fish ; Ni, Ray
> Subject: RE: [edk2-devel] [Patch V2 3/3] EmulatorPkg:
> Add -D DISABLE_NEW_DEPRECATED_INTERFACES
>
> Hello
Hi Mike,
I re-sent the patch to add the IntelProprietaryLicense.txt.
Thanks
David
-Original Message-
From: Kinney, Michael D
Sent: Friday, August 9, 2019 3:54 PM
To: devel@edk2.groups.io; Wei, David Y ; Kinney, Michael
D
Subject: RE: [edk2-devel] [edk2-non-osi patch 0/1] Add UNDI ROM
Add UNDI option ROM for SIMICS QSP Network support
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
.../UndiBinary/GigUndiDxe.efi
New in V3
==
* Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c
* Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c
* Add NOOPT build target to DSC file.
New in V2
=
* Fix size values in safe string function calls.
* Update POSIX sources to
https://bugzilla.tianocore.org/show_bug.cgi?id=162
Update EmulatorPkg specific modules and libraries to use
safe string functions in BaseLib and safe PcdSetxx()
functions in PcdLib. With these updates, the define
DISABLE_NEW_DEPRECATED_INTERFACES is enabled in the DSC
file.
Cc: Jordan Justen
Add NOOPT to BUILD_TARGETS in DSC file.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
Remove the use of the defines UNIX_SEC_BUILD and
WIN_SEC_BUILD. This simplifies the build command
for the EmulatorPkg. Instead, use !if statements
in the DSC file using $(ARCH) and $(FAMILY) to
determine if the build is for a Windows or POSIX
https://bugzilla.tianocore.org/show_bug.cgi?id=2056
The IA32 build of the EmulatorPkg for VS20xx does not boot
because the default value of PCD PcdPeiServicesTablePage
rarely succeeds to be mapped on IA32 Windows Host Environments.
Change the DEC default value for this PCD to a value that
is
On 2019-08-09 15:44:01, Michael D Kinney wrote:
> New in V3
> ==
> * Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c
> * Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c
> * Add NOOPT build target to DSC file.
>
> New in V2
> =
> * Fix size
Add UNDI option ROM for SIMICS QSP Network support
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
Add UNDI option ROM to provide the support for SIMICS quick start platform.
it uses X58/ICH10 and emulated by SIMICS model.
David Wei (1):
SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform
Silicon/Intel/SimicsICH10SiliconBinPkg/License.txt | 30 ++
VS2017 builds for X64 are failing due to the use of the
memset intrinsic. The local variable GopVersion is an
array that is initialied in the declaration. Update to
use ZeroMem() to intialize GopVersion.
Cc: Zailiang Sun
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Create the SimicsOpenBoardPkg and its silicon Pkg to provide the support
for SIMICS quick start platform. it uses X58/ICH10 and emulated by SIMICS
model.
David Wei (7):
SimicsX58SktPkg: Add CPU Pkg for SimicsX58
SimicsICH10Pkg: Add PCH Pkg for SimicsICH10
SimicsOpenBoardPkg: Add
Add BoardX58ICH10 module for QSP Build tip
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
Add DXE driver for Legacy Sio support
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
.../LegacySioDxe/ComponentName.c
Add CPU Pkg for SimicsX58. It is added for simics QSP project support
Cc: Hao Wu
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: David Wei
---
Hi Liming
Since the SmmAccess.h of MdeModulePkg removal is still under discussion, can we
push the MmAccess.h and MmControl.h to MdePkg first? I have other tasks pending
by this.
We can keep discussing the SmmAccess after push the code.
Thanks,
Marc
> -Original Message-
> From:
The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig(). This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.
David,
The file License.txt make a reference to the file
IntelProprietaryLicense.txt, but I do not see that
file in this patchset.
For example, the content in Silicon/Intel/QuarkSocBinPkg
has a License.txt file and the content in the path
56 matches
Mail list logo
