Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-14 Thread Liming Gao
Eric: Is this a bug fix or new feature? Dose it catch to this 201908 stable tag? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Dong, Eric >Sent: Tuesday, August 13, 2019 10:29 AM >To: devel@edk2.groups.io; ler...@redhat.com

[edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Zhang, Shenglei
Initialize PageMapLevel5Entry at the beginning of the function. This commit will fix a GCC 4.8.5 build failure introduced by commit b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version. The commit

Re: [edk2-devel] [Patch v2 0/6] Add "test then write" mechanism.

2019-08-14 Thread Dong, Eric
Hi liming, This is a bug fix. It is required by 201908 stable tag. Thanks, Eric > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 14, 2019 3:27 PM > To: devel@edk2.groups.io; Dong, Eric ; > ler...@redhat.com > Cc: Ni, Ray ; leif.lindh...@linaro.org; af...@apple.com; >

[edk2-devel] [PATCH v3 2/2] CryptoPkg/OpensslLib: remove clone commands

2019-08-14 Thread Wang, Jian J
https://bugzilla.tianocore.org/show_bug.cgi?id=1910 edk2/Readme.md has added a section to explain the correct clone commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt are removed to avoid any inconsistency. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by:

[edk2-devel] [PATCH v3 0/2] Add edk2 submodule policy

2019-08-14 Thread Wang, Jian J
>v3 change > [1/2] a. change wording about submodule per Liming's comment. >b. add more steps to do submodule update per Mike's comment. >c. add commands for update of submodule > [2/2] no changes. https://bugzilla.tianocore.org/show_bug.cgi?id=1910 Cc: Leif Lindholm Cc:

[edk2-devel] [PATCH v3 1/2] Readme.md: add submodule policy and clone commands

2019-08-14 Thread Wang, Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 A section 'Submodules' is added to clarify the submodule policy in edk2 repo. Git commands are also added to show the correct way to clone submodule repos, in which '--recursive' is removed because it's not needed but recommended in other

Re: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough

2019-08-14 Thread Gao, Zhichao
Ping again. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Friday, July 26, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > oleks...@ami.com > Subject: FW: [edk2-devel] [PATCH

Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag

2019-08-14 Thread Eric Jin
Hi Leif, Thank for the valuable suggestion. In the patch series V2, Sean has been set as author on patch 1/2. Thank you. Best Regards Eric -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm Sent: Wednesday, August 14, 2019 2:47 AM To:

Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-14 Thread Eric Jin
Liming, Thank you for notification. Best Regards Eric -Original Message- From: Gao, Liming Sent: Wednesday, August 14, 2019 12:38 PM To: Jin, Eric ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution Eric: I push the first 3

Re: [edk2-devel] [PATCH v3 0/2] Add edk2 submodule policy

2019-08-14 Thread Wang, Jian J
Sorry for the late update for this patch series. Please find v2 review at https://edk2.groups.io/g/devel/topic/32413655#43457 Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Wednesday, August 14, 2019 4:15

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Leif Lindholm
On Wed, Aug 14, 2019 at 06:21:06PM +0800, Chasel Chiu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 > > A script that can return UTC date and time in ascii > format which is convenient for patching build time > information in any binary. > > Cc: Bob Feng > Cc: Liming Gao >

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread rebecca
On 2019-08-14 04:21, Chiu, Chasel wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 > > A script that can return UTC date and time in ascii > format which is convenient for patching build time > information in any binary. I know it's not a required tool to be run before

Re: [edk2-devel] [PATCH] MdePkg: Add MmAccess and MmControl definition.

2019-08-14 Thread Marc W Chen
Thanks Liming for pushing the code. Can we have a conclusion for the SmmAccess.h removal from MdeModulePkg? Who can make the decision? Or do we need any further discussion? Thanks, Marc > -Original Message- > From: Gao, Liming > Sent: Tuesday, August 13, 2019 5:20 PM > To:

[edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Signed-off-by: Chasel Chiu ---

Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c

2019-08-14 Thread Wu, Hao A
> -Original Message- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Gao, Liming > Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve > comparisons in CapsuleOnDisk.c > > BZ:

Re: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Improve comparisons in CapsuleOnDisk.c

2019-08-14 Thread Wu, Hao A
> -Original Message- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:54 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Gao, Liming > Subject: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Improve > comparisons in CapsuleOnDisk.c > > BZ:

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Wednesday, August 14, 2019 6:21 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Leif Lindholm Subject: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Vitaly Cheptosv via Groups.Io
Liming, Thank you for adding everyone to the CC list. Yes, I would like this to be merged into the next EDK II stable release. Best regards, Vitaly On чт, авг. 15, 2019 at 04:59, Gao, Liming wrote: > Vitaly: > > As you know, edk2 201908 stable tag will start soft freeze tomorrow. Dose >

[edk2-devel] [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Zhang, Shenglei
Initialize PageMapLevel5Entry at the beginning of the function. This commit will fix a GCC 4.8.5 build failure introduced by commit b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2 version. The commit

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
Hi Liming, As we plan to add new TimerLib to use CPUID Leaf 0x15 (CPU XTAL clock frequency) to calculate TSC to resolve performance value unreliable concern. As the code review had got approved and planning into 201908 stable tag. Please help to review whether any concern for 201908 stable

[edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name

2019-08-14 Thread Marcin Wojtas
SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms. Replace board name placeholder in order to avoid confusion. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms: PATCH v2 02/10] Marvell/Cn9130Db: Add ACPI tables

2019-08-14 Thread Marcin Wojtas
This patch adds ACPI tables and necessary headers, which are common for Cn913x SoCs and the CN9130 development board (variant A). Wiring up of support will be done in the follow-up commits. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9130DbA.inf | 56

[edk2-devel] [edk2-platforms: PATCH v2 00/10] Marvell Octeon CN913X SoC family support

2019-08-14 Thread Marcin Wojtas
Hi, The second round of Marvell Octeon CN913X SoC patches bring significant changes. In order to build CN9131/2 variants of the development board, according flag should be added to the command. By default CN9130 is compiled. Above allowed to use single .dsc / .fdf.inc files. The .dsc.inc files

[edk2-devel] [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs

2019-08-14 Thread Marcin Wojtas
Hitherto MppLib code assumed that there could be only two Xenon SdMmc controllers' PHYs. Remove this limitation, so that to support CN913x SoCs, which may have up to 4 of such interfaces. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/MppLib/MppLib.c | 4 +--- 1 file changed, 1

[edk2-devel] [edk2-platforms: PATCH v2 08/10] Marvell/Cn9131Db: Introduce board support

2019-08-14 Thread Marcin Wojtas
This patch introduces all necessary components required for building EDK2 firmware for CN9131-DB setup A. In order to build this variant, '-D CN9131' flag should be added. Otherwise the default (CN9130) will be compiled. Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH v2 04/10] Marvell/Cn9130Db: Introduce board support

2019-08-14 Thread Marcin Wojtas
This patch introduces all necessary components required for building EDK2 firmware for CN9130-DB setup A. Because the board is modular and can be extended to support also CN9131 and CN9132 SoC variants, extract common part into .dsc.inc file, which will be included by them. Signed-off-by: Marcin

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Thursday, August 15, 2019 8:26 AM > To: devel@edk2.groups.io; ler...@redhat.com; Zhang, Shenglei > Cc: Bi, Dandan; Wu, Hao A > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize > pointer PageMapLevel5Entry > >

[edk2-devel] [edk2-non-osi][PATCH V2 0/2] Add CoffeelakeSiliconBinPkg

2019-08-14 Thread Kubacki, Michael A
Adds binaries needed for Coffee Lake and Whiskey Lake. V2 changes: * Corrected repository name in subject to edk2-non-osi Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: Michael Kubacki Michael Kubacki (2): CoffeelakeSiliconBinPkg: Add package

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Liming Gao
Shenglei: The change is good. I agree to add comments for this change purpose like BZ https://bugzilla.tianocore.org/show_bug.cgi?id=607 With this change, Reviewed-by: Liming Gao . Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On

Re: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Improve comparisons in CapsuleOnDisk.c

2019-08-14 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:54 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Improve > comparisons in CapsuleOnDisk.c > > BZ:

Re: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c

2019-08-14 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Xu, Wei6 > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in > CapsuleOnDisk.c > > BZ:

[edk2-devel] [Patch v3 6/6] UefiCpuPkg/CpuCommonFeaturesLib: Use new macros.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Below code is current implementation: if (MsrRegister[ProcessorNumber].Bits.Lock == 0) { CPU_REGISTER_TABLE_WRITE_FIELD ( ProcessorNumber, Msr, MSR_IA32_FEATURE_CONTROL, MSR_IA32_FEATURE_CONTROL_REGISTER,

[edk2-devel] [Patch v3 0/6] Add "test then write" mechanism

2019-08-14 Thread Dong, Eric
v3 changes: 1. Avoid changing exist API CpuRegisterTableWrite, add new API CpuRegisterTableTestThenWrite which align new adds macros. Only 1/6 patch been changed in v3. V2 changes: 1. Split CR read/write action in to one discrete patch 2. Keep the old logic which continue the process if error

[edk2-devel] [Patch v3 4/6] UefiCpuPkg/RegisterCpuFeaturesLib: Combine CR read/write action.

2019-08-14 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 110 ++ 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c

[edk2-devel] [Patch v3 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Combine CR read/write action.

2019-08-14 Thread Dong, Eric
Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++ 1 file changed, 62 insertions(+), 42 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index

[edk2-devel] [edk2-platforms: PATCH v2 01/10] Marvell/Armada7k8k: Fix 32-bit compilation

2019-08-14 Thread Marcin Wojtas
It turned out, that the recently added features broke ARM compilation. Fix all issues: * Use SIGNATURE_32 only * Do not shift address by 32-bit in ICU * Limit memory for ARM build to 1GB and stop using non-existent PCD Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH v2 09/10] Marvell/Cn9132Db: Introduce board support

2019-08-14 Thread Marcin Wojtas
This patch introduces all necessary components required for building EDK2 firmware for CN9132-DB setup A. Note the ACPI is not yet available for this variant, due to the current ICU (CP1xx interrupt controller) support implementation. In order to build this variant, '-D CN9132' flag should be

[edk2-devel] [edk2-platforms: PATCH v2 05/10] Marvell/Library: ArmadaSoCDescLib: Extend Xenon information

2019-08-14 Thread Marcin Wojtas
Hitherto SoC description library code assumed that there could be only two Xenon SdMmc controller instances in the SoC. Remove this limitation, so that to support CN913x SoCs, which may have up to 4 of such interfaces. Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH v2 03/10] Marvell/Cn9130Db: Add DeviceTree

2019-08-14 Thread Marcin Wojtas
This patch adds device tree sources which are common for Cn913x SoCs and the CN9130 development board (variant A). Wiring up of support will be done in the follow-up commits. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn9130DbA.inf | 22 +

[edk2-devel] [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information

2019-08-14 Thread Marcin Wojtas
In case the number of CP11x components exceeded the maximum of currently supported, the user is informed with the information. It turned out that the print arguments were incorrect - fix it. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/IcuLib/IcuLib.c | 4 ++-- 1 file changed, 2

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Liming Gao
Donald: This change is a new feature. Now, it is not in edk2 feature planning list. If you want to catch it into 201908 stable tag, please get approve from Stewards first. I have cc this mail to all Stewards. For this patch, I have one minor comment. You add one PCD in UefiCpuPkg DEC.

[edk2-devel] [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Add below new micros which test the current value before write the new value. Only write new value when current value not same as new value. CPU_REGISTER_TABLE_TEST_THEN_WRITE32 CPU_REGISTER_TABLE_TEST_THEN_WRITE64

[edk2-devel] [Patch v3 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Supports test then write new value logic.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29

[edk2-devel] [Patch v3 5/6] UefiCpuPkg/RegisterCpuFeaturesLib: Supports test then write new value logic.

2019-08-14 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 Supports new logic which test current value before write new value. Only write new value when current value not same as new value. Signed-off-by: Eric Dong Cc: Ray Ni Acked-by: Laszlo Ersek --- .../CpuFeaturesInitialize.c

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Donald Kuo > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V > Subject:

Re: [edk2-devel] [PATCH v3 0/2] Add edk2 submodule policy

2019-08-14 Thread Wang, Jian J
Pushed at 2556350d1b..5ab96088ae Regards, Jian > -Original Message- > From: Gao, Liming > Sent: Thursday, August 15, 2019 8:33 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > > Subject: RE: [PATCH v3 0/2] Add edk2 submodule policy > > Jian: >

[edk2-devel] [edk2-platforms][PATCH V1 0/2] Add CoffeelakeSiliconBinPkg

2019-08-14 Thread Kubacki, Michael A
Adds binaries needed for Coffee Lake and Whiskey Lake. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: Michael Kubacki Michael Kubacki (2): CoffeelakeSiliconBinPkg: Add package contents edk2-non-osi: Add CoffeelakeSiliconBinPkg maintainers

[edk2-devel] [edk2-platforms][PATCH V1 2/2] edk2-non-osi: Add CoffeelakeSiliconBinPkg maintainers

2019-08-14 Thread Kubacki, Michael A
Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 9fba131..5759e4c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@

Re: [edk2-devel] [PATCH v3 0/2] Add edk2 submodule policy

2019-08-14 Thread Liming Gao
Jian: Thanks for your update. The change is good. Reviewed-by: Liming Gao > -Original Message- > From: Wang, Jian J > Sent: Wednesday, August 14, 2019 4:15 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH v3 0/2] Add edk2

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Liming Gao
Vitaly: As you know, edk2 201908 stable tag will start soft freeze tomorrow. Dose this patch plan to catch this stable tag? If yes, please ask the feedback from Tianocore Stewards. I have cc this patch to all Stewards. Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Yao, Jiewen
Good input. I think we should separate the work to convert all EDKII code to use STATIC_ASSERT. We can do that work once we add STATIC_ASSERT. I recommend: 1) Step 1: Add STATIS_ASSERT - this patch and this Bugzilla 2) Step 2: Convert VERIFY_SIZE_OF to STATIS_ASSERT, and remove

Re: [edk2-devel] [PATCH] SecurityPkg/SecurityPkg.uni: Add missing strings for new PCDs

2019-08-14 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Wang, Jian J Sent: Wednesday, August 14, 2019 5:01 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Zhang, Chao B ; Zhang, Shenglei Subject: [PATCH] SecurityPkg/SecurityPkg.uni: Add missing strings for new PCDs REF:

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Liming Gao
Shenglei: > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, August 15, 2019 10:23 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; Wu, > Hao A > Subject: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer > PageMapLevel5Entry > > Initialize

[edk2-devel] [edk2-non-osi][PATCH V2 2/2] edk2-non-osi: Add CoffeelakeSiliconBinPkg maintainers

2019-08-14 Thread Kubacki, Michael A
Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 9fba131..5759e4c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@

Re: [edk2-devel] [edk2-non-osi][PATCH V2 2/2] edk2-non-osi: Add CoffeelakeSiliconBinPkg maintainers

2019-08-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Thursday, August 15, 2019 12:15 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ;

[edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909 Cc: Ray Ni Cc: Star Zeng Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Signed-off-by: Donald Kuo --- UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++ UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35 +++

[edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables

2019-08-14 Thread Zhang, Shenglei
At latest edk2 version, there is build failure when building ShellPkg with VS2012x86, which results from uninitialized local variables. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang --- .../Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
Thanks Liming for review. Update UefiCpuPkg.uni for review again. Thanks, Donald > -Original Message- > From: Gao, Liming > Sent: Thursday, August 15, 2019 12:03 PM > To: Kuo, Donald ; Dong, Eric > ; devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Chan, > Amy ; Chaganty, Rangasai V >

[edk2-devel] [PATCH] SecurityPkg/SecurityPkg.uni: Add missing strings for new PCDs

2019-08-14 Thread Wang, Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2026 Cc: Jiewen Yao Cc: Chao Zhang Cc: Shenglei Zhang Signed-off-by: Jian J Wang --- SecurityPkg/SecurityPkg.uni | 23 +++ 1 file changed, 23 insertions(+) diff --git a/SecurityPkg/SecurityPkg.uni

Re: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough

2019-08-14 Thread Augustine, Linson
Reviewed-by: Linson Augustine Regards, -Linson -Original Message- From: Gao, Zhichao Sent: Wednesday, August 14, 2019 2:03 PM To: devel@edk2.groups.io; Gao, Zhichao Cc: Carsey, Jaben ; Ni, Ray ; oleks...@ami.com; Augustine, Linson Subject: RE: [edk2-devel] [PATCH V2]

Re: [edk2-devel] [Patch v1] ShellPkg: update drivers command for more children

2019-08-14 Thread Augustine, Linson
Reviewed-by: Linson Augustine Regards, -Linson -Original Message- From: Carsey, Jaben Sent: Tuesday, August 13, 2019 8:12 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Augustine, Linson ; Gao, Zhichao Subject: [Patch v1] ShellPkg: update drivers command for more children this allows for

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Chiu, Chasel
V2 re-wrote the script to use ArgumentParser and remove sys.exit(). Regards, Chasel > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Chiu, Chasel > Sent: Wednesday, August 14, 2019 6:21 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ;

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Liming Gao
Can you add the sample usage of new macro STATIC_ASSERT? Or, give the link of static_assert or _Static_assert. If so, the developer knows how to use them in source code. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of vit9696

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-14 Thread Yao, Jiewen
My comments below. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, August 14, 2019 12:09 AM > To: edk2-devel-groups-io > Cc: edk2-rfc-groups-io ; qemu devel list > ; Igor Mammedov ; > Paolo Bonzini ; Yao, Jiewen > ; Chen, Yingwen ; > Nakajima, Jun

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-14 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, August 13, 2019 5:48 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Gao, Liming > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan > > Subject: Re: [edk2-devel] [Patch]

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Michael D Kinney
Liming, I think a good candidate to demonstrate this feature are the checks made in MdePkg/Include/Base.h. The current implementation forces a divide by 0 in the C pre-processor to break the build. STATIC_ASSERT() would be a better way to do this. I would also remove unused externs from the

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-14 Thread Liming Gao
Laszlo: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Wednesday, August 14, 2019 11:13 PM > To: Gao, Liming ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan >

Re: [edk2-devel] [PATCH v2] BaseTools/Scripts: Add GetUtcDateTime script.

2019-08-14 Thread Chiu, Chasel
Yes, as pylama currently not requirement yet we will evaluate this later. Thanks! Regards, Chasel > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > rebe...@bsdio.com > Sent: Wednesday, August 14, 2019 7:51 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag

2019-08-14 Thread Eric Jin
Hi Leif, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Wednesday, August 14, 2019 2:47 AM > To: Gao, Liming > Cc: Jin, Eric ; r...@edk2.groups.io; devel@edk2.groups.io; > Feng, Bob C ; Cetola, Stephano > ; Laszlo

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Vitaly Cheptosv via Groups.Io
Michael, Liming, Laszlo, Static assertions via _Static_assert are standard C11 functionality, thus any at least C11 (ISO/IEC 9899 2011) conforming compiler is required to support the second argument with the diagnostic description. The notation without the message currently is only present in

[edk2-devel] [PATCH v5 5/5] BaseTools: Improve the file saving and copying reliability

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2079 The Basetool CopyFileOnChange() and SaveFileOnChange() functions might raise the IOError occasionally when build in Windows with multi-process and build cache enabled. The CopyFileOnChange() and SaveFileOnChange() might

[edk2-devel] [PATCH v5 1/5] BaseTools: Improve the cache hit in the edk2 build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1927 Current cache hash algorithm does not parse and generate the makefile to get the accurate dependency files for a module. It instead use the platform and package meta files to get the module depenedency in a quick but

[edk2-devel] [PATCH v5 3/5] BaseTools: Change the [Arch][Name] module key in Build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951 Current build cache use the module's [self.Arch][self.Name] info as the ModuleAutoGen object key in hash list and dictionary. The [self.Arch][self.Name] is not safe as the module key because there could be two modules

[edk2-devel] [PATCH v5 4/5] BaseTools: Add GenFds multi-thread support in build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923 Fix the issue that the GenFds multi-thread will build fail if enable the build cache together. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 23

[edk2-devel] [PATCH v5 2/5] BaseTools: Print first cache missing file for build cachle

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925 When a module build cache miss, add support to print the first cache missing file path and name. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 ++

[edk2-devel] [PATCH v5 0/5] Build cache enhancement

2019-08-14 Thread Steven Shi
From: "Shi, Steven" This patch set is for the 201908 stable tag Enhance the edk2 build cache with below patches: Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash algorithm Patch 02/05: Print more info to explain why a module build cache miss Patch 03/05: Fix the

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-14 Thread Paolo Bonzini
On 14/08/19 15:20, Yao, Jiewen wrote: >> - Does this part require a new branch somewhere in the OVMF SEC code? >> How do we determine whether the CPU executing SEC is BSP or >> hot-plugged AP? > [Jiewen] I think this is blocked from hardware perspective, since the first > instruction. > There

Re: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough

2019-08-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Augustine, Linson > Sent: Wednesday, August 14, 2019 1:41 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > oleks...@ami.com > Subject: RE: [edk2-devel] [PATCH V2] >

Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"

2019-08-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, August 13, 2019 8:37 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove > the variable

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-14 Thread Laszlo Ersek
On 08/14/19 16:00, Gao, Liming wrote: > Laszlo: > > I cherry pick this patch from Mu project with the minimal change. > I can update the comment style. Yes, please. Thanks! >> The gEfiMemoryTypeInformationGuid HOB is supposed to be built -- if it >> is built at all -- no later than in the

Re: [edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Laszlo Ersek
(adding back the list) On 08/13/19 16:30, vit9...@protonmail.com wrote: > Laszlo, > > GCC implemented _Static_assert in 4.6. See its official wiki for C11 > compatibility documentation: > > https://gcc.gnu.org/wiki/C11Status Awesome news! Once this is upstreamed, we should go through all the

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 14 August 2019 #cal-cancelled

2019-08-14 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190814T144618Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com

Re: [edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 14 August 2019 #cal-cancelled

2019-08-14 Thread Stephano Cetola
No topics this week. Also, I'll be at the Open Source Summit next week. Ray will likely run the design meeting on Thursday, and unless anyone has any topics for Wednesday, we'll probably cancel that one. Cheers, Stephano On Wed, Aug 14, 2019 at 7:46 AM devel@edk2.groups.io Calendar wrote: > >

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-14 Thread Laszlo Ersek
On 08/13/19 13:23, Roman Kagan wrote: > On Tue, Aug 13, 2019 at 11:10:27AM +0200, Laszlo Ersek wrote: >> On 08/12/19 20:43, Roman Kagan wrote: >>> On Fri, Aug 09, 2019 at 04:07:00PM +, Roman Kagan via Groups.Io wrote: On Thu, Aug 08, 2019 at 07:39:14PM +0200, Laszlo Ersek wrote: > On

Re: [edk2-devel] [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms

2019-08-14 Thread Michael D Kinney
Hi Andy, Thanks for the contribution. Is this patch for the edk2-platform repo? The email subject can help clarify the intended repo. Also, we prefer the patches to be provided inline instead of an attachment. You can use the 'git send-email' feature to do this. Here are a couple links to

Re: [edk2-devel] [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms

2019-08-14 Thread Leif Lindholm
Hi Andy, Many thanks for this submission. I am finding a few issues when building with gcc/clang (I expect you use Visual Studio). The RELEASE target barfs with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c:363:1: error: unused function 'CalculateRefreshRate' since

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer PageMapLevel5Entry

2019-08-14 Thread Laszlo Ersek
On 08/14/19 09:37, Zhang, Shenglei wrote: > Initialize PageMapLevel5Entry at the beginning of the function. > > This commit will fix a GCC 4.8.5 build failure introduced by commit > b3527dedc3951f061c5a73cb4fb2b0f95f47e08b. > > OvmfPkg build failure wtih gcc 4.8.5 still exists at latest edk2

Re: [edk2-devel] [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms

2019-08-14 Thread Leif Lindholm
Hi Andy, A follow-up - a few more things need changing: UsbDisplayLink.h (well, any .h file) should only contain the headers it itself requires. Moreover, the inclusion of wchar.h must disappear completely. Instead, use CHAR16 * in the two locations in UsbDisplayLink.c. Removing wchar.h will

[edk2-devel] [PATCH v4 0/5] Build cache enhancement

2019-08-14 Thread Steven Shi
From: "Shi, Steven" Enhance the edk2 build cache with below patches: Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash algorithm Patch 02/05: Print more info to explain why a module build cache miss Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in

[edk2-devel] [PATCH v4 3/5] BaseTools: Change the [Arch][Name] module key in Build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951 Current build cache use the module's [self.Arch][self.Name] info as the ModuleAutoGen object key in hash list and dictionary. The [self.Arch][self.Name] is not safe as the module key because there could be two modules

[edk2-devel] [PATCH v4 1/5] BaseTools: Improve the cache hit in the edk2 build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1927 Current cache hash algorithm does not parse and generate the makefile to get the accurate dependency files for a module. It instead use the platform and package meta files to get the module depenedency in a quick but

[edk2-devel] [PATCH v4 5/5] BaseTools: Improve the file saving and copying reliability

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2079 The Basetool CopyFileOnChange() and SaveFileOnChange() functions might raise the IOError occasionally when build in Windows with multi-process and build cache enabled. The CopyFileOnChange() and SaveFileOnChange() might

[edk2-devel] [PATCH v4 4/5] BaseTools: Add GenFds multi-thread support in build cache

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923 Fix the issue that the GenFds multi-thread will build fail if enable the build cache together. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 23

[edk2-devel] [PATCH v4 2/5] BaseTools: Print first cache missing file for build cachle

2019-08-14 Thread Steven Shi
From: "Shi, Steven" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925 When a module build cache miss, add support to print the first cache missing file path and name. Cc: Liming Gao Cc: Bob Feng Signed-off-by: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 ++

Re: [edk2-devel] [PATCH v4 1/5] BaseTools: Improve the cache hit in the edk2 build cache

2019-08-14 Thread Christian Rodriguez
For all 5 patches in patch set: Acked-by: Christian Rodriguez >-Original Message- >From: Shi, Steven >Sent: Wednesday, August 14, 2019 11:11 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >; Rodriguez, Christian >; Johnson, Michael >; Shi, Steven >Subject: [PATCH v4 1/5]

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-14 Thread Andrew Fish via Groups.Io
> On Aug 14, 2019, at 8:16 AM, Laszlo Ersek wrote: > > On 08/13/19 13:23, Roman Kagan wrote: >> On Tue, Aug 13, 2019 at 11:10:27AM +0200, Laszlo Ersek wrote: >>> On 08/12/19 20:43, Roman Kagan wrote: On Fri, Aug 09, 2019 at 04:07:00PM +, Roman Kagan via Groups.Io wrote: > On Thu,