Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue of incorrect Module Unique Name

2019-08-16 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, August 16, 2019 3:55 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Shi, Steven > Subject: RE: [edk2-devel] [Patch 1/1] BaseTools: Fixed issue of incorrect > Module Unique Name > > This patch is to fix

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
Jordan, It is not a typo. Andrew generated the XCODE specific changes, so they have been tested by him. I have also reviewed and tested the XCODE changes and verified that all 6 combinations build and boot to shell (IA32/X64 for RELEASE/DEBUG/NOOPT). Since they are all related to making

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-16 Thread Laszlo Ersek
On 08/14/19 18:26, Andrew Fish wrote: > > >> On Aug 14, 2019, at 8:16 AM, Laszlo Ersek wrote: >> >> On 08/13/19 13:23, Roman Kagan wrote: >>> On Tue, Aug 13, 2019 at 11:10:27AM +0200, Laszlo Ersek wrote: On 08/12/19 20:43, Roman Kagan wrote: > On Fri, Aug 09, 2019 at 04:07:00PM +,

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-16 Thread Laszlo Ersek
On 08/14/19 17:55, Gao, Liming wrote: > If Platform PEIM doesn't build HOB, DxeIpl will not build HOB, My reading of the code is the opposite. If the platform PEIM does not build the HOB, then the DXE IPL PEIM will attempt to build the HOB, from the UEFI variable. At commit caa7d3a896f6, in

[edk2-devel] [POC Seabios PATCH] seabios: use isolated SMM address space for relocation

2019-08-16 Thread Igor Mammedov
for purpose of demo SMRAM (at 0x3) is aliased at a in system address space for easy initialization of SMI entry point. Here is resulting debug output showing that RAM at 0x3 is not affected by SMM and only RAM in SMM adderss space is modified: init smm smm_relocate: before relocaten

[edk2-devel] [POC QEMU PATCH 0/2] CPU hotplug: use dedicated SMRAM at 0x30000 in SMM address space

2019-08-16 Thread Igor Mammedov
It's just a quick hack together with Seabios to show that normal RAM at 0x3 is not affected by SMM relocation and dedicated SMRAM could be used for relocation without need to care about untrusted RAM content at 0x3. CC: "Chen, Yingwen" CC: edk2-devel-groups-io CC: Phillip Goerl CC:

[edk2-devel] [PATCH QEMU 1/1] q35: use dedicated SMRAM at default SMM_BASE

2019-08-16 Thread Igor Mammedov
it will allow us to hide sensetive SMM_BASE area from non SMM running env, that will allow us to ensure that hotplugged CPU will run trusted SMM BASE relocation code and we won't need to force all present CPUs into SMM mode since we don not care about about 0x3 content in normal RAM address

Re: [edk2-devel] [Patch v4 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then Write" Macros.

2019-08-16 Thread Laszlo Ersek
On 08/16/19 05:57, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040 > > Add below new micros which test the current value before write the new > value. Only write new value when current value not same as new value. > CPU_REGISTER_TABLE_TEST_THEN_WRITE32 >

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Andrew Fish via Groups.Io
Tested-by: Andrew Fish I tested the XCODE builds of the emulator and made sure that source level debugging worked probably for builds that generate symbols. Thanks, Andrew Fish > On Aug 16, 2019, at 8:09 AM, Michael D Kinney > wrote: > > Jordan, > > It is not a typo. > > Andrew

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Jordan Justen
On 2019-08-16 08:09:55, Kinney, Michael D wrote: > Jordan, > > It is not a typo. > > Andrew generated the XCODE specific changes, so they have > been tested by him. In that case, is the git author for the patches set to Andrew? If it was, I would expect to see a line inside the email body

Re: [edk2-devel] static data in dxe_runtime modules

2019-08-16 Thread Roman Kagan
On Wed, Aug 14, 2019 at 09:26:47AM -0700, Andrew Fish via Groups.Io wrote: > Every runtime driver I've every seen usually works like this: > 1) Loads as an EFI driver and uses EFI Boot Services in its constructor (gBS, > gDS, AllocatePool(), etc.) > 2) You use the EFI Boot Service to register the

Re: [edk2-devel] [edk2-platforms: PATCH v2 03/10] Marvell/Cn9130Db: Add DeviceTree

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:07AM +0200, Marcin Wojtas wrote: > This patch adds device tree sources which are common for Cn913x SoCs > and the CN9130 development board (variant A). Wiring up of support > will be done in the follow-up commits. > > Signed-off-by: Marcin Wojtas Again, I've not

Re: [edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote: > SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms. > Replace board name placeholder in order to avoid confusion. Stupid/lazy question - do we already specify the actual platform name elsewhere? / Leif >

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-16 Thread Laszlo Ersek
On 08/16/19 17:24, Gao, Liming wrote: > Laszlo: > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, August 16, 2019 11:18 PM >> To: Gao, Liming ; devel@edk2.groups.io; Kinney, >> Michael D >> Cc: Mike Turner ;

[edk2-devel] BaseTools/BinWrappers question?

2019-08-16 Thread Andrew Fish via Groups.Io
Why does BaseTools/BinWrappers/WindowsLike only have wrappers for Python commands, while BaseTools/BinWrappers/PosixLike has wrappers for C based tools too? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45832):

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
Laszlo, I have already mentioned that the documentation is sufficient as _Static_assert is C standard, so I do not plan to make a V3 for this patch. The patch is merge ready. As for usage examples I have an opposing opinion to yours and believe it is based on very good reasons. Not using

Re: [edk2-devel] [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:11AM +0200, Marcin Wojtas wrote: > In case the number of CP11x components exceeded the maximum > of currently supported, the user is informed with the information. > It turned out that the print arguments were incorrect - fix it. Whoops. > Signed-off-by: Marcin

Re: [edk2-devel] [edk2-platforms: PATCH v2 09/10] Marvell/Cn9132Db: Introduce board support

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:13AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9132-DB setup A. Note > the ACPI is not yet available for this variant, due to > the current ICU (CP1xx interrupt controller) support >

[edk2-devel] [patch v2][edk2-stable201908] MdeModulePkg DxeCore: Fix for missing Memory Attributes Table (MAT) update

2019-08-16 Thread Liming Gao
From: Mike Turner The Fpdt driver (FirmwarePerformanceDxe) saves a memory address across reboots, and then does an AllocatePage for that memory address. If, on this boot, that memory comes from a Runtime memory bucket, the MAT table is not updated. This causes Windows to boot into Recovery.

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Laszlo Ersek
On 08/15/19 03:59, Gao, Liming wrote: > Vitaly: > As you know, edk2 201908 stable tag will start soft freeze tomorrow. Dose > this patch plan to catch this stable tag? > If yes, please ask the feedback from Tianocore Stewards. I have cc this > patch to all Stewards. If a feature patch (or

Re: [edk2-devel] [edk2-platforms: PATCH v2 02/10] Marvell/Cn9130Db: Add ACPI tables

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:06AM +0200, Marcin Wojtas wrote: > This patch adds ACPI tables and necessary headers, > which are common for Cn913x SoCs and the CN9130 development board > (variant A). Wiring up of support will be done in the follow-up > commits. > > Signed-off-by: Marcin Wojtas

Re: [edk2-devel] Patch List for 201908 stable tag

2019-08-16 Thread Laszlo Ersek
On 08/16/19 10:00, Gao, Liming wrote: > > From: Gao, Liming [mailto:liming@intel.com] > Sent: Friday, August 16, 2019 3:59 PM > To: Laszlo Ersek (ler...@redhat.com) ; > leif.lindh...@linaro.org; Kinney, Michael D ; > af...@apple.com; Cetola, Stephano > Cc: edk2-de...@lists.01.org >

Re: [edk2-devel] [patch v2][edk2-stable201908] MdeModulePkg DxeCore: Fix for missing Memory Attributes Table (MAT) update

2019-08-16 Thread Laszlo Ersek
On 08/16/19 17:39, Liming Gao wrote: > From: Mike Turner > > The Fpdt driver (FirmwarePerformanceDxe) saves a memory address across > reboots, and then does an AllocatePage for that memory address. > If, on this boot, that memory comes from a Runtime memory bucket, > the MAT table is not

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-16 Thread Laszlo Ersek
On 08/15/19 18:21, Paolo Bonzini wrote: > On 15/08/19 17:00, Laszlo Ersek wrote: >> On 08/14/19 16:04, Paolo Bonzini wrote: >>> On 14/08/19 15:20, Yao, Jiewen wrote: > - Does this part require a new branch somewhere in the OVMF SEC code? > How do we determine whether the CPU executing

Re: [edk2-devel] [edk2-platforms: PATCH v2 04/10] Marvell/Cn9130Db: Introduce board support

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:08AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9130-DB setup A. > Because the board is modular and can be extended to support > also CN9131 and CN9132 SoC variants, extract common part into

Re: [edk2-devel] [Patch V4 09/10] EmulatorPkg/Sec: Change local variable scope for XCODE5

2019-08-16 Thread Jordan Justen
On 2019-08-15 19:14:36, Michael D Kinney wrote: > The local variable PpiArray[10] is declared in middle > of the SEC module _ModuleEntryPoint(). When building > for XCODE5 with optimizations enabled, this results in > corruption and an exception. It looks like with old code, the scope containing

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Laszlo Ersek
On 08/15/19 06:02, Gao, Liming wrote: > Donald: This change is a new feature. Now, it is not in edk2 feature > planning list. If you want to catch it into 201908 stable tag, please > get approve from Stewards first. I have cc this mail to all Stewards. - I don't mind adding a new feature, as long

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Laszlo Ersek
On 08/14/19 18:22, vit9...@protonmail.com wrote: > Michael, Liming, Laszlo, > > Static assertions via _Static_assert are standard C11 functionality, thus any > at least C11 (ISO/IEC 9899 2011) conforming compiler is required to support > the second argument with the diagnostic description. >

Re: [edk2-devel] [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements

2019-08-16 Thread Leif Lindholm
On Fri, Aug 16, 2019 at 11:00:07AM +0100, Pete Batard wrote: > Changes from v1: > - Break down DEBUB output embellishments from the other code changes. > - Use GUIDs that are explicitly named after each platform/model rather than > generic ones. > - Drop the use of a GUID table/index and use a

Re: [edk2-devel] [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:10AM +0200, Marcin Wojtas wrote: > Hitherto MppLib code assumed that there could be only two > Xenon SdMmc controllers' PHYs. Remove this limitation, so that to > support CN913x SoCs, which may have up to 4 of such interfaces. Should this be merged with the preceding

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-16 Thread Liming Gao
Laszlo: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Friday, August 16, 2019 11:18 PM > To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael > D > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan > >

Re: [edk2-devel] [edk2-platforms: PATCH v2 01/10] Marvell/Armada7k8k: Fix 32-bit compilation

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:05AM +0200, Marcin Wojtas wrote: > It turned out, that the recently added features broke > ARM compilation. Fix all issues: > * Use SIGNATURE_32 only > * Do not shift address by 32-bit in ICU > * Limit memory for ARM build to 1GB and stop using non-existent PCD > >

Re: [edk2-devel] [edk2-platforms: PATCH v2 05/10] Marvell/Library: ArmadaSoCDescLib: Extend Xenon information

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:09AM +0200, Marcin Wojtas wrote: > Hitherto SoC description library code assumed that there could > be only two Xenon SdMmc controller instances in the SoC. Remove this > limitation, so that to support CN913x SoCs, which may have up to 4 of > such interfaces. > >

Re: [edk2-devel] Determining TSC frequency programmatically

2019-08-16 Thread Andrew Fish via Groups.Io
Vitaly, As Mike mentioned platforms can know more info about how they are constructed thus you may not want to have a lot of generic discovery code floating about if you don't really need it. One option could be to pass up the TSC Frequency/Period via some EFI mechanism so generic code can

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Laszlo Ersek
On 08/15/19 18:08, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney To summarize: personally, I disgree, but I can accept if the patch goes in with Mike's R-b. Thanks, Laszlo >> -Original Message- >> From: devel@edk2.groups.io >> [mailto:devel@edk2.groups.io] On Behalf Of

Re: [edk2-devel] [edk2-platforms: PATCH v2 08/10] Marvell/Cn9131Db: Introduce board support

2019-08-16 Thread Leif Lindholm
On Thu, Aug 15, 2019 at 04:54:12AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9131-DB setup A. > > In order to build this variant, '-D CN9131' flag should be added. > Otherwise the default (CN9130) will be compiled.

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Laszlo Ersek
On 08/16/19 19:23, vit9...@protonmail.com wrote: > Laszlo, > > I have already mentioned that the documentation is sufficient as > _Static_assert is C standard Yes, in a release of the ISO C standard that edk2 does not target. In addition, edk2 already has several restrictions in place against

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Laszlo Ersek
On 08/16/19 18:16, Laszlo Ersek wrote: > On 08/15/19 06:02, Gao, Liming wrote: >> Donald: This change is a new feature. Now, it is not in edk2 feature >> planning list. If you want to catch it into 201908 stable tag, please >> get approve from Stewards first. I have cc this mail to all Stewards. >

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
Andrew, Mike, Actually thanks for making me recheck it. I have just installed doxygen, and can confirm that it can generate parameters for non-functional macros. This was my main reason for going with /// comment style, which is used for all other plain macros. I have just submitted V3 version

[edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib: Use STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 Use new STATIC_ASSERT macro instead of VERIFY_SIZE_OF. Signed-off-by: Vitaly Cheptsov --- MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 2/3] MdePkg: Use STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 Use new STATIC_ASSERT macro instead of VERIFY_SIZE_OF. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Base.h | 79 ++-- 1 file changed, 40 insertions(+), 39 deletions(-) diff --git a/MdePkg/Include/Base.h

[edk2-devel] [PATCH v1 3/3] MdePkg: Drop VERIFY_SIZE_OF in favour of STATIC_ASSERT

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 New STATIC_ASSERT macro supersedes VERIFY_SIZE_OF as being more functional. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Base.h | 13 - 1 file changed, 13 deletions(-) diff --git a/MdePkg/Include/Base.h

[edk2-devel] [PATCH v1 0/3] Replace VERIFY_SIZE_OF with STATIC_ASSERT

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
Things to note: - This patchset should go after STATIC_ASSERT implementation: https://edk2.groups.io/g/devel/topic/32917749 - It is suggested that unlike the previous patch, which in my opinion should appear in edk2-stable201908, this patchset should land in edk2-stable2019011. This will

[edk2-devel] [edk2-platforms][PATCH V1 05/37] CoffeelakeSiliconPkg/Pch: Add ConfigBlock headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds header files to Pch/Include/ConfigBlock. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 15/37] CoffeelakeSiliconPkg/Cpu: Add library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds CPU library class instances. * BaseCpuMailboxLibNull - Generic CPU mailbox interaction services. * PeiCpuPolicyLib - CPU policy configuration services. * PeiCpuPolicyLibPreMem - CPU policy pre-memory configuration services. *

[edk2-devel] [edk2-platforms][PATCH V1 10/37] CoffeelakeSiliconPkg/Pch: Add Private/Library include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds the following header files: * Pch/Include/Private/Library Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 17/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds PCH Base library class instances. * BaseResetSystemLib * BaseSmbusLib Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 07/37] CoffeelakeSiliconPkg/Pch: Add PPI and Protocol include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds the following header files: * Pch/Include/Ppi * Pch/Include/Protocol Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 04/37] CoffeelakeSiliconPkg/Pch: Add include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds Pch/Include headers. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/DxeHdaNhlt.h

[edk2-devel] [edk2-platforms][PATCH V1 06/37] CoffeelakeSiliconPkg/Pch: Add Library include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds the following header files: * Pch/Include/library Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 11/37] CoffeelakeSiliconPkg/Pch: Add Private/Protocol include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds the following header files: * Pch/Include/Private/Protocol Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 36/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add DSC and build files

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083 Adds the DSC and build files necessary to build the WhiskeylakeURvp board instance. Key files = * build_config.cfg - Board-specific build configuration file. * OpenBoardPkg.dsc - The WhiskeylakeURvp board description file. *

[edk2-devel] [edk2-platforms][PATCH V1 12/37] CoffeelakeSiliconPkg/SampleCode: Add Include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds header files common to silicon Sample Code. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha > Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 16/37] CoffeelakeSiliconPkg/Me: Add library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds ME library class instances. * PeiMePolicyLib - PEI ME policy configuration services. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 03/37] CoffeelakeSiliconPkg/Me: Add Include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds header files common to ME modules. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 29/37] CoffeelakeSiliconPkg: Add package DSC files

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 215

[edk2-devel] [edk2-platforms][PATCH V1 18/37] CoffeelakeSiliconPkg/Pch: Add DXE library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds PCH DXE library class instances. * DxePchPolicyLib * DxeResetSystemLib * DxeRuntimeResetSystemLib Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael

[edk2-devel] [edk2-platforms][PATCH V1 24/37] CoffeelakeSiliconPkg/Pch: Add SMM private library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds PCH SMM private library class instances. * SmmPchPrivateLib Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 22/37] CoffeelakeSiliconPkg/Pch: Add DXE private library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds PCH DXE private library class instances. * DxeGpioNameBufferLib * DxePchHdaLib Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 02/37] CoffeelakeSiliconPkg/Cpu: Add Include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds header files common to CPU modules. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 09/37] CoffeelakeSiliconPkg/Pch: Add Private include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds the following header files: * Pch/Include/Private Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 20/37] CoffeelakeSiliconPkg/Pch: Add SMM library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds PCH SMM library class instances. * SmmSpiFlashCommonLib Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 32/37] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083 Header files for the WhiskeylakeURvp board instance. Cc: Sai Chaganty Cc: Chasel Chiu Cc: Liming Gao Cc: Nate DeSimone Cc: Michael D Kinney Cc: Ankit Sinha Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH V1 01/37] CoffeelakeSiliconPkg: Add package and Include headers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Create the CoffeelakeSiliconPkg to provide an initial package for silicon initialization code for Coffee Lake (CFL) and Whiskey Lake (WHL) generation products. * Major areas of functionality are categorized into CPU, Management Engine

[edk2-devel] [edk2-platforms][PATCH V1 21/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds Pch/Library/Private Base library class instances. * BaseGpioHelpersLibNull * BasePchSpiCommonlib * BaseSiScheduleResetLib * BaseSiScheduleResetLibFsp Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D

[edk2-devel] [edk2-platforms][PATCH V1 14/37] CoffeelakeSiliconPkg: Add package common library instances

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Adds package-level library class instances. * BaseConfigBlockLib - Library functions for config block management. * BaseSiConfigBlockLib - Library functions for managing component config blocks. * DxeAslUpdateLib - Services to update ACPI

[edk2-devel] [edk2-platforms][PATCH V1 37/37] Add WhiskeylakeOpenBoardPkg to global build config and documentation

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2083 * Adds the WhiskeylakeURvp board as a build option in build.cfg so it it is listed as a valid build target. * Updates relevant Readme.md files to include instructions for WhiskeylakeOpenBoardPkg. * Adds the maintainers for

[edk2-devel] [edk2-platforms][PATCH V1 30/37] Maintainers.txt: Add CoffeelakeSiliconPkg maintainers

2019-08-16 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2082 Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- Maintainers.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Laszlo Ersek
On 08/16/19 21:38, Laszlo Ersek wrote: > I understand that edk2 is a "kit", and quite explicitly caters to > out-of-tree platforms. That's not a positive trait of edk2 however; > it's a negative one, in my judgement. To clarify... I didn't mean that edk2 should willfully ignore dependent

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
Laszlo, I am very glad to you for expressing a different opinion as this lets me view the situation from different angles. I understand your concerns, and believe that most of them should actually be addressed in a way you explain. In fact, I plan to submit more patches myself for everyone's

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread rebecca
On 2019-08-16 15:40, Vitaly Cheptsov via Groups.Io wrote: > I missed your message while writing mine, but I am afraid I disagree > with the functional macro usage for this feature. > > I explicitly quoted C standard static_assert definition in one of my > previous messages, and I want EDK II to be

[edk2-devel] [PATCH v3 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2048 Provide a macro for compile time assertions. Equivalent to C11 static_assert macro from assert.h. Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Base.h | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/37] CoffeelakeSiliconPkg: Add package and Include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:15 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/37] CoffeelakeSiliconPkg/Pch: Add Private include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 02/37] CoffeelakeSiliconPkg/Cpu: Add Include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:15 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/37] CoffeelakeSiliconPkg/SampleCode: Add Include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 03/37] CoffeelakeSiliconPkg/Me: Add Include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:15 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/37] CoffeelakeSiliconPkg/Pch: Add PPI and Protocol include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 15/37] CoffeelakeSiliconPkg/Cpu: Add library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 24/37] CoffeelakeSiliconPkg/Pch: Add SMM private library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/37] CoffeelakeSiliconPkg/Pch: Add Private/Library include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 18/37] CoffeelakeSiliconPkg/Pch: Add DXE library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 17/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 14/37] CoffeelakeSiliconPkg: Add package common library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/37] CoffeelakeSiliconPkg/Pch: Add Library include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 21/37] CoffeelakeSiliconPkg/Pch: Add Base library instances

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/37] CoffeelakeSiliconPkg/Pch: Add Private/Protocol include headers

2019-08-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, August 16, 2019 5:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Kinney, Michael D ; Sinha, Ankit Subject: [edk2-platforms][PATCH V1

Re: [edk2-devel] [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
Jordan, Thanks. Yes. Updating the Author sounds like the right fix. I will send an updated series soon. Thanks, Mike > -Original Message- > From: Justen, Jordan L > Sent: Friday, August 16, 2019 11:21 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Ni, Ray ; Andrew Fish >

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-16 Thread rebecca
On 2019-08-16 18:03, Andrew Fish wrote: > It is also interesting in the context of our CI as we could pick oldest and > newest version from every compiler family for the CI build test. Yes, that's going to be important. Given

[edk2-devel] [Patch V5 02/11] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD

2019-08-16 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2055 Remove the use of the defines UNIX_SEC_BUILD and WIN_SEC_BUILD. This simplifies the build command for the EmulatorPkg. Instead, use !if statements in the DSC file using $(ARCH) and $(FAMILY) to determine if the build is for a Windows or POSIX

[edk2-devel] [Patch V5 06/11] EmulatorPkg: Fix XCODE5 lldb issues

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Fix scripts to support lldb symbolic debugging when using XCODE5 tool chain. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/lldbefi.py | 8 +---

[edk2-devel] [Patch V5 08/11] EmulatorPkg/Unix/Host: Remove debug code from BerkeleyPacketFilter.c

2019-08-16 Thread Michael D Kinney
From: Andrew Fish Remove old debug code that generates an exception. Cc: Jordan Justen Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Andrew Fish Reviewed-by: Michael D Kinney Tested-by: Andrew Fish --- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 4 1 file changed, 4 deletions(-)

[edk2-devel] [Patch V5 10/11] EmulatorPkg/Sec: Change scope of PpiArray[10]

2019-08-16 Thread Michael D Kinney
From: Andrew Fish The local variable PpiArray[10] is declared in the middle of the SEC module _ModuleEntryPoint() with its own scope. However, PpiArray has a dangling reference to its location on the stack after the scope is closed. This causes issues with some compilers (e.g. XCODE5). The fix

[edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-16 Thread Michael D Kinney
New in V5 = * Update author to be Andrew Fish for XCODE5 fixes * Split patch #7 into two patches * Break up long line in build.sh into multiple lines New in V4 (Resolve XCODE5 issues) == * Disable inline if SecGdbScriptBreak() for XCODE5 issues * Disable

[edk2-devel] [Patch V5 04/11] EmulatorPkg: Add support for NOOPT target

2019-08-16 Thread Michael D Kinney
Add NOOPT to BUILD_TARGETS in DSC file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Michael D Kinney Reviewed-by: Hao A Wu Reviewed-by: Jordan Justen Tested-by: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2-devel] [edk2-platforms][PATCH V1 02/37] CoffeelakeSiliconPkg/Cpu: Add Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, Ankit > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V1 01/37] CoffeelakeSiliconPkg: Add package and Include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, Ankit > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/37] CoffeelakeSiliconPkg/Pch: Add ConfigBlock headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, Ankit > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/37] CoffeelakeSiliconPkg/Pch: Add PPI and Protocol include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, Ankit > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/37] CoffeelakeSiliconPkg/Pch: Add include headers

2019-08-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, August 17, 2019 8:16 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Kinney, Michael D ; Sinha, Ankit > > Subject:

  1   2   >