Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX ; devel@edk2.groups.io
>Cc: Gao, Liming
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng
>
Pushed at 0970a80583a9a0595eb357f380e604b57136fa26
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Tuesday, August 20, 2019 2:24 PM
To: Feng, Bob C ; Fan, ZhijuX ;
devel@edk2.groups.io
Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
variable name
Hi Liming,
Done.
Patch is attached to https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Another BZ to apply CpuTimerLib will be tracking on:
https://bugzilla.tianocore.org/show_bug.cgi?id=2096
Thanks,
Donald
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, August 20, 2019
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Krzysztof Koch
Sent: 19 August 2019 09:25 AM
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [PATCH v2 03/11]
Pushed at 0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 ...
94459080c118049aba927ec0444ba5b750b7d2c9
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
Sent: Friday, August 16, 2019 12:06 PM
To: Shi, Steven ; devel@edk2.groups.io
Donald:
Please also attach the patch linker in BZs.
And, please submit another BZ for
edk2-platforms\Platform\Intel\KabylakeOpenBoardPkg to apply this new library
instance.
Thanks
Liming
>-Original Message-
>From: Kuo, Donald
>Sent: Tuesday, August 20, 2019 10:44 AM
>To:
From: Tom Lendacky
Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must
be used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 35 +++
1 file changed, 35 insertions(+)
diff
From: Tom Lendacky
Currently, the OVMF code relies on the hypervisor to enable the cache
support on the processor in order to improve the boot speed. However,
with SEV-ES, the hypervisor is not allowed to change the CR0 register
to enable caching.
Update the OVMF Sec support to enable caching
From: Tom Lendacky
Create a function that can be used to determine if the VM is running
as an SEV-ES guest.
Signed-off-by: Tom Lendacky
---
OvmfPkg/Include/Library/MemEncryptSevLib.h| 12 +++
.../MemEncryptSevLibInternal.c| 77 ---
2 files changed, 62
From: Tom Lendacky
Under SEV-ES, a MWAIT/MWAITX intercept generates a #VC exception.
VMGEXIT must be used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 29 +++
1 file changed, 29 insertions(+)
From: Tom Lendacky
Under SEV-ES, a RDTSCP intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 34 +++
1 file changed, 34 insertions(+)
diff
From: Tom Lendacky
Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 22 +++
1 file changed, 22 insertions(+)
diff
From: Tom Lendacky
Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must
be used to allow the hypervisor to handle this intercept.
Add support to construct the required GHCB values to support an MSR_PROT
NAE event. Parse the instruction that generated the #VC exception to
From: Tom Lendacky
Allocate memory for the GHCB pages during SEV initialization for use
during Pei and Dxe phases. Since the GHCB pages must be mapped as shared
pages, modify CreateIdentityMappingPageTables() so that pagetable entries
are created without the encryption bit set.
Signed-off-by:
From: Tom Lendacky
VMGEXIT is a new instruction used for Hypervisor/Guest communication when
running as an SEV-ES guest. A VMGEXIT will cause an automatic exit (AE)
to occur, resulting in a #VMEXIT with an exit code value of 0x403.
To support VMGEXIT, define the VMGEXIT assember routine to
From: Tom Lendacky
An SEV-ES guest will generate a #VC exception when it encounters a
non-automatic exit (NAE) event. It is expected that the #VC exception
handler will communicate with the hypervisor using the GHCB to handle
the NAE event.
Update the Pei and Dxe exception handling support to
From: Tom Lendacky
Add base support to handle #VC exceptions. This includes a stub routine
to invoke when a #VC exception occurs and special checks in the common
exception handlers to invoke the #VC exception handler routine.
Signed-off-by: Tom Lendacky
---
.../DxeCpuExceptionHandlerLib.inf
From: Tom Lendacky
This patch series provides support for running EDK2/OVMF under SEV-ES.
Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the
SEV support to protect the guest register state from the hypervisor. See
"AMD64 Architecture Programmer's Manual Volume 2: System
From: Tom Lendacky
A GHCB page is needed during the Sec phase, so this new page must be
created. Since the GHCB must be marked as an un-encrypted, or shared,
page, an additional pagetable page is required so break down the 2MB
region where the GHCB page lives into 4K pagetable entries.
Hi Ray,
On 8/19/19 4:47 PM, Ni, Ray wrote:
> Tom,
> 1. It's not a common practice to have static inline functions defined in
> header file. Who is going to call them?
The functions are called from two locations, so that's why I made them
static inline. I'm new to EDK2 programming, so I'm sure
From: Tom Lendacky
Under SEV-ES, a DR7 read or write intercept generates a #VC exception.
The #VC handler must provide special support to the guest for this. On
a DR7 write, the #VC handler must cache the value and issue a VMGEXIT
to notify the hypervisor of the write. However, the #VC handler
From: Tom Lendacky
A per-CPU implementation for holding values specific to a CPU when
running as an SEV-ES guest, specifically to hold the Debug Register
value. Allocate an extra page immediately after the GHCB page for each
AP.
Using the page after the GHCB ensures that it is unique per AP.
From: Tom Lendacky
When running as an SEV-ES guest in 32-bit mode, it is not possible to
perform a CPUID instruction because it will require communicating with
the hypervisor using the GHCB. However, writes to the GHCB when in
32-bit mode will be will be encrypted and thus not able to be read
From: Tom Lendacky
Typically, an AP is booted using the INIT-SIPI-SIPI sequence. This
sequence is intercepted by the hypervisor, which sets the AP's registers
to the values requested by the sequence. At that point, the hypervisor can
start the AP, which will then begin execution at the
From: Tom Lendacky
When starting APs in an SMP configuration, the AP needs to know if it is
running as an SEV-ES guest in order to assign a GHCB page.
Add a field to the CPU_MP_DATA structure that will indicate if SEV-ES is
active. This new field is set during MP library initialization with the
From: Tom Lendacky
Add support to the #VC exception handler to handle string IO. This
requires expanding the IO instruction parsing to recognize string based
IO instructions as well as preparing an un-encrypted buffer to be used
to transfer (either to or from the guest) the string contents for
From: Tom Lendacky
Under SEV-ES, a WBINVD intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 22 +++
1 file changed, 22 insertions(+)
diff
From: Tom Lendacky
Under SEV-ES, a MONITOR/MONITORX intercept generates a #VC exception.
VMGEXIT must be used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 31 +++
1 file changed, 31
From: Tom Lendacky
Introduce a finalization routine to the MP library. This routine is
used at the end of UEFI before transferring control to the OS and allows
for SEV-ES related AP state and information to be communicated to the OS.
The APs will be parked using VMGEXIT AP Reset Hold and the
From: Tom Lendacky
Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Add support to construct the required GHCB values to support a CPUID NAE
event. Additionally, CPUID 0x_000d requires XCR0 to be supplied in
From: Tom Lendacky
An SEV-ES guest will generate a #VC exception when it encounters a
non-automatic exit (NAE) event. It is expected that the #VC exception
handler will communicate with the hypervisor using the GHCB to handle
the NAE event.
NAE events can occur during the Sec phase, so
From: Tom Lendacky
Under SEV-ES, a RDPMC intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 33 +++
1 file changed, 33 insertions(+)
diff
From: Tom Lendacky
Under SEV-ES, a NPF intercept for an NPT entry with a reserved bit set
generates a #VC exception. This condition is assumed to be an MMIO access.
VMGEXIT must be used to allow the hypervisor to handle this intercept.
Add support to construct the required GHCB values to
From: Tom Lendacky
The SEV support will clear the C-bit from non-RAM areas. The early GDT
lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT
will be read as un-encrypted even though it is encrypted. This will result
in a failure to be able to handle the exception.
Move
From: Tom Lendacky
Under SEV-ES, a RDTSC intercept generates a #VC exception. VMGEXIT must be
used to allow the hypervisor to handle this intercept.
Signed-off-by: Tom Lendacky
---
.../X64/AMDSevVcCommon.c | 30 +++
1 file changed, 30 insertions(+)
diff
From: Tom Lendacky
Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT
must be used to allow the hypervisor to handle this intercept.
Add support to construct the required GHCB values to support a IOIO_PROT
NAE event. Parse the instruction that generated the #VC exception,
Donald:
Thanks for your update. If no other comment, I will help push this patch
tomorrow.
Thanks
Liming
> -Original Message-
> From: Kuo, Donald
> Sent: Tuesday, August 20, 2019 3:22 PM
> To: Gao, Liming ; devel@edk2.groups.io;
> ler...@redhat.com; Dong, Eric
> Cc: Ni, Ray ; Zeng,
Push @ ada905ab5c0e7ea7017e71d52219aaec1abd8dcb
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, August 19, 2019 1:42 PM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Mike Turner ; Wang, Jian J
> ; Bi, Dandan ; Laszlo Ersek
>
> Subject: RE: [patch v2][edk2-stable201908]
Leif, Andrew,
Better if a "yes" could be from one of you so that makes 3 "yes" of 4.
Thanks,
Ray
From: Kinney, Michael D
Sent: Monday, August 19, 2019 4:30 PM
To: Ni, Ray ; devel@edk2.groups.io; Gao, Liming
; Laszlo Ersek (ler...@redhat.com) ;
leif.lindh...@linaro.org; af...@apple.com; Cetola,
Hi Eric,
Comments inline.
On Tue, 2019-08-20 at 00:07 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
> Besides, EOL is converted to CRLF.
If you mix EOL conversion to CRLF and bug fix for
gBlackBoxEfiSimplePointerProtocolGuid, it is difficult to review the
Please ignore this. V2 is sent out. Thanks.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Eric Jin
> Sent: Wednesday, August 21, 2019 9:34 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-test][Patch 1/2] uefi-sct/SctPkg:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
Cc: Supreeth Venkatesh
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/UEFI/UEFI.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec
index
For 1-2, 4, 6-11: Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Thursday, August 15, 2019 9:11 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ;
Reasonable. Will split it in v2.
Best Regards
Eric
-Original Message-
From: devel@edk2.groups.io On Behalf Of Supreeth
Venkatesh
Sent: Wednesday, August 21, 2019 2:41 AM
To: Jin, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Fix the
Cc: Supreeth Venkatesh
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +-
1 file changed, 103 insertions(+), 103 deletions(-)
diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec
index bdf3323fc2da..c05fccdd9c10 100644
---
Signed-off-by: Eric Jin
---
uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +-
1 file changed, 103 insertions(+), 103 deletions(-)
diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec
index bdf3323fc2da..c05fccdd9c10 100644
---
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Monday, August 19, 2019 4:25 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ; sami.muja...@arm.com;
> matteo.carl...@arm.com;
My vote is Yes.
Thanks,
Andrew Fish
> On Aug 20, 2019, at 10:02 AM, Ni, Ray wrote:
>
> Ray,
>
> With your review, my vote is yes.
>
> Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46120):
Andrew, Mike,
Thank you. The "test and write" patches have been pushed.
Thanks,
Ray
From: af...@apple.com
Sent: Tuesday, August 20, 2019 10:53 AM
To: Ni, Ray
Cc: Kinney, Michael D ; devel@edk2.groups.io; Gao,
Liming ; Laszlo Ersek (ler...@redhat.com)
; leif.lindh...@linaro.org; Cetola,
Liming,
Thanks for the confirmation. It has been pushed.
Thanks,
Ray
From: Gao, Liming
Sent: Monday, August 19, 2019 5:48 PM
To: Ni, Ray ; devel@edk2.groups.io
Subject: RE: [edk2-devel] Patch List for 201908 stable tag
Ray:
It follows current soft feature freeze process. I am OK to fix it for
Remember to add entry for it at
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning.
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, August 20, 2019 7:56 PM
> To: Kuo, Donald ; devel@edk2.groups.io;
> ler...@redhat.com; Dong, Eric
> Cc: Ni, Ray ;
*Reminder:* TianoCore Design / Bug Triage - EMEA
*When:* Wednesday, 21 August 2019, 8:00am to 9:00am, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/695893389
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503238 )
*Organizer:* Stephano Cetola
52 matches
Mail list logo
