REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2059
These build failures can be reproduced simply by building the
AdvancedFeaturePkg.dsc file in GCC5. To build the whole package
DSC (not pull individual features into other packages), set
the WORKSPACE variable to the edk2 directory in the
Common definitions are not consumed by VFR. They are not required to be
defined in Tcg2ConfigNvData.h with WA way. New shared internal header
file is added to include those common definitions.
Cc: Jian Wang
Cc: Chao Zhang
Signed-off-by: Liming Gao
---
In V2:
Keep struct TCG2_DEVICE_DETECTION
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869
The UEFI spec requires that if any error occurs in
UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned
and not the return code of UninstallProtocolInterface().
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Dandan Bi
On 9/12/19 3:59 AM, Bi, Dandan wrote:
Hi ,
Thanks for the update.
I don't know how you send this patch, the format and subject seems a little
different from V1 patch. Anyway it doesn't block my review of this patch.
I have two minor comments for the function comments:
1. Per EDKII C Coding
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, September 11, 2019 8:27 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [PATCH v2 1/2] MinPlatformPkg/AcpiTables:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Wednesday, September 11, 2019 8:27 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject:
Hello Stephano,
the EDK II C Coding Standards Specification is available at:
https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf
It is copyright restricted, allowing only copying for internal use.
As EDK II has moved to be open source wouldn't it make
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2188
build -p MdeModulePkg\MdeModulePkg.dsc -a IA32 -m
MdeModulePkg\Universal\PCD\Pei\Pcd.inf
Error:
AttributeError: 'PlatformInfo' object has no attribute
'DynamicPcdList'
The DSC data object used to build a separate module today
is
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1858
for Dict={},There are pitfalls in the way this default parameter is set
and Dict is not used in functions, other functions have these two cases,
I will change some incorrect parameter defaults
This patch is going to fix this issue
Cc:
Two comments on SolStatus.c:
1. "SolEnabled" seems more appropriate variable name than just "Enabled. Should
we consider renaming the variable name?
2. Please replace EFI_D_ERROR with DEBUG_ERROR
-Original Message-
From: Kubacki, Michael A
Sent: Wednesday, September 11, 2019 11:09 PM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2113
AdapterInfoProtocolTest SetInformation Func and Conf change to
pass on EFI_UNSUPPORTED, better fitting the UEFI Spec.
Cc: Supreeth Venkatesh
Cc: Eric Jin Eric Jin
Signed-off-by: Tom Zhao
---
Cc other reviewers.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of John E
> Lofgren
> Sent: Tuesday, September 10, 2019 2:41 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Fix
> #AC
On Thu, 12 Sep 2019 at 15:46, Laszlo Ersek wrote:
>
> On 09/11/19 18:23, Ard Biesheuvel wrote:
> > After upgrading the CI system we use for building the ArmVirtPkg
> > targets, we started seeing failures due to the NOOPT build running
> > out of space when using the CLANG38 toolchain definition
On 09/11/19 18:23, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want to increase
Hi Ard,
On 9/11/19 6:23 PM, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want
On 9/11/2019 11:16 PM, Heinrich Schuchardt wrote:
Hello Stephano,
the EDK II C Coding Standards Specification is available at:
https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf
That's a link to an older doc. Check out the latest docs here:
On 09/12/19 16:46, Laszlo Ersek wrote:
> On 09/11/19 18:23, Ard Biesheuvel wrote:
>> After upgrading the CI system we use for building the ArmVirtPkg
>> targets, we started seeing failures due to the NOOPT build running
>> out of space when using the CLANG38 toolchain definition combined
>> with
Hi Jiewen,
Looking at the code yes you are right, sorry I forgot what exactly VarCheckLib
hooked in to versus didn’t hook into. The other one that same to mind was the
EDKII_VARIABLE_LOCK_PROTOCOL, but again, that only affects writes not reads.
Since the current variable driver does not have
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
Sent: Wednesday, September 11, 2019 8:27 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel] [PATCH v2 2/2]
After upgrading the CI system we use for building the ArmVirtPkg
targets, we started seeing failures due to the NOOPT build running
out of space when using the CLANG38 toolchain definition combined
with clang 7.
We really don't want to increase the FD/FV sizes in general to
accommodate this, so
On Thu, 12 Sep 2019 at 16:20, Philippe Mathieu-Daudé wrote:
>
> Hi Ard,
>
> On 9/11/19 6:23 PM, Ard Biesheuvel wrote:
> > After upgrading the CI system we use for building the ArmVirtPkg
> > targets, we started seeing failures due to the NOOPT build running
> > out of space when using the CLANG38
On 9/12/19 6:58 PM, Ard Biesheuvel wrote:
> After upgrading the CI system we use for building the ArmVirtPkg
> targets, we started seeing failures due to the NOOPT build running
> out of space when using the CLANG38 toolchain definition combined
> with clang 7.
>
> We really don't want to
While I'm all for improvements throughout the file, the scope of this change is
just to fix the GCC failures
and make general style improvements to impacted lines. I'll send a patch V2
with the DEBUG
macro updated to DEBUG_ERROR. Anything further peripheral cleanup is a slippery
slope for this
On 9/12/19 7:13 PM, Ard Biesheuvel wrote:
> On Thu, 12 Sep 2019 at 18:05, Philippe Mathieu-Daudé
> wrote:
>>
>> On 9/12/19 6:50 PM, Ard Biesheuvel wrote:
>>> On Thu, 12 Sep 2019 at 16:20, Philippe Mathieu-Daudé
>>> wrote:
Hi Ard,
On 9/11/19 6:23 PM, Ard Biesheuvel wrote:
Your whitespace doesn't quite match the edk2 coding style guidelines, but we
can fix that during commit.
Reviewed-by: Nate DeSimone
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, September 11, 2019 7:55 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869
BS.UninstallMultipleProtocolInterfaces - InterfaceTestCheckpoint7 - 9
expect UninstallMultipleProtocols() to return EFI_ACCESS_DENIED but the
UEFI spec has:
"If any errors are generated while the protocol interfaces are being
uninstalled,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2059
These build failures can be reproduced simply by building the
AdvancedFeaturePkg.dsc file in GCC5. To build the whole package
DSC (not pull individual features into other packages), set
the WORKSPACE variable to the edk2 directory in the
The patch series has been pushed as 5dd12a154d.. 9ea86f187d
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei
Sent: Wednesday, September 11, 2019 8:27 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
; Gao, Liming
28 matches
Mail list logo
