Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add library
>
>
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, October 5, 2019 1:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V2 3/3]
> BoardModulePkg/FirmwareBootMediaInfoPei: Add module
>
>
Reviewed-by: Eric Dong
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 1, 2019 9:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [edk2-platforms][PATCH V1 2/3]
> BoardModulePkg/FirmwareBootMediaInfoLib: Add library
>
>
Hi David,
I just realized you have the comments on Bugzilla 960:
>"...given that testing is failing and code inspection shows it would never
>have been expected to work."
Do you mean you didn't pass the verification if URLs with IPv6 literals
(https://[2001:8b0:10b:1236::1]/)? Can you also
Michael,
One comment below.
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, September 28, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wang, Jian J
> ; Wu, Hao
Codes changes for SMBIOS spec 3.3.0 (Already public on DMTF).
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Abner Chang (3):
MdeModulePkg: Update to support SmBios 3.3.0
MdePkg/Include: Update to support SmBios 3.3.0
ShellPkg/UefiShellDebug1CommandsLib: Update to
Shell command smbiosview updates for SMBIOS 3.3.0 spec.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
.../SmbiosView/PrintInfo.c | 23
This commit update the revision of SMBIOS spec reported in PCDs.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/MdeModulePkg.dec | 4 ++--
1 file changed, 2
Update SmBios.h to support SMBIOS 3.3.0 spec.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdePkg/Include/IndustryStandard/SmBios.h | 76
Codes changes for SMBIOS spec 3.3.0 (Already public on DMTF).
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Abner Chang (3):
MdeModulePkg: Update to support SmBios 3.3.0
MdePkg/Include: Update to support SmBios 3.3.0
ShellPkg/UefiShellDebug1CommandsLib: Update to
Shell command smbiosview updates for SMBIOS 3.3.0 spec.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
.../SmbiosView/PrintInfo.c | 23
Update SmBios.h to support SMBIOS 3.3.0 spec.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdePkg/Include/IndustryStandard/SmBios.h | 76
This commit update the revision of SMBIOS spec reported in PCDs.
Bugzilla link,
https://bugzilla.tianocore.org/show_bug.cgi?id=2202
Signed-off-by: Abner Chang
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/MdeModulePkg.dec | 4 ++--
1 file changed, 2
Push at 3d98de052fcd47f187190802e6201ac6aaabfda7
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eric Jin
Sent: Monday, September 30, 2019 2:56 PM
To: Heinrich Schuchardt ; EDK II Development
Cc: Supreeth Venkatesh ; Stephano Cetola
Subject: Re:
Thanks Liming,
[PATCH v5] was sent.
I added BZ link in commit message in each patch and reverted the changes on
PcdSmbiosDocRev.
Abner
> -Original Message-
> From: Gao, Liming [mailto:liming@intel.com]
> Sent: Tuesday, October 8, 2019 9:15 AM
> To: devel@edk2.groups.io; Chang,
Hi Liming,
If you push this set (v5), could you possibly also push it to
https://github.com/tianocore/edk2-staging/tree/RISC-V-V2 ?
The three patches apply cleanly on this revision, and are a
prerequisite for the code destined to go in there.
Best Regards,
Leif
On Tue, Oct 08, 2019 at
Repo: https://github.com/lersek/edk2.git
Branch: max_cpus_bz_1515
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515
UefiCpuPkg/MpInitLib currently lacks support for the following use case:
- time-limited AP enumeration is not reliable on the platform
(individual AP check-in may
PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are
only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen does
not include that module. Remove the unnecessary dynamic PCD defaults from
"OvmfXen.dsc".
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Igor Mammedov
MaxCpuCountInitialization() currently handles the following options:
(1) QEMU does not report the boot CPU count.
In this case, PlatformPei makes MpInitLib enumerate APs up to the
default PcdCpuMaxLogicalProcessorNumber value (64) minus 1, or until
the default
pc-q35-4.2+ and pc-i440fx-4.2+ machine types report CPU topology info in
the "etc/x86-smp-topology" fw_cfg file. Add a structure type for parsing
this blob.
Cc: Ard Biesheuvel
Cc: Igor Mammedov
Cc: Jordan Justen
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515
Signed-off-by: Laszlo
If a platform boots with a CPU topology that is not fully populated (that
is, the boot CPU count is smaller than PcdCpuMaxLogicalProcessorNumber),
then the platform cannot use the "fast AP detection" logic added in commit
6e1987f19af7. Said logic depends on the boot CPU count being equal to
On Tue, 8 Oct 2019 at 13:27, Laszlo Ersek wrote:
>
> Repo: https://github.com/lersek/edk2.git
> Branch: max_cpus_bz_1515
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515
>
> UefiCpuPkg/MpInitLib currently lacks support for the following use case:
>
> - time-limited AP enumeration
On 10/8/19 1:27 PM, Laszlo Ersek wrote:
PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are
only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen does
not include that module. Remove the unnecessary dynamic PCD defaults from
"OvmfXen.dsc".
Cc: Anthony
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Abner Chang [mailto:abner.ch...@hpe.com]
> Sent: Tuesday, October 08, 2019 1:04 AM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni,
> Ray ; Gao, Zhichao ; Leif
> Lindholm ; Gilbert Chen
>
Laszlo:
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, October 1, 2019 4:42 AM
> To: devel@edk2.groups.io; Gao, Liming
> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain
>
> Hi Liming,
>
> On 09/27/19 09:46, Liming Gao wrote:
> > 1. Apply CLANG9
On Mon, Oct 07, 2019 at 02:02:26AM +0200, Marcin Wojtas wrote:
> Hitherto code was executing by mistake the first
> possible initialization routine (valid for 88E1512 PHY),
> regardless the setting in gMarvellTokenSpaceGuid.PcdPhyDeviceIds.
> Fix this.
>
> Signed-off-by: Marcin Wojtas
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Jeremy Soller
> Subject: [edk2-platforms][PATCH V1 05/17]
> KabylakeOpenBoardPkg/GalagoPro3:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Jeremy Soller
> Subject: [edk2-platforms][PATCH V1 04/17]
> KabylakeOpenBoardPkg/GalagoPro3:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
>
> Subject: [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC
> include file section
BaseTools VolInfo tool. Its input is the binary FvImage file. In the same
directory, GuidedSectionTools.txt (built in the FV directory) should be here.
Thanks
Liming
> -Original Message-
> From: Loh, Tien Hock
> Sent: Tuesday, October 1, 2019 10:34 AM
> To: Gao, Liming ;
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 03/17]
> KabylakeOpenBoardPkg/KabylakeRvp3: DSC cleanup
>
>
From: devel@edk2.groups.io On Behalf Of Andrew Fish via
Groups.Io
Sent: Tuesday, October 1, 2019 5:12 AM
To: devel@edk2.groups.io; ler...@redhat.com
Cc: Gao, Liming
Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove
__inline__ attribute for IO functions
On Sep 30,
On Tue, 8 Oct 2019 13:27:14 +0200
Laszlo Ersek wrote:
> MaxCpuCountInitialization() currently handles the following options:
>
> (1) QEMU does not report the boot CPU count.
>
> In this case, PlatformPei makes MpInitLib enumerate APs up to the
> default PcdCpuMaxLogicalProcessorNumber
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 11/17]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Update FSP
Push @2de1f611be06ded3a59726a4052a9039be7d459b
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Tuesday, October 1, 2019 7:12 AM
> To: devel@edk2.groups.io; Ni, Ray ; p...@akeo.ie
> Cc: Gao, Zhichao
> Subject: Re: [edk2-devel] [PATCH 1/1]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1974
Removing calls to UNDI->Shutdown() and Stop() functions in ExitBootServices
event notification function. Since SNP event reacting to ExitBootServices
is only calling those two functions, I am removing that as well.
Cc: Siyuan Fu
Cc:
Patch addresses Bugzilla #1972.
During ExitBootServices stage, drivers should not call any
functions known to use Memory Allocation Services. One of such
functions (as per UEFI spec) is UNDI->Shutdown().
Since UNDI drivers during ExitBootServices phase are expected
to put the adapter to such a
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 09/17]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 08/17]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Relocate
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abner Chang
> Sent: Tuesday, October 8, 2019 4:04 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com
> Subject: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0
>
> Codes changes for
OK. I will push them to edk2-staging/tree/RISC-V-V2.
Thanks
Liming
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, October 8, 2019 6:11 PM
> To: Gao, Liming
> Cc: devel@edk2.groups.io; abner.ch...@hpe.com; Kinney, Michael D
> ; Chen, Gilbert
>
> Subject: Re: [edk2-devel]
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
>
> Subject: [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC
> include file section tags
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 12/17]
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: DSC cleanup
Laszlo:
I will verify your option (a) and (b). The problem is described in
https://bugzilla.tianocore.org/show_bug.cgi?id=2024.
I know there are some discussion in Jordan patch for PeiCore change. Before
the conclusion for Jordan change is made,
I expect to find the alternate option to
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:16 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V1 01/17]
> KabylakeOpenBoardPkg/KabylakeRvp3: Remove
Ok, noted with thanks Liming. I'll try the tools out.
Thanks
Tien Hock
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, October 8, 2019 10:04 PM
> To: Loh, Tien Hock ; devel@edk2.groups.io;
> ler...@redhat.com
> Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 8, 2019 1:17 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Jeremy Soller
> Subject: [edk2-platforms][PATCH V1 06/17]
> KabylakeOpenBoardPkg/GalagoPro3: DSC
On 10/08/19 15:11, Philippe Mathieu-Daudé wrote:
> On 10/8/19 1:27 PM, Laszlo Ersek wrote:
>> PcdCpuMaxLogicalProcessorNumber and PcdCpuApInitTimeOutInMicroSeconds are
>> only referenced in "OvmfPkg/PlatformPei/PlatformPei.inf", and OvmfXen
>> does
>> not include that module. Remove the
I will clarify that aspect in the commit message.
Thanks,
Michael
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, October 7, 2019 7:12 PM
> To: devel@edk2.groups.io; Kubacki, Michael A
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney,
Reply inline.
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, October 7, 2019 11:08 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael
> D ; Ni, Ray ; Wu, Hao A
> ; Yao, Jiewen
On 10/08/19 16:47, Gao, Liming wrote:
> [Liming] I verify GCC5 tool chain. I will verify GCC48/GCC49 and
> XCODE5.
>
> I don’t know the specific reason about __inline__. If there is no
> impact on
>
> other GCC tool chain, I prefer to remove them.
> [Liming] This seems the
On 10/08/19 17:06, Igor Mammedov wrote:
> On Tue, 8 Oct 2019 13:27:14 +0200
> Laszlo Ersek wrote:
>
>> MaxCpuCountInitialization() currently handles the following options:
>>
>> (1) QEMU does not report the boot CPU count.
>>
>> In this case, PlatformPei makes MpInitLib enumerate APs up to
Hello,
I am creating the edk2-ci branch in the edk2-staging
repo to test out some of the concepts from the RFCs to
add CI to the edk2 repo.
https://edk2.groups.io/g/rfc/message/93
https://edk2.groups.io/g/rfc/message/96
Best regards,
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
On 10/08/19 17:02, Gao, Liming wrote:
> Laszlo:
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Tuesday, October 1, 2019 4:42 AM
>> To: devel@edk2.groups.io; Gao, Liming
>> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain
>>
>> Hi Liming,
>>
>> On
On 10/08/19 13:35, Ard Biesheuvel wrote:
> On Tue, 8 Oct 2019 at 13:27, Laszlo Ersek wrote:
>>
>> Repo: https://github.com/lersek/edk2.git
>> Branch: max_cpus_bz_1515
>> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515
>>
>> UefiCpuPkg/MpInitLib currently lacks support for the
The rationale for moving the generic parsing functions out would be better to
capture in the
commit message. That will be added to V3.
Thanks,
Michael
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, October 7, 2019 7:12 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCEL
CALSCALE:GREGORIAN
BEGIN:VEVENT
STATUS:CANCELLED
UID:calendar.15...@groups.io
DTSTAMP:20191009T000616Z
ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com
DTSTART:20190529T15Z
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 8, 2019 7:27 PM
> To: edk2-devel-groups-io
> Cc: Dong, Eric ; Igor Mammedov
> ; Ni, Ray
> Subject: [edk2-devel] [PATCH 1/4]
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10:
Relocate DSC includes
This change
Hi, Maciej
Have you tested what will happen if this SNP co-work with those UNDI drivers
which don't have an ExitBootService event callback to shut down its DMA
activity? And what's the impact to OS if UNDI's DMA is not shut down?
Best Regards
Siyuan
> -Original Message-
> From:
On 09/17/19 21:49, Laszlo Ersek wrote:
> Repository: https://github.com/lersek/edk2.git
> Branch: voidptr
>
> The UEFI / PI / Shell specifications define a number of standard types
> as pointers to VOID. This is arguably a design mistake; those types
> should have been pointers to distinct
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 16/17] SimicsOpenBoardPkg/BoardX58Ich10: DSC
cleanup
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 17/17] SimicsOpenBoardPkg: Assign unique
token namespace
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 15/17] SimicsOpenBoardPkg/BoardX58Ich10:
Remove OpenBoardPkgConfig.dsc
How about change the function name from ProcessorArchitectureType to
DisplayProcessorArchitectureType?
And why separate the processor arch type display into two section:
i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thru
PRINT_STRUCT_VALUE_H, second display the value's
On 10/08/19 02:32, Fu, Siyuan wrote:
> Just return from vacation. Sorry for late response.
>
> Reviewed-by: Siyuan Fu
Thank you and Mike both!
Laszlo
>> -Original Message-
>> From: devel@edk2.groups.io On Behalf Of Philippe
>> Mathieu-Daudé
>> Sent: 2019年9月24日 19:00
>> To:
I'm going to cancel these meetings going forward as we have not been receiving
regular designs to review.
If I do get any design review requests, I will schedule this meeting on a "as
needed" basis.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
String parsing code is added to BIOSInfoUpdateSmbiosType0() so that
any numeric "x.y" value being passed in PcdFirmwareVersionString is
now used to populate the BIOS major and minor.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 44
Improve RpiFirmwareGetSerial() to derive a serial number from the
MAC address, in case the platform returns 0 for the serial number.
Also fix a typo where "%s" was used instead of "%a".
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 11
v1 can be found at https://edk2.groups.io/g/devel/message/46806 - 46808
Changes for v2:
- Split *functional* changes into multipe commits
- Spell out serial number
- *NEW* Derive Type 19 addresses from board revision (RPi4 improvement)
Also, with regards to further splitting that was requested
This patch cleans up the population SMBIOS entries by removing elements
that we don't have data for, as well as properly filling the ones for
which we do, through the newly added queries from RpiFirmwareDxe.
Additional minor improvements are also applied, such as consistent use
of uppercase
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b) and doubling in size for each value.
Signed-off-by: Pete Batard
---
This patch introduces the capability to also query the Model Name/
Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware
protocol. This is aims at making the driver more suitable to cater
for platforms other than the Raspberry Pi 3 as well as simplifying
the population of entries in
73 matches
Mail list logo
