On Wed, 2019-10-16 at 16:43 +0200, Laszlo Ersek wrote:
> Regarding the current edk2 patch set, I think we should do the following:
>
> - use X509_VERIFY_PARAM_set1_ip() rather than
> X509_VERIFY_PARAM_set1_ip_asc()
>
> - incorporate "StdLib/BsdSocketLib/inet_pton.c" from the edk2-libc
> project
On Wed, Oct 16, 2019 at 06:50:29PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/16/19 5:18 PM, Leif Lindholm wrote:
> > For this reason *I* would not use said script, but I'm not going to
> > say we shouldn't have it. I will say it shouldn't be enabled by
> > default by SetupGit.py though.
>
>
Thanks Ray, this was a good discussion. I will leave the library instances
as-is for now.
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, October 15, 2019 11:30 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V
> Subject: RE: [edk2-platforms][PATCH
Platform\Intel\KabylakeOpenBoardPkg\GalagoPro3\OpenBoardPkg.dsc
* Please move $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf under
the "Board Package" section.
Platform\Intel\KabylakeOpenBoardPkg\KabylakeRvp3\OpenBoardPkg.dsc:
* Please move $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf under
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Tuesday, October 15, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH v2 4/4] Platform/Intel: Add FIT
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Tuesday, October 15, 2019 3:51 PM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info
>
Platform\Intel\WhiskeylakeOpenBoardPkg\WhiskeylakeURvp\OpenBoardPkg.dsc:
* Please move $(PLATFORM_BOARD_PACKAGE)/BiosInfo/BiosInfo.inf under
the "Board Package" section.
Thanks,
Michael
> -Original Message-
> From: Agyeman, Prince
> Sent: Tuesday, October 15, 2019 3:51 PM
> To:
> My concerns with that approach:
>
> 1. In general, I believe it is better if the library reads the value once and
> caches it. The firmware boot media is fixed after power-on by nature and in
> some platforms, boot media information may be provided to the IBB in a
> temporary SRAM (or other
Hi Leif,
wt., 15 paź 2019 o 20:07 Leif Lindholm napisał(a):
>
> On Mon, Oct 14, 2019 at 03:25:04PM +0200, Marcin Wojtas wrote:
> > From: Patryk Duda
> >
> > This patch implements convenient way of changing strings included
> > in SMBIOS Table1, Table2, Table3.
> >
> > Strings can be altered by
Hi Michael,
Please see my inline comments.
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wang, Jian J
When c/h file use macro after #include, for example,
In this case, GenMake is not able to create a healthy dependency for the c
file. GenMake used to add $(FORCE_REBUILD) dependency in the c file, this
guarantee the c file is always compiled in incremental build. But, this
function is broken since
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155
Now the test item "EFICompliantTest" will be gen in the XXX.csv.
However, I find most of the SCT user will not know what platform
config they test is, so I think we can independently generate a
file of the "EFICompliantTest" tests, then
Adjust the prefix to [edk2-devel] [edk2-test] [PATCH V3] in subject
Hi Arvin,
Still have one comment in the GenTestConfigTitle()
> -Original Message-
> From: Chen, ArvinX
> Sent: Tuesday, October 15, 2019 4:53 PM
> To: devel@edk2.groups.io
> Cc: Jin, Eric
> Subject: [PATCH]
Adjust the prefix to [edk2-devel] [edk2-test] [PATCH V4] in subject
Reviewed-by: Eric Jin
> -Original Message-
> From: Chen, ArvinX
> Sent: Wednesday, October 16, 2019 2:33 PM
> To: devel@edk2.groups.io
> Cc: Jin, Eric
> Subject: [PATCH] uefi-sct/SctPkg: Auto gen result of
Hi Jiaxin,
On 10/16/19 07:18, Wu, Jiaxin wrote:
> These days I'm too busy with other things. Just take the time to
> review the email discussion & researched the correct behavior of HTTPS
> cert verification.
>
> I did never though my patch caused the function regression, and I'm
> also not loop
On Wed, 2019-10-16 at 05:18 +, Wu, Jiaxin wrote:
> Fortunately, I get my wanted answer in RFC6125, SECTION 3.1 :
>
>If a subjectAltName extension of type dNSName is present, that MUST
>be used as the identity. Otherwise, the (most specific) Common Name
>field in the Subject field
On Wed, 2019-10-16 at 09:36 +0200, Laszlo Ersek wrote:
> On 10/16/19 07:18, Wu, Jiaxin wrote:
> >In some cases, the URI is specified as an IP address rather than a
> >Hostname . In this case, the iPAddress subjectAltName must be
> >present in the certificate and must exactly match the
Hi Liming,
Would you please add the BZ link to each of the patches? So that we can see it
in git commit log.
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Tuesday, October 15, 2019 8:27 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Shi, Steven ;
Justen, Jordan L ; Laszlo
The comments are for VariableRuntimeCache.c only.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian
> J
> Sent: Wednesday, October 16, 2019 2:46 PM
> To: Kubacki, Michael A ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ;
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 03/10]
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, October 04, 2019 2:35 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen
> Subject: RE: [edk2-devel] [PATCH
Here's an extra point:
On 10/16/19 09:36, Laszlo Ersek wrote:
> On 10/16/19 07:18, Wu, Jiaxin wrote:
>> Fortunately, I get my wanted answer in RFC6125, SECTION 3.1 :
>>
>>If a subjectAltName extension of type dNSName is present, that MUST
>>be used as the identity. Otherwise, the (most
pushed at 1e509eb07d5fa4ce93653cd4410b04cf6c815ea5
-Original Message-
From: devel@edk2.groups.io On Behalf Of Eric Jin
Sent: Saturday, October 12, 2019 12:57 PM
To: devel@edk2.groups.io; supreeth.venkat...@arm.com
Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Convert files
Sunny,
For the OS recovery question, I had the code change in
https://github.com/niruiyu/edk2/tree/bds/osrecovery.
Due to there is no OS support for OS recovery yet, the code was not pushed.
Do you see any needs of the OS recovery?
Thanks,
Ray
> -Original Message-
> From: Wang, Sunny
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 02/10]
On 10/16/19 09:40, Wang, Sunny (HPS SW) wrote:
> According to the UEFI specification section 3.4.1 and 3.4.2, the OsRecovery
> and PlatformRecovery options should still be processed regardless of the
> value of OsIndications variable if processing of BootOrder does not result in
> success.
Again, I would like to ask for help from other reviewers to look at this patch
(patch 7/10) and the next one (patch 8/10) (at least from the security
perspective). Any help will be appreciated, thanks in advance.
One comment inherited from the feedback on the V2 series:
I saw AtRuntime() is
On Wed, 2019-10-16 at 09:54 +0200, Laszlo Ersek wrote:
> Anyway: once David's PR#9201 is merged into OpenSSL, the example code in
> the wiki page that calls SSL_set1_host() will become right.
Crypto libraries should make it hard for users to get it wrong.
Film at 11.
-=-=-=-=-=-=-=-=-=-=-=-
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 05/10]
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 08/10]
On 10/16/19 09:36, Laszlo Ersek wrote:
> On 10/16/19 07:18, Wu, Jiaxin wrote:
>> Comment2: do we really need the app_verify_callback function setting?
>> Why not call X509_VERIFY_PARAM_set1_ip_asc (TlsConn->Ssl->param,
>> HostName) in TlsSetVerifyHost directly? anything I missed in the
>>
On Tue, 2019-10-15 at 19:34 +0200, Laszlo Ersek wrote:
> Ehh, I failed to ask the actual question.
>
> Is it OK to call X509_VERIFY_PARAM_set1*() multiple times -- basically,
> every time just before we call X509_verify_cert()?
>
> My concern is not with the crypto functionality, but whether we
Thanks for checking this, Zhichao and Ray.
I just sent a patch to fix it with the subject " [edk2-devel] [PATCH]
MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications"
Regards,
Sunny Wang
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
MdeModulePkg/BdsDxe: Do PlatformRecovery regardless of OsIndications
According to the UEFI specification section 3.4.1 and 3.4.2,
the OsRecovery and PlatformRecovery options should still be
processed regardless of the value of OsIndications variable
if processing of BootOrder does not result in
Hi Liming,
Would you please add more description in commit message? This patch is in the
patch set of CLANG9 enabling, but it's hard for me to see the direct
relationship between CLANG9 and this fix and why the original code is wrong.
Thanks
Bob
-Original Message-
From:
According to the UEFI specification section 3.4.1 and 3.4.2, the OsRecovery and
PlatformRecovery options should still be processed regardless of the value of
OsIndications variable if processing of BootOrder does not result in success.
Therefore, update the code to check
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 01/10]
Liming,
You missed the Cc tag so Andrew and I were not CCed.
3 comments in below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Liming
> Gao
> Sent: Tuesday, October 15, 2019 8:27 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable
Thanks for catching this, Laszlo.
Thanks for the suggestion and information, Zhichao. Next time, I will
definitely take care of this in the first place.
Hi Jian and Hao,
I forgot to add both of you in Cc. Sorry about that. I will send you guys a new
patch with the updated commit message
On 10/16/19 11:40, David Woodhouse wrote:
> On Tue, 2019-10-15 at 19:34 +0200, Laszlo Ersek wrote:
>> Ehh, I failed to ask the actual question.
>>
>> Is it OK to call X509_VERIFY_PARAM_set1*() multiple times -- basically,
>> every time just before we call X509_verify_cert()?
>>
>> My concern is
On 10/16/19 11:19, David Woodhouse wrote:
> On Wed, 2019-10-16 at 09:36 +0200, Laszlo Ersek wrote:
>> On 10/16/19 07:18, Wu, Jiaxin wrote:
>>>In some cases, the URI is specified as an IP address rather than
>>>a Hostname . In this case, the iPAddress subjectAltName must be
>>>present
On 10/15/19 1:07 PM, Ard Biesheuvel wrote:
DynamicTablesPkg can be built for ARM as well as for AARCH64, but on
the former, doing so will result in a build failure due to the lack
of 64-bit division helpers provided by the ArmPkg intrinsics library.
So add the missing reference, for both ARM and
On Wed, 2019-10-16 at 01:08 +0200, Laszlo Ersek wrote:
> Notes:
> Unfortunately, there are two problems with this patch:
>
> (1) X509_VERIFY_PARAM_set1_ip_asc() does not accept IPv4 addresses in
> dot-decimal notation (unless I messed up the code). My log file
>
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Derek,
On 10/16/19 8:17 AM, Lin, Derek (HPS SW) wrote:
When c/h file use macro after #include, for example,
Apparently you forgot to write your example.
In this case, GenMake is not able to create a healthy dependency for the c
file. GenMake used to add $(FORCE_REBUILD) dependency in the
On 10/16/19 1:43 PM, Pete Batard wrote:
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Oops.
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +-
1 file changed, 1
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek
Reviewed-by: Hao A Wu
Reviewed-by: Liming Gao
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+),
Some "processing/processed" words are written with an extra 's'.
Properly write them.
v2: Rebased
Philippe Mathieu-Daudé (4):
MdeModulePkg DxeCore: Fix typo in function name
MdeModulePkg/PiSmmCore: Fix typo in function name
StandaloneMmPkg/Core: Fix typo in function name
On 10/16/19 15:25, Philippe Mathieu-Daude wrote:
> Some "processing/processed" words are written with an extra 's'.
> Properly write them.
>
> v2: Rebased
>
> Philippe Mathieu-Daudé (4):
> MdeModulePkg DxeCore: Fix typo in function name
> MdeModulePkg/PiSmmCore: Fix typo in function name
>
On 10/16/19 4:09 PM, Philippe Mathieu-Daude wrote:
Add a new script GitCcCmd.sh that git-send-email can use to
automatically determine which addresses to cc on patch submission.
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/GitCcCmd.sh | 38 +++
On 10/16/19 15:35, David Woodhouse wrote:
> On Wed, 2019-10-16 at 13:41 +0200, Laszlo Ersek wrote:
>> Anyway: we still have the issue that X509_VERIFY_PARAM_set_ip_asc()
>> appears to reject IPv4 address literals. Could you check that please?
>>
>> (Using a hosted (Linux userspace) program like
On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/16/19 1:43 PM, Pete Batard wrote:
> > DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
>
> Oops.
+1
> Reviewed-by: Philippe Mathieu-Daude
And
Reviewed-by: Leif Lindholm
Pushed as
An extra 's' slipped into the 'processing' word.
Drop it to fix the typo.
Reviewed-by: Laszlo Ersek
Reviewed-by: Siyuan Fu
Signed-off-by: Philippe Mathieu-Daude
---
NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6Option.c
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek
Reviewed-by: Hao A Wu
Reviewed-by: Liming Gao
Signed-off-by: Philippe Mathieu-Daude
---
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+), 2
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek
Signed-off-by: Philippe Mathieu-Daude
---
StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
StandaloneMmPkg/Core/FwVol.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
On 2019.10.16 14:24, Leif Lindholm wrote:
On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote:
On 10/16/19 1:43 PM, Pete Batard wrote:
DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
Oops.
+1
Yeah, my bad here.
I was under the impression that
On Wed, 2019-10-16 at 13:41 +0200, Laszlo Ersek wrote:
> On 10/16/19 11:19, David Woodhouse wrote:
> > In the end you did actually solve it all for yourself -- based on the
> > pointer I'd given in bugzilla, and then ignoring my subsequent
> > misdirection about callbacks and my overly complex
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Wednesday, October 16, 2019 9:26 PM
> To: devel@edk2.groups.io
> Cc: Supreeth Venkatesh ; Dong, Eric
> ; Gao, Liming ; Achin Gupta
> ; Bi, Dandan ; Wu, Jiaxin
> ; Wu, Hao A ; Ni, Ray
> ; Fu,
Add a new script GitCcCmd.sh that git-send-email can use to
automatically determine which addresses to cc on patch submission.
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/GitCcCmd.sh | 38 +++
1 file changed, 38 insertions(+)
create mode 100755
The GetMaintainer.py script use the "if __name__ == '__main__'"
evaluation so it expects to be run as a standalone program.
We have other Python scripts with the executable permission, let
this one be executable too.
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/GetMaintainer.py
Hi,
This series contains trivial fixes to the GetMaintainer.py script,
then adds a new script which allow git-send-email to automatically
fills the email addresses relevant to each patch, using the new
Maintainer.txt format (with the GetMaintainer.py script).
I sent this series adding:
To have GetMaintainer.py script output easily parsable by
scripts, add the '--quiet' option. Output will be formatted
as one email per line.
Signed-off-by: Philippe Mathieu-Daude
---
BaseTools/Scripts/GetMaintainer.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
Hi Phil,
On 10/16/19 16:09, Philippe Mathieu-Daude wrote:
> Hi,
>
> This series contains trivial fixes to the GetMaintainer.py script,
> then adds a new script which allow git-send-email to automatically
> fills the email addresses relevant to each patch, using the new
> Maintainer.txt format
reviewed-by: jiewen Yao
thank you!
Yao, Jiewen
> 在 2019年10月17日，上午7:47，Gao, Liming 写道：
>
> commit a7e2d20193e853020a1415c25b53280955055394 introduces the code to
> get PcdTpm2AcpiTableRev in the driver entry point. This PCD is designed as
> DynamicHii or DynamicHiiEx PCD. So, this PCD
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, October 16, 2019 9:32 PM
> To: Philippe Mathieu-Daude; devel@edk2.groups.io
> Cc: Supreeth Venkatesh; Dong, Eric; Gao, Liming; Achin Gupta; Bi, Dandan;
> Wu,
Yes. I will add it on next version patch.
Thanks
Liming
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, October 16, 2019 5:19 PM
>To: Gao, Liming ; devel@edk2.groups.io
>Cc: Yao, Jiewen ; Shi, Steven
>; Justen, Jordan L ; Laszlo
>Ersek ; Andrew Fish ; Ni, Ray
>; Ard Biesheuvel ;
Evelyn,
GetGlobalVtdPmrAlignment() is the only API listed in the library header file
but I saw all
the three functions in the library C file have the EFIAPI prefix.
Only the public library API needs the EFIAPI prefix.
Thanks,
Ray
> -Original Message-
> From: Wang, Iwen Evelyn
> Sent:
IndexTable->Length is used as index in array IndexTable->Index[].
So IndexTable->Length needs to be checked, which should be less than
the array size.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/Variable/Pei/Variable.c | 2 +-
1 file changed, 1
Push
@b8fc5c03e5b5551b083f7efe91a051faa00c1e27..e797a806a8d090a09a782fe10ba2765154579d4b
Please close BZ 2202.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Gao, Zhichao
>Sent: Wednesday, October 16, 2019 8:45 AM
>To: Abner
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770
1) DisableDMAr Function Code Optimization
Optimize the flow to follow the VT-d spec requirements.
2) Renamed InitDmar() to InitGlobalVtd()
The oringal function name is misleading
Signed-off-by: Evelyn Wang
Cc: Jenny Huang
Cc: More Shih
> The "Data" parameter is marked OPTIONAL in FindVariableInRuntimeCache () for
> essentially the same reason
> it is labeled OPTIONAL in the GetVariable () API in the UEFI specification.
> Callers
> expect that they can pass a
> NULL as an actual parameter for Data and get back the size of a
Hi Phillippe,
Yeah, I forgot to fill my example. Thanks for the catch.
It is exactly as Bob mentioned, #include MACRO(xxx.h).
There are silicon code use macro to separate definitions, and use the approach
to reuse code. Like:
#define PATH(x) // in platform 1
#define PATH(x) // in platform 2
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 16, 2019 10:14 AM
> To: Ashish Singhal; devel@edk2.groups.io; Ni, Ray; jbra...@nvidia.com
> Subject: RE: [PATCH v4 2/2] MdeModulePkg/XhciPei: Fix Aligned Page
> Allocation
>
> > -Original Message-
> > From: Ashish
OK. I will update the commit message to describe this issue.
This change is to make sure section size is in section raw data scope.
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, October 16, 2019 5:27 PM
>To: devel@edk2.groups.io; Gao, Liming
>Subject: RE: [edk2-devel]
Your threshold is slightly lower than mine for adding the local variable. My
test plan is already
done on this patch series. Do you consider this mandatory?
Thanks,
Michael
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 16, 2019 6:01 PM
> To: Kubacki, Michael A ;
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Friday, October 4, 2019 12:32 AM
> To: devel@edk2.groups.io; Chen, Gilbert
> Cc: Palmer Dabbelt
> Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14]
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Wang, Iwen Evelyn
> Sent: Thursday, October 17, 2019 7:02 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny ; Shih, More
> ; Ni, Ray ; Chaganty, Rangasai V
> ; Yao, Jiewen
> Subject: [PATCH] IntelSiliconPkg-Vtd: Code Optimization
>
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770
1) IOMMU PMR feature should be generic to support different hardware
architecture. Platforms may request no overlap between PMR regions
and system reserve memory. Create an interface to control PLMR/PHMR
regions. It allows silicon code to
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen
> Subject: [PATCH V4 04/10]
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, October 17, 2019 12:37 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen
> Subject: RE: [edk2-devel]
The "Data" parameter is marked OPTIONAL in FindVariableInRuntimeCache () for
essentially the same reason
it is labeled OPTIONAL in the GetVariable () API in the UEFI specification.
Callers expect that they can pass a
NULL as an actual parameter for Data and get back the size of a buffer needed
> >
> >1. Why move the assignment to a later place? Can you explain a bit more?
> The hang issue here.
>
> I investigate this issue more. The root cause is that GetProcessAffinityMask()
> API requires the 64bit pointer as the input for 64bit ARCH. So, the correct
> fix
> should declare
Ray:
>-Original Message-
>From: Ni, Ray
>Sent: Wednesday, October 16, 2019 5:32 PM
>To: devel@edk2.groups.io; Gao, Liming
>Cc: 'Andrew Fish (af...@apple.com)'
>Subject: RE: [edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool
>chain
>
>Liming,
>You missed the Cc tag so Andrew
The returned value from GetBufferForValue might be NULL, so add a
check for that before it is used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 5 +
1 file changed, 5 insertions(+)
diff --git
If the target string doesn't appear in the searched string,
StringPtr will be NULL. So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 4
1 file changed, 4 insertions(+)
diff --git
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
The variables and return value might be NULL.
So add check for them before they are used.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
MdeModulePkg/EbcDebugger: Add check for Entry and RetEntry
MdeModulePkg/HiiDatabaseDxe: Add
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
Reviewed-by: Ray Ni
> -Original Message-
> From: Wang, Iwen Evelyn
> Sent: Thursday, October 17, 2019 11:21 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny ; Shih, More
> ; Ni, Ray ; Chaganty, Rangasai V
> ; Yao, Jiewen
> Subject: [v7 v7] IntelSiliconPkg-Vtd: A new PMR interface
>
>
I think one of the example would be like this:
#include MACRO(xxx.h)
I think this patch is good. Thanks for caching and fixing this bug.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe
Just expecting consistency for the rule, I found that for function
VariableServiceGetNextVariableName(), there are 4 occurrences and the local
variable is introduced.
But for VariableExLibFindNextVariable(), there are 5 occurrences but no local
variable is introduced.
Best Regards,
Hao Wu
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Tuesday, October 08, 2019 4:04 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Wu, Hao A; Wang, Jian J; Leif Lindholm; Gilbert
> Chen
> Subject: [edk2-devel] [PATCH
commit a7e2d20193e853020a1415c25b53280955055394 introduces the code to
get PcdTpm2AcpiTableRev in the driver entry point. This PCD is designed as
DynamicHii or DynamicHiiEx PCD. So, this PCD depends on Variable service.
To make sure PcdTpm2AcpiTableRev value be got, add Variable service as Depex.
On 10/16/19 5:18 PM, Leif Lindholm wrote:
Hi Phil,
This is definitely a manual step that could do with automation, so
many thanks for having a go. ...But, I have a few reservations
regarding the actual solution.
First of all, doing it as a .sh means it will not work for those
developers
Hi Phil,
This is definitely a manual step that could do with automation, so
many thanks for having a go. ...But, I have a few reservations
regarding the actual solution.
First of all, doing it as a .sh means it will not work for those
developers working primarily with Visual Studio. Rewriting it
The InitVariableParsing () function has already been removed entirely in V3+ to
prevent issues like this. I strongly believe this is the right direction. It is
only a
matter of time before someone else modifies the global and forgets to call
InitVariableParsing ().
Furthermore, VariablePei has
On 10/14/19 20:36, Laszlo Ersek wrote:
> On 10/14/19 17:03, Pete Batard wrote:
>> Changes from previous version:
>> - Additional empty comment lines above and below, to keep with existing
>> comment
>> style
>> - Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the
>> same
AtRuntime () is implemented in VariableSmmRuntimeDxe.c because it is called by
VariableParsing.c
which is linked to both VariableSmmRuntimeDxe and VariableSmm. VariableSmm
cannot directly
invoke EfiAtRuntime (), so prior to this change, VariableSmm stores the runtime
status in the global
98 matches
Mail list logo
