Re: [edk2-devel] [edk2-platforms] [PATCH v3 4/4] Platform/Intel: Add FIT generation tool

2019-10-17 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Thursday, October 17, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v3 4/4] Platform/Intel: Add FIT

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 05/14] RiscV/Library: Initial version of libraries introduced in RISC-V platform package

2019-10-17 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 1:05 AM > To: devel@edk2.groups.io; Chen, Gilbert > Cc: Palmer Dabbelt > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 05/14] >

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-17 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, October 18, 2019 12:38 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert ; Palmer Dabbelt > > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info HOB

2019-10-17 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Thursday, October 17, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info >

Re: [edk2-devel] [edk2-platforms] [PATCH v3 3/4] WhiskeylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Thursday, October 17, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v3 3/4] WhiskeylakeOpenBoardPkg: Add >

Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/4] KabylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Thursday, October 17, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v3 2/4] KabylakeOpenBoardPkg: Add BIOS

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info HOB

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Thursday, October 17, 2019 5:02 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-devel] [edk2-platforms] [PATCH v3 1/4]

Re: [edk2-devel] [edk2-platforms] [PATCH v3 3/4] WhiskeylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Thursday, October 17, 2019 5:02 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH v3 3/4] WhiskeylakeOpenBoardPkg: Add BIOS Info PEIM

Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/4] KabylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Thursday, October 17, 2019 5:02 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-devel] [edk2-platforms] [PATCH v3 2/4]

Re: [edk2-devel] [edk2-platforms] [PATCH v3 4/4] Platform/Intel: Add FIT generation tool

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Thursday, October 17, 2019 5:02 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH v3 4/4] Platform/Intel: Add FIT generation tool

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4'

2019-10-17 Thread Dandan Bi
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, October 17, 2019 2:21 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add check > for

Re: [edk2-devel] [v9 v9] IntelSiliconPkg-Vtd: A new PMR interface

2019-10-17 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Wang, Iwen Evelyn Sent: Thursday, October 17, 2019 6:22 PM To: devel@edk2.groups.io Cc: Huang, Jenny ; Shih, More ; Ni, Ray ; Chaganty, Rangasai V ; Yao, Jiewen Subject: [v9 v9] IntelSiliconPkg-Vtd: A new PMR interface REF:

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 14, 2019 2:26 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-17 Thread Nate DeSimone
Hi Ray, This really comes down to a philosophical question of how much do we wish to shield the user of the BootMediaLib against the nuances of the library's underlying implementation. The primary function of BootMediaLib is retrieval of state. All of the functions in BootMediaLib are

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Ni, Ray
Liming, Emulator is using a generic SEC module. The host specific module is called "Host". So I prefer to change the macro to "WIN_HOST_BUILD", with this change, Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Thursday, October 17, 2019 2:56 PM > To:

[edk2-devel] [Patch v3 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Disable warning reported from CLANG9. Signed-off-by: Liming Gao Reviewed-by: Jian J Wang --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 +

[edk2-devel] [Patch v3 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao Cc: Michael Kinney Reviewed-by:

[edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 1. Add WIN_SEC_BUILD macro check for CLANG9 tool chain build -p EmulatorPkg\EmulatorPkg.dsc -a IA32 -DWIN_SEC_BUILD=TRUE -t CLANG9 build -p EmulatorPkg\EmulatorPkg.dsc -a X64 -DWIN_SEC_BUILD=TRUE -t CLANG9 2. Append CLANG CC and LINK flags to

[edk2-devel] [Patch v3 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 __inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. Signed-off-by: Liming Gao Acked-by: Laszlo Ersek Cc: Michael Kinney Reviewed-by: Philippe

[edk2-devel] [Patch v3 01/11] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 $(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao Reviewed-by: Bob Feng --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions(+),

[edk2-devel] [Patch v3 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 CLANG9 generated PE image exposes below two issues. 1. SectionSize is used to copy PE section data. It should be smaller than section raw size. 2. The real data is required to be copied. So, copy the min size of VirtualSize and SizeOfRawData.

Re: [edk2-devel] [edk2-platforms] [PATCH v2 4/4] Platform/Intel: Add FIT generation tool

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Tuesday, October 15, 2019 3:51 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-devel] [edk2-platforms] [PATCH v2 4/4]

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info HOB

2019-10-17 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Tuesday, October 15, 2019 3:51 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info HOB Added

[edk2-devel] [Patch v3 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file

[edk2-devel] [Patch v3 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Conf/build_rule.template | 26 ++ BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff

[edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9

2019-10-17 Thread Liming Gao
In v3, add the detail commit message for patch 3. Update the fix in EmulatorPkg based on the comments. In v2, drop patch 12, and update commit message for 5 & 11. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Code: https://github.com/lgao4/edk2/tree/CLANG9 Wiki:

[edk2-devel] [Patch v3 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao Reviewed-by: Jian J Wang Reviewed-by: Philippe Mathieu-Daude --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file

[edk2-devel] [Patch v3 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Signed-off-by: Liming Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git

[edk2-devel] [Patch v3 11/11] OvmfPkg: Enable CLANG9 tool chain

2019-10-17 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 1. Apply CLANG9 Linker option. 2. Exclude -mno-mmx -mno-sse compiler option for CLANG9 These two options will cause CLANG Linker crush. Signed-off-by: Liming Gao Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++-

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 10/17/2019 6:30pm-7:30pm #cal-reminder

2019-10-17 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 17 October 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503246 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [PATCH 1/3] BaseTools: Let the GetMaintainer.py script be executable

2019-10-17 Thread Bob Feng
Hi Phil, To make python script to be executable, I think only change file permission would not be enough. There also need to be a shebang #!/usr/bin/env python at the top of this script. But from the patch 3/3, I see in the GitCcCmd.sh, GetMaintainer.py is called by "python

Re: [edk2-devel] [edk2-test] [PATCH V4] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-17 Thread Eric Jin
Pushed at bd239933cf41f882a9342d39fcca65266a6280ad -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Wednesday, October 16, 2019 2:46 PM To: Chen, ArvinX ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-test] [PATCH V4] uefi-sct/SctPkg: Auto gen result of

Re: [edk2-devel] [PATCH V5 00/10] UEFI Variable SMI Reduction

2019-10-17 Thread Wang, Jian J
For the whole patch series (1-10), Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Friday, October 18, 2019 8:14 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Laszlo Ersek > ;

[edk2-devel] [PATCH] MdeModulePkg/SdBlockIoPei: Add check for DeviceIndex

2019-10-17 Thread Zhang, Shenglei
DeviceIndex is used as index in Slot[]. The max size of Slot[] is SD_PEIM_MAX_SLOTS. So DeviceIndex should be checked before used. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Shenglei Zhang --- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4'

2019-10-17 Thread Zhang, Shenglei
The size of mHiiEfiColors is 16. mHiiEfiColors[Private->Attribute >> 4] may be out of boundary. So add a check for that. Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Shenglei Zhang --- MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [edk2-devel] [RFC v1 5/4] CryptoPkg/TlsLib: accept peer certs via both DNS names and IP addresses

2019-10-17 Thread Laszlo Ersek
Jiaxin, On 10/16/19 17:25, David Woodhouse wrote: > On Wed, 2019-10-16 at 16:43 +0200, Laszlo Ersek wrote: >> Regarding the current edk2 patch set, I think we should do the following: >> >> - use X509_VERIFY_PARAM_set1_ip() rather than >> X509_VERIFY_PARAM_set1_ip_asc() >> >> - incorporate

Re: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-17 Thread Wang, Jian J
> > Again, I would like to ask for help from other reviewers to look at this patch > (patch 7/10) and the next one (patch 8/10) (at least from the security > perspective). Any help will be appreciated, thanks in advance. > I'm trying to do a simple analysis below from security perspective.

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-17 Thread Leif Lindholm
On Thu, Oct 17, 2019 at 07:44:47AM +, Abner Chang wrote: > > -Original Message- > > From: Chang, Abner (HPS SW/FW Technologist) > > Sent: Thursday, October 17, 2019 10:21 AM > > To: devel@edk2.groups.io; leif.lindh...@linaro.org; Chen, Gilbert > > > > Cc: Palmer Dabbelt > > Subject:

Re: [edk2-devel] [Patch v3 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-10-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Thursday, October 17, 2019 2:56 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [Patch v3 02/11] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image BZ:

Re: [edk2-devel] [Patch v3 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-10-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Thursday, October 17, 2019 2:56 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [Patch v3 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize BZ:

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-17 Thread Abner Chang
> -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, October 17, 2019 10:21 AM > To: devel@edk2.groups.io; leif.lindh...@linaro.org; Chen, Gilbert > > Cc: Palmer Dabbelt > Subject: RE: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] >

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-17 Thread Ni, Ray
Nate, I remember that I've agreed with current implementation. I agree with you the library helps caller in a certain way. But another problem we need to solve is how to simplify platform DSC with so many library instances. I don't strongly prefer to merge the two library instances for this

Re: [edk2-devel] [PATCH 2/4] MdeModulePkg/HiiDatabaseDxe: Add check for StringPtr

2019-10-17 Thread Dandan Bi
> -Original Message- > From: Zhang, Shenglei > Sent: Thursday, October 17, 2019 11:31 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: [PATCH 2/4] MdeModulePkg/HiiDatabaseDxe: Add check for > StringPtr > > If the target string doesn't appear in the searched string,

[edk2-devel] [v7 v7] IntelSiliconPkg-Vtd: A new PMR interface

2019-10-17 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to control PLMR/PHMR regions. It allows silicon code to

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 02/14] Silicon/SiFive: Add library module of SiFive RISC-V cores

2019-10-17 Thread Leif Lindholm
On Wed, Oct 16, 2019 at 01:36:07AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Wednesday, October 2, 2019 5:15 AM > > To: devel@edk2.groups.io; Chen,

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-17 Thread Andrew Fish via Groups.Io
Ray, Sorry I'm coming a little late to this and I'm confused. I have some questions? 1) Does CLANG9 imply CLANGPE? 2) Does CLANGPE work on Linux and macOS? Can you pass the Windows style arguments to CLANGPE linker on Linux and macOS? 3) For the EmulatorPkg don't you have the extra requirement

Re: [edk2-devel] [RFC v1 5/4] CryptoPkg/TlsLib: accept peer certs via both DNS names and IP addresses

2019-10-17 Thread David Woodhouse
On Thu, 2019-10-17 at 17:35 +0200, Laszlo Ersek wrote: > Reference [2] advises to put the IP address in both CN and > SAN.iPAddress > for best compatibility, and that would be fine, for > X509_VERIFY_PARAM_set1_ip(). But the word "only" in [3] is really bad > for X509_VERIFY_PARAM_set1_ip(). I

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-17 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 17, 2019 7:19 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert ; Palmer Dabbelt > > Subject: Re:

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-1 PATCH V4] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-10-17 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954 New interface added to PCI Platform Protocol / PCI Override Protocol to retrieve device-specific platform policy for the following PCI standard features, like Maximum Payload Size (MPS), Maximum Read Request Size (MRRS),Extended Tags, Relax

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] SfcPkg: Add new package

2019-10-17 Thread Leif Lindholm
First of all, could you respin this to align more with what's described in https://github.com/tianocore/edk2-platforms/blob/about/Readme.md ? Specifically, it should be visible from the Readme.md (not just the Maintainers.txt history) who owns the branch (you). Secondly, I would prefer

[edk2-devel] [edk2-platforms][PATCH 0/1] New pkg for Solarflare Communications

2019-10-17 Thread Tomas Pilar (tpilar)
I would like to add a new package to support Solarflare Communications adapters. This package will eventually host drivers and utilities for a number of products, most of them network adapters. Ideally, I would like this to start with a devel-sfc branch. Leif helpfully offered to do git lifting

Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9

2019-10-17 Thread Leif Lindholm
Hi Liming, I had missed that this set was out for review (I would appreciate a cc on any future revisions). On Thu, Oct 17, 2019 at 02:55:44PM +0800, Liming Gao wrote: > In v3, add the detail commit message for patch 3. > Update the fix in EmulatorPkg based on the comments. > > In v2, drop

[edk2-devel] [edk2-platforms][PATCH 1/1] SfcPkg: Add new package

2019-10-17 Thread Tomas Pilar (tpilar)
This package is for Solarflare Communications drivers and utilities. Signed-off-by: Tomas Pilar Cc: Leif Lindholm Cc: Michael D Kinney --- Drivers/SfcPkg/Readme.md | 11 +++ Maintainers.txt | 4 Readme.md| 7 +++ 3 files changed, 22 insertions(+)

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-17 Thread Leif Lindholm
On Thu, Oct 17, 2019 at 04:09:44PM +, Abner Chang wrote: > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Thursday, October 17, 2019 7:19 PM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) >

Re: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-17 Thread Kubacki, Michael A
Jian, thanks a lot your analysis. The intention was very much to constrain the flow of information from SMM to the non-SMM environment and not vice versa during runtime cache operation. I agree that the buffers pointed to in SMM_VARIABLE_COMMUNICATE_RUNTIME_VARIABLE_CACHE_CONTEXT should be

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 10/17/2019 5:00pm-5:30pm #cal-reminder

2019-10-17 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 17 October 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503254 ) *Organizer:* Stephano Cetola

[edk2-devel] [edk2-platforms] [PATCH v3 3/4] WhiskeylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Agyeman, Prince
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2211 Added BIOS Info PEIM to publish Bios Info HOB. This PEIM currently publishes the microcode FV information. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../BiosInfo/BiosInfo.c

[edk2-devel] [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info HOB

2019-10-17 Thread Agyeman, Prince
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2210 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2211 Added gBiosInfoGuid to be used in publishing the BIOS information HOB which is needed in FIT generation Also added the BIOS Info header file BiosInfo.h that defines the BIOS info

[edk2-devel] [edk2-platforms] [PATCH v3 4/4] Platform/Intel: Add FIT generation tool

2019-10-17 Thread Agyeman, Prince
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2210 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2211 Added FitGen tool build and FIT generation to the BIOS build process. What was done: - Build the FIT generation tool - Added default/empty BIOS_INFO_GUID to the build.cfg - Added

[edk2-devel] [edk2-platforms] [PATCH v3 0/4] Add FIT support using FitGen

2019-10-17 Thread Agyeman, Prince
Changes in v3: - Added PcdLib to BiosInfo.inf's LibraryClasses section - Cleaned up OpenBoardPkg.dscs for all three platforms - Added bugzilla references Changes in v2: - Moved BIOS Info PEIM to KabylakeOpenBoardPkg shared by both KabylakeRvp3, GalagoPro3 - Moved BIOS Info PEIM to

[edk2-devel] [edk2-platforms] [PATCH v3 2/4] KabylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-17 Thread Agyeman, Prince
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2210 Added BIOS Info PEIM to KabylakeRvp3 and GalagoPro3 to publish the BIOS info HOB. This PEIM currently publishes the board's microcode region information. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince

[edk2-devel] [PATCH V5 03/10] MdeModulePkg/Variable: Parameterize VARIABLE_INFO_ENTRY buffer

2019-10-17 Thread Kubacki, Michael A
UpdateVariableInfo () currently accepts parameters regarding updates to be made to a global variable of type VARIABLE_INFO_ENTRY. This change passes the structure by pointer to UpdateVariableInfo () so structures other than the fixed global variable can be updated. Cc: Dandan Bi Cc: Ard

[edk2-devel] [PATCH V5 01/10] MdeModulePkg/Variable: Consolidate common parsing functions

2019-10-17 Thread Kubacki, Michael A
This change moves the following functions into a dedicated file so they may be used in other variable files as needed. These are commonly needed for basic variable data structure parsing operations. The functions are grouped together in VariableParsing.c to support cohesiveness for these

[edk2-devel] [PATCH V5 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-17 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 This change reduces SMIs for GetVariable () by maintaining a UEFI variable cache in Runtime DXE in addition to the pre- existing cache in SMRAM. When the Runtime Service GetVariable() is invoked, a Runtime DXE cache is used instead of

[edk2-devel] [PATCH V5 05/10] MdeModulePkg/Variable: Add a file for NV variable functions

2019-10-17 Thread Kubacki, Michael A
This change adds a dedicated file for variable operations specific to non-volatile variables. This decreases the overall length of the relatively large Variable.c file. Cc: Dandan Bi Cc: Ard Biesheuvel Cc: Eric Dong Cc: Laszlo Ersek Cc: Liming Gao Cc: Michael D Kinney Cc: Ray Ni Cc: Jian J

[edk2-devel] [PATCH V5 02/10] MdeModulePkg/Variable: Parameterize GetNextVariableInternal () stores

2019-10-17 Thread Kubacki, Michael A
The majority of logic related to GetNextVariableName () is currently implemented in VariableServiceGetNextVariableInternal (). The list of variable stores to search for the given variable name and variable GUID is defined in the function body. This change adds a new parameter so that the caller

[edk2-devel] [PATCH V5 00/10] UEFI Variable SMI Reduction

2019-10-17 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 V5 Changes: [PATCH V4 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support * Increased validation of the runtime buffers passed in the SMM comm buffer SMM_VARIABLE_COMMUNICATE_RUNTIME_VARIABLE_CACHE_CONTEXT structure to the

[edk2-devel] [PATCH V5 06/10] MdeModulePkg VariableInfo: Always consider RT DXE and SMM stats

2019-10-17 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 The current VariableInfo application only checks for variable statistics from SMM if the variable information entries are not present in the UEFI System Configuration table as published by the DXE UEFI variable driver (VariableRuntimeDxe).

[edk2-devel] [PATCH V5 04/10] MdeModulePkg/Variable: Parameterize auth status in VariableParsing

2019-10-17 Thread Kubacki, Michael A
The file VariableParsing.c provides generic functionality related to parsing variable related structures and information. In order to calculate offsets for certain operations, the functions must know if authenticated variables are enabled as this increases the size of variable headers. This

[edk2-devel] [PATCH V5 09/10] OvmfPkg: Disable variable runtime cache

2019-10-17 Thread Kubacki, Michael A
Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc so that when SMM_REQUIRE is TRUE, the SMM variable driver will not use the runtime variable cache. This is done for OvmfPkg because it currently depends upon a SMM

[edk2-devel] [PATCH V5 08/10] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-10-17 Thread Kubacki, Michael A
https://bugzilla.tianocore.org/show_bug.cgi?id=2220 This change implements the Runtime Service GetNextVariableName() using the runtime cache in VariableSmmRuntimeDxe. Runtime Service calls to GetNextVariableName() will no longer trigger a SW SMI when

[edk2-devel] [PATCH V5 10/10] MdeModulePkg: Enable variable runtime cache by default

2019-10-17 Thread Kubacki, Michael A
This change enables the variable runtime cache by default by setting gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in MdeModulePkg.dec to TRUE. Cc: Dandan Bi Cc: Ard Biesheuvel Cc: Eric Dong Cc: Laszlo Ersek Cc: Liming Gao Cc: Michael D Kinney Cc: Ray Ni Cc: Jian J Wang Cc: