Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific

On 05/06/20 18:33, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass > XCODE5 tool chain") introduced binary patching into the exception handling > support. CPU exception handling is allowed

Re: [EXTERNAL] Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

On 5/6/20 1:07 PM, Bret Barkelew via groups.io wrote: > Should that > section not use the !if check and just list both .inf files > (SecPeiCpuExceptionHandlerLib.inf and > Xcode5SecPeiCpuExceptionHandlerLib.inf)? Hmmm, this is a very good point; after all, the updated (=reverted)

Re: [edk2-devel] [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 2/7]

Re: [edk2-devel] [edk2-platforms:PATCH v5 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 3/7]

Re: [edk2-devel] [edk2-platforms:PATCH v5 4/7] MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 4/7]

Re: [edk2-devel] [edk2-platforms:PATCH v5 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 1/7]

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific

On 5/6/20 2:01 PM, Laszlo Ersek via groups.io wrote: > On 05/06/20 18:33, Tom Lendacky wrote: >> BZ: >>

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

Hi Eric, On 5/6/20 10:06 AM, Dong, Eric wrote: > Hi Tom, > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of >> Lendacky, Thomas >> Sent: Wednesday, May 6, 2020 9:20 PM >> To: Dong, Eric ; devel@edk2.groups.io; >> ler...@redhat.com >> Cc: Justen, Jordan L ; Ard Biesheuvel

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: smbiosview - print field values as unsigned integers

On 5/6/20 6:52 PM, Rebecca Cran wrote: This prevents overflow when printing DWORD fields such as the type 17 tables's extended DIMM size. Signed-off-by: Rebecca Cran Cc: Ray Ni Cc: Zhichao Gao Cc: Philippe Mathieu-Daude --- .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6

Re: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notification types

Hi Bret. Sorry for late reply. I was waiting for more comments from others. Yes all previous notification types are defined in Include/Guid/Cper.h You are right about the typos. But this were just copy/paste from previous notification types definitions from Cper.h - I am not a native English

[edk2-devel] Reminder: Tomorrow's TianoCore Community Meeting at 9am and 7.30pm (PST)

Dear Community Members, Please note the time for tomorrow's community meeting - 9-10am (PST) and 7.30-8.30pm (PST). You can view the calendar here - https://edk2.groups.io/g/devel/viewevent?repeatid=23293=700773=2020-04-16 I hope to see you all tomorrow. Regards, Soumya Soumya Guptha Open

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuExceptionHandler: Revert CpuExceptionHandler binary patching

On 05/06/20 18:33, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > Now that an XCODE5 specific CpuExceptionHandlerLib library is in place, > revert the changes made to the ExceptionHandlerAsm.nasm in commit > 2db0ccc2d7fe ("UefiCpuPkg: Update

Re: [edk2-devel] [edk2-platforms:PATCH v5 7/7] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 7/7]

Re: [edk2-devel] [edk2-platforms:PATCH v5 6/7] CoffeelakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 6/7]

Re: [edk2-devel] [edk2-platforms:PATCH v5 5/7] KabylakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Tuesday, May 05, 2020 8:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v5 5/7]

Re: [edk2-devel] [PATCH v2 0/3] XCODE5 toolchain binary patching fix

On 05/06/20 18:32, Tom Lendacky wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass > XCODE5 tool chain") introduced binary patching in the > ExceptionHandlerAsm.nasm in order to support the XCODE5 toolchain. >

Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg: Use toolchain appropriate CpuExceptionHandlerLib

On 05/06/20 18:33, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 > > During the SEC phase, use the XCODE5 CpuExceptionHandlerLib library in > place of the standard library when building with the XCODE5 toolchain. > The SEC XCODE5 version of the library performs

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EkdRepo: Update Checkout Pin to Support Multiple Manifest Repos

Update the checkout pin command to look for pin files only in the workspace's source manifest repository. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/checkout_pin_command.py | 19

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Integrate multiple manifest repository support in the manifest command

Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/manifest_command.py | 79 +++- 1 file changed, 50 insertions(+), 29 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update Create-Pin to be support multiple manifest repositories

Update the create pin command to select and interact with only the workspaces source manifest repository. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/create_pin_command.py | 26

[edk2-devel] [edk2-platform][PATCH v1 0/2] Update ASIX USB Networking drivers

This series adds two new ASIX USB networking drivers, Ax88179 and Ax88772c. Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (2): OptionRomPkg: UsbNetworking: ASIX Ax88179 driver Drivers/OptionRomPkg: UsbNetworking: ASIX Ax88772c

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

Hi Tom, > -Original Message- > From: Tom Lendacky > Sent: Thursday, May 7, 2020 2:33 AM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ; Brijesh Singh ; Wang, Jian J > ; Wu, Hao A >

[edk2-devel] Updated Event: TianoCore Bug Triage - APAC / NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:mlda.1580078539586725120.r...@groups.io DTSTAMP:20200507T011644Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

Hi Tom, > -Original Message- > From: Tom Lendacky > Sent: Thursday, May 7, 2020 2:33 AM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ; Brijesh Singh ; Wang, Jian J > ; Wu, Hao A >

Re: [edk2-devel] [PATCH 1/1] BaseTools: add repo name option to SetupGit.py

This patch looks good for me. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek Sent: Thursday, May 7, 2020 12:36 AM To: Feng, Bob C ; Gao, Liming Cc: devel@edk2.groups.io; l...@nuviainc.com; rebe...@bsdio.com Subject: Re: [edk2-devel]

[edk2-devel] [PATCH V3 3/8] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 ARC4 is not secure any longer. Remove the ARC4 support from edk2. Change the ARC4 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney

[edk2-devel] [PATCH V3 7/8] CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 HMAC SHA1 is not secure any longer. Remove the HMAC SHA1 support from edk2. Change the HMAC SHA1 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any long. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc:

[edk2-devel] [PATCH V3 2/8] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 MD4 is not secure any longer. Remove the MD4 support from edk2. Change the MD4 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc:

[edk2-devel] [PATCH V3 0/8] CryptoPkg: Retire the deprecated functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Retire below deprecated functions: MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. V2: Seprate the MD5 and SHA1 changes to other patch set. Change the deprecated function wrapper implementatuion in EDKII_CRYPTO_PROTOCOL to call a dummy

[edk2-devel] [PATCH V3 8/8] CryptoPkg/Crypto.h: Update the version of Crypto Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 The binary is totally changed, so update the Crypto Version to 7: 1. Retire below deprecated function: MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao

[edk2-devel] [PATCH V3 1/8] CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Add a internal worker function to indicate the deprecated functions. It would print out debug messages and asserts ot inform the consumer they are using a deprecated function. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D

[edk2-devel] [PATCH V3 6/8] CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 HMAC MD5 is not secure any longer. Remove the HMAC MD5 support from edk2. Change the HMAC MD5 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any long. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael

[edk2-devel] [PATCH V3 4/8] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Tdes is not secure any longer. Remove the Tdes support from edk2. Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney

[edk2-devel] [PATCH V3 5/8] CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Aes Ecb mode is not secure any longer. Remove the Aes Ecb mode support from edk2. Change the Aes Ecb mode field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any long. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu

Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed

Pushed at 8af507c1f16d9cc311e83397881016e3887acfbb.. faef5a367c8345df906be3755e15e0dabc3105b3 > -Original Message- > From: Krzysztof Koch > Sent: Friday, May 1, 2020 7:27 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Ni, Ray > > Cc: Sami Mujawar ; Matteo Carlini > ; Laura Moretta ; nd

[edk2-devel] [PATCH v2] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2698 To enhance FSP silicon initialization flexibility an optional Multi-Phase API is introduced and FSP header needs update for new API offset. Also new SecCore module created for FspMultiPhaseSiInit API New ARCH_UPD introduced for enhancing

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi: allow selecting which system config tables are exposed

On 5/6/20 2:59 AM, Andrei Warkentin wrote: Today we just have an option to hide DT entirely, while ACPI is always exposed. This change extends the option to provide all three choices: - ACPI only - ACPI + DT - DT only Why? Because not all OSes will prefer DT over ACPI when both are available.

[edk2-devel] [PATCH] EmbeddedPkg/EmbeddedPkg.dsc: remove some stale component references

Some driver were recently moved to edk2-platforms, but the DSC file in EmbeddedPkg still refers to them. Drop these references. Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dsc | 7 --- 1 file changed, 7 deletions(-) diff --git a/EmbeddedPkg/EmbeddedPkg.dsc

[edk2-devel] [PATCH 1/1] SignedCapsulePkg: Add handling of NULL returned from FMP Descriptor

Firmware management protocol that does not support GetImageInfo return Unsupported. hence FMP Image Information Buffer is NULL. Freeing NULL buffer results in Exception. Added NULL check for Image Info buffer and skip processing FMP protocol handle, which does not support GetImageInfo.

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/RaspberryPi/RPi4: drop Cortex-A53 erratum workaround

The Raspberry Pi4 uses Cortex-A72 cores so it has no need for the Cortex-A53 ADRP erratum workaround. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryPi/RPi4/RPi4.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc

Re: [edk2-devel] [PATCH] EmbeddedPkg/EmbeddedPkg.dsc: remove some stale component references

On Wed, May 06, 2020 at 09:06:37 +0200, Ard Biesheuvel wrote: > Some driver were recently moved to edk2-platforms, but the DSC file > in EmbeddedPkg still refers to them. Drop these references. > > Signed-off-by: Ard Biesheuvel Sorry, should have cought that in review. Reviewed-by: Leif

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RaspberryPi/RPi4: drop Cortex-A53 erratum workaround

On Wed, May 06, 2020 at 11:56:14 +0200, Ard Biesheuvel wrote: > The Raspberry Pi4 uses Cortex-A72 cores so it has no need for the > Cortex-A53 ADRP erratum workaround. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 1 - > 1 file

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/RaspberryPi/DualSerialPortLib: split up to ease reuse

One minor whitespace issue inline: On 2020.05.05 15:50, Ard Biesheuvel wrote: In preparation of creating different versions of DualSerialPortLib, split off the parts that will be shared between all versions. Signed-off-by: Ard Biesheuvel ---

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform/RaspberryPi: introduce DebugDualSerialPortLib

On 2020.05.05 15:50, Ard Biesheuvel wrote: On DEBUG builds that use the serial port directly for debug output, every module reinitializes the UART hardware, through the DebugLib constructor calling SerialPortInitialize. This is unnecessary, but usually harmless. However, in cases where this

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/RaspberryPi: fix 16550 divisor calculation logic

One general remark below: On 2020.05.05 19:10, Ard Biesheuvel wrote: On 5/5/20 4:50 PM, Ard Biesheuvel wrote: The 16550 'miniUART' on the Raspberry Pi gets its input clock from different sources on RPi3 and RPi3. Fix the logic that derives the This should be 'Rpi3 and RPi4' divisor for the

Re: [edk2-devel] [PATCH edk2-platforms 4/5] Platform/RaspberryPi3: query firmware for 16550 input clock at boot

One remark below: On 2020.05.05 19:11, Ard Biesheuvel wrote: On 5/5/20 4:50 PM, Ard Biesheuvel wrote: Query the firmware for the clock rate that is used to drive the 16550 baud clock, so that we can program the correct baud rate. Co-authored-by: Pete Batard Co-authored-by: Andrei Warkentin

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/RaspberryPi: fix 16550 divisor calculation logic

On 5/6/20 12:18 PM, Pete Batard wrote: One general remark below: On 2020.05.05 19:10, Ard Biesheuvel wrote: On 5/5/20 4:50 PM, Ard Biesheuvel wrote: The 16550 'miniUART' on the Raspberry Pi gets its input clock from different sources on RPi3 and RPi3. Fix the logic that derives the This

Re: [edk2-devel] [PATCH edk2-platforms 4/5] Platform/RaspberryPi3: query firmware for 16550 input clock at boot

On 5/6/20 12:18 PM, Pete Batard wrote: One remark below: On 2020.05.05 19:11, Ard Biesheuvel wrote: On 5/5/20 4:50 PM, Ard Biesheuvel wrote: Query the firmware for the clock rate that is used to drive the 16550 baud clock, so that we can program the correct baud rate. Co-authored-by: Pete

Re: [edk2-devel] [PATCH 1/1] BaseTools: add repo name option to SetupGit.py

On Tue, May 05, 2020 at 17:40:35 +0200, Laszlo Ersek wrote: > CC Leif > > On 05/01/20 22:00, Rebecca Cran wrote: > > Allow users who didn't clone one of the TianoCore repos from a > > canonical URL to specify the name of the repo (edk2, edk2-platforms > > or edk2-non-osi) when running SetupGit.py

Re: [edk2-devel] [PATCH edk2-platforms 4/5] Platform/RaspberryPi3: query firmware for 16550 input clock at boot

On 2020.05.06 11:31, Ard Biesheuvel wrote: On 5/6/20 12:18 PM, Pete Batard wrote: One remark below: On 2020.05.05 19:11, Ard Biesheuvel wrote: On 5/5/20 4:50 PM, Ard Biesheuvel wrote: Query the firmware for the clock rate that is used to drive the 16550 baud clock, so that we can program the

Re: [edk2-devel] [PATCH edk2-platforms v4 12/24] Silicon/NXP: Move RAM retrieval from SocLib

Hi Pankaj, I have a few minor comments on this patch, but I have pushed 1-11/24 as ca1a7187861c..725d1198e262. On Fri, May 01, 2020 at 11:19:43 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > RAM retrieval using SMC commands is common to all Layerscape SOCs. > Therefore, move it to

Re: [edk2-devel] [PATCH edk2-platforms v4 15/24] Silicon: NXP: Remove direct calls to SwapMmio* APIs

On Fri, May 01, 2020 at 11:19:46 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SwapMmio** APIs are supposed to be called indirectly via > GetMmioOperations** APIs. > Therefore, remove the SwapMmio** APIs from IoAccessLib.h and make > these APIs STATIC to IoAccessLib.c, so that no

Re: [edk2-devel] [PATCH edk2-platforms v4 16/24] Silicon/NXP: Add Chassis2 Package

On Fri, May 01, 2020 at 11:19:47 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > A Chassis is a base framework used for building SoCs. > We can think of Chassis/Soc/Platform(a.k.a Board) in Object model terms. > Chassis is base. Soc is based on some Chassis. > Platform is based on some

Re: [edk2-devel] [PATCH edk2-platforms v4 17/24] Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg

On Fri, May 01, 2020 at 11:19:48 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Now the we have added Chassis Package, move the chassis specific common > code for all SOCs belonging to same chassis to ChassisLib. > > Use ChassisLib APIs in SocLib. > > Signed-off-by: Pankaj Bansal

Re: [edk2-devel] [PATCH edk2-platforms v4 24/24] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

On Fri, May 01, 2020 at 11:19:55 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add PEI phase to LS1043aRdb. This is needed because we need to have > dynamic PCDs support to be able to reserve memory before reporting > memory to UEFI firmware. > Using PEI phase we are now also dynamically

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

Because of its widespread availability and low price, we expect the Raspberry Pi source to be used by platform developers as a starting point to create their own platform implementation. As such, it makes a lot of sense to want to use the most up to date underlying standards, even if the pay off

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

On 5/6/20 2:45 PM, Pete Batard wrote: On 2020.05.06 13:26, Ard Biesheuvel wrote: On 5/6/20 1:37 PM, Pete Batard wrote: ... Therefore, since we do see a need for ACPI 6.x features, and effectively have a 6.3 table with PPTT, and also since we have tested that we are not seeing ill effects from

Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

On 5/5/20 5:15 PM, Laszlo Ersek via groups.io wrote: On 05/01/20 22:17, Lendacky, Thomas wrote: BZ:

Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

Thomas: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lendacky, > Thomas > Sent: Wednesday, May 6, 2020 10:35 PM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Gao, Liming ; > Dong, Eric ; Ni, Ray ; Brijesh Singh > ; Anthony

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

On 5/5/20 8:53 PM, Dong, Eric wrote: -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek Sent: Tuesday, May 5, 2020 11:30 PM To: Tom Lendacky ; Dong, Eric ; devel@edk2.groups.io Cc: Justen, Jordan L ; Ard Biesheuvel ; Kinney, Michael D

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

On 5/6/20 1:37 PM, Pete Batard wrote: ... Therefore, since we do see a need for ACPI 6.x features, and effectively have a 6.3 table with PPTT, and also since we have tested that we are not seeing ill effects from doing so for the most common OSes we support, we bring all of the relevant ACPI

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RaspberryPi/RPi4: drop Cortex-A53 erratum workaround

On 5/6/20 12:14 PM, Leif Lindholm wrote: On Wed, May 06, 2020 at 11:56:14 +0200, Ard Biesheuvel wrote: The Raspberry Pi4 uses Cortex-A72 cores so it has no need for the Cortex-A53 ADRP erratum workaround. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks Pushed as

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

On 2020.05.06 13:26, Ard Biesheuvel wrote: On 5/6/20 1:37 PM, Pete Batard wrote: ... Therefore, since we do see a need for ACPI 6.x features, and effectively have a 6.3 table with PPTT, and also since we have tested that we are not seeing ill effects from doing so for the most common OSes we

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

On 2020.05.06 13:50, Ard Biesheuvel wrote: On 5/6/20 2:45 PM, Pete Batard wrote: On 2020.05.06 13:26, Ard Biesheuvel wrote: On 5/6/20 1:37 PM, Pete Batard wrote: ... Therefore, since we do see a need for ACPI 6.x features, and effectively have a 6.3 table with PPTT, and also since we have

Re: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency implement to library

Reviewed-by: Liming Gao > -Original Message- > From: Xu, Wei6 > Sent: Tuesday, April 28, 2020 9:25 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Sean Brogan > > Subject: [edk2-devel] [PATCH 0/4] FmpDevicePkg: Move capsule dependency > implement to library >

Re: [edk2-devel] [edk2-platforms][PATCH 1/3] Platform/RPi: Fortify mailbox code

On 5/4/20 1:15 PM, Pete Batard wrote: From: Andrei Warkentin As part of the analysis done in: https://github.com/raspberrypi/firmware/issues/1376: * Bump up max tries, to avoid command time-outs. * Macro-ify RaspberryPiHelper.S some more to make code more maintainable. * Add ".align 4" before

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h

On 05/06/20 03:31, Dong, Eric wrote: > Acked-by: Eric Dong > > Hi Laszlo, > > I saw you already provided Review-by tag and I can't verify the change, so I > don't add comments for this patch. > > I will provide Acked-by tag for the similar case next time. Thank you -- I only have an "R" role

[edk2-devel] [PATCH v2 1/1] ShellPkg: smbiosview - print field values as unsigned integers

This prevents overflow when printing DWORD fields such as the type 17 tables's extended DIMM size. Signed-off-by: Rebecca Cran Cc: Ray Ni Cc: Zhichao Gao Cc: Philippe Mathieu-Daude --- .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

On 05/06/20 15:19, Tom Lendacky wrote: > On 5/5/20 8:53 PM, Dong, Eric wrote: >> >> >>> -Original Message- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Laszlo Ersek >>> Sent: Tuesday, May 5, 2020 11:30 PM >>> To: Tom Lendacky ; Dong, Eric >>> ;

[edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 protocol (PI 1.7a)

Now that version 1.7 errata A of the PI spec has finally been released, we can take another look at this series, which incorporates the new MM communicate2 protocol definition, updates the producers for conventional SMM and standalone MM, and updates the variable store components to consume the

[edk2-devel] [PATCH resend 5/7] MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2

Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 2 +- MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.c| 25

[edk2-devel] [PATCH resend 2/7] MdeModulePkg/SmmIpl: expose MM communicate 2 protocol

The MM communicate 2 protocol was introduced to factor out the mismatch between traditional MM, which requires the physical address of the MM buffer to be passed, and standalone MM, which copies the MM communicate buffer data into a separate buffer, requiring the virtual address. For this reason,

[edk2-devel] [PATCH resend 1/7] MdePkg: introduce MM communicate 2 protocol

Add the protocol definition of the MM communicate 2 protocol, which has been introduced by version 1.7 errata A of the PI spec. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Protocol/MmCommunication2.h | 69 MdePkg/MdePkg.dec | 7 ++ 2 files

[edk2-devel] [PATCH resend 3/7] ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol

Implement the new MmCommunication2 protocol which supports the use of standalone MM at runtime inside an address space that has been virtually remapped by the OS. Note that the implementation of the old MM Communicate protocol is removed: it never worked correctly so there is no point in keeping

[edk2-devel] [PATCH resend 6/7] MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2

Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Include/Guid/SmmVariableCommon.h| 6 +-- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 39

[edk2-devel] [PATCH resend 4/7] MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol

Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Application/VariableInfo/VariableInfo.c | 19 +++ MdeModulePkg/Application/VariableInfo/VariableInfo.inf | 2 +- 2 files changed, 12

[edk2-devel] [PATCH resend 7/7] StandaloneMmPkg: switch to MM communicate 2 protocol

Update the reference to MM communicate to refer to the MM communicate 2 protocol instead. This makes no difference for the MM side of the implementation, but is more accurate nonetheless, since the original MM protocol does not work in combination with standalone MM. Signed-off-by: Ard Biesheuvel

Re: [EXTERNAL] [edk2-devel] [PATCH resend 4/7] MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol

Note that the VariablePolicy code that is still out for review also uses Mm communication and would need to be updated if it lands first. - Bret From: Ard Biesheuvel via groups.io Sent: Wednesday, May 6, 2020 10:28 AM To:

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/CpuExceptionHandler: Make XCODE5 changes toolchain specific

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") introduced binary patching into the exception handling support. CPU exception handling is allowed during SEC and this results in binary patching of

[edk2-devel] [PATCH v2 0/3] XCODE5 toolchain binary patching fix

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") introduced binary patching in the ExceptionHandlerAsm.nasm in order to support the XCODE5 toolchain. However, the CpuExceptionHandlerLib can be used

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuExceptionHandler: Revert CpuExceptionHandler binary patching

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 Now that an XCODE5 specific CpuExceptionHandlerLib library is in place, revert the changes made to the ExceptionHandlerAsm.nasm in commit 2db0ccc2d7fe ("UefiCpuPkg: Update CpuExceptionHandlerLib pass XCODE5 tool chain") so that binary

[edk2-devel] [PATCH v2 2/3] OvmfPkg: Use toolchain appropriate CpuExceptionHandlerLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2340 During the SEC phase, use the XCODE5 CpuExceptionHandlerLib library in place of the standard library when building with the XCODE5 toolchain. The SEC XCODE5 version of the library performs binary patching and should only be used when

Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

On 05/06/20 16:35, Tom Lendacky wrote: > On 5/5/20 5:15 PM, Laszlo Ersek via groups.io wrote: >> On 05/01/20 22:17, Lendacky, Thomas wrote: >>> BZ: >>>

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform/RaspberryPi: fix serialportlib dependency hell

On 5/5/20 4:50 PM, Ard Biesheuvel wrote: This proposes an alternative approach to the issue described in https://github.com/raspberrypi/firmware/issues/1376. Instead of fiddling with HobLib internals and relying on headers being included in the correct order, this replaces all DEBUG uses of

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi: allow selecting which system config tables are exposed

Ok that sounds reasonable to me. I'll remove the "both" option entirely. A From: devel@edk2.groups.io on behalf of Ard Biesheuvel via groups.io Sent: Wednesday, May 6, 2020 1:38 AM To: Andrei Warkentin ; devel@edk2.groups.io Cc: l...@nuviainc.com ;

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

Hi Tom, > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Wednesday, May 6, 2020 9:20 PM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ;

Re: [edk2-devel] [PATCH 1/1] BaseTools: add repo name option to SetupGit.py

On 05/06/20 12:31, Leif Lindholm wrote: > On Tue, May 05, 2020 at 17:40:35 +0200, Laszlo Ersek wrote: >> CC Leif >> >> On 05/01/20 22:00, Rebecca Cran wrote: >>> Allow users who didn't clone one of the TianoCore repos from a >>> canonical URL to specify the name of the repo (edk2, edk2-platforms

Re: [EXTERNAL] Re: [edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandler: Revert binary patching in standard CpuExceptionHandlerLib

> Should that > section not use the !if check and just list both .inf files > (SecPeiCpuExceptionHandlerLib.inf and > Xcode5SecPeiCpuExceptionHandlerLib.inf)? Hmmm, this is a very good point; after all, the updated (=reverted) "SecPeiCpuExceptionHandlerLib.inf" instance will not build with