On 5/8/20 12:09 PM, Laszlo Ersek wrote:
Hello Guomin,
On 05/08/20 10:38, Guomin Jiang wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
UGA is replaced by GOP and remove all related code.
I'm responding under the cover letter.
(1) You should have CC'd the cover letter to
Eric, Ray, Liming -- do you have comments please?
I'm ready to push the series (it has two UefiCpuPkg patches and one
OvmfPkg patch).
Please consider specifically whether we should push the last patch at
once. The last patch would prevent the following "edk2-platforms" DSC
files from building
On 5/8/20 3:09 AM, Gao, Zhichao wrote:
Thanks for point out the typo. I would fix it.
About the align, see below.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: Thursday, May 7, 2020 3:48 PM
To: edk2-devel-groups-io ; Gao, Zhichao
Cc: Wang,
Ard and Laszlo,
It's my problem.
I will improve the patch and make it more professional.
I am busy recently and will do it after July.
Thanks
> -Original Message-
> From: Ard Biesheuvel
> Sent: Friday, May 8, 2020 7:00 PM
> To: Laszlo Ersek ; devel@edk2.groups.io; Jiang, Guomin
>
>
Hi Zhiguang.
Commit messages are formatted correctly in patches when I view them in editor
(notepad ++). Looks like sending them via emails resulted in eliminating all
EOL before dot (making single sentences inline).
I am using "git send-email --suppress-from --to ..." command. Is there any
Laszlo:
This change is OK to me. It doesn't impact those platforms, because their SEC
and PEI are IA32 only. This patch is to update SecPei library instance for X64
arch.
Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Laszlo Ersek
> Sent: Friday, May 8, 2020
Zhichao,
Thanks for making this patch series.
Just two comments for patch 3:
(1) If possible, please group patch file based on module unit. For this patch,
I think at least OpensslLib can be put in separate patch file.
(2) Please update process_files.pl in OpensslLib to generate
Hello Guomin,
On 05/08/20 10:38, Guomin Jiang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
>
> UGA is replaced by GOP and remove all related code.
I'm responding under the cover letter.
(1) You should have CC'd the cover letter to each person that is CC'd on
at least one
On 05/07/20 18:45, Bret Barkelew wrote:
> I know I've also seen tests that randomize the driver dispatch order
> to try to catch these "implementation-specific" edge cases. Perhaps we
> could instrument something similar with a weekly OVMF CI test?
That won't work for -- at least -- the
Any new OVMF binary (containing commit d42fdd6f8384, and built with
SMM_REQUIRE) is likely to reboot during its first boot, regardless of
whether the variable store is logically empty, or it contains a
MemoryTypeInformation variable from an earlier OVMF binary.
This "reboot on first boot after
The previous patch has no effect -- i.e., it cannot stop the tracking of
BS Code/Data in MemTypeInfo -- if the virtual machine already has a
MemoryTypeInformation UEFI variable.
In that case, our current logic allows the DXE IPL PEIM to translate the
UEFI variable to the HOB, and that translation
Some OvmfPkg modules already depend on "EmbeddedPkg.dec"; thus, replace
the open-coded memory type info defaults in the source code with the
EmbeddedPkg PCDs that stand for the same purpose. Consequently, platform
builders can override these values with the "--pcd" option of "build",
without
In commit d42fdd6f8384 ("OvmfPkg: improve SMM comms security with adaptive
MemoryTypeInformation", 2020-03-12), we enabled the boot-to-boot tracking
of the usages of various UEFI memory types.
Both whitepapers listed in that commit recommend that BS Code/Data type
memory *not* be tracked. This
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2706
Repo: https://pagure.io/lersek/edk2.git
Branch: memtypeinfo_rework
Please find the problem statement and the solution outline in the
Bugzilla ticket linked above.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Philippe
Zhichao,
Similar comments, please refer to them in my review email for patch 3.
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
> ; Yao, Jiewen
Hi Zhiguang.
Comment is in Spec.
See description of CapsuleId field right after declaration of
EFI_CAPSULE_RESULT_VARIABLE_JSON structure (p.280 of 2.8 ErrataB).
Agree with second comment.
Regards, Oleksiy.
-Original Message-
From: Liu, Zhiguang [mailto:zhiguang@intel.com]
Sent:
Reviewed-by: Maurice Ma
> -Original Message-
> From: Jiang, Guomin
> Sent: Friday, May 8, 2020 1:38
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Ma, Maurice
> ; Dong, Guo ; You, Benjamin
>
> Subject: [PATCH 02/18] UefiPayloadPkg: Remove All UGA Support
>
> From: GuoMinJ
>
> REF:
Reviewed-by: Maurice Ma
> -Original Message-
> From: Jiang, Guomin
> Sent: Friday, May 8, 2020 1:38
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Ma, Maurice
> ; Dong, Guo ; You, Benjamin
>
> Subject: [PATCH 16/18] UefiPayloadPkg: Remove All UGA Support
>
> From: GuoMinJ
>
> REF:
Sorry for the out-of-order review. Please refer to comments for patch 3.
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
> ; Yao, Jiewen
>
Zhichao,
Similar to patch 3, please update OpensslLib/process_files.pl to update
OpensslLibXxx.inf
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney,
Zhichao,
You could add 'Intel' copyright in file header. With it addressed,
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney,
Zhichao,
The removal of AesEcbEncrypt() and AesEcbDecrypt() should go to patch 5.
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
> ; Yao,
Just a typo (see below). With it addressed,
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, May 07, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
> ; Yao, Jiewen
>
Hi Zhiguang.
Is this about MdePkg.dec or about new added file RtPropertiesTable.h?
Regards, Oleksiy.
-Original Message-
From: Liu, Zhiguang [mailto:zhiguang@intel.com]
Sent: Friday, May 08, 2020 2:08 AM
To: devel@edk2.groups.io; Oleksiy Yakovlev
Cc: Gao, Liming; Kinney, Michael D;
During the Community Meeting last night, I was asked to send this email
starting a discussion about where to put the bhyve code in the edk2
tree: whether it should be in a new BhyvePkg, or added under OvmfPkg. It
appears it's already been decided it should be in edk2 along with the
other
I have a newer version which supports the functionality discussed earlier.
Please review it once I post the update.
Thank you,
Vladimir
-Original Message-
From: Gao, Liming
Sent: Friday, May 8, 2020 8:58 AM
To: devel@edk2.groups.io; Gao, Zhichao ;
samer.el-haj-mahm...@arm.com; Vladimir
Hi Oleksiy,
This patch is not correct and can't be applied to master branch.
Can you confirm?
The line number seems not consistent.
Thanks
Zhiguang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Oleksiy
> Yakovlev
> Sent: Friday, May 8, 2020 3:35 AM
> To:
EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
UEFI 2.8 mantis 1832.
Signed-off-by: Oleksiy Yakovlev
---
MdePkg/Include/Protocol/SerialIo.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Added entrie in the EFI_SYSTEM_TABLE related definitions section,
to signify UEFI 2.8 spec revision.
(UEFI 2.8 mantis 1926)
Signed-off-by: Oleksiy Yakovlev
---
MdePkg/Include/Uefi/UefiSpec.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Include/Uefi/UefiSpec.h
Added Guids and structures, that defines the work flow to perform
capsule update using JSON objects.
(UEFI 2.8 mantis 1935)
Signed-off-by: Oleksiy Yakovlev
---
MdePkg/Include/Guid/CapsuleReport.h | 29 +++
MdePkg/Include/Guid/JsonCapsule.h | 97 +
Provided a mechanism for UEFI FW to identify and hand off bootable
NVDIMM namespaces to the OS by standardizing the EFI device path.
EFI device path for physical NVDIMM devices changed from an ACPI
_ADR device to an ACPI NVDIMM device for correctness.
(UEFI 2.8 mantis 1858)
Signed-off-by: Oleksiy
Provided a mechanism for UEFI FW to identify and hand off bootable
NVDIMM namespaces to the OS by standardizing the EFI device path.
EFI device path for physical NVDIMM devices changed from an ACPI
_ADR device to an ACPI NVDIMM device for correctness.
(UEFI 2.8 mantis 1858)
Signed-off-by: Oleksiy
Following patches add/update structures/definitions, that was
introduced/modified by UEFI Spec v.2.8.
Oleksiy Yakovlev (7):
MdePkg: Extend SERIAL_IO with DeviceTypeGuid
BaseTools: REST style formset
MdePkg: REST style formset
BaseTools: Bootable NVDIMM namespaces
MdePkg: Bootable
In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.
(UEFI 2.8 mantis 1853)
Signed-off-by: Oleksiy Yakovlev
---
BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h | 1 +
1 file changed, 1 insertion(+)
diff --git
New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined.
In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.
(UEFI 2.8 mantis 1853)
Signed-off-by: Oleksiy Yakovlev
---
MdePkg/Include/Guid/HiiPlatformSetupFormset.h| 4
I was able to use the pull request method that Laszlo documented and fixed
up all of the issues identified by the VS compiler.
An additional change I'm planning to make for the next version (v8) of the
patches is to create a NULL library instance of the VmgExitLib that will
also include the
Add support for the Broadcom GENET v5 ethernet controller
for the Raspberry Pi 4 (BCM2711)
Cc: Pete Batard
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Andrei Warkentin
Cc: Jared McNeill
Co-authored-by: Jared McNeill
Co-authored-by: Andrei Warkentin
Co-authored-by: Samer El-Haj-Mahmoud
Move PCDs from GENET driver to Raspberry Pi and Bcm27xx packages.
The Genet driver follows the UEFI driver model, so it should not have
PCDs defined that describe MMIO and MAC addresses of a single instance.
Also, move related definitions around, and update references accordingly.
Cc: Pete Batard
From: Ard Biesheuvel
The driver for the Broadcom Genet network controller was modified
from a minimal MAC address programming driver to a true SNP driver
implementing full network functionality. Since this involve DMA,
set the DmaLib parameters correctly in the platform.
Cc: Pete Batard
Cc:
Register an event at EndOfDxe to instantiate the EFI device path protocol
with the GENET MAC address on a new handle, and install the
BcmGenetPlatformDeviceProtocol on that handle. This protocol is used to
pass platform information (GENET MAC address and register base address)
to the GENET driver,
Add BcmGenetPlatformDevice definition for GENET. This protocol
will be used to register GENET platform device that is on a
non-discoverable bus.
Cc: Pete Batard
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Andrei Warkentin
Authored-by: Ard Biesheuvel
Signed-off-by: Samer El-Haj-Mahmoud
---
Remove thePlatformPcdLib. It is completely unnecessary. Originally,
this was meant for the GENET driver, but now that ConfigDxe registers
the platform device, the library is superfluous.
Cc: Pete Batard
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Andrei Warkentin
Cc: Jared McNeill
Authored-by:
Update the checkout pin command to look for pin files only in
the workspace's source manifest repository.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo/commands/checkout_pin_command.py | 15
On 5/6/20 9:38 PM, Dong, Eric wrote:
Hi Tom,
Hi Eric,
-Original Message-
From: Tom Lendacky
Sent: Thursday, May 7, 2020 2:33 AM
To: Dong, Eric ; devel@edk2.groups.io;
ler...@redhat.com
Cc: Justen, Jordan L ; Ard Biesheuvel
; Kinney, Michael D
; Gao, Liming ; Ni, Ray
; Brijesh
Update find_project_in_all_indices() to only return None values
for the source manifest repo and config file if the project is
truly not found in any manifest repository. In the case a path
to a manifest file is provided recursively call
find_in_all_indices() with the code name from the manifest
For this patch series: Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Lendacky, Thomas
> Sent: Thursday, May 7, 2020 9:07 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Laszlo Ersek
> ; Ard Biesheuvel ; Gao,
> Liming ; Dong, Eric ; Ni,
Hi Oleksiy.
I think we all agree to remove the comment marker before the final parameter in
struct.
Please see this mail https://edk2.groups.io/g/devel/message/57895
Let me know if you have any concern.
And one little suggestion.
If you send a newer version but don't change anything, you can
The information in commit message is not helpful for me
to understand why this change can avoid OVMF hang.
> -Original Message-
> From: Jiang, Guomin
> Sent: Friday, May 8, 2020 4:38 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Gao, Zhichao ;
> Ni, Ray
> Subject: [PATCH 13/18]
Ok can you add comments to explain:
1. Why 0xFF instead of 0x00 is used as a condition of break (I am not clear).
2. Why 0xFF is used (I am clear now thanks for the explanation. Please
explain in comments).
> -Original Message-
> From: Feng, YunhuaX
> Sent: Saturday, May 9, 2020
Mike,
It's a huge improvement to me as an Outlook user if pull-request-based review
is enabled!
Please help me to understand: The pull-request-based review has been enabled
naturally when edk2
was migrated to Github. People don't use it because it's not accepted by
community. Your process
Update the clone command to support searching for the project
to be cloned in all manifest repositories defined within both
the edkrepo.cfg and the edkrepo_user.cfg files.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo/common/common_repo_functions.py | 11 +++
1 file changed, 11 insertions(+)
diff --git a/edkrepo/common/common_repo_functions.py
Update the clone command to support multiple manifest repositories
and add verify_single_manifest to perform validation of a
single manifest file in a single manifest repository.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince
Hi Tom,
> -Original Message-
> From: Tom Lendacky
> Sent: Thursday, April 23, 2020 1:41 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Laszlo Ersek
> ; Ard Biesheuvel ; Kinney,
> Michael D ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; Brijesh Singh
> Subject: [PATCH v7 08/43]
if found the next FFS size equal 0xFF, return NOT_FOUND
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/FMMT/FmmtLib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/BaseTools/Source/C/FMMT/FmmtLib.c
b/BaseTools/Source/C/FMMT/FmmtLib.c
index
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2707
Ecc fails with Python 3.8 because it uses the deprecated time.clock()
function - https://docs.python.org/3.7/library/time.html#time.clock
This change updates EccMain.py to use time.perf_counter().
Cc: Bob Feng
Cc:
Hello,
This is a proposal to change from the current email-based code review process to
a GitHub pull request-based code review process for all repositories maintained
in TianoCore. The current email-based code review process and commit message
requirements are documented in Readme.md or
I'm working to update a CSM (for bhyve) from UDK2014.SP1 to the latest
master. I've already fixed several problems, but one I'm stuck on now is
that while the code previously had no problem finding Block Io protocol
via gBS->LocateHandleBuffer(ByProtocol, , ...),
it's no longer working: from
Hi Ray,
I have checked the EFI_FFS_FILE_HEADER, the Size only 3 bytes,
GetFfsFileLength only return 0xFF. I not found existing macro
typedef struct {
EFI_GUID Name;
EFI_FFS_INTEGRITY_CHECK IntegrityCheck;
EFI_FV_FILETYPE Type;
EFI_FFS_FILE_ATTRIBUTES Attributes;
UINT8 Size[3];
Yes , you are right, the condition of break should think about Fv's erase
policy, I will update this patch.
Thank you
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Saturday, May 9, 2020 11:28 AM
To: Feng, YunhuaX ; devel@edk2.groups.io
Cc: Feng, Bob C ; Gao,
Hi Everyone,
Wanted to give everyone a heads up that the FSP git repository has moved from
http://www.github.com/IntelFsp/FSP to https://github.com/intel/FSP. Please
update your links.
Regards,
Nate
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Oleksiy,
Sorry I didn't explain myself clearly. It is about the below line.
An Opcode with this flag indicates this question support REST style operation
It has 79 characters, but Commit-Message-Format wiki recommend to have less
than 76 characters.
I don't know if breaking this rule
Yunhua,
Why the comparison is against 0xFF not 0x?
Is there any existing macro that you can use?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Feng, YunhuaX
> Sent: Saturday, May 9, 2020 9:59 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ;
Guomin,
Have you tested the EmulatorPkg in Linux environment with this change?
What's the result?
Thanks,
Ray
> -Original Message-
> From: Jiang, Guomin
> Sent: Friday, May 8, 2020 4:38 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Justen, Jordan L
> ; Andrew Fish ;
> Ni, Ray
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2686
The build tool will give an incorrect GUID value if the GUID includes character
' or " ASCII value.
This patch is going to fix this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yunhua Feng
---
Hi Oleksiy,
It's about the new added file RtPropertiesTable.h?
>MdePkg/Include/Guid/RtPropertiesTable.h | 68 +++
This mean it has 68 lines added.
>+++ b/MdePkg/Include/Guid/RtPropertiesTable.h
>@@ -0,0 +1,71 @@
And this means the total line number is 71.
The two
Guomin,
Can you complete remove HiiFramework.h?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin Jiang
> Sent: Friday, May 8, 2020 4:38 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Feng, Bob C ;
> Gao, Liming
> Subject: [edk2-devel] [PATCH 01/18] BaseTools: Remove
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, YunhuaX
> Sent: Saturday, May 9, 2020 9:59 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [edk2-staging][PATCH] BaseTools/Fmmt: Fix found the next FFS issue
>
> if found the next FFS size equal
Hi Guomin,
Where are the typos? Please point out all the typos you found; it makes easy
for Zhichao to fix all the typos.
Thanks,
Eric
From: devel@edk2.groups.io On Behalf Of Guomin Jiang
Sent: Friday, May 8, 2020 3:24 PM
To: devel@edk2.groups.io; Gao, Zhichao
Cc: Wang, Jian J ; Lu, XiaoyuX ;
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in GraphicsConsoleDxe, remove comment about UGA
in HiiDatabaseDxe.
Cc: Dandan Bi
Cc: Eric Dong
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../GraphicsConsoleDxe/GraphicsConsole.c
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in OvmfPkg.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Guomin Jiang
---
OvmfPkg/OvmfPkgIa32.dsc| 1 -
OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
OvmfPkg/OvmfPkgX64.dsc |
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ArmVirtPkg
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Guomin Jiang
---
ArmVirtPkg/ArmVirtQemu.dsc | 1 -
ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 -
2 files
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
UGA is replaced by GOP and remove all related code.
GuoMinJ (18):
BaseTools: Remove All UGA Support
UefiPayloadPkg: Remove All UGA Support
ShellPkg: Remove All UGA Support
MdeModulePkg: Remove All UGA Support
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in MdePkg.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Guomin Jiang
---
MdePkg/Include/Protocol/UgaDraw.h| 160 ---
MdePkg/Include/Protocol/UgaIo.h | 191
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove the PcdConOutGopSupport definition.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Guomin Jiang
---
MdeModulePkg/MdeModulePkg.dec | 7 ---
MdeModulePkg/MdeModulePkg.uni | 6 --
2 files changed, 13
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Guomin Jiang
---
ArmVirtPkg/ArmVirtQemu.dsc | 4
ArmVirtPkg/ArmVirtQemuKernel.dsc
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Delete PcdConOutGopSupport, it is unnecessary any more.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Guomin Jiang
---
OvmfPkg/OvmfPkgIa32.dsc| 1 -
OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support in BaseTools package.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Guomin Jiang
---
.../Source/C/Include/Protocol/HiiFramework.h | 51 --
BaseTools/Source/C/Include/Protocol/UgaDraw.h | 161
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ShellPkg.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Guomin Jiang
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 --
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove PcdConOutGopSupport, it is unnecessary any more.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Signed-off-by: Guomin Jiang
---
.../Library/PlatformBootManagerLib/PlatformBootManager.h| 2 +-
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove Pcds related to UGA.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Guomin Jiang
---
MdeModulePkg/MdeModulePkg.dec | 7 ---
MdeModulePkg/MdeModulePkg.uni | 6 --
2 files changed, 13 deletions(-)
diff --git
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ArmPkg.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Guomin Jiang
---
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h | 2 +-
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in ConSplitterDxe component.
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../Console/ConSplitterDxe/ConSplitter.c | 290 ++---
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in MdeModulePkg, first remove from library.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Guomin Jiang
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 +-
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in UefiPayloadPkg.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Signed-off-by: Guomin Jiang
---
.../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 --
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove the PcdConOutGopSupport, it is unnecessary any more.
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../Console/ConSplitterDxe/ConSplitter.c | 84 ---
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support in EmulatorPkg.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
EmulatorPkg/EmuGopDxe/Gop.h | 8 ++-
EmulatorPkg/EmuGopDxe/GopScreen.c
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Avoid OVMF hang when remove UGA support.
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../Universal/Console/ConSplitterDxe/ConSplitter.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
Any update on this patch? This is a useful command to add to the Shell (for
both testing and deployment/scripting).
> -Original Message-
> From: Vladimir Olovyannikov
> Sent: Tuesday, April 21, 2020 1:37 PM
> To: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io; Ray Ni ; Zhichao Gao
>
>
It seem ok except some typo, please modify it.
Reviewed-by: Guomin Jiang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao,
> Zhichao
> Sent: Thursday, May 7, 2020 7:58 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Fu, Siyuan ; Kinney, Michael D
>
On 5/6/20 10:54 AM, Gaurav Jain via groups.io wrote:
Firmware management protocol that does not support GetImageInfo
return Unsupported.
The UEFI spec does not list EFI_UNSUPPORTED as a permitted return value
for EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo()
What is the point of producing
Ashraf,
Thanks for the reply. Inline comments below.
> -Original Message-
> From: Javeed, Ashraf
> Sent: Tuesday, April 21, 2020 2:22 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/12]
>
On 05/07/20 15:53, Ard Biesheuvel wrote:
> On 5/7/20 3:43 PM, Daniel Schaefer wrote:
>> Should I/we try to remove the APRIORI entries from OVMF in a similar
>> way?
>>
>
> Let's get to the bottom of this first. Laszlo may remember why exactly
> those entries are there in the first place, and I
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove the PcdConOutGopSupport, it is unnecessary any more.
Cc: Agyeman Prince
Signed-off-by: Guomin Jiang
---
.../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 1 -
1 file changed, 1 deletion(-)
diff
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA Support in INTEL platform.
Cc: Agyeman Prince
Cc: Zailiang Sun
Cc: Yi Qian
Signed-off-by: Guomin Jiang
---
.../BoardX58Ich10/OpenBoardPkgPcd.dsc | 1 -
.../Library/DxeLogoLib/DxeLogoLib.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove All UGA Support
GuoMinJ (3):
Platform/Intel: Remove All UGA Support
Platform/Intel/SimicsOpenBoardPkg: Fix build error.
Platform/Intel: Remove All UGA Support
.../SimicsOpenBoardPkg/AcpiTables/Dsdt.asl| 4 +-
From: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
It seem that the '=' expression is unallowed and the value should be
hex.
Cc: Agyeman Prince
Signed-off-by: Guomin Jiang
---
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl | 4 ++--
1 file changed, 2
97 matches
Mail list logo
