Re: [edk2-devel] [Patch 6/7] BaseTools: Add new CLANG8ELF tool chain for new LLVM/CLANG8

2019-05-16 Thread Bob Feng
The Basetools patch is good for me. For this single patch, Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Friday, April 26, 2019 10:43 PM To: devel@edk2.groups.io Subject: [edk2-devel] [Patch 6/7] BaseTools

Re: [edk2-devel] [PATCH] BaseTools: VfrCompile/Pccts: Fix invalid bytes

2019-05-13 Thread Bob Feng
/josephlr/edk2/tree/format Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Signed-off-by: Joe Richey --- BaseTools/Source/C/VfrCompile/Pccts/KNOWN_PROBLEMS.txt | 2 +- BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr1.txt | 78 ++-- BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg1.txt

Re: [edk2-devel] [PATCH V3] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-27 Thread Bob Feng
) { |.bmp } As shown in the rule above,if SectionType and FileType not defined, FFS files are generated directly, and no other type of file is generated. The patch is to make the BaseTools support these two rules Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source

Re: [edk2-devel] [PATCH V4] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-28 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, May 28, 2019 2:29 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V4] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE BZ:https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer

2019-06-05 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Zhu, Yonghong Sent: Wednesday, June 5, 2019 8:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer As Yonghong has some other focus, remove him from

Re: [edk2-devel] [RFC PATCH 0/2] BaseTools: add script to set up git environment

2019-06-05 Thread Bob Feng
Hi Leif, https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers is a great resource. It's very useful. I tested this scripts. I found a minor issue that I have a local edk2 repo which was cloned by the command: "git clone

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Bob Feng
is to make the BaseTools support these two rules Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Common/DataType.py| 1 + BaseTools/Source/Python/GenFds/EfiSection.py | 22 +- BaseTools/Source/Python/GenFds/FdfParser.py

Re: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File

2019-05-29 Thread Bob Feng
Patch looks fine. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Tuesday, May 28, 2019 11:24 PM To: devel@edk2.groups.io Subject: [edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule

Re: [edk2-devel] [PATCH] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

2019-05-29 Thread Bob Feng
://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. This script can be run in both Py2 and Py3. Cc: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [PATCH] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

2019-05-29 Thread Bob Feng
[--pfx-file PFXFILE] [--arch ARCH] [--operating-system-string OPERATINGSYSTEMSTRING] Cc: Bob Feng Cc: Liming Gao Cc: Kinney Michael D Signed-off-by: Eric Jin --- BaseTools/Source/P

Re: [edk2-devel] Edk2 BaseTools Patches.

2019-05-30 Thread Bob Feng
Thanks for your comments. I’ll push the below 2 patches. [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache [PATCH] BaseTools:Update binary cache restore time to current time I have no strong justification to push this patch in this stable tag. I’ll push it after the

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Bob Feng
OK. For this patch, Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, May 29, 2019 4:25 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE The Dict parameter

Re: [edk2-devel] [PATCH] BaseTools:Update binary cache restore time to current time

2019-05-29 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Tuesday, May 28, 2019 4:35 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section

2019-05-30 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Thursday, May 30, 2019 12:27 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section BZ: https

[edk2-devel] Edk2 BaseTools Patches.

2019-05-30 Thread Bob Feng
Hi, Currently, we have 5 Basetools patches which are ready to push. Since we are in the soft-freeze phase, I'd like to ask for your opinions if those patches can be pushed to edk2 master. These 5 patches are to fix the issues for the build cache feature. [Patch V4 2/2] BaseTools: Refactor

Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

2019-05-29 Thread Bob Feng
The "entend" should be "extend", right? I can fix it when I push this patch. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Thursday, May 30, 2019 10:31 AM To: devel@edk2.groups.io Cc

Re: [edk2-devel] [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file

2019-05-30 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Thursday, May 30, 2019 12:27 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file BZ: https

Re: [edk2-devel] Edk2 BaseTools Patches.

2019-05-30 Thread Bob Feng
Thanks Christian. I add some short description for the patches. These 5 patches are all for binary cache feature. [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file The above 2 patches

Re: [edk2-devel] [PATCH v2] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.

2019-06-13 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Thursday, June 13, 2019 4:32 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming ; Feng, Bob C Subject: [edk2-devel

Re: [edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.

2019-06-13 Thread Bob Feng
Hi Chasel, Patch looks good. For the process number, build.py does the same thing as this patch. If pass -n 0 to build.py, build.py will set the processor number to multiprocessing.cpu_count() Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On

Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Build Cache output notification message

2019-06-16 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Friday, June 14, 2019 7:45 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [PATCH v2 1/1] BaseTools:Build Cache output notification message BZ:https

Re: [edk2-devel] [Patch] BaseTools/Capsule: Supports UEFI Capsule with multiple payloads and embedded drivers

2019-06-10 Thread Bob Feng
ot;-j JSONFILE" to support multiple payloads and embedded drivers with JSON file. The update is in a backwards compatible manner, so all command line options to support single payload are still supported. But all the options associated with multiple payloads should be provided in a JSON file.

Re: [edk2-devel] [PATCH 2/2] BaseTools: add script to configure local git options

2019-06-10 Thread Bob Feng
This patch looks good to me. Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Monday, June 10, 2019 7:54 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong ; Andrew Fish ; Laszlo Ersek ; Kinney, Michael D

Re: [edk2-devel] [PATCH V2] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts

2019-06-10 Thread Bob Feng
I question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files based on vfi/vfr/hfr/sd/sdi in the tree. This script can be run in both Py2 and Py3. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan

Re: [edk2-devel] [PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-10 Thread Bob Feng
Hi Leif, These 2 new file have no license header, need to add? Thanks, Bob -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Monday, June 10, 2019 7:54 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong ; Andrew Fish ; Laszlo Ersek

Re: [edk2-devel] [PATCH] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-10 Thread Bob Feng
how_bug.cgi?id=1850</a> This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs. The input parameters are Dec file and package directory. This script can be run in both Py2 and Py3. Cc: Bob Feng <bob.c.f...@intel.com> Cc: Liming Gao <liming@intel.com> Signed-o

Re: [edk2-devel] [PATCH v2 1/1] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

2019-06-10 Thread Bob Feng
[--product-fw-mfg-name PRODUCTFWMFGNAME] [--product-fw-desc PRODUCTFWDESC] [--capsule-file-name CAPSULEFILENAME] [--pfx-file PFXFILE] [--arch ARCH] [--operating-system-string OPERATINGSYSTEMSTRING] Cc: Bob

Re: [edk2-devel] [PATCH] BaseTools:Build cache support the cache files for library package

2019-06-10 Thread Bob Feng
e expected result is the BinCache folder is generated and the MdePkg build cache files (e.g. .hash and .lib) are stored in the BinCache folder. But the BinCache folder is not generated at all. This patch is going to fix that issue. Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Signed-off-by:

Re: [edk2-devel] [PATCH] BaseTools:Add import in FvImageSection

2019-06-20 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, June 20, 2019 2:08 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Add import in FvImageSection BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1872 Since

[edk2-devel] [Patch 2/2] BaseTools: Move Build Cache related function out of CreateAsBuiltInf

2019-06-23 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1932 There are two functions in current CreateAsBuiltInf, Copy Binary files to build cache folder and create asbuild inf file. This patch is to separate UpdateBuildCache and CreateAsBuiltInf into two functions. Signed-off-by: Bob Feng Cc

[edk2-devel] [Patch 1/2] BaseTools: refine CreateAsBuiltInf function

2019-06-23 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1932 ModuleAutogen.CreateAsBuiltInf IsOnlyCopy parameter and related function can be moved out of CreateAsBuiltInf, so that CreateAsBuiltInf is more clean. Cc: Liming Gao Cc: Steven Shi Cc: Christian Rodriguez Signed-off-by: Bob Feng

[edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

2019-06-23 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=1932 In current implementation, there are 2 functions in CreateAsBuiltInf, one is create asbuildinf, the other is update build cache. They should be separated. Feng, Bob C (2): BaseTools: refine CreateAsBuiltInf function BaseTools: Move Build

Re: [edk2-devel] [PATCH V3] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-23 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=1850">https://bugzilla.tianocore.org/show_bug.cgi?id=1850</a> This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs. The input parameters are Dec file and package directory. This script can be run in both Py2 and Py3.

Re: [edk2-devel] [PATCH V4] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-24 Thread Bob Feng
<pre>Reviewed-by: Bob Feng <bob.c.f...@intel.com> -Original Message- From: Fan, ZhijuX Sent: Monday, June 24, 2019 6:26 PM To: devel@edk2.groups.io Cc: Gao, Liming <liming@intel.com>; Feng, Bob C <bob.c.f...@intel.com> Subject: [PATCH V4] BaseTools:Add Dete

Re: [edk2-devel] [PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-11 Thread Bob Feng
OK. I will add the header when I do push. Reviewed-by: Bob Feng -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Tuesday, June 11, 2019 5:35 PM To: Feng, Bob C Cc: devel@edk2.groups.io; Gao, Liming ; Zhu, Yonghong ; Andrew Fish ; Laszlo Ersek ; Kinney

Re: [edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-17 Thread Bob Feng
Adding FMMT, FCE to BaseTools is fine for me. The patch is good to me. Reviewed-by: Bob Feng -Original Message- From: Zhang, Shenglei Sent: Tuesday, June 11, 2019 1:23 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT t

Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Build cache cannot store the cache files for library package

2019-06-16 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Tuesday, June 11, 2019 2:33 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH v2 1

Re: [edk2-devel] [PATCH v3 1/1] BaseTools: Cannot store library cache of different arch together

2019-06-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Monday, June 17, 2019 4:16 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian Subject: [PATCH v3 1/1] BaseTools: Cannot store library cache of different arch together https

Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Introduce CopyFileOnChange() function to copy cache files

2019-06-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Monday, June 17, 2019 4:44 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian Subject: [PATCH v2 1/1] BaseTools:Introduce CopyFileOnChange() function to copy cache files BZ:https

Re: [edk2-devel] [PATCH] Revert "BaseTools:code of test python module is moved to edksetup"

2019-05-09 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, May 9, 2019 2:50 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] Revert "BaseTools:code of test python module is moved to edksetup" This reve

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
g/show_bug.cgi?id=1787 >> >> > >> >> > Get a list of local header files that are not present in the >> >> > MetaFile for this module. Add those local header files into the >> >> > hashing algorithm for a module. If a local header file is not >>

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
>>> -Original Message- >>>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf >>>>> Of Laszlo Ersek >>>>> Sent: Thursday, May 09, 2019 7:53 PM >>>>> >>>>> Hello Christian, >>>>> >>&g

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

2019-05-13 Thread Bob Feng
[edk2-devel] [PATCH] BaseTools: Include headers not >>>>> mentioned in inf are not hashed >>>>> >>>>>> -Original Message- >>>>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On >>>>>> Behalf O

Re: [edk2-devel] [Patch] BaseTools: Update Conf/target.template with the default EmulatorPkg.dsc

2019-05-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming Gao Sent: Tuesday, May 21, 2019 11:09 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [edk2-devel] [Patch] BaseTools: Update Conf/target.template with the default

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Bob Feng
ow_bug.cgi?id=1561 > > > > > >When a target of 'run' is passed into build.py, > BaseTools > > >unconditionally attempts to execute the application > called './SecMain' > > >in the build output directory. > > > > > >This behavior appl

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-22 Thread Bob Feng
> > >; Kinney, Michael D > > > > > >Subject: [Patch] BaseTools: Remove './SecMain' > from > > 'run' target > > > > > > > >BZ: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1561 > > > > > > > >When a target of '

Re: [edk2-devel] [PATCH] BaseTools:Change the path of the file that Binary Cache

2019-05-23 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, May 24, 2019 1:02 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Shi, Steven Subject: [PATCH] BaseTools:Change the path of the file that Binary Cache BZ:https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [PATCH V2] BaseTools:Make BaseTools support the correct RAW FFS FILE generation

2019-05-24 Thread Bob Feng
] FILE RAW = $(NAMED_GUID) { SectionType FileType $(INF_OUTPUT)/$(MODULE_NAME).bin } As shown in the rule above,if SectionType and FileType not defined, FFS files are generated directly, and no other type of file is generated. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan

Re: [edk2-devel] [PATCH] BaseTools: Add a checking for Sources section in INF file

2019-05-23 Thread Bob Feng
ng fetched for Makefile purposes. All other information is already cached in memory. No extra IO time is needed. Signed-off-by: Christian Rodriguez Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 6 -- BaseTools/Source/Python/AutoGen/GenMake

[edk2-devel] [Patch 2] BaseTools: Remove './SecMain' from 'run' target

2019-05-23 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561 This patch is related to commit 9ca1f1 It's to remove the second .SecMain call from 'run' target. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Michael D Kinney --- BaseTools/Source/Python/build/build.py | 4 1 file changed, 4

Re: [edk2-devel] [Patch V2] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-20 Thread Bob Feng
due to the fact that they are built as dependencies. So on a clean build, we now generate the .hash after the library dependencies are complete. Added early escape as optimization, if hash already exists in memory. Signed-off-by: Christian Rodriguez Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu

[edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-10 Thread Bob Feng
in the EmulatorPkg. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Michael D Kinney --- BaseTools/Source/Python/build/build.py | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index 7271570d29..04f266abf5 100644

Re: [edk2-devel] [PATCH] BaseTools: Check the fread function and avoid dead loop

2019-05-10 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Liu, Zhiguang Sent: Friday, May 10, 2019 9:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools: Check the fread function and avoid dead loop REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1789

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-10 Thread Bob Feng
32Pkg which is being replaced with >features in the EmulatorPkg. > >Signed-off-by: Bob Feng >Cc: Liming Gao >Cc: Michael D Kinney >--- > BaseTools/Source/Python/build/build.py | 4 > 1 file changed, 4 deletions(-) > >diff --git a/BaseTools/Source/Python/build/build.py >

Re: [edk2-devel] [edk2][PATCH] BaseTools:Coding problems cause can not encode FMP Auth Header

2019-04-14 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, April 10, 2019 4:41 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Coding problems cause can not encode FMP Auth Header GenerateCapsule: error: can not encode FMP

Re: [edk2-devel] [PATCH] BaseTools:Makefiles cause data errors on some platforms

2019-04-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, April 17, 2019 10:02 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:Makefiles cause data errors on some platforms As the Dict is unordered, an error occurs when using

Re: [edk2-devel] [PATCH] BaseTools:Makefiles cause data errors on some platforms

2019-04-17 Thread Bob Feng
y helpful, it's just that the subject lines were chosen in an unfortunate way. Bob: please enforce higher standards for commit messages under BaseTools. People *care*. (I certainly do.) Good commit messages teach details about the subsystem or module. Thanks, Laszlo > > Cc: Bob Feng >

Re: [edk2-devel] [PATCH V2] BaseTools:Makefiles cause data errors on some platforms

2019-04-18 Thread Bob Feng
, use OrdereDict instead of Dict. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/AutoGen/GenMake.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen

Re: [edk2-devel] [PATCH V3] BaseTools:fixed the incorrect autogen makefile which cause build failure.

2019-04-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, April 18, 2019 7:21 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V3] BaseTools:fixed the incorrect autogen makefile which cause build failure. BZ:https://bugzilla.tianocore.org

Re: [edk2-devel] [PATCH] BaseTools: Hash false success.. minor change in hash invalidation

2019-04-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Christian Rodriguez Sent: Wednesday, April 17, 2019 3:41 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [edk2-devel] [PATCH] BaseTools

Re: [edk2-devel] [Patch V2] BaseTools: Enhance Bin Cache database to support save the cache

2019-04-21 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Thursday, April 18, 2019 10:16 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V2] BaseTools: Enhance Bin Cache database to support save the cache BZ: https

[edk2-devel] [Patch] BaseTools: Support customized compiling command

2019-04-22 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1737 User may add other commands before CC command from build_rule.txt for specific purpose. It worked fine before commit 05217d210e. This patch is going to fix the bug in commit 05217d210e to support customized CC command. Signed-off-by: Bob

Re: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-23 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek Sent: Friday, April 19, 2019 1:47 AM To: edk2-devel-groups-io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [edk2-devel] [PATCH v2 3/5] BaseTools

Re: [edk2-devel] [PATCH] BaseTools:Fixed an issue where the order of Guids changed in guid.xref

2019-04-25 Thread Bob Feng
e if set() is used > >This patch is going to fix that issue. > >Cc: Bob Feng >Cc: Liming Gao >Signed-off-by: Zhiju.Fan >--- > BaseTools/Source/Python/Workspace/DscBuildData.py | 20 ++- >- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff

[edk2-devel] [Patch] Document: Correct the Appendix G to Appendix F

2019-04-27 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1690 This patch is going to fix the typo of Appendix G in Inf spec. Signed-off-by: Bob Feng Cc: Liming Gao --- 2_inf_overview/24_[defines]_section.md | 2 +- appendix_f_module_types.md | 2 +- 2 files changed, 2 insertions(+), 2

[edk2-devel] [Patch] BaseTools: Add GCC flags to Basetool build.

2019-04-29 Thread Bob Feng
these 3 build options to BaseTool GCC build option. Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Makefiles/header.makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles

[edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines.

2019-04-30 Thread Bob Feng
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 To be easy to review in future, split the long line into multiple shorter lines. Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Makefiles/header.makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[edk2-devel] [Patch 2/2] BaseTools: Add GCC flags to Basetool build.

2019-04-30 Thread Bob Feng
are available: -fno-delete-null-pointer-checks tells the compiler NOT to assume that null pointer deference does not exist. -fwrapv tells the compiler that signed overflow always wraps. This patch is going to add these 2 build options to BaseTool GCC build option. Signed-off-by: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [Patch] BaseTools: Add GCC flags to Basetool build.

2019-04-30 Thread Bob Feng
GCC flags to Basetool build. Hi Bob, On 04/29/19 10:01, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 > > Some compiler flags restrict the compiler from making arbitrary > decisions while handling undefined C/C++ behaviors. > Therefore they can be used to

Re: [edk2-devel] [Patch 1/2] BaseTools: split long line into multiple short lines.

2019-04-30 Thread Bob Feng
line into multiple short lines. Hi Bob, On 04/30/19 13:06, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 > > To be easy to review in future, split the long line into multiple > shorter lines. > > Signed-off-by: Bob Feng > Cc: Liming Gao > -

Re: [edk2-devel] [PATCH V2] BaseTools:Fixed an issue where the order of GuidS changed in guid.xref

2019-04-30 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, April 26, 2019 10:30 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:Fixed an issue where the order of GuidS changed in guid.xref BZ:https://bugzilla.tianocore.org

Re: [edk2-devel] [PATCH 1/3] BaseTools:Delete FrameworkDatabase from BaseTools/Conf

2019-05-06 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, May 6, 2019 5:16 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH 1/3] BaseTools:Delete FrameworkDatabase from BaseTools/Conf BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627

Re: [edk2-devel] [PATCH] BaseTools:Optimize code to support C files with different suffixes

2019-05-06 Thread Bob Feng
to support C files with different suffixes BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773 Build break if C file suffixes of named .C Under certain circumstances. Some programs do not recognize filenames with uppercase suffixes. This patch is going to fix that issue. Cc: Bob Feng Cc: Liming

Re: [edk2-devel] [PATCH] BaseTools:ECC report errors on account of analyze special characters

2019-05-06 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Monday, May 6, 2019 10:35 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:ECC report errors on account of analyze special characters BZ:https://bugzilla.tianocore.org/show_bug.cgi?id

Re: [edk2-devel] [PATCH] BaseTools:The code used to test python module is moved to edksetup

2019-05-06 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, April 30, 2019 10:16 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH] BaseTools:The code used to test python module is moved to edksetup BZ:https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2-devel] [PATCH] BaseTools:corrected error message for the DatumType error

2019-05-06 Thread Bob Feng
ype error message is inappropriate. This patch corrects the error message. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/Workspace/DscBuildData.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Worksp

Re: [edk2-devel] [patch 01/11] BaseTools/VfrCompile: Remove framework VFR support

2019-05-06 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan Bi Sent: Monday, April 29, 2019 10:16 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [patch 01/11] BaseTools/VfrCompile: Remove

Re: [edk2-devel] [PATCH V2] BaseTools:corrected error message for the DatumType error

2019-05-07 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, May 7, 2019 3:14 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:corrected error message for the DatumType error BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1762

[edk2-devel] [Patch] BaseTools: Fix the issue that build report missing Module Size

2019-05-08 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1786 commit b1e27d changed GENFW output folder from DEBUG to OUTPUT, but that commit missed updating the buildreport.py for FwReportFileName. This patch is going to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source

Re: [edk2-devel] [PATCH V2] BaseTools:improve code to support C files with .C suffixes

2019-05-08 Thread Bob Feng
t;> unittest tested minplatform, Ovmf. This problem was found when >>>>>> building a platform inside Intel. >>>>>> We've tested it on Linux and Windows. >>>>>> >>>>>> Any question, please let me know. Thanks. >>>>

Re: [edk2-devel] [PATCH] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-16 Thread Bob Feng
that they are built as dependencies. So on a clean build, we now generate the .hash after the library dependencies are complete. Added early escape as optimization, if hash already exists in memory. Signed-off-by: Christian Rodriguez Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- BaseTools

[edk2-devel] [Patch] BaseTools: Fix private includes for FILE_GUID override

2019-05-16 Thread Bob Feng
to see if the module INF is in the package with private includes. Signed-off-by: Michael D Kinney Cc: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- BaseTools/Source/Python/Common/Misc.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH V2] BaseTools:Update mailing list address in BaseTools error messages

2019-05-20 Thread Bob Feng
aseTools error messages BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1815 The edk2 source tree contains four instances of the outdated mailing list address "edk2-de...@lists.01.org". I created a new variable, MSG_EDKII_MAIL_ADDR, to receive the new email address and repla

Re: [edk2-devel] [Patch V3] BaseTools: Library hashing fix and optimization for --hash feature

2019-05-20 Thread Bob Feng
This patch is good to me. Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Monday, May 20, 2019 10:18 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V3] BaseTools: Library hashing fix and optimization for --hash

Re: [edk2-devel] [PATCH V3] BaseTools:Update mailing list address in BaseTools error messages

2019-05-20 Thread Bob Feng
This patch looks fine. Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, May 21, 2019 10:07 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V3] BaseTools:Update mailing list address in BaseTools error messages BZ:https

Re: [edk2-devel] [PATCH] BaseTools: Fix various typos

2019-07-04 Thread Bob Feng
The attached patch looks fine. Reviewed-by: Bob Feng On Thu, Jul 4, 2019 at 09:03 PM, Leif Lindholm wrote: > > +Bob, Liming > > On Wed, Jul 03, 2019 at 08:08:59AM -0700, Cœur wrote: > >> Fix various typos in BaseTools. >> >> Contributed-under: TianoCore Con

Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos

2019-07-04 Thread Bob Feng
Hi Antoine, Patch looks fine. Would you attach the patch file again? I can't extract the patch file from the mail. Pccts is the predecessor of ANTLR. It's dead. Thanks, Bob -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, July 4, 2019 9:07 PM

Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-06-27 Thread Bob Feng
ao, Liming > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files > > The patches look good. > > I think removing --nt32 option is incompatible change. What about keep the > --nt32 ? > > For the Patch 2 setup for different VS tool chains. > Reviewed-by: Bob

[edk2-devel] [Patch 1/1] BaseTools: Detect the change of env variable used in tooldef.txt

2019-06-27 Thread Bob Feng
is changed, build tool will rebuild the platform. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Steven Shi --- BaseTools/Source/Python/AutoGen/AutoGen.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b

[edk2-devel] [Patch 1/1] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-06-28 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

[edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

2019-06-28 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

Re: [edk2-devel] [PATCH] MinPlatformPkg: FSP Python script to python 3.x.

2019-06-27 Thread Bob Feng
Patch looks good. Reviewed-by: Bob Feng -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42973): https://edk2.groups.io/g/devel/message/42973 Mute This Topic: https://groups.io/mt/32192703/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-28 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, June 28, 2019 2:59 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Ard Biesheuvel ; Leif Lindholm ; Kinney, Michael D Subject: [edk2-platform patch V6] Platform/Intel:Add UniTool into edk2-platforms

[edk2-devel] [Patch 1/1] BaseTools: Fixed the issue when ToolDefinitionFile is not generated

2019-07-10 Thread Bob Feng
ToolDefinitionFile is generated by PlatformAutoGen.ToolDefinition() Code assume ToolDefinition is always called before using ToolDefinitionFile, but in some cases, it's not true. This patch is to fix this issue. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

Re: [edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

2019-07-10 Thread Bob Feng
Reviewed-by: Feng Bob C -Original Message- From: Gao, Liming Sent: Thursday, July 11, 2019 9:45 AM To: devel@edk2.groups.io Cc: Leif Lindholm ; Feng, Bob C Subject: [Patch 0/7] Revert new added BfmLib/FCE/FMMT Rewrite those tools for review again. Now, move them into

[edk2-devel] [Patch 1/1] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-11 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

2019-07-11 Thread Bob Feng
WORKSPACE folder to PACKAGES_PATH My patch works fine. But there is a bug in original code for case 1#, I'll send out another patch to fix that. Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng Sent: Thursday, July 11, 2019 5

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

2019-07-11 Thread Bob Feng
1875 > >The build config files are target.txt, build rule, tooldef During a >build, the config is not changed, so the object to handle them need to >be singleton. > >Cc: Liming Gao >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/AutoGen/AutoGen.py| 33 ++--

Re: [edk2-devel] [Patch 1/1] BaseTools: Singleton the object to handle build conf file

2019-07-11 Thread Bob Feng
folder to > PACKAGES_PATH > > My patch works fine. > > But there is a bug in original code for case 1#, I'll send out another patch > to fix that. > > Thanks, > Bob > > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >

Re: [edk2-devel] [PATCH] BaseTools: Fix python3.8 SyntaxWarning

2019-07-12 Thread Bob Feng
I tested this patch on python2.7 and 3.7. It works fine. Reviewed-by: Bob Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, July 13, 2019 5:03 AM To: Cole Robinson ; devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: Re: [PATCH] BaseTools

  1   2   3   >