https://bugzilla.tianocore.org/show_bug.cgi?id=1799
1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1
2. Base on PciHostBridge related PCDs to Initialize RootBridges.
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Cc: Sai Chaganty
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1799
1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1
2. Base on PciHostBridge related PCDs to Initialize RootBridges.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Query the supported attributes firstly, then AND (&&) both
VGA_IO and VGA_IO_16. Since the supported attributes should
only have VGA_IO or VGA_IO_16 set, the result of AND (&&) is
either VGA_IO or IO_16. Then the result can be passed to
PciIo->Attributes() to set the attributes.
Signed-off-by:
Query the supported attributes firstly, then AND (&&) both
VGA_IO and VGA_IO_16. Since the supported attributes should
only have VGA_IO or VGA_IO_16 set, the result of AND (&&) is
either VGA_IO or IO_16. Then the result can be passed to
PciIo->Attributes() to set the attributes.
Signed-off-by:
Query the supported attributes firstly, then bitwise AND (&) both VGA_IO
and VGA_IO_16. Since the supported attributes should only have one of
VGA_IO or VGA_IO_16 set, the result of bitwise AND (&) is either VGA_IO
or IO_16. Then the result can be passed to PciIo->Attributes() to set the
rall ; Marc-André Lureau
> ; Stefan Berger
> Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't
> assume system in VGA alias mode.
>
> On 06/05/19 13:14, Marc W Chen wrote:
> > Query the supported attributes firstly, then AND (&&) both
> > VGA_IO and
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then
base on PciHostBridge related PCDs to Initialize RootBridges.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc Chen
Cc: Michael Kubacki
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1, then
base on PciHostBridge related PCDs to Initialize RootBridges.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marc Chen
Cc: Michael Kubacki
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1
2. Base on PciHostBridge related PCDs to Initialize RootBridges.
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Cc: Sai Chaganty
---
https://bugzilla.tianocore.org/show_bug.cgi?id=1799
1. Add PcdPciSegmentCount PCD in MinPlatformPkg.dec and set default to 1
2. Base on PciHostBridge related PCDs to Initialize RootBridges.
Signed-off-by: Marc Chen
Cc: Michael Kubacki
Cc: Sai Chaganty
---
>> > Thanks
> >> > Laszlo
> >> >
> >> > > I prefer to remove the files in MdeModulePkg to avoid future
> confusion.
> >> > >
> >> > > Thanks,
> >> > > Ray
> >> > >
> >> &
\CoffeelakeSiliconPkg\SampleCode\IntelFrameworkPkg\Include\Guid\SmramMemoryReserve.h
Signed-off-by: Marc W Chen
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Kelly Steele
Cc: Thad Gillispie
Cc: Daocheng Bu
Cc: Isaac W Oram
---
.../Include/Guid/SmramMemoryReserve.h
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 339 +
-Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Marc W Chen
> > Sent: Monday, August 26, 2019 2:14 PM
> > To: devel@edk2.groups.io
> > Cc: Chen, Marc W ; Ni, Ray ;
> > Chaganty, Rangasai V
> > Subject: [edk2-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 339 +
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +
Kinney
Cc: Kelly Steele
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Include/Guid/SmramMemoryReserve.h | 54 ---
.../Smm/Dxe/SmmAccessDxe/SmmAccess.inf| 2 +-
.../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c| 2
: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Include/Guid/SmramMemoryReserve.h | 54 ---
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 --
.../PlatformInitPei
: Daocheng Bu
Cc: Isaac W Oram
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Include/Guid/SmramMemoryReserve.h | 43 ---
Silicon/Intel/PurleySktPkg/SocketPkg.dec | 3 +-
2 files changed, 1 insertion(+), 45 deletions
\SmramMemoryReserve.h
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Include/Guid/SmramMemoryReserve.h | 51 ---
Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec | 5 --
.../SystemAgent
\SmramMemoryReserve.h
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Include/Guid/SmramMemoryReserve.h | 54 ---
Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec| 4 --
.../SystemAgent
Kinney
Cc: Kelly Steele
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Signed-off-by: Nate DeSimone
---
.../Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c | 4 ++--
.../Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.inf | 2 +-
.../Platform/Pei/PlatformInit/MrcWrapper.c
\CoffeelakeSiliconPkg\SampleCode\IntelFrameworkPkg\Include\Guid\SmramMemoryReserve.h
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Chasel Chiu
Cc: Liming Gao
Cc: Nate DeSimone
Cc: Kelly Steele
Cc: Thad Gillispie
Cc: Daocheng Bu
Cc: Isaac W Oram
Co-authored-by: Nate DeSimone
Signed-off-by: Marc W Chen
Thanks Ray and Sai for reviewing, please see my below reply for your questions.
1. The reason why I put the Library folder in Feature/SmmAccess folder is
because I saw Feature/Capsule also doing it this way, so I thought we want to
put all related implementation in the same feature folder
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +
Implement a S3 Advanced PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Marc Chen
---
.../S3Advanced/S3AdvancedPei/S3AdvancedPei.c | 36
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154
Implement a S3 Advanced PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Marc Chen
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154
Implement a S3 Advanced PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Marc Chen
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154
Implement a S3 PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Marc Chen
---
Implement a S3 Advanced PEIM driver for supporting S3 feature.
So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
Change-Id: Ie5841047be350f411650ad30f16d210b98197dc4
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Marc Chen
---
devel@edk2.groups.io; Chen, Marc W
> > > > Cc: Kinney, Michael D ; Ni, Ray
> > > >
> > > > Subject: RE: [edk2-devel] [PATCH] MdePkg: Add MmAccess and
> > MmControl
> > > > definition.
> > > >
> > > > Marc:
> > &g
the following patches for the change in MdeModulePkg?
>
> Thanks
> Liming
> >-Original Message-
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Marc W Chen
> >Sent: Monday, July 29, 2019 12:26 PM
> >To: devel@edk2.groups.io
&
e one in MdeModulePkg. Have
> > you the following patches for the change in MdeModulePkg?
> >
> > Thanks
> > Liming
> > >-Original Message-
> > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > >Marc W Chen
> >
t; >
> >Cc: Michael D Kinney
> >Cc: Liming Gao
> >Cc: Ray Ni
> >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
> >Signed-off-by: Marc W Chen
> >---
> > MdePkg/Include/Guid/SmramMemoryReserve.h | 45
> >
&g
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45
MdePkg
EFI MmAccess and MmControl PPIs are defined in the PI 1.5 specification.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2023
Signed-off-by: Marc W Chen
---
MdePkg/Include/Ppi/MmAccess.h | 155
>
> Marc:
> Normally, gEfiGuidCName matches GUID C Macro name. Can you follow this
> rule?
>
> Thanks
> Liming
> >-Original Message-
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Marc W Chen
> >Sent: Monday, Jul
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45
MdePkg
> Subject: Re: [edk2-devel] [PATCH] MdePkg: Add MmAccess and MmControl
> definition.
>
> On 08/01/19 12:15, Marc W Chen wrote:
> > Yes, my purpose is to avoid platform code update if the package is allowed
> to use MdeModulePkg like OvmfPkg.
> > For those packages that cannot
>>> -Original Message-
> >>> From: devel@edk2.groups.io On Behalf Of
> Laszlo
> >>> Ersek
> >>> Sent: Friday, August 2, 2019 10:14 AM
> >>> To: devel@edk2.groups.io; Chen, Marc W ; Ni,
> >>> Ray ; Gao, Liming
> &
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45
MdePkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Ray Ni
Cc: Liming Gao
Cc: Shenglei Zhang
Signed-off-by: Marc Chen
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 ++--
.../SmmAccess/SmmAccessDxe/SmmAccessDriver.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Ray Ni
Cc: Liming Gao
Cc: Shenglei Zhang
Signed-off-by: Marc Chen
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 ++--
.../SmmAccess/SmmAccessDxe/SmmAccessDriver.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Ray Ni
Cc: Liming Gao
Cc: Shenglei Zhang
Signed-off-by: Marc Chen
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 +--
.../SmmAccess/SmmAccessDxe/SmmAccessDriver.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436
Fixed some doxygen comment that does not follow correct doxygen format.
Updated some description of some functions.
Notes:
v1:
- Initial version of code change.
v2:
- Update some description of some functions.
v3:
- Update some description
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Cc: Shenglei Zhang
Signed-off-by: Marc Chen
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 19 ---
.../Feature/SmmAccess/SmmAccessDxe/SmmAccessDriver.c
47 matches
Mail list logo
