Fix a few typos in LegacyBiosBuildE820, and improve the debug output of
the E820 table to pad with zeros instead of spaces, remove extra hyphens
and display the memory type in decimal.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
---
Is there any expectation that EDK2 will build on non-x86 systems?
I tried building BaseTools (from git master,
ae2fb9ead47b5abaf2a4e815b5f57c8f4838b221) using GCC 8.2 on a SoftIron
OverDrive 1000 (running FreeBSD) but there are lots of errors, such as:
gcc -c -I .. -I ../Include/Common -I
On 2019-04-10 08:41, Philippe Mathieu-Daudé wrote:
This doesn't look like an architecture problem. It seems your GCC
version isn't checked correctly by BaseTools. This warning is supposed
to be disabled, see:
StdLib/LibC/Stdio/Stdio.inf: GCC:*_*_*_CC_FLAGS= -fno-builtin
On 2019-04-10 18:09, Liming Gao wrote:
Yes. No test on FreeBSD. If possible, can you contribute the patch to fix this
issue on FreeBSD?
Thanks. I'm working on fixing it now: it looks like it needs new
compiler flags in BaseTools/Source/C/Makefiles/header.makefile, as well
as recognizing
Some systems such as FreeBSD identify the platform as 'arm64'
and not 'aarch64' as Linux does.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/C/GNUmakefile | 5 +++--
BaseTools/Source/C/Makefiles/header.makefile | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff
On 2019-04-10 20:07, Rebecca Cran via Groups.Io wrote:
Thanks. I'm working on fixing it now: it looks like it needs new
compiler flags in BaseTools/Source/C/Makefiles/header.makefile, as
well as recognizing arm64 as a platform name in addition to aarch64
It didn't need any compiler flag
On 2019-04-11 11:52, Laszlo Ersek wrote:
On 04/11/19 16:23, Philippe Mathieu-Daudé wrote:
On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote:
Some systems such as FreeBSD identify the platform as 'arm64'
and not 'aarch64' as Linux does.
Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id
On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
The include guard is incomplete and does not define the macro.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Rebecca Cran
Signed-off-by: Michael Kubacki
---
Improve the Readme.md in Platform/Ampere:
- At this point eMAG is irrelevant, and most people are likely
using Altra systems. Drop mention of it.
- Instead of mentioning the 'latest' versions of CentOS and Ubuntu
(which will by definition change over time), specify Ubuntu 22.04
and CentOS
On 9/12/2023 10:04 AM, CrossedCarpet via groups.io wrote:
Greetings,
As newer laptops start lacking Ethernet ports, I started investigating
the possibility of using *USB Tethering* as a replacement, to *allow for
internet connection at boot*.
Current attempts at employing *ifconfig* to
On 9/12/2023 3:58 AM, Leif Lindholm via groups.io wrote:
So, it's really good that you add "known good" versions so that if
someone runs into a problem around toolchain version compatibility,
they know what to use. But anything in edk2-platform should be kept up
to date so that it builds on
On 9/7/2023 9:46 AM, Nhi Pham wrote:
This adds Rebecca Cran as reviewer, updates myself as maintainer, and
Leif as reviewer. Also, removes Vu Nguyen and Thang Nguyen due to no
longer working on EDK2.
Signed-off-by: Nhi Pham
---
Maintainers.txt | 7 +++
1 file changed, 3 insertions(+), 4
On 10/17/2023 4:05 AM, Laszlo Ersek wrote:
Nhi says that reading LINK_CONTROL_LINK_STATUS_REG is redundant; its only
use was debugging (before commit 380b4b40c60d). Thus, we can go farther
than commit 2e27c62ef000, and remove the MmioRead32() call altogether.
Build-tested with "Jade.dsc".
Cc:
On 10/27/2023 9:15 AM, Joey Vagedes via groups.io wrote:
Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to v0.25.1
and performs all necessary integrations as noted in the individual package
commits.
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Cc: Liming Gao
Improve the Readme.md in Platform/Ampere:
Direct people to the top-level Readme.md file for build instructions.
Mention the edk2-ampere-tools repo for additional build tools.
Delete everything else, since it's redundant.
Signed-off-by: Rebecca Cran
---
Platform/Ampere/Readme.md | 29
On 9/25/2023 3:03 AM, Marcin Juszkiewicz via groups.io wrote:
I feel sick each time I have to edit EDK2 code.
All those INF, DEC, DSC, FDF, XYZ files are something I do not even try
to understand, just got minimal knowledge what goes where by asking Leif
(thanks a lot!) and observing build
On 9/20/2023 9:55 AM, Marcin Juszkiewicz via groups.io wrote:
Those changes float around whenever I do some changes in code. Time to
send them for merge and stop bothering.
Marcin Juszkiewicz (2):
Silicon/SbsaQemu: drop duplicated Pcd
Silicon/SbsaQemu: fix comment to show proper table
On 1/22/2024 6:53 PM, Oliver Smith-Denny wrote:
I was able to repro your bug (by just turning on page guards on
ArmVirtQemu, allocating runtime mem and freeing it). I think you
are the first person to free runtime mem on ARM64 with page guards
enabled (and to care when it failed :).
The heap
On 1/19/2024 1:03 PM, Oliver Smith-Denny wrote:
Thanks for trying. In lieu of being able to test myself, all I can offer
is adding some more prints, when the memory gets allocated, making sure
it is 64k aligned then. I'd be curious to see what the address is that
is attempting to be freed.
My
On 1/23/2024 7:10 AM, Sami Mujawar wrote:
@@ -310,6 +318,7 @@ GenericWatchdogEntry (
{
EFI_STATUS Status;
EFI_HANDLE Handle;
+ UINT32 WatchdogIId;
[SAMI] Minor, the above variable name should be WatchdogIid to comply with the
coding standard.
I was wondering about the naming, since it's the
Improve the wording of the comment explaining the DEBUG_MANAGEABILITY
debug level.
Signed-off-by: Rebecca Cran
---
MdePkg/Include/Library/DebugLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/Library/DebugLib.h
b/MdePkg/Include/Library/DebugLib.h
Update MdePkg.dec to add the manageability debug level to
PcdFixedDebugPrintErrorLevel.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac54338089e8..bec63f5416e2 100644
--- a/MdePkg/MdePkg.dec
+++
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.
Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting.
Rebecca Cran (4):
MdePkg: Improve wording
Update MdePkg.uni with the manageability debug level.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.uni | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
index 5c1fa24065c7..75dbc6ffe3c0 100644
--- a/MdePkg/MdePkg.uni
+++ b/MdePkg/MdePkg.uni
@@ -214,6
Update the debug level comments in ArmVirt.dsc.inc to sync with
MdePkg/Include/Library/DebugLib.h.
Signed-off-by: Rebecca Cran
---
ArmVirtPkg/ArmVirt.dsc.inc | 42 ++--
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.
Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting.
Wouldn't it be better to add the Stack Protector library
(MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf) instead of
disabling it?
--
Rebecca Cran
On 1/4/2024 11:49 AM, Prabin CA via groups.io wrote:
Add the no-stack-protector compiler flag to allow StandaloneMM builds
on both
I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and
Michael Roth have funky Author lines, which I think means .mailmap needs
updated?
commit 7a5823f85be99b9a92751fcf4141f7982fa5cc80
Author: Jeff Brasen via groups.io
Date: Thu Dec 28 12:47:08 2023 -0800
EmbeddedPkg:
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Introduce global mTimerPeriod and remove calculation
ArmPkg: Disable watchdog interaction after
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
---
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
Thanks, I've incorporated the changes into the v2 patch series.
--
Rebecca
On 1/4/2024 3:01 AM, Sami Mujawar wrote:
Hi Rebecca,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 03/01/2024, 20:44, "Rebecca Cran"
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Introduce global mTimerPeriod and remove calculation
ArmPkg: Disable watchdog interaction after
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
---
Thanks, I've incorporated the changes into the v2 patch series.
--
Rebecca
On 1/3/2024 3:56 PM, Ard Biesheuvel wrote:
Hi Rebecca,
On Wed, 3 Jan 2024 at 21:44, Rebecca Cran
wrote:
Fix the calculation of the timer period in GenericWatchdogDxe: we need
to multiply before dividing to keep the
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Rebecca Cran (3):
ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe
ArmPkg: Disable watchdog interaction
Fix the calculation of the timer period in GenericWatchdogDxe: we need
to multiply before dividing to keep the values as integers.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 14
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
---
On 1/5/2024 1:26 AM, Ard Biesheuvel via groups.io wrote:
On Fri, 5 Jan 2024 at 06:15, Rebecca Cran
wrote:
Fixes and improvements to GenericWatchdogDxe.
What is the difference between v2 and v3?
Sorry, I should have said that. I forgot to build v2 and it had a bug in
the exit boot
On 1/18/2024 9:48 AM, Oliver Smith-Denny via groups.io wrote:
Are you including this commit:
https://github.com/tianocore/edk2/commit/00b51e0d78a547dd78119ec44fcc74a01b6f79c8?
Can you share some more details on where this is failing? I.e. what
assert is getting tripped? Presumably without
I've been debugging an assert failure when using HeapGuard on AArch64. A
call to FreePages in SmbiosDxe is failing because the memory is aligned
to 0x1000 instead of 0x1 as defined by
RUNTIME_PAGE_ALLOCATION_GRANULARITY.
I'm enabling HeapGuard by setting the PCDs to the following values:
On 1/18/2024 11:38 AM, Oliver Smith-Denny wrote:
Yeah, if you can get it running there, that would be a good data point.
I assume you mean the Project Mu QemuSbsaPkg? If so that is great, but
you will need to update the RUNTIME_PAGE_ALLOCATION_GRANULARITY back to
0x1. It was set to 0x1000
On 1/18/2024 12:04 PM, Oliver Smith-Denny wrote:
On 1/18/2024 10:45 AM, Rebecca Cran via groups.io wrote:
No, I mean SbsaQemu from edk2-platforms:
https://github.com/tianocore/edk2-platforms/tree/master/Platform/Qemu/SbsaQemu
Sure, if you can repro there that is helpful.
I've realized
On 1/5/2024 4:12 AM, Sami Mujawar wrote:
- // if TimerPeriod is 0, this is a request to stop the watchdog.
+ // If we've exited Boot Services but TimerPeriod isn't zero, this
+ // indicates that the caller is doing something wrong.
+ if (mExitedBootServices && (TimerPeriod != 0)) {
[SAMI]
On 1/5/2024 1:26 AM, Ard Biesheuvel wrote:
@@ -91,7 +88,8 @@ WatchdogExitBootServicesEvent (
)
{
WatchdogDisable ();
- mNumTimerTicks = 0;
+ mTimerPeriod= 0;
+ mExitedBootServices = TRUE;
Where is this declared/defined?
Oh, it's defined in the 3rd patch - which
Fixes and improvements to GenericWatchdogDxe.
PR: https://github.com/tianocore/edk2/pull/5176
Changes between v3 and v4:
- Check Interface Identification Register for architecture revision before
setting the high offset register value.
- Use @par for reference.
- Move setting of EBS flag from
The calculation of the timer period was broken. Introduce a global
mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
is only used in one place, remove the global and make it a local
variable. Do the same with mNumTimerTicks.
Signed-off-by: Rebecca Cran
---
The generic watchdog offset register is 48 bits wide, and can be set by
performing two 32-bit writes.
Add support for writing the high 16 bits of the offset register and
update the signature of the WatchdogWriteOffsetRegister function to take
a UINT64 value.
Signed-off-by: Rebecca Cran
---
Update GenericWatchdogDxe to disable watchdog interaction after exiting
boot services. Also, move the mEfiExitBootServicesEvent event to the top
of the file with the other static variables.
Signed-off-by: Rebecca Cran
---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 17
On 1/18/2024 12:26 PM, Oliver Smith-Denny wrote:
Does this solve your issue? I have to run to a meeting, but I can
write this in actual patch form (and give it a quick test) later.
Unfortunately that didn't work: I still get the assert.
...
SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit
On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote:
Funnily enough, my stance is quite the opposite. I happen to disagree
with some patterns that uncrustify enforces, but I'm thankful that at
any given state of CI (= using any given version of uncrustify), we
can't have any more debates
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
The issue with doing this is there's a push to remove all C/C++ code
from BaseTools
56 matches
Mail list logo
