Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-06-02 Thread Yao, Jiewen
Since there is no other module, I think we can use this specific package name to tell people what it is. It is also good for feature isolation. Thank you Yao Jiewen From: Dong, Eric Sent: Monday, June 3, 2019 8:53 AM To: Yao, Jiewen ; devel@edk2.groups.io; Gao, Liming ; Kubacki, Michael

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-05-31 Thread Yao, Jiewen
Would you please clarify the position of SecuritySamplePkg ? What is the difference between SecurityPkg and SecuritySamplePkg ? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 3:46 PM To: devel@edk2.groups.io; Gao, Liming ; Kubacki, Michael A ; Oram, Isaac W ; Kinney, Michael

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-05-31 Thread Yao, Jiewen
Would you please clarify what "sample" here really means? Not for production? Or something else? Thank you Yao Jiewen From: Dong, Eric Sent: Friday, May 31, 2019 4:02 PM To: Yao, Jiewen ; devel@edk2.groups.io; Gao, Liming ; Kubacki, Michael A ; Oram, Isaac W ; Kinney, Michael D S

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-11 Thread Yao, Jiewen
u can those description in StoredHashFvPpi.h file 8) Same code above, would you please clarify if it is legal or illegal that StoredHashFvPpi->FvNumber == 0 ? If it is illegal, I prefer use ASSERT() Thank you Yao Jiewen > -Original Message- > From: Wang, Jian J > Sent: Tuesd

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-10 Thread Yao, Jiewen
Thanks. Got it. I would use term - "MemoryManagement". :-) Thank you Yao Jiewen > -Original Message- > From: Wu, Hao A > Sent: Monday, June 10, 2019 2:20 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Zeng, Star > ; ler...@redhat.com; Ni, Ray ; > Gao, Liming

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-10 Thread Yao, Jiewen
Good list. What does "memory" mean ? MemoryTest ? How about put "LockBox" into "S3"? How about list "EBC" as standalone component? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, June 10, 2019 2:02 PM > To:

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-24 Thread Yao, Jiewen
thanks How about to put driversample to ui? How about to put iommu to device? thank you! Yao, Jiewen > 在 2019年6月25日,上午4:30,Laszlo Ersek 写道: > >> On 06/24/19 03:16, Wu, Hao A wrote: >> Hello all, >> >> With Leif's comment on the better usage of the wildcard

Re: [edk2-devel] [PATCH v4 0/3] Common OBB verification feature

2019-06-25 Thread Yao, Jiewen
Thanks Jian. Comment below: 1) My previous comment 8 is NOT addressed. Please add assert for "StoredHashFvPpi->FvNumber". if (!EFI_ERROR(Status) && StoredHashFvPpi != NULL && StoredHashFvPpi->FvNumber > 0) { With that fixed, reviewed-by: jiewen..

Re: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen

2019-06-25 Thread Yao, Jiewen
, maybe we have other C-tool update. Should we add them to CC list in any tool patch? Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Tuesday, June 25, 2019 10:09 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Zhang, > Shenglei ; ard.biesheu...@linaro.or

Re: [edk2-devel] [PATCH v3 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-06-25 Thread Yao, Jiewen
Please address the feedback from Leif. With email address fixed, reviewed-by: jiewen@intel.com. > -Original Message- > From: Desai, Imran > Sent: Tuesday, June 25, 2019 2:14 AM > To: Yao, Jiewen ; Leif Lindholm > ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Wang, J

Re: [edk2-devel] TPM ACPI HID creation

2019-06-25 Thread Yao, Jiewen
Thanks Jason. I think we should NOT measure TPM2 table *after* ACPI table patch. The measurement should happen *before* ACPI table patch. Hi Chao Do you agree on that? Thank you Yao Jiewen From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of jason.spottsw...@hpe.com Sent

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-06-13 Thread Yao, Jiewen
Yes, ok for me. Good idea to add the overview of the package content. Thank you Yao Jiewen From: Oram, Isaac W Sent: Friday, June 14, 2019 8:55 AM To: Gao, Liming ; Yao, Jiewen ; Dong, Eric ; devel@edk2.groups.io; Kinney, Michael D Subject: RE: [RFC][edk2-platform][Add new packages

Re: [edk2-devel] [PATCH] EmulatorPkg/Win: support running multiple WinHost.exe

2019-06-14 Thread Yao, Jiewen
Hi It is good to support 2nd instance. But the risk is that 2 instances may access to the same variable region. It might cause unpredictable behavior in the variable driver later. Do we have investigate that impact? Thank you Yao Jiewen > -Original Message- > From: deve

Re: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen

2019-06-20 Thread Yao, Jiewen
TFORM repo? Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Friday, June 21, 2019 10:31 AM > To: Yao, Jiewen ; devel@edk2.groups.io; Zhang, > Shenglei > Cc: Feng, Bob C > Subject: RE: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE >

Re: [edk2-devel] [edk2-platform patch 0/6] Add tools FMMT FCE and FitGen

2019-06-20 Thread Yao, Jiewen
HI I saw some conflict: = BaseTools/FCE: Add a tool FCE Add FMMT and FCE into Platform/Intel/Tools. = I agree that FitGet goes to Intel silicon. Should we put both FCE/FMMT to BaseTools? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.gro

Re: [edk2-devel] [PATCH v3 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-06-20 Thread Yao, Jiewen
Thanks Leif to point out. Other comment: Would you please describe the delta between v1, v2 and v3? I have reviewed the v1. Please share with us on what is updated in v2 and v3. Thank you Yao Jiewen > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

2019-05-09 Thread Yao, Jiewen
Cool. Thanks! Then I would like to see a patch to remove INC check. :) > -Original Message- > From: Gao, Liming > Sent: Thursday, May 9, 2019 7:05 AM > To: Yao, Jiewen ; Shi, Steven > ; devel@edk2.groups.io > Cc: Feng, Bob C ; Rodriguez, Christian > ; Johnson, Mic

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

2019-05-09 Thread Yao, Jiewen
source code. As such, when we need skip more type of file, we just update the configuration, instead of tool source code. Just like we have tools_def and build_rule today, when we need update those configuration, we don't need update tool source code. Thank you Yao Jiewen > -Original Mes

Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

2019-05-09 Thread Yao, Jiewen
ed. May I know what is the relationship between this patch and Bugzilla? Why we need change the default value? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, May 9, 2019 2:

Re: [edk2-devel] [PATCH 4/6] MdePkg: Add gEfiCpu2ProtocolGuid and header file

2019-05-23 Thread Yao, Jiewen
Sorry, it is CPU2 not CPU_IO2. Right, I did not find CPU2 protocol in PI spec today. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, May 23, 2019 10:35 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Gao, > Liming > Cc: Sean Brogan ; Kinney, Michael D

Re: [edk2-devel] [PATCH 4/6] MdePkg: Add gEfiCpu2ProtocolGuid and header file

2019-05-23 Thread Yao, Jiewen
EFI_CPU_IO2_PROCOL is defined in PI spec Volume 5 Chapter 15 CPU I/O Protocol. Thank you Yao jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Thursday, May 23, 2019 10:28 PM > To: Gao, Liming ; devel

Re: [edk2-devel] [edk2] [PATCH] IntelSiliconPkg VTdDxe: a question about the source code

2019-05-20 Thread Yao, Jiewen
Thanks. We are also reviewing the VTd disabling flow and may update recently. If you want to file Bugzilla, please go ahead. Thank you Yao Jiewen From: Zeng, Star Sent: Sunday, May 19, 2019 8:33 PM To: Jerry Zhou(BJ-RD) ; edk2-de...@lists.01.org; devel@edk2.groups.io Cc: Yao, Jiewen ; Ni, Ray

Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

2019-05-20 Thread Yao, Jiewen
hi thanks for this contribution Besides the comment from Laszlo, would you please also share your unit test result? What test you have done for this patch? thank you! Yao, Jiewen > 在 2019年5月17日,下午2:43,Imran Desai 写道: > > https://github.com/idesai/edk2/tree/enable_sm3_meas

Re: [edk2-devel] [patch 08/11] SignedCapsulePkg: Remove PcdFrameworkCompatibilitySupport usage

2019-05-07 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Dandan Bi > > Sent: Monday, April 29, 2019 10:16 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Chao &g

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

2019-05-08 Thread Yao, Jiewen
Hi Can we have better way to describe the binary cache? I have 2 concern: 1) we have other type of binary besides MCB. How can we indicate that without update base tool source code ? 2) .inc might be text file, instead of binary. How can we support that? Thank you Yao Jiewen > -Origi

Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

2019-05-21 Thread Yao, Jiewen
Cool Thanks thank you! Yao, Jiewen > 在 2019年5月21日,上午9:58,Desai, Imran 写道: > > Hello Jiewen, > > I tested SM3 PCR extensions on the OvmfPkg using swTPM (and TPM2 simulator). > The validation was done comparing PCR extensions from the TCG2 EventLog and > SM3 PCR Bank da

Re: [edk2-devel] [edk2-InfSpecification PATCH] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-04 Thread Yao, Jiewen
Answer below: > -Original Message- > From: Gao, Liming > Sent: Friday, July 5, 2019 12:59 PM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Yao, Jiewen > Subject: RE: [edk2-InfSpecification PATCH] Document: Add new > MODULE_TYPE HOST_APPLICATION > > Xiaoyu:

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-06-28 Thread Yao, Jiewen
Hi Would you please share the info on what test has been done for this 5 level paging? Such as stack paging enable/disable, SMM profile, etc. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent:

Re: [edk2-devel] [PATCH v6 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3 digest algorithm

2019-07-13 Thread Yao, Jiewen
that, please drop me a mail and I can help you on that. Once sm3 is added in the next uefi spec, we may add sm3 to mdepkg at that time. thank you! Yao, Jiewen > 在 2019年7月13日,上午8:47,Imran Desai 写道: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 > GITHUB: https://github.com

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

2019-07-02 Thread Yao, Jiewen
HI Eric Would you please share what unit test you have done for this new feature? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dong, Eric > Sent: Wednesday, July 3, 2019 10:43 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek >

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

2019-07-02 Thread Yao, Jiewen
It looks great. Thanks! > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 3, 2019 10:58 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol > > Hi Jiewen, >

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Yao, Jiewen
Right. So far we just duplicate what USER_DEFINED does. With more and more example, we will see if and how we enhance that. But it is good enough now. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Monday, July 8, 2019 9:15 AM > To: Yao, Jiewen ;

Re: [edk2-devel] TPM ACPI HID creation

2019-06-25 Thread Yao, Jiewen
Hi Jason Would you mind to help us to file a Bugzilla - https://bugzilla.tianocore.org/ for tracking purpose? Thank you Yao Jiewen From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Yao, Jiewen Sent: Wednesday, June 26, 2019 12:08 AM To: devel@edk2.groups.io; jason.spottsw

Re: [edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique structure signatures

2019-06-28 Thread Yao, Jiewen
, Jian J ; Wu, Hao A > ; Ni, Ray ; Zeng, Star > ; Yao, Jiewen > Subject: [edk2-devel] [Patch] MdeModulePkg/PiSmmCore: Use unique > structure signatures > > https://bugzilla.tianocore.org/show_bug.cgi?id=1948 > > Update the data structure signatures in the PiSmmCore > to b

Re: [edk2-devel] [PATCH] SecurityPkg/DxeDeferImageLoadLib: Remove DxeDeferImageLoadLib

2019-06-30 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, June 20, 2019 9:31 AM > To: devel@edk2.groups.io > Cc: Zhang, Chao B ; Yao, Jiewen > ; Wang, Jian J > Subject: [PATCH] SecurityPkg/DxeDeferImageLoadLib: Remove &

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-13 Thread Yao, Jiewen
Evelyn I still saw below EFIAPI missing issue: +UINTN +GetGlobalVtdPmrAlignment ( +); Thank you Yao jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Evelyn Wang > Sent: Monday, August 12, 2019 12:48 PM > To: devel@edk2

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy

2019-08-02 Thread Yao, Jiewen
Thanks and agree. Comment inlined. thank you! Yao, Jiewen > 在 2019年8月3日,上午6:06,Laszlo Ersek 写道: > >> On 08/02/19 04:46, Yao, Jiewen wrote: >> Thanks Laszlo. Comment below: >> >>> -Original Message- >>> From: devel@edk2.groups.io [mailto:dev

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-14 Thread Yao, Jiewen
VERIFY_SIZE_OF – the other patch and the other Bugzilla 3) Step 3: Scan the rest, if there is need. – Another patch and another Bugzilla Thank you Yao Jiewen From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptosv via Groups.Io Sent: Thursday, August 15, 2019 12

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-18 Thread Yao, Jiewen
in real world, we deprecate AB-seg usage because they are vulnerable to smm cache poison attack. I assume cache poison is out of scope in the virtual world, or there is a way to prevent ABseg cache poison. thank you! Yao, Jiewen > 在 2019年8月19日,上午3:50,Paolo Bonzini 写道: > >> On

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-15 Thread Yao, Jiewen
Hi Paolo I am not sure what do you mean - "You do not need a reset vector ...". If so, where is the first instruction of the new CPU in the virtualization environment? Please help me understand that at first. Then we can continue the discussion. Thank you Yao Jiewen > -Ori

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add STATIC_ASSERT macro

2019-08-15 Thread Yao, Jiewen
Acked-by: Jiewen Yao Reviewed-by: Jiewen Yao From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptosv via Groups.Io Sent: Thursday, August 15, 2019 10:22 AM To: Gao, Liming ; devel@edk2.groups.io; Yao, Jiewen ; Kinney, Michael D Cc: Laszlo Ersek ; leif.lindh

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-15 Thread Yao, Jiewen
Comment below: > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, August 16, 2019 12:21 AM > To: Laszlo Ersek ; devel@edk2.groups.io; Yao, Jiewen > > Cc: edk2-rfc-groups-io ; qemu devel list > ; Igor Mammedov ; > Chen,

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-16 Thread Yao, Jiewen
below > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, August 16, 2019 3:20 PM > To: Yao, Jiewen ; Laszlo Ersek > ; devel@edk2.groups.io > Cc: edk2-rfc-groups-io ; qemu devel list > ; Igor Mammedov ; > Chen, Yingwen ;

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-14 Thread Yao, Jiewen
My comments below. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, August 14, 2019 12:09 AM > To: edk2-devel-groups-io > Cc: edk2-rfc-groups-io ; qemu devel list > ; Igor Mammedov ; > Paolo Bonzini ; Yao, Jiewen > ; Chen, Y

Re: [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-16 Thread Yao, Jiewen
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, August 17, 2019 6:20 AM > To: Laszlo Ersek > Cc: Yao, Jiewen ; Paolo Bonzini > ; devel@edk2.groups.io; edk2-rfc-groups-io > ; qemu devel list ; Igor > Mammedov ; Ch

Re: [edk2-devel] [PATCH v4] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-21 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Evelyn Wang > Sent: Wednesday, August 21, 2019 1:50 AM > To: devel@edk2.groups.io > Cc: Huang, Jenny ; Shih, More > ; Ni, Ray ; Chaganty, Rangasai V > > Subject:

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-23 Thread Yao, Jiewen
I give my thought. Paolo may add more. > -Original Message- > From: Kinney, Michael D > Sent: Friday, August 23, 2019 11:25 PM > To: Yao, Jiewen ; Paolo Bonzini > ; Laszlo Ersek ; > r...@edk2.groups.io; Kinney, Michael D > Cc: Alex Williamson ; devel@edk2.groups.

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-22 Thread Yao, Jiewen
potential attack surface in virtual environment, if hot-added CPU need run code with stack or heap before SMI rebase. Other threats, such as SMRAM or DMA, are same. Thank you Yao Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Friday, August 23, 2019 9:03 AM > To: P

Re: [edk2-devel] [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

2019-09-08 Thread Yao, Jiewen
buffer. Thank you Yao Jiewen From: devel@edk2.groups.io On Behalf Of Johnson, Michael Sent: Saturday, September 7, 2019 5:52 AM To: Kubacki, Michael A ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction Yes - both things I bring up are just

Re: [edk2-devel] [edk2-rfc] [edk2-devel] UEFI Variable SMI Reduction

2019-09-10 Thread Yao, Jiewen
Nate I believe this SMI reduction work only handle GetVariable. VarCheckLib only handles SetVariable. VarCheckLib does not handle GetVaraible. Thank you Yao Jiewen From: Desimone, Nathaniel L Sent: Wednesday, September 11, 2019 10:43 AM To: devel@edk2.groups.io; Yao, Jiewen ; Johnson, Michael

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-16 Thread Yao, Jiewen
That is correct. Current trunk only supports ARM system. I have branch to support x86 - https://github.com/jyao1/edk2/tree/StandaloneSmmX86Poc But that is not merged into trunk yet. Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel > Sent: Monday, September 1

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-13 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Ard Biesheuvel > Sent: Saturday, September 14, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: ler...@redhat.com; achin.gu...@arm.com; Yao, Jiewen > ; Ard Biesheuvel > Subject: [PATCH] StandaloneMmPkg: make pa

[edk2-devel] [tianocore-docs EDK_II_Secure_Coding_Guide PATCH] Add Appendix: Threat Mode for EDK II.

2019-08-05 Thread Yao, Jiewen
This patch adds "Threat model for EDK II" as the appendix section of "EDK II secure coding guide" document. The threat model discussed here is a general guide and serves as the baseline of the EDK II firmware. For each specific feature in EDK II firmware, there might be additional

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/TpmCommLib: Remove TpmCommLib

2019-08-05 Thread Yao, Jiewen
Good. Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Shenglei > Sent: Monday, August 5, 2019 1:55 PM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Yao, Jiewen > ; Wang, Jian J ; Zhang, > Chao B > Subject: [PATCH 1/1] SecurityPkg/TpmCo

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Variable/RuntimeDxe: Not copy SMM pointers in comm buffer

2019-08-06 Thread Yao, Jiewen
the door, but leave windows open. It is necessary but not sufficient. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Wednesday, August 7, 2019 11:22 AM > To: devel@edk2.groups.io;

Re: [edk2-devel] [tianocore-docs EDK_II_Secure_Coding_Guide PATCH] Add Appendix: Threat Mode for EDK II.

2019-08-07 Thread Yao, Jiewen
ick "EDK II Security White Papers", then goto https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Security-White-Papers Or you can search "security" keyword in the wiki search box. Then "EDK II Security White Papers" will show up. Thank you Yao Jiewen &g

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy

2019-07-31 Thread Yao, Jiewen
of supported combination to reduce the effort of validation and maintenance. thank you! Yao, Jiewen > 在 2019年8月1日,上午7:13,Laszlo Ersek 写道: > > Hi Ray, Jiewen, > > I've got several comments / questions: > >> On 07/31/19 18:38, Ni, Ray wrote: >> This patch skip

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy

2019-07-31 Thread Yao, Jiewen
SmmAccessOut = SMM access memory outside SMRAM. So, do we want to treat SMM access ACPI NVS, RSVD, Runtime, MMIO, to be SmmAccessOut? Thank you Yao Jiewen > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 10:24 AM > To: Yao, Jiewen ; devel@edk2.grou

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy

2019-07-31 Thread Yao, Jiewen
memory. It could be static or dynamic paging. PcdCpuSmmAccessOut seems also confusing. What "Out" means ??? What Out=False means? Only allow inside SMRAM access? Anyway, I am open for the naming proposal. Thank you Yao Jiewen > -Original Message- > From

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpu: PcdCpuSmmAccessOut controls SMM access-out policy

2019-08-01 Thread Yao, Jiewen
Thanks Laszlo. Comment below: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, August 2, 2019 10:05 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric ; Wang, > Jian J

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-29 Thread Yao, Jiewen
Hi I think this policy protocol should be EDKII specific. Currently it is no in PI spec. Should it be in MdeModulePkg ? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Monday, July 29,

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-29 Thread Yao, Jiewen
they are updated. Thank you Yao Jiewen > -Original Message- > From: Javeed, Ashraf > Sent: Monday, July 29, 2019 4:12 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Gao, > Liming > Cc: Kinney, Michael D ; Ni, Ray > > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHA

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-29 Thread Yao, Jiewen
, then decide if there is need to add to PI spec. Thank you Yao Jiewen > -Original Message- > From: Javeed, Ashraf > Sent: Monday, July 29, 2019 7:18 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Gao, > Liming > Cc: Kinney, Michael D ; Ni, Ray > > Subject

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-29 Thread Yao, Jiewen
Forgot to mention: since we want to handle device policy, another option is to create PCI_DEVICE_POLICY_PROTOCOL. No need to update previous one. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Yao, Jiew

Re: [edk2-devel] [PATCH] IntelSiliconPkg-Vtd: A new PMR interface

2019-08-09 Thread Yao, Jiewen
always hardcode BASE_4GB, the ProtectedHighBase in hob is useless. 8) Please use LShiftU64 for 64bit operation. HighTop = (UINT64) SysMemHob->ProtectedHighLimit << 20; Using direct shift might cause link failure in non-optimization mode. Thank you Yao Jiewen > -Original Message

Re: [edk2-devel] [PATCH] Extened PMR feature: allow silicon code to adjust PLMR/PHMR region base on the project needs

2019-08-08 Thread Yao, Jiewen
ame:" in the title. Thank you Yao Jiewen > -Original Message- > From: Wang, Iwen Evelyn > Sent: Thursday, August 8, 2019 8:29 AM > To: devel@edk2.groups.io > Cc: Huang, Jenny ; Yao, Jiewen > > Subject: [PATCH] Extened PMR feature: allow silicon code to adjust

Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

2019-07-18 Thread Yao, Jiewen
Patch 1~3, reviewed-by: jiewen@intel.com Patch 4, acked-by: jiewen@intel.com > -Original Message- > From: Desai, Imran > Sent: Friday, July 19, 2019 6:53 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Yao, >

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

2019-09-26 Thread Yao, Jiewen
OS, we also need reserve the black hole here. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, September 24, 2019 7:35 PM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Boris Ostrovsky > ; Brijesh

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

2019-09-26 Thread Yao, Jiewen
Thank you Yao Jiewen > -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 26, 2019 10:52 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Boris Ostrovsky > ; Brijesh Singh ; Igor > Mammedov ; Joao M Martins > ; Justen, Jordan L ;

Re: [edk2-devel] [Patch 00/12] New Cross OS tool chain CLANG9

2019-09-27 Thread Yao, Jiewen
Thank you Liming. That is cool feature. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Friday, September 27, 2019 3:46 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Shi, Steven ; > Justen, Jordan L ; Laszl

Re: [edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-09-27 Thread Yao, Jiewen
Hi +int GLOBAL_USED _fltused = 1; May I know what is the use of GLOBAL_USED? Only for compiler stub symbol? If so, why we add __GNUC__ here? Any other usage? +#if defined(__GNUC__) || defined(__clang__) + #define GLOBAL_USED __attribute__((used)) +#else + #define GLOBAL_USED +#endif >

Re: [edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table

2019-09-29 Thread Yao, Jiewen
Got it. Thanks for the reminder. I will follow. Thank you Yao Jiewen > -Original Message- > From: Wang, Jian J > Sent: Monday, September 30, 2019 1:23 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Zhang, Chao B > Subject: RE: [edk2-devel] [PATCH 0/3] Add Laml

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-30 Thread Yao, Jiewen
below > -Original Message- > From: devel@edk2.groups.io On Behalf Of Igor > Mammedov > Sent: Monday, September 30, 2019 8:37 PM > To: Laszlo Ersek > Cc: devel@edk2.groups.io; qemu-de...@nongnu.org; Chen, Yingwen > ; phillip.go...@oracle.com; > alex.william...

[edk2-devel] [PATCH 1/3] MdePkg/Include: correct Lasa in Tpm2Acpi.

2019-09-29 Thread Yao, Jiewen
Correct Lasa according to TCG ACPI spec. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Jiewen Yao --- MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Tpm2Acpi.h

[edk2-devel] [PATCH 3/3] SecurityPkg/Tcg2: Add Support Laml, Lasa for TPM2 ACPI.

2019-09-29 Thread Yao, Jiewen
Tcg2Dxe produces PcdTpm2AcpiTableLaml/Lasa for event log address. Tcg2Smm consumes PcdTpm2AcpiTableLaml/Lasa to fill TPM2 ACPI table. Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 32 +++--

[edk2-devel] [PATCH 2/3] SecurityPkg/dsc: Add PCD for Laml, Lasa for TPM2.

2019-09-29 Thread Yao, Jiewen
Those PCDs will be used for TPM2 ACPI table. Tcg2Dxe need produce those for event log address. Tcg2Smm need consume those to fill TPM2 ACPI table. Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec | 8 SecurityPkg/SecurityPkg.uni | 9 +

[edk2-devel] [PATCH 0/3] Add Laml/Lasa to TPM2 acpi table

2019-09-29 Thread Yao, Jiewen
TCG2_PROTOCOL. Test: Use default TPM2 version 3. No ALMA/ALSA shown in TPM2 table. Use TPM2 version 4. The DXE driver reports ALMA/ALSA PCD and the SMM driver installs ALMA/ALSA in TPM2 table. Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Jiewen Yao Jiewen Yao (3): MdePkg/Include: correct Lasa

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-14 Thread Yao, Jiewen
Thanks. Comment below: > -Original Message- > From: Wang, Jian J > Sent: Friday, June 14, 2019 8:30 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: RE: [PATCH v2 0/3] Common OBB verificatio

Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-13 Thread Yao, Jiewen
Thank you Christopher. Your code looks good to me. I also recommend MdeModulePkg/SCSI owner take a look and give r-b. Ray or Hao Can you help on that? Thank you Yao Jiewen > -Original Message- > From: Zurcher, Christopher J > Sent: Friday, June 14, 2019 6:26 AM > To:

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Yao, Jiewen
Currently, it is xxx.efi. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Monday, July 8, 2019 8:43 AM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Feng, Bob C ; Yao, Jiewen > > Subject: RE: [PATCH v1 1/1] BaseTools: Add HOST_APPL

Re: [edk2-devel] [PATCH] SecurityPkg: Fix TPM2 ACPI measurement.

2019-11-05 Thread Yao, Jiewen
Reviewed by: Jiewen Yao > -Original Message- > From: Derek Lin > Sent: Wednesday, November 6, 2019 9:01 AM > To: derek.l...@hpe.com; devel@edk2.groups.io > Cc: jason.spottsw...@hpe.com; Yao, Jiewen ; Wang, > Jian J ; Zhang, Chao B > Subject: [PATCH] Secur

Re: [edk2-devel] [PATCH V3 4/6] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Add PciSecurity.

2019-11-11 Thread Yao, Jiewen
Agree. I will remove them. > -Original Message- > From: Ni, Ray > Sent: Monday, November 11, 2019 4:20 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Lou, Yun > > Subject: RE: [PATCH V3 4/6] IntelSiliconPkg/IntelPciDeviceSecurityD

Re: [edk2-devel] [PATCH V3 2/6] IntelSiliconPkg/Include: Add Platform Device Security Policy protocol

2019-11-08 Thread Yao, Jiewen
Hi Ray I checked the UEFI spec and other protocol definition again. I believe Revision is a better name for minor update. I will update the structure field from Version to Revision. Thank you Yao Jiewen > -Original Message- > From: Ni, Ray > Sent: Friday, November 8, 201

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/Pci: Add DeviceSecurity support.

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V2 5/6] IntelSiliconPkg/SamplePlatformDevicePolicyDxe: Add sample policy.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition.

2019-11-05 Thread Yao, Jiewen
Hi Liming/Michael Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH V2 2/6] IntelSiliconPkg/Include: Add Platform Device Security Policy protocol

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 3/4] MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid.

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V2 6/6] IntelSiliconPkg/dsc: Add Device Security component.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 1/6] IntelSiliconPkg/Include: Add Intel PciSecurity definition.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 4/6] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Add PciSecurity.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io &

Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h

2019-11-06 Thread Yao, Jiewen
access the device once the device access protocol is installed. Thank you Yao Jiewen > -Original Message- > From: Ni, Ray > Sent: Wednesday, November 6, 2019 3:56 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Wang, Jian J ; Wu, Hao A ; > Lou, Yun > Subject: RE

Re: [edk2-devel] [PATCH V3 0/4] Add SPDM device security

2019-11-07 Thread Yao, Jiewen
Hi I forget to mention that this patch is also pushed to git. The EDKII repo update is at https://github.com/jyao1/edk2/tree/DeviceSecurityMasterV3 The EDKII platform repo update is at https://github.com/jyao1/edk2-platforms/tree/DeviceSecurityMasterV3 Thank you Yao Jiewen > -Origi

Re: [edk2-devel] [PATCH V3 0/6] Add Device Security driver

2019-11-07 Thread Yao, Jiewen
devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, November 7, 2019 9:38 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V3 0/6] Add Device Security driver > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 > > === V3

[edk2-devel] [PATCH V3 1/6] IntelSiliconPkg/Include: Add Intel PciSecurity definition.

2019-11-07 Thread Yao, Jiewen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Yun Lou Signed-off-by: Jiewen Yao --- .../IndustryStandard/IntelPciSecurity.h | 92 +++ 1 file changed, 92 insertions(+) create mode 100644

[edk2-devel] [PATCH V3 6/6] IntelSiliconPkg/dsc: Add Device Security component.

2019-11-07 Thread Yao, Jiewen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Yun Lou Signed-off-by: Jiewen Yao --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc

[edk2-devel] [PATCH V3 0/6] Add Device Security driver

2019-11-07 Thread Yao, Jiewen
The device measurement can be shown in TCG event log. signed-off-by: Jiewen Yao Jiewen Yao (6): IntelSiliconPkg/Include: Add Intel PciSecurity definition. IntelSiliconPkg/Include: Add Platform Device Security Policy protocol IntelSiliconPkg/dec: Add ProtocolGuid definition. IntelSiliconPkg/Inte

[edk2-devel] [PATCH V3 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-07 Thread Yao, Jiewen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Yun Lou Signed-off-by: Jiewen Yao --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 4 1 file changed, 4 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec

  1   2   3   4   5   6   7   8   9   10   >