; Sent: Friday, May 17, 2019 9:04 AM
> To: Zeng, Star ; devel@edk2.groups.io;
> ler...@redhat.com
> Cc: Dong, Eric ; Kumar, Chandana C
>
> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib:
> Remove CPU generation check
>
> Star,
> I think the disc
Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, June 3, 2019 8:03 PM
> To: Zeng, Star
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Chandana C ; Li, Kevin Y
> ; edk2-devel-groups-io
> Subject: Re: [PATCH 0/2] Fix GP fault issu
Shouldn't the SplitFspBinUserManual.md also be updated?
Thanks,
Star
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, May 29, 2019 10:33 PM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH] IntelF
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Thursday, May 30, 2019 12:58 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary.
REF: https
devel-groups-io ; Anthony PERARD
>
> Cc: Wang, Jian J ; Ni, Ray ; Zeng,
> Star ; Wu, Hao A ; Julien Grall
> ; Leif Lindholm ; Laszlo
> Ersek
> Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only
> once
>
> On Wed, 29 May 2019 at 13:37, Anthony PERARD
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1808
In current code, the values of TopaEntryPtr->Uint64 for TopaTable
and the values of OutputBaseReg.Uint64 and OutputMaskPtrsReg.Uint64
to register table write for RTIT_OUTPUT_BASE and RTIT_OUTPUT_MASK_PTRS
are not been initialized in whole.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1809
Current code disables TraceEn at the end of ProcTraceInitialize(),
then there will be much memory allocated even when ProcTrace feature
is disabled.
This patch updates code to disable TraceEn and return at the beginning
of
This patch series mainly fixes GP fault issue about ProcTrace for
https://bugzilla.tianocore.org/show_bug.cgi?id=1808.
It aslo enhances code about ProcTrace for
https://bugzilla.tianocore.org/show_bug.cgi?id=1809.
Please check the individual patches for detail.
Cc: Laszlo Ersek
Cc: Eric Dong
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1808
In current code, the values of TopaEntryPtr->Uint64 for TopaTable
and the values of OutputBaseReg.Uint64 and OutputMaskPtrsReg.Uint64
to register table write for RTIT_OUTPUT_BASE and RTIT_OUTPUT_MASK_PTRS
are not been initialized in whole.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1809
Current code disables TraceEn at the end of ProcTraceInitialize(),
then there will be much memory allocated even when ProcTrace feature
is disabled.
This patch updates code to disable TraceEn and return at the beginning
of
This patch series mainly fixes GP fault issue about ProcTrace for
https://bugzilla.tianocore.org/show_bug.cgi?id=1808.
It aslo enhances code about ProcTrace for
https://bugzilla.tianocore.org/show_bug.cgi?id=1809.
Please check the individual patches for detail.
Cc: Laszlo Ersek
Cc: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 5, 2019 4:03 PM
> To: Ni, Ray ; Gao, Liming ;
> ard.biesheu...@linaro.org; Leif Lindholm ; Kinney,
> Michael D ; Liu, Zhiguang
> ; Justen, Jordan L ;
> Andrew
Just curious about where the IntelSiliconPkg will be put in edk2-platforms repo?
Thanks,
Star
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chaganty,
Rangasai V
Sent: Wednesday, May 22, 2019 3:13 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Ni, Ray
Subject:
And the 'Ppi' postfix seems not needed in the file name.
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zeng, Star
> Sent: Sunday, June 16, 2019 9:11 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Des
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, June 17, 2019 10:42 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883
Add
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1642
This patch fixes typo in CPU_FEATURE_THREE_STRICK_COUNTER.
CPU_FEATURE_THREE_STRICK_COUNTER
->
CPU_FEATURE_THREE_STRIKE_COUNTER
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Chandana Kumar
Cc: Kevin Li
Signed-off-by: Star Zeng
Removed-by: Star Zeng to the series.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Friday, June 21, 2019 11:00 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1642
This patch fixed typo in CPU_FEATURE_THREE_STRICK_COUNTER.
CPU_FEATURE_THREE_STRICK_COUNTER
->
CPU_FEATURE_THREE_STRIKE_COUNTER
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Chandana Kumar
Cc: Kevin Li
Signed-off-by: Star Zeng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829
There will be ASSERT if LMCE is supported as below.
DXE_ASSERT!: [CpuFeaturesDxe]
XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342):
ConfigData != ((void *) 0)
The code should get Config Data and
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1829
There will be ASSERT if LMCE is supported as below.
DXE_ASSERT!: [CpuFeaturesDxe]
XXX\UefiCpuPkg\Library\CpuCommonFeaturesLib\MachineCheck.c (342):
ConfigData != ((void *) 0)
The code should get Config Data and
Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, May 22, 2019 6:32 PM
> To: devel@edk2.groups.io; Zeng, Star
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Chandana C ; Li, Kevin Y
>
> Subject: Re: [edk2-deve
about this.
You may submit Bugzilla at https://bugzilla.tianocore.org if you wait.
Thanks,
Star
From: Jerry Zhou(BJ-RD) [mailto:jerryz...@zhaoxin.com]
Sent: Monday, May 13, 2019 7:28 PM
To: Zeng, Star ; edk2-de...@lists.01.org;
devel@edk2.groups.io
Cc: Yao, Jiewen ; Ni, Ray
Subject: 答复: [edk2
: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process.
>
> From: "Chasel, Chiu"
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1716
>
> In API mode F
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, April 22, 2019 6:12 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
REF: https://bugzilla.tianocore.org/show_bug.cgi
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1810
This patch covers two problems.
1. Current code gets CPUID_THERMAL_POWER_MANAGEMENT in
ClockModulationInitialize() and uses its ECMD bit for all processors.
But ClockModulationInitialize() is only executed by BSP, that means
the bit is just
Thanks for the understanding to all of you.
Star
> -Original Message-
> From: Ni, Ray
> Sent: Friday, May 17, 2019 9:11 PM
> To: Zeng, Star ; devel@edk2.groups.io;
> ler...@redhat.com
> Cc: Dong, Eric ; Kumar, Chandana C
> ; Li, Kevin Y
> Subject: RE: [edk2-d
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679
The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough,
the checking to CPU generation could be removed, then the code
could be reused by more platforms.
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Chandana Kumar
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, May 16, 2019 9:06 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Chandana C
> Subject:
devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu,
Chasel
Sent: Monday, June 24, 2019 10:35 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP Python scripts to support 3.x.
https://bugzilla.tianocore.org/
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961
Enhance Ppin code to enable and unlock for TRUE State,
and disable and lock for FALSE State.
Note: enable and lock could not be set both.
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Chandana Kumar
Cc: Kevin Li
Signed-off-by: Star Zeng
4 comments are added inline.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dong, Eric
> Sent: Friday, July 12, 2019 9:53 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
Some minor comments inline.
> -Original Message-
> From: Dong, Eric
> Sent: Friday, July 12, 2019 9:53 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoi
Reviewed-by: Star Zeng
> -Original Message-
> From: Antoine Cœur [mailto:co...@gmx.fr]
> Sent: Friday, July 5, 2019 10:17 PM
> To: devel@edk2.groups.io; Desimone, Nathaniel L
> ; Zeng, Star ; Chiu,
> Chasel
> Cc: Antoine Cœur
> Subject: [PATCH] IntelFsp2Pkg: Fi
; From: Dong, Eric
> Sent: Monday, July 15, 2019 3:01 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Kumar,
> Chandana C ; Zeng, Star
>
> Subject: [Patch v2 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: avoid use
> dynamic PCD.
>
> REF: https://bugzilla.t
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1922
The Type4 Voltage field may be various.
So this patch adds it into the blacklist.
Signed-off-by: Star Zeng
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Donald Kuo
Cc: Chasel Chiu
---
Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Monday, July 1, 2019 2:20 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSP Python scripts to support 3.x.
https
Good idea. Reviewed-by: Star Zeng .
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, June 29, 2019 4:19 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
>
Some comments below.
> -Original Message-
> From: Kuo, Donald
> Sent: Monday, August 12, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
>
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15)
>
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, August 15, 2019 10:51 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Zeng,
> Star
> Subject: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then
> W
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 16, 2019 9:27 AM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test
> Then Write" Macro
d:
> Thanks for your update. If no other comment, I will help push this patch
> tomorrow.
>
> Thanks
> Liming
> > -Original Message-
> > From: Kuo, Donald
> > Sent: Tuesday, August 20, 2019 3:22 PM
> > To: Gao, Liming ; devel@edk2.groups.io;
> >
Include new library and driver to IntelSiliconPkg.dsc for building coverage?
In SmmAccessLib.h, it still refers the _PEI_SMM_ACCESS_PPI definition from
MdeModulePkg? And need have _EFI prefix for _PEI_MASTER_BOOT_MODE_PEIM_PPI and
_PEI_PERMANENT_MEMORY_INSTALLED_PPI?
In PeiSmmAccessLib.inf, the
Reviewed-by: Star Zeng
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, August 28, 2019 6:41 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH] IntelFsp2Pkg/FspSecCore: Remove unneeded
> MdeModulePk
Both XXXPkg.uni need to be updated as the PCD movement.
With that, Reviewed-by: Star Zeng
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Wednesday, August 28, 2019 7:27 AM
> To: devel@edk2.groups.io
> Subject:
Reviewed-by: Star Zeng
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Wednesday, September 4, 2019 2:18 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subj
Reviewed-by: Star Zeng
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Chiu, Chasel
> Sent: Thursday, September 5, 2019 12:27 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [edk2-devel] [PATCH v2]
The DstInfoEntry is better to have identifer [out] instead of [in]?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, August 6, 2019 3:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
>
Same with Chasel. Reviewed-by: Star Zeng .
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, August 8, 2019 2:59 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCor
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2051
Original code GetConfigTable for AddrPtr first, if failed,
InstalConfigTable with allocated AddrPtr. So the AddrPtr
should not be NULL and the NULL pointer dereference case
should be false positive. This patch is just to address
the case
Reviewed-by: Star Zeng for my part.
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, July 18, 2019 9:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Andrew Fish ;
> Laszlo Ersek ; Leif Lindholm ;
> Kinney, Michael D ; Bi, Dandan
> ; Dong, Eric ; Ga
The new VS2012 build failure is caused by 7a0df26.
xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) :
warning C4701: potentially uninitialized local variable 'MpEvent' used
It is a false positive alarm.
MpEvent is assigned at line 238 and will be used at line 258, both
lines are
Reviewed-by: Star Zeng
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, July 17, 2019 9:59 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Chandana C
> ; Zeng, Star
> Subject: [Patch v3 2/2] UefiCpuPkg/RegisterC
Eric,
Thanks for the comments.
Attach the updated patch, and you may help push it if it is ok.
Thanks,
Star
> -Original Message-
> From: Dong, Eric
> Sent: Tuesday, July 16, 2019 3:24 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Laszlo Ersek ; Ni, Ray ; Kumar,
&g
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Chiu, Chasel
> Sent: Thursday, July 25, 2019 11:51 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [edk2-devel] [PATCH] IntelFsp
Temporary memory exit.
2. The gFspTempRamExitPpiGuid should be added into IntelFsp2Pkg.dec, right?
Thanks,
Star
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, June 14, 2019 5:56 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968
We met assertion like below, it happens when there is only
one processor.
ASSERT_EFI_ERROR (Status = Not started)
ASSERT [CpuFeaturesDxe] X:\XXX\XXX\RegisterCpuFeaturesLib\
DxeRegisterCpuFeaturesLib.c(149): !EFI_ERROR (Status)
The code
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ray
Sent: Thursday, November 21, 2019 1:46 PM
To: Jeff Brasen ; edk2-de...@lists.01.org;
devel@edk2.groups.io
Cc: Gao, Liming ; Kinney, Michael D
; Wu, Hao A ; Gao, Zhichao
; Zeng, Star
Subject: RE: [PATCH 2/3] MdePkg/MdeModule
Thank you. Reviewed-by: Star Zeng
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, December 6, 2019 7:26 PM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Zeng, Star
>
> Subject: [edk2-devel] [PA
Reviewed-by: Star Zeng
-Original Message-
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
Sent: Wednesday, December 4, 2019 12:15 AM
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Chiu, Chasel ;
Desimone, Nathaniel L ; Zeng, Star
; Philippe Mathieu-Daude
Subject: [PATCH 10/79
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 4:47 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> Hello S
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 9:23 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> On 02/03
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 2:
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 3:
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Got the point.
With the typo fixed, Reviewed-by: Star Zeng
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 2, 2020 11:15 AM
> To: Zeng, Star ; Ray Ni
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kinney, Michael D
>
> Subject: RE: [PATCH v2 3/
: devel@edk2.groups.io; Zeng, Star
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: RE: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib:
> Match data type and format specifier
>
> Reviewed-by: Eric Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Be
Reviewed-by: Star Zeng
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, February 10, 2020 11:53 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
>
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, January 2, 2020 10:16 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan
> Subject: RE: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105
> support.
>
&g
Reviewed-by: Star Zeng
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 3/6] MdeModulePkg/Smbios: Done measure Smbios
>
Minor comments.
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Bi, Dandan ; Zeng, Star
> Subject: [PATCH 5/6] MdeModulePkg/Smbios: Add TCG PFP rev 105 sup
Minor comment added.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ray Ni
> Sent: Tuesday, November 26, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Dong, Eric
> Subject: [edk2-devel] [PATCH v2 2/3]
Some feedback added.
> -Original Message-
> From: Ray Ni [mailto:niru...@users.noreply.github.com]
> Sent: Tuesday, November 26, 2019 2:16 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
> ; Kinney, Michael D
> Subject: [PATCH v2 3/3]
Reviewed-by: Star Zeng
-Original Message-
From: Ray Ni [mailto:niru...@users.noreply.github.com]
Sent: Tuesday, November 26, 2019 2:16 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Eric ; Zeng, Star
Subject: [PATCH v2 1/3] UefiCpuPkg/RegisterCpuFeaturesLib: Delete
CPU_FEATURE_
Your time is super fast.
> -Original Message-
> From: Ni, Ray
> Sent: Friday, April 10, 2020 10:50 AM
> To: Dong, Eric ; Ray Ni
> ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the
> performance of GetFr
Reviewed-by: Star Zeng
> -Original Message-
> From: Dong, Eric
> Sent: Friday, April 10, 2020 11:00 AM
> To: Ray Ni ; devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star
> Subject: RE: [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Improve the
> performance of GetFreeToken()
&
Reviewed-by: Star Zeng
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, May 1, 2020 5:59 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silico
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 24, 2020 3:12 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
> ; Brian J . Johnson
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPk
.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Kinney, Michael
> D ; Zeng, Star ; Brian J .
> Johnson
> Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to
> control AP status check interval
>
> REF:https://bugzilla.tianocore.o
equilivant is a typo?
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, May 20, 2020 12:12 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add FunctionParametePtr to
> FspGlob
A little surprised by "Average time taken to find CpuCrystalFrequencyHob: about
2000 ns".
It depends on the hob is built early or late?
Seemingly, NanoSecondDelay() will always have some deviation.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
No need to resend new patch, you can go ahead with Nate's review after the
correction.
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, May 20, 2020 12:25 PM
> To: Zeng, Star ; Desimone, Nathaniel L
> ; devel@edk2.groups.io
> Cc: Ma, Maurice
>
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Wednesday, September 16, 2020 8:21 PM
To: devel@edk2.groups.io; gaolim...@byosoft.com.cn
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize
IncLines
Reviewed-by: Star Zeng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
Sent: 2020年8月3日 14:05
To: devel@edk2.groups.io
Cc: Gao, Zhichao ; Wang, Jian J ;
Wu, Hao A ; Gao, Liming ; Ni, Ray
; Bi, Dandan ; Zeng, Star
Subject: [edk2-devel] [PATCH V3
Reviewed-by: Star Zeng with the copyright year correction.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, June 11, 2020 4:35 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add
NumberOfCpus local variable in GetAcpiCpuData will be uninitialized
when CpuS3DataDxe runs before DxeRegisterCpuFeaturesLib (linked by
CpuFeaturesDxe) because there is no code to initialize it at
(AcpiCpuData != NULL) execution path.
The issue is exposed after
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, January 21, 2021 10:38 PM
> To: devel@edk2.groups.io; Zeng, Star
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib:
> NumberOfCpus may be uninitialized
>
&
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, January 21, 2021 9:48 PM
> To: devel@edk2.groups.io; Zeng, Star
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg RegisterCpuFeaturesLib:
> NumberOfCpus may be uninitialized
>
&
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, January 26, 2021 5:18 AM
> To: Zeng, Star ; Ni, Ray ; Kinney,
> Michael D ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul1
>
> Subject: Re: [edk2-devel] [Pa
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, January 26, 2021 10:26 AM
> To: Laszlo Ersek ; Zeng, Star ;
> Kinney, Michael D ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul1
>
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fi
Series Reviewed-by: Star Zeng
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, January 19, 2021 11:55 PM
> To: edk2-devel-groups-io
> Cc: Ard Biesheuvel ; Dong, Eric
> ; Justen, Jordan L ;
> Philippe Mathieu-Daudé ; Kumar, Rahul1
> ; Ni, Ray ; Zeng, S
Does
https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/MpInitLib/MpLib.c#L909
(also decrements NumApsExecuting) also need be handled?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Saturday, January 23, 2021 1:10
inal Message-
> From: Kinney, Michael D
> Sent: Monday, January 25, 2021 1:16 PM
> To: Zeng, Star ; devel@edk2.groups.io; Kinney,
> Michael D
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Rahul1
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib
> -Original Message-
> From: Ni, Ray
> Sent: Monday, January 25, 2021 4:53 PM
> To: Zeng, Star ; Kinney, Michael D
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kumar, Rahul1
> Subject: RE: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fix AP
Hi All,
Do you think it worth or not to also update MpFuncs.nasm in
Edk2\UefiCpuPkg\PiSmmCpuDxeSmm?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Thursday, February 4, 2021 10:59 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Dong,
Sent: 2021年6月19日 18:56
To: Zeng, Star ; Yao, Jiewen ;
devel@edk2.groups.io
Subject: [edk2-devel] Possibly incorrect size in memory profile structure
Good day,
I have a question regarding a part of the memory profiling code. Namely this
piece of code [1] introduced storing the PDB file name among
In C1e.c, the MSR_FEATURE_CONFIG is better to be corrected to
MSR_NEHALEM_POWER_CTL.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, June 1, 2021 11:25 PM
To: Li, Daoxiang ; devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek ; Kumar,
Just like to give my RB: Reviewed-by: Star Zeng
Please also get the RB from maintainer.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: 2021年6月2日 6:05
To: devel@edk2.groups.io; Bi, Dandan ;
gaolim...@byosoft.com.cn; Kinney, Michael D ;
age-
> From: Lou, Yun
> Sent: Thursday, April 15, 2021 2:49 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Zeng, Star ;
> Ni, Ray
> Subject: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs
>
> REF: https://bugzi
1 - 100 of 156 matches
Mail list logo
